From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C154F46BAE for ; Fri, 18 Jul 2025 21:36:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC9C040611; Fri, 18 Jul 2025 21:36:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9C50340611 for ; Fri, 18 Jul 2025 21:36:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W54H4uHZWvQQYacpQvZ81NF0jqamxed4JNc0KSBhohA=; b=a4H+4EJJPIR9aXeArr0R6KCTadR3eOyst1/moTlAVGnptmrHmMpDuWPgGV6kCtc6s2ibD+ Zhxhjqqz1/17FridTlo7EE7G8bYPx2G3oTujHa1UHPjhDYA9EWKvCAo8SOtRnOgPEnR9qo WtWEw7DZ57Q2nm5+pDVKbvh5utVAHJE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-1VLyjVT-OY-Pin_nTpsPxg-1; Fri, 18 Jul 2025 15:35:57 -0400 X-MC-Unique: 1VLyjVT-OY-Pin_nTpsPxg-1 X-Mimecast-MFC-AGG-ID: 1VLyjVT-OY-Pin_nTpsPxg_1752867356 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0324819560AB; Fri, 18 Jul 2025 19:35:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96A65180045B; Fri, 18 Jul 2025 19:35:54 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'bus: cleanup device lists' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:21 +0100 Message-ID: <20250718193247.1008129-87-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EnaIKP0cDbAsAx1cMDrlqzRMkcIVUmfGRcsL2kMSlPQ_1752867356 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1b5dfa8745d22cbd1ee6c4a72a6e5636a66eace6 Thanks. Kevin --- >From 1b5dfa8745d22cbd1ee6c4a72a6e5636a66eace6 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 20 Feb 2025 16:09:06 +0800 Subject: [PATCH] bus: cleanup device lists MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] Although eal_bus_cleanup() is not invoked for multiple times, this is a good programming habit to remove the device object from list when cleanup bus. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Fixes: 62b906cf06ba ("bus/uacce: introduce UACCE bus") Fixes: 65780eada9d9 ("bus/vmbus: support cleanup") Signed-off-by: Chengwen Feng Acked-by: Morten Brørup --- drivers/bus/pci/pci_common.c | 1 + drivers/bus/uacce/uacce.c | 1 + drivers/bus/vdev/vdev.c | 1 + drivers/bus/vmbus/vmbus_common.c | 1 + 4 files changed, 4 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 70faae4e44..57c355e474 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -450,4 +450,5 @@ free: dev->vfio_req_intr_handle = NULL; + TAILQ_REMOVE(&rte_pci_bus.device_list, dev, next); pci_free(RTE_PCI_DEVICE_INTERNAL(dev)); } diff --git a/drivers/bus/uacce/uacce.c b/drivers/bus/uacce/uacce.c index c1529c38c0..36d5d48abb 100644 --- a/drivers/bus/uacce/uacce.c +++ b/drivers/bus/uacce/uacce.c @@ -455,4 +455,5 @@ uacce_cleanup(void) free: + TAILQ_REMOVE(&uacce_bus.device_list, dev, next); memset(dev, 0, sizeof(*dev)); free(dev); diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index ec7abe7cda..ae79cfd049 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -597,4 +597,5 @@ vdev_cleanup(void) dev->device.driver = NULL; free: + TAILQ_REMOVE(&vdev_device_list, dev, next); free(dev); } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 8a965d10d9..4dac5a6298 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -239,4 +239,5 @@ rte_vmbus_cleanup(void) dev->driver = NULL; dev->device.driver = NULL; + TAILQ_REMOVE(&rte_vmbus_bus.device_list, dev, next); free(dev); } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.035079075 +0100 +++ 0087-bus-cleanup-device-lists.patch 2025-07-18 20:29:10.991907518 +0100 @@ -1 +1 @@ -From 398bb775edc5434ad94578a5e6c49fa1328acc0f Mon Sep 17 00:00:00 2001 +From 1b5dfa8745d22cbd1ee6c4a72a6e5636a66eace6 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 5df4086f31..c88634f790 100644 +index 70faae4e44..57c355e474 100644 @@ -31 +32 @@ -@@ -452,4 +452,5 @@ free: +@@ -450,4 +450,5 @@ free: @@ -38 +39 @@ -index 9b8ac23952..f5343ed87a 100644 +index c1529c38c0..36d5d48abb 100644 @@ -41 +42 @@ -@@ -456,4 +456,5 @@ uacce_cleanup(void) +@@ -455,4 +455,5 @@ uacce_cleanup(void) @@ -48 +49 @@ -index beee8c4033..be375f63dc 100644 +index ec7abe7cda..ae79cfd049 100644 @@ -51 +52 @@ -@@ -604,4 +604,5 @@ vdev_cleanup(void) +@@ -597,4 +597,5 @@ vdev_cleanup(void) @@ -58 +59 @@ -index ac04ee11f8..a787d8b18d 100644 +index 8a965d10d9..4dac5a6298 100644 @@ -61 +62 @@ -@@ -241,4 +241,5 @@ rte_vmbus_cleanup(void) +@@ -239,4 +239,5 @@ rte_vmbus_cleanup(void)