From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2B2946BAE for ; Fri, 18 Jul 2025 21:36:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD91B40B8F; Fri, 18 Jul 2025 21:36:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D0AE240B8F for ; Fri, 18 Jul 2025 21:36:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cDR60ReEJiXSGaQ1Pc47AhsPf4U3U05tmhcpWJk84i4=; b=JhbVfTXgp9u7iPREVsomDHrIupnr9khqFI+mhrJl2okHnTfyaNQYWphlbIQPEsmVIrOwar tnfPQjmYaT6NPl4CbNy+4EXSjLsu8qL6/zaX82CoAfrc5sb9z0hDveVRu80FPIqUMpI+Il qjdNoiRQPGFNtXObJzNUtOzRTGeTh9w= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-iyl_7ziWOGm58czhzDYmug-1; Fri, 18 Jul 2025 15:36:10 -0400 X-MC-Unique: iyl_7ziWOGm58czhzDYmug-1 X-Mimecast-MFC-AGG-ID: iyl_7ziWOGm58czhzDYmug_1752867370 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1D2C1800371; Fri, 18 Jul 2025 19:36:09 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4AA3118003FC; Fri, 18 Jul 2025 19:36:08 +0000 (UTC) From: Kevin Traynor To: Ariel Otilibili Cc: Stephen Hemminger , dpdk stable Subject: patch 'pcapng: fix null dereference in close' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:27 +0100 Message-ID: <20250718193247.1008129-93-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bDW8BsgAnU56GtbflZE1DRcIwe3HeCybjuDkc_bBqz4_1752867370 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f0b892c99960cbc2069c60fcb9e23f206e2bd51e Thanks. Kevin --- >From f0b892c99960cbc2069c60fcb9e23f206e2bd51e Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 24 Feb 2025 17:40:31 +0100 Subject: [PATCH] pcapng: fix null dereference in close [ upstream commit b24a6349ae1d56b947186c9545349fca1ca87614 ] rte_pcapng_close() might dereference a null pointer; as example, PVS-Studio gives its usage in test_pcapng.c: indeed, that call to rte_pcapng_close() might receive a null pointer. Link: https://pvs-studio.com/en/docs/warnings/v522/ Link: https://github.com/DPDK/dpdk/blob/e5176f23ae8b31437c3e5eb875c81f95bf3a9942/app/test/test_pcapng.c#L438 Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Suggested-by: Stephen Hemminger Signed-off-by: Ariel Otilibili --- lib/pcapng/rte_pcapng.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 16485b27cb..66c16ba227 100644 --- a/lib/pcapng/rte_pcapng.c +++ b/lib/pcapng/rte_pcapng.c @@ -717,5 +717,7 @@ void rte_pcapng_close(rte_pcapng_t *self) { - close(self->outfd); - free(self); + if (self) { + close(self->outfd); + free(self); + } } -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.234486737 +0100 +++ 0093-pcapng-fix-null-dereference-in-close.patch 2025-07-18 20:29:10.999943414 +0100 @@ -1 +1 @@ -From b24a6349ae1d56b947186c9545349fca1ca87614 Mon Sep 17 00:00:00 2001 +From f0b892c99960cbc2069c60fcb9e23f206e2bd51e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b24a6349ae1d56b947186c9545349fca1ca87614 ] + @@ -22 +24 @@ -index cacbefdc50..2a07b4c1f5 100644 +index 16485b27cb..66c16ba227 100644 @@ -25 +27 @@ -@@ -725,5 +725,7 @@ void +@@ -717,5 +717,7 @@ void