From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1D6146BAE for ; Fri, 18 Jul 2025 21:36:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C948F40611; Fri, 18 Jul 2025 21:36:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7667940611 for ; Fri, 18 Jul 2025 21:36:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NlSHSbJ8iCniIA1H4KUAP+UajNuJZDT9n8Yclzku1uU=; b=SP0pyjPjPqqRUKur9gzj0zds8YaV6E1aZzxNBSsBcC0wmzioQjjhRYnjwRRuKycfS8cOyo 2r6scVfUfP/RLzd8cmgvltfnTFPwfTBuwPtmD3b3oC8iV8aVP+bRqSQ8suEYdXOVvDkco7 eQhEK58ApIYjZ5HD+0N2SYiefIpk4iA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-cJRLuoO7M6KYzz27T64Yaw-1; Fri, 18 Jul 2025 15:36:14 -0400 X-MC-Unique: cJRLuoO7M6KYzz27T64Yaw-1 X-Mimecast-MFC-AGG-ID: cJRLuoO7M6KYzz27T64Yaw_1752867373 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99E4919560B5; Fri, 18 Jul 2025 19:36:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5298918003FC; Fri, 18 Jul 2025 19:36:12 +0000 (UTC) From: Kevin Traynor To: Andre Muezerie Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix link on Windows' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:29 +0100 Message-ID: <20250718193247.1008129-95-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8LAAFn8p_lPB-sYBmjFx52qMZqyf-1L57Addho-S4M0_1752867373 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e225716e63cda946eef8e50956492e2581731c88 Thanks. Kevin --- >From e225716e63cda946eef8e50956492e2581731c88 Mon Sep 17 00:00:00 2001 From: Andre Muezerie Date: Mon, 5 May 2025 07:45:37 -0700 Subject: [PATCH] net/mlx5: fix link on Windows [ upstream commit 4031a5f261754ad5d4125e84888316d0678f43e7 ] When compiling DPDK with mlx5 using clang on Windows with "debug" buildtype the error below is hit: net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol mlx5_geneve_tlv_parser_create referenced in function flow_dv_discover_priorities drivers\rte_net_mlx5-25.dll : fatal error LNK1120: 1 unresolved externals With a "release" buildtype the error is not seen, which explains why this issue was not reported earlier. The same problem will show up with MSVC, but patches which are still under review are needed for this to be hit with MSVC. The cause of this problem seems to be that mlx5_flow_geneve.c is only compiled on Linux. This patch fixes the issue by compiling the file on all operating systems. It also sorts the file names in meson.build in alphabetical order. Fixes: f5177bdc8b76 ("net/mlx5: add GENEVE TLV options parser API") Signed-off-by: Andre Muezerie Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/meson.build | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build index 78a8648b43..6a91692759 100644 --- a/drivers/net/mlx5/meson.build +++ b/drivers/net/mlx5/meson.build @@ -18,11 +18,14 @@ headers = files('rte_pmd_mlx5.h') sources = files( 'mlx5.c', + 'mlx5_devx.c', 'mlx5_ethdev.c', 'mlx5_flow.c', - 'mlx5_flow_meter.c', - 'mlx5_flow_dv.c', 'mlx5_flow_aso.c', + 'mlx5_flow_dv.c', 'mlx5_flow_flex.c', + 'mlx5_flow_geneve.c', + 'mlx5_flow_meter.c', 'mlx5_mac.c', + 'mlx5_nta_rss.c', 'mlx5_rss.c', 'mlx5_rx.c', @@ -31,6 +34,6 @@ sources = files( 'mlx5_rxtx.c', 'mlx5_stats.c', - 'mlx5_trigger.c', 'mlx5_trace.c', + 'mlx5_trigger.c', 'mlx5_tx.c', 'mlx5_tx_empw.c', @@ -38,19 +41,16 @@ sources = files( 'mlx5_tx_nompw.c', 'mlx5_tx_txpp.c', - 'mlx5_txq.c', 'mlx5_txpp.c', - 'mlx5_vlan.c', + 'mlx5_txq.c', 'mlx5_utils.c', - 'mlx5_devx.c', - 'mlx5_nta_rss.c', + 'mlx5_vlan.c', ) if is_linux sources += files( - 'mlx5_flow_geneve.c', 'mlx5_flow_hw.c', - 'mlx5_hws_cnt.c', 'mlx5_flow_quota.c', 'mlx5_flow_verbs.c', + 'mlx5_hws_cnt.c', 'mlx5_nta_split.c', ) -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.300654657 +0100 +++ 0095-net-mlx5-fix-link-on-Windows.patch 2025-07-18 20:29:11.001907548 +0100 @@ -1 +1 @@ -From 4031a5f261754ad5d4125e84888316d0678f43e7 Mon Sep 17 00:00:00 2001 +From e225716e63cda946eef8e50956492e2581731c88 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4031a5f261754ad5d4125e84888316d0678f43e7 ] + @@ -26 +27,0 @@ -Cc: stable@dpdk.org