From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2123546BAE for ; Fri, 18 Jul 2025 21:36:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1641740E2E; Fri, 18 Jul 2025 21:36:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BF54E40E30 for ; Fri, 18 Jul 2025 21:36:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752867380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GNIwyD++oNlrbgcQZTaozcMyF3Mwr7MXVLBBPcRWWhs=; b=E85Rh/E/M8dV6gtfyTpj+vN/KC6AjOZJsxjMEozVfXw0xci+nngklnQ7e6XGIVddHQmsZa 7ooybwA5O+pml5ie/rItHzP5FigSo7hd6n9ibRHj4cUAGsX95mK5k3aKYgBU/55T0f1d3i L0ew/lP2Sa3i4Pk6SffSAp3iQZ7rdTA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-esIsw4yPMVKfnEFcbM4AWQ-1; Fri, 18 Jul 2025 15:36:17 -0400 X-MC-Unique: esIsw4yPMVKfnEFcbM4AWQ-1 X-Mimecast-MFC-AGG-ID: esIsw4yPMVKfnEFcbM4AWQ_1752867375 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBB4F18001DA; Fri, 18 Jul 2025 19:36:15 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4AD7C180045B; Fri, 18 Jul 2025 19:36:13 +0000 (UTC) From: Kevin Traynor To: Maxime Coquelin Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: avoid setting kernel MTU if not needed' has been queued to stable release 24.11.3 Date: Fri, 18 Jul 2025 20:30:30 +0100 Message-ID: <20250718193247.1008129-96-ktraynor@redhat.com> In-Reply-To: <20250718193247.1008129-1-ktraynor@redhat.com> References: <20250718193247.1008129-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1jRY4nEkcgDzseL_DfzK0LmpPxQPPt8Q_hap4D67pdw_1752867375 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/23/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a9ea24c564ab79d37387995c0c3cc33e17f771b6 Thanks. Kevin --- >From a9ea24c564ab79d37387995c0c3cc33e17f771b6 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 28 May 2025 11:36:44 +0200 Subject: [PATCH] net/mlx5: avoid setting kernel MTU if not needed [ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes: 10859ecf09c4 ("net/mlx5: fix MTU configuration") Signed-off-by: Maxime Coquelin Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 7708a0b808..f2ae75a8e1 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -648,4 +648,12 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) if (ret) return ret; + + if (kern_mtu == mtu) { + priv->mtu = mtu; + DRV_LOG(DEBUG, "port %u adapter MTU was already set to %u", + dev->data->port_id, mtu); + return 0; + } + /* Set kernel interface MTU first. */ ret = mlx5_set_mtu(dev, mtu); -- 2.50.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-18 20:29:14.333097682 +0100 +++ 0096-net-mlx5-avoid-setting-kernel-MTU-if-not-needed.patch 2025-07-18 20:29:11.002907552 +0100 @@ -1 +1 @@ -From f1f9113a08b202d302ba9448d351c04da48ff46d Mon Sep 17 00:00:00 2001 +From a9ea24c564ab79d37387995c0c3cc33e17f771b6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index a50320075c..b7df39ace9 100644 +index 7708a0b808..f2ae75a8e1 100644 @@ -26 +27 @@ -@@ -679,4 +679,12 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) +@@ -648,4 +648,12 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)