From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7FA546BE8 for ; Tue, 22 Jul 2025 15:39:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B690440661; Tue, 22 Jul 2025 15:39:29 +0200 (CEST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by mails.dpdk.org (Postfix) with ESMTP id 4D11A402DE for ; Tue, 22 Jul 2025 15:39:28 +0200 (CEST) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4ab92d06ddeso79796981cf.3 for ; Tue, 22 Jul 2025 06:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1753191567; x=1753796367; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bGI6JtgwTsXBdnuhfuDTnc+vdvbF2Iqa1O1vV9o2+0Q=; b=fxu06lRCq+i2XO3V5CvAMGEd+7oaKS/4FXNkCTbOfIme1ToDf8A8zvfYxhpodF51ko 4K5jISBU0/JSuK6z2ZTHXa7r7f7wu9/j8HzID77ValKk+VyUVEx+dLUbhljvEs4mT2bp rQ6amyHFuLuBalV35gB9qtTFLue3F1zlyGti8aEF44oEYIYFocB/QPF4xRfeCKhRotlR XczZxEEhvsQnfL1i4hUXhePGOuLyx1gMzptjDIrKCvL805KMwTbb4HmYBqzet3UhIdMZ Nhh3/iAV/iaH4IHIBk3YOhd/9iESwvCDMH4D4glauc/M30yaLyOpPfLvjIwMzX+VE1Yj 3qXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753191567; x=1753796367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bGI6JtgwTsXBdnuhfuDTnc+vdvbF2Iqa1O1vV9o2+0Q=; b=wUQmJUlyse33Uf8P7CSHFJY8VMm6uIYThEXQOb4w5drOM9aLqv+/MaOIlTuDjnii0o H4yNUMw+HmFvmmiiPLCBRY0W0A02rlcjWUwFQEL39hiRhKPU/sLUVRbtrb/EppgDjqxB wq8RQ5N6l/YDFzXhz6aV/EMK3DeXTMqrFQ47VvGrkS05aVlY4Hrpq/aX3ah9U+BeGyd6 OJ8hOIxZmwia27H9VMcXX7hgll+TmZIFHeTeoMXfjIGWXOeywuW/GlQjsXOlVYDMkQCG +KpbsPZRNRTS2Q3VAlhXyGfLPNXbXjtqjr0RgYW76tzbTFANk6xVSXwU0ZXpIeTe5ZYU s/ZA== X-Forwarded-Encrypted: i=1; AJvYcCW/f2lf32zcVEedFTqKHF4xFFdZoah9c0si7dKwgU7YyqNOV42VHuvnfrkRzbXVGsiOUWn4Y7M=@dpdk.org X-Gm-Message-State: AOJu0YxPUYFttFZQKObGF2/SNaEh55OabsNpEISElfoZYxGsKwclw6Px ZtLrUYYXqjeHCB+Fs9UM/ZD9ML10pLxbkDEqYHP2RVNKBaUNxWq2XSTy387MVuzIQCI= X-Gm-Gg: ASbGnctJ9oW8UYzAseak3o22UUW9AZwIll6idFCf5m4HVnAVxzYhE4ldSiWHIwsGF4T jb0+VzPhbIpbiSTsFlvgnxvqTeHfJ8OdZbb06zl6qyjqQqSjK1o4Zx+EjCvEJGm5ESlxHGNmEge E/Yc9URN8E1Zt+fCiJQGSRXTjAOl7gpxKVjugNJzK0kBFBUJ9up/UTtdyG7ivWprq4bpvJuagfP hvKbwWgd6W1TVoQdkuo37wN4AYqkqV249FkbZ+WFNQCCKWS0nxgALWTz/19dFiorvirkimYgv0Y Yx6KZh17N0VWCFdqfP/SpBxxfSamRjZag4b6HEY8bCEW1z9SlUtv84b8jNAWqNw3TXiKCXj9v4p vc6QG78gnEyTussO4j734vPnLXvv55CO4SbijIUKmgpFD8p3kPR0j6ciJki/40im93IfkdbG1L0 U= X-Google-Smtp-Source: AGHT+IGSGDvQV+Zzvr6hAt1Ty26Oqw+ChqGVo7La98AnpX0halnnDA5QBbCnQL1LOUurZwMv7MnnIg== X-Received: by 2002:a05:622a:1995:b0:4ab:408f:d1af with SMTP id d75a77b69052e-4ab93d8d7ecmr354082211cf.31.1753191567526; Tue, 22 Jul 2025 06:39:27 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4abb4af26bdsm52948721cf.35.2025.07.22.06.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 06:39:27 -0700 (PDT) Date: Tue, 22 Jul 2025 06:39:24 -0700 From: Stephen Hemminger To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Cc: thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Message-ID: <20250722063924.2f87f3f7@hermes.local> In-Reply-To: <20250722115439.1353573-1-14pwcse1224@uetpeshawar.edu.pk> References: <20250722115439.1353573-1-14pwcse1224@uetpeshawar.edu.pk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 22 Jul 2025 07:54:39 -0400 Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote: > + if (rte_eal_process_type() == RTE_PROC_SECONDARY && > + (dev == NULL || dev->data == NULL || > + dev->data->dev_private == NULL || dev can't be NULL and checking it here will cause a Coverity warning. There are many other ethdev calls that will fail if primary dies. stats, xstats, rx/tx burst, ... I don't think it is good idea to add checks here.