From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FF7846BE5 for ; Tue, 22 Jul 2025 19:38:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 403B740671; Tue, 22 Jul 2025 19:38:30 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 9346040616 for ; Tue, 22 Jul 2025 19:38:27 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-23aeac7d77aso49091845ad.3 for ; Tue, 22 Jul 2025 10:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1753205907; x=1753810707; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZPblH1j/xZMXIegVUSLcKz2r8cP+fyII2ULvQCzQFds=; b=qRS7Vub6VK6ZtBtsqdc+M7+cytwTdecPd3tACtqwmJnQqAoOcUAhr7tz9Jf5bTXzLO seiIq9k+epOFaONSQ0uMurMrK+6cZD+UrkUcg5Gl9VIEYlmixbv5p23NB0sD8MS5JNAM Gc9xdGO5wlIHUJigIxcFtLygcPEKgi76RxYJHBEocB/sM989ZkUVUDmbO6biVlZIvmrN db5bIuosnLSTB9IzMIwpmPJPCBZhrhGSiQltc9eKFq1kgV2BZr2Csgju0tgSB+zdhdlo a7kkaFuRgq7plLHpr85pMXjLrYV0k6ZGN+pE6gPZdMpAT1BQ2SGuqKjutPli7Mg0HL4B jXNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753205907; x=1753810707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPblH1j/xZMXIegVUSLcKz2r8cP+fyII2ULvQCzQFds=; b=qD9s+rbV2Wh6XzQBzAFJ50oY8V+A+zpgwTA2NDyP2/2KFHhsr4c5AdSqD/nhK+iNzb mKiUVk2aBgFxfAyix0v+1y+3S/oz6cCebYu4z0tSRdr790URZ8chVi1diCXJbbqAmse2 qYrHiAy9TSLxHZCZLUVBF+AmQRAMqysTtWrSDBkSPFUdm3imwFhhwX1kq7rYAXWGdGgS VGs85uLE7Bd+Otl39fQ82yaoeeIWPhBy4rBc1lgvBExxF/JbEr3/B584XyPS8yKc7Qyp aRnYhtD4957QwDhxVpZ8BkpHxyc2H7t1zWUTFiXmpQCSyaPgMqM2pFQoTpXCNIv8eqY1 74wQ== X-Forwarded-Encrypted: i=1; AJvYcCXDRwv6wFg2k7Gaacxd2t+YoIt2FtcsK96Zae7qBrrprHKbn1XFirqJIRZOahhwA03t0+Tsyzs=@dpdk.org X-Gm-Message-State: AOJu0YyxdsihLeYMeybth9d43YFtgjKsjaHXcLONbkT73s7bhWMYzJxy kvp2SSIW+CsZsChei2jR/g3WecBMr1HlZ3wQIRnsOJOy0tCOQaz3BmrZRM9VZHWepdI= X-Gm-Gg: ASbGncufZHE6PnNzxlHFUBF8SEutzMRPJxaZGWUHvkPaQLzCNxB/Ht8vUl+7U4k6fF5 CFoY9wH05/ITbS8KAfZtgR/MrgJC1R8UUQDia2KCgyZMADEVYb+Rf7FOJr8tpP6loSzaoZhgKHi nYJqOHRzrqRdYMlkfhPMwSMwPjK7c5/uGHWUkxmK2caWlfwWpvopB82F3RGZTOyUKD42MGGvoYV ZfPYtA1ipc4D8QITfFz9UnZLSqOS8i2gTPjJmUqnXSbURMOMltfRyJTuYrJkZHyB8WaYGeM+Nyr jI1dVuBb9quh4wMzO0E4u/hQQY64zOaGZI3b6WjI+JiTlC9qZUQPaNEn73bHrgUvJK3nRwvUgrm TNXRch5G5ArK4IBslC+x3GwobGdqI/aNwRc41RLFcoJiwG0EktBsqvzTBrtdQdiOdbhsiG+i5U2 A= X-Google-Smtp-Source: AGHT+IHVI0LhuUO9PkP9rkvt05IIcjZCQ9M68ZRDYldKunm6wMe7VT3EaiTyl8cM09PTNcbr/cb7Cg== X-Received: by 2002:a17:903:3c6c:b0:235:f51f:c9e4 with SMTP id d9443c01a7336-23e24f49430mr394729975ad.12.1753205906698; Tue, 22 Jul 2025 10:38:26 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b60f096sm80071685ad.78.2025.07.22.10.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 10:38:26 -0700 (PDT) Date: Tue, 22 Jul 2025 10:38:24 -0700 From: Stephen Hemminger To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Cc: Bruce Richardson , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, dpdk stable Subject: Re: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Message-ID: <20250722103824.7c9db0a0@hermes.local> In-Reply-To: References: <20250722115439.1353573-1-14pwcse1224@uetpeshawar.edu.pk> <20250722063924.2f87f3f7@hermes.local> <20250722084225.7a40e2bc@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 22 Jul 2025 22:04:32 +0500 Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote: > Agree, but I think it's also a good practice to guard against known cases > that are prone to crashes. Right but DPDK chooses performance over API safety. For example rx/tx burst doesn't check args. The point is that as a library, if application is doing something wrong returning error doesn't always help.