From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33EBC46BE4 for ; Tue, 22 Jul 2025 13:54:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14DC040265; Tue, 22 Jul 2025 13:54:51 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 8008340265 for ; Tue, 22 Jul 2025 13:54:50 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-234d3261631so43035965ad.1 for ; Tue, 22 Jul 2025 04:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1753185289; x=1753790089; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OFlkxXxEvhMxJ6O5O6X2a0Pmpnvx9QADNavd4cExEls=; b=eEWIzuBsZzWgohqpMJ2NjCYMOv6J28pCLeq3a34iGhK+hwlRsNhZ2zz8yoCbYLud9t yJvu4QI0MinjKp/3UhyRuWVyPN5TwBzgC55SI2AZyazFPtUkpOzpDCleWSNckfVJ700P caEnQu5uv8+NMwd/ZM4x64pDfdWfA1hKEzpYZ9EgJTdA8k9OASMc126aIbgy4825ngbX 9BD6hnR+TwiXE4DBYt553/h6gG/V5nZSq5Wg6mRPthj8bUE5XL6HZDDssO6PFohOw5I4 FUO0A76fDc0BMrYaJs8OJl7GbuAyRzOyKJWT53zImr9o86i3Rgl6xPYfj28VhMketgrQ Y8gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753185289; x=1753790089; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OFlkxXxEvhMxJ6O5O6X2a0Pmpnvx9QADNavd4cExEls=; b=b5RJpk7OpNXs5zE0/iB1JurcqHfsGCk2s3ZoOb/A0y65YfHb3I+erpBDglakYnlvCW syTbdTNp18eJMbY9wto5+Hr81aECTl+aC5MNEPpiDf9t7hz9H5HnzKcELS/CkEt8muGz UrOeOpETn7uJhoXBOCEkeAyzGLboSUnAkXNF7z4lUNQJz1X5CbZdAeN+MucRwo47ucdL tKFrHDqjK/K2NpMkLPoeM+R6LaLwudiOpaPsX+m6x6ZQQyfExbqeQIRE+pbF7/StvMlW 19Y8OW43T9zblKFxP0u+suzD6loHZZMHGbQGT9vELJ3j8k7acHROTaIBZC/kEFMV1z4i vphA== X-Forwarded-Encrypted: i=1; AJvYcCV5g7y6UyyzYgBU+xkkkdF2WPYDMRSXDevsIwrvDiZgBqdgMbmrZBos+j68tvmpPokOU/UfOzo=@dpdk.org X-Gm-Message-State: AOJu0Yxr7jUcAdeTpA2llH/0nK/WK6kZ3tnnIMfMuuBvX8RVyd25f+pk yiSjP2nIqfX6kzoAsvpwlJzr1EMuSBR5iahgqDjTQR65txa50XYKUTXwa3lIzWwblyk= X-Gm-Gg: ASbGncv+79p+diBNQXGTID79LQ8r30DEAMW2jKZE4/aWBNdRmcokNJ6QHE2B925IV1k UEy/ryNpUEas+e9W5h/CWn0GFvrpvLm+YpQZ1KT0RA2QKTToHH5UCIHVyUWTKFz54kCXQAEpbXA hbldp4pyOcoG4TWvgCPjGF09BBPeY8SyPpE9iiXPsI6vWLn6erYRYgGIdCiSq60GA+UX0HE5pze yof513L+gop/akQ11Bbr33dfuJje4elAa6+uZ4ODAK31fSOj6OObEwL+Gbj7NT6R6ND+IwIl//r f50lb+v2/FQuI+lEHqsjxelKwH5WAjzZuC0stHNHpZMdcfnDgBSHmijrqe1MWhANLLT/KHhIUZy EAyueaQjQ3pzJoXdjgRHjGqDtIXxZb5ERVd3W8y9CDUa7PGE5 X-Google-Smtp-Source: AGHT+IFZr14/TFWLiQMtMRd2J0z9GeWlD2uUHFIPGPEnbGmtBZohAwGC/NSE+qBvMa+V2PPjkFm0Gw== X-Received: by 2002:a17:902:f906:b0:234:d1f2:da31 with SMTP id d9443c01a7336-23e3b766079mr175530855ad.2.1753185289504; Tue, 22 Jul 2025 04:54:49 -0700 (PDT) Received: from localhost.localdomain ([64.62.143.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b6b5631sm74684865ad.124.2025.07.22.04.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 04:54:49 -0700 (PDT) From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> To: thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru Cc: dev@dpdk.org, stable@dpdk.org, Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Subject: [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Date: Tue, 22 Jul 2025 07:54:39 -0400 Message-ID: <20250722115439.1353573-1-14pwcse1224@uetpeshawar.edu.pk> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org In secondary processes, accessing 'dev->data->dev_private' directly can cause a segmentation fault if the primary process has exited or the shared memory is unavailable. This patch adds a check for dev/data/dev_private and uses rte_mem_virt2phy to ensure the pointer is still valid. Fixes: bdad90d12ec8 ('ethdev: change device info get callback to return int') Cc: stable@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- lib/ethdev/rte_ethdev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index dd7c00bc94..03ef446a96 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -4079,6 +4079,15 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) if (dev->dev_ops->dev_infos_get == NULL) return -ENOTSUP; + if (rte_eal_process_type() == RTE_PROC_SECONDARY && + (dev == NULL || dev->data == NULL || + dev->data->dev_private == NULL || + rte_mem_virt2phy(dev->data->dev_private) == RTE_BAD_PHYS_ADDR)) { + RTE_ETHDEV_LOG_LINE(ERR, + "Secondary: dev_private not accessible (primary exited?)"); + rte_errno = ENODEV; + return -rte_errno; + } diag = dev->dev_ops->dev_infos_get(dev, dev_info); if (diag != 0) { /* Cleanup already filled in device information */ -- 2.43.0