From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E1D646BE7 for ; Tue, 22 Jul 2025 15:36:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3187F4003C; Tue, 22 Jul 2025 15:36:11 +0200 (CEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 56FD34003C for ; Tue, 22 Jul 2025 15:36:10 +0200 (CEST) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3b49ffbb31bso3543179f8f.3 for ; Tue, 22 Jul 2025 06:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753191370; x=1753796170; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihrQhTzrLWISBNXvcGy/X5uhi6pkQ9+jf0j2KBCUUsU=; b=D+xamp+tpnTELz8nims6Iv+e/SsDgJgHeliYIGH7iyzD6fHuQmUzhZ/AO2z5ETF0+N mLgpDx3FpOoT1c4jZasc8ElFvGvzZWyIc2udhhVy5Dcfm0VGbEeRy2aUjcNJsNwDtyHR WDIrjz25aShu6O6mA1WwzXTCsEFTcieZ2ISoSx7/uvOQs7GbIZIAp2xTpQLpCh6KdwUY 3dwExl237flqXyJQF7+3LTfHVcKK3PGOexqS+QsPnpZ++E+4eqDOrsvjZGwRMMAEWY7s PauasPuxeN0/z7wDg/0dn8+H1ZNBeQbroASnnOxarwFseEQuBrBh8bOVEPIpUsoGNZWB L2Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753191370; x=1753796170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihrQhTzrLWISBNXvcGy/X5uhi6pkQ9+jf0j2KBCUUsU=; b=GDjsRvaAsLjIC/sc2NV2wg/D4bZXsAaVzyWl/BHflHh0aNacfBIY0AEH4ZljlbIV6j 1P2m11fjy2bjId6WVbe9achG8mKyfZdl6QVxgq8gOaLDYV/2NhQM+6deUOb1jj7os8R7 eryD2vEj1t+Esg5G7usAGlU8TeLUY+O5emKqLFXvQUGvF6DkUiBTm7zZGgY3+YiLrXkA NnmiJciHp+5GkudcypXh5vUegpSuxfzFXC9b1cTmc1n9dC5S8MmWX5pvYxtEZ2bDPFhz g5hPQFyz5ZPktApbvwPjmHSpGzrSOykoniNPkJH+4mwt5KrTZL4Q+KjgF6wVrnj110vc 8LyQ== X-Forwarded-Encrypted: i=1; AJvYcCXN4p1oTefOJDnMeOPl5vUeDsV6L/9nFD9BhI88Vuc9oqqlFI56spEx/gpuie5LWrDXfjjgo3Y=@dpdk.org X-Gm-Message-State: AOJu0YwJWCbu5XJpCrKkQG1EomofxCJV1+4tuPI5XUOzLdnxioW958K7 jL/IYKZyYsd2IVaJvnjZy9fUbb9nXXLV0YkbOIwDyZOJqkHLu9RuXRiPIFwXl4g/ X-Gm-Gg: ASbGnctsIdRucOXAUudN6NT0mRotf0LfBuexHpRMxSoLgX9JpTyVr3MggByOmGPKZ15 cU6PdCj3nOE2gsRPQgsxYGkVjRaVLeST1Ga+REsmKhg2koS1jE9eK4mVOE2vtKRW8O7u3f3HCRs waVs3Jci6jn/qsAeY3/LEWRoR4ue5C+cepjvzN+y4oNsIBVmNaAySB9dhePtQfg1w0hpWxlIs9p Fa3rXeWqjDnYAIeUDkwKBG1EfwSvq462X7UGJ9cm4gn+sZoVXN3wPxsHDpQB8ZsEakmEuotwBpk hyBLZDTfB+KozojONHw8q7J450KJl9oYCKfcVV58F1ekhKSeg/Xj7ZnR0Vl/DTBBiN79swkkTQv bXU5WwJ+h7/sAxfqsgQw/pFVtEtQ= X-Google-Smtp-Source: AGHT+IEP5ZFMh2HtasAcSiszi5qjGUY73ZfrDJp0kM5QazbzntzLp0rB0fOwqVHK278FobNXg0lxpQ== X-Received: by 2002:a05:6000:250d:b0:3a5:58a5:6a83 with SMTP id ffacd0b85a97d-3b613e66eaemr16419425f8f.13.1753191369527; Tue, 22 Jul 2025 06:36:09 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:77d:dea3:da3f:6cae]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b61ca25443sm13586272f8f.9.2025.07.22.06.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 06:36:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Thomas Monjalon Cc: Song Jiale , dpdk stable Subject: patch 'examples/multi_process: revert ports cleanup on exit' has been queued to stable release 22.11.9 Date: Tue, 22 Jul 2025 14:35:40 +0100 Message-ID: <20250722133606.1566947-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714151121.219866-21-luca.boccassi@gmail.com> References: <20250714151121.219866-21-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/24/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fcd0c8dfcace88dd137f2af3ae7649b7cdfff673 Thanks. Luca Boccassi --- >From fcd0c8dfcace88dd137f2af3ae7649b7cdfff673 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 15 Jul 2025 13:08:15 +0200 Subject: [PATCH] examples/multi_process: revert ports cleanup on exit [ upstream commit dc88beed495c04b745d17bc8c1718fa76b914593 ] When closing the primary process, an error occurs when closing ports: Error closing ports EAL: failed to send to (/var/run/dpdk/dpdk_X/mp_socket_Y) due to Bad file descriptor EAL: Fail to send request /var/run/dpdk/dpdk_X/mp_socket_Y:mp_malloc_sync EAL: Could not send sync request to secondary process And the secondary process crashes. It may show several problems to fix in the next release. Revert the fix causing these issues for 25.07 release. Bugzilla ID: 1751 Fixes: 4382d58097b4 ("examples/multi_process: fix ports cleanup on exit") Reported-by: Song Jiale Signed-off-by: Thomas Monjalon --- examples/multi_process/symmetric_mp/main.c | 27 ++++------------------ 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 2dbbaa06f5..1ff85875df 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -92,25 +92,6 @@ smp_usage(const char *prgname, const char *errmsg) exit(1); } -static void -exit_cleanup(void) -{ - unsigned int i; - - RTE_LOG(INFO, APP, "Close ports.\n"); - for (i = 0; i < num_ports; i++) { - if (rte_eal_process_type() == RTE_PROC_PRIMARY) { - if (rte_eth_dev_stop(ports[i])) - rte_exit(EXIT_FAILURE, "Error stopping ports\n"); - if (rte_eth_dev_close(ports[i])) - rte_exit(EXIT_FAILURE, "Error closing ports\n"); - } - } - - /* clean up the EAL */ - rte_eal_cleanup(); - exit(0); -} /* signal handler configured for SIGTERM and SIGINT to print stats on exit */ static void @@ -123,10 +104,9 @@ print_stats(int signum) printf("Port %u: RX - %u, TX - %u, Drop - %u\n", (unsigned)p_num, pstats[p_num].rx, pstats[p_num].tx, pstats[p_num].drop); } - exit_cleanup(); + exit(0); } - /* Parse the argument given in the command line of the application */ static int smp_parse_args(int argc, char **argv) @@ -506,5 +486,8 @@ main(int argc, char **argv) rte_eal_mp_remote_launch(lcore_main, NULL, CALL_MAIN); - exit_cleanup(); + /* clean up the EAL */ + rte_eal_cleanup(); + + return 0; } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-22 14:35:32.136473293 +0100 +++ 0001-examples-multi_process-revert-ports-cleanup-on-exit.patch 2025-07-22 14:35:32.094012273 +0100 @@ -1 +1 @@ -From dc88beed495c04b745d17bc8c1718fa76b914593 Mon Sep 17 00:00:00 2001 +From fcd0c8dfcace88dd137f2af3ae7649b7cdfff673 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dc88beed495c04b745d17bc8c1718fa76b914593 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index de16608a0f..f7d8439cd4 100644 +index 2dbbaa06f5..1ff85875df 100644