From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68FFF46BF8 for ; Thu, 24 Jul 2025 07:49:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 461C940267; Thu, 24 Jul 2025 07:49:26 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id F1E8840267 for ; Thu, 24 Jul 2025 07:49:24 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-b34c068faf8so721590a12.2 for ; Wed, 23 Jul 2025 22:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1753336164; x=1753940964; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W5qXZwlvBwpNIXTaaNF5uBTc4ByGFQf9nI1coTRXrOM=; b=P80Iro2hCBT+/VNKYPr+Z8pVM6SjDn0ghfIZcHHuFV1ha0rooTrvjXG5qou0CQFWi8 1yQCwAt6VoIKXIcrek3V/1Gown6BOk4OZQW3EuFAnt1SZ8fT1Hmp48mLUWmzeQBP5v0o 20+zWQsRvI8JIFw7pLYE1/U4E1tdxrXgvYNIf5PYxr8eDjztsT6vglZHCtqNzOV+fpZk 2oh3F7o/888pMgXzDATEJg+xRVNbv4Nsm2d+tBEQiRom6hkYp09FR4bKiFYPxcXQX470 Jz5HHhhg8/bpXl5dUz4tSUvI3mifnSL2eUvqZbnUZjmmqgI3ioHkB7JifjTqQdD79mKP KysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753336164; x=1753940964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W5qXZwlvBwpNIXTaaNF5uBTc4ByGFQf9nI1coTRXrOM=; b=A1YyZovYkWfYiIgn9KLiHjFtDP35m7og8l37oWTWrcHkwjX9x/s3enyHm5f9eYns5L D3Z5uq409CuPhaG3BmuQjfPMKSM7FI2usenm5O6EpPdYlhxXInsG/RkKr3elEyozDoXB wVFCpHBzLeylVCQwOBrpXpT1dAXPHQwFMQpvnHoIPDlWJiQNJ5vBmkVXvf9oExMCNQcw t0t1IS9ia9WOLuDJ3kdcvmeZGjqSSymZ1Mx/OaF+/gQBLjU4tGvIRshPkWZLDnt6oG5+ eTYcavJdA/JcfbqyuJytcVja7syCdEzOqX/aNLPxrQdO3ZXjGrmpKh0eX5DEWAwyW3v+ 1s0w== X-Forwarded-Encrypted: i=1; AJvYcCXi0+ynveOS5Z5pnXJQaiNuP99TgXc3Tz01GEvUkgbQLr6YhWH8dvwbYf2t/ZR2FUKWMubhDxc=@dpdk.org X-Gm-Message-State: AOJu0YyBkK60Nv+4xfJSUNzgIMN6tg3o/fNbbaKgCHLJCDU+BeTKgqlC CRtUCejes6YEOkRhONNB15hFqdu6mdJ+paq1N3Tk723tvWLCuP1w03/NYPCwZqh5gcc= X-Gm-Gg: ASbGncsl8RcUpa1pzrV/T690aVoBxSC5coTEg6n36wvOz1hyTwL2whemMV8T1/jD/2U +F934a00dCdeFGxEAAlu5IRdjO2OmBuT9BLnORwEUqtRlJ3iaPyCnL6tuYdVZ3QdUfoUN5XVuRc WruK562GsRiXXq8Gj3TsjT/CabJ9g/16qfDOvcI45pcEikA+SlgxziDszs4vwPcoHbx1fCmhlDA 0kkD4BiX0YH/CpNWIn+8ZSb4AcwcDx72U9WZKkGhLi3ma8M9CWdDbHf5dB5EVZD3A/PTsu7OTUv 38cN+jatl1fClOo95pD65jVLr7QOOxSZkH8IbX8zVc1y6p8xT4UQC4mt8MqyENIlaUg2cMgolZc ZG0KVqrqfoTbs0mGHvcyxyFV5U0KKxZBKHY60fJMvDL/kZ7lZ X-Google-Smtp-Source: AGHT+IGhR1s4PMljGUcH+q0WekXTDscNIrDRTzRllDOoRLXO5g2piS185+e5iyn/srlNWlNNkneI1A== X-Received: by 2002:a05:6300:6713:b0:22b:f4e5:d0ee with SMTP id adf61e73a8af0-23d4902d89amr10248864637.14.1753336163830; Wed, 23 Jul 2025 22:49:23 -0700 (PDT) Received: from localhost.localdomain ([64.62.143.197]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-761ae158d40sm763446b3a.52.2025.07.23.22.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jul 2025 22:49:23 -0700 (PDT) From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> To: stephen@networkplumber.org, thomas@monjalon.net, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] [PATCH v3] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Date: Thu, 24 Jul 2025 01:49:03 -0400 Message-ID: <20250724054903.1923586-1-14pwcse1224@uetpeshawar.edu.pk> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250723072216.5a34b44a@hermes.local> References: <20250723072216.5a34b44a@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Stephen, Thanks for the feedback. This patch doesn’t monitor the primary process, it only adds basic checks to prevent crashes when the secondary process calls certain APIs after the primary has exited. Right now, I think, only specific apps like `dumpcap` use `enable_primary_monitor`, but most (like `testpmd`) don’t monitor the primary at all. I understand your point about improving the whole primary-secondary monitoring system using a better method like Unix domain sockets instead of lock files. That would definitely be a cleaner and more reliable solution, and I’d be glad to help with that in future work. However, even with better monitoring, we would still need the checks in this patch. They’re basic safety checks that help avoid crashes in any case, for example, when the API is called with null or invalid data. So I see this patch as a necessary short-term fix that doesn’t replace, but supports, any long-term redesign. Best regards, Khadem