From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 442A546C4D for ; Wed, 30 Jul 2025 09:12:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38BFB40E30; Wed, 30 Jul 2025 09:12:11 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061.outbound.protection.outlook.com [40.107.220.61]) by mails.dpdk.org (Postfix) with ESMTP id 31BD64025E for ; Wed, 30 Jul 2025 09:12:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i8qomTizQcdH+R1315J6fZq1CHCcq0KEKqbqxnbocS49a496RjjszlbCjAhmyGZ2VD0DMoSinhg0nT3TV0Qyy8ajtx6jfJGI1SgBCqHV2vAx6rnEA0m1Rg83zSm7v3fyP++RXHT0uM/J544KReR6aGWaorlSCjEAK69O0ghb3/f9wF+BDZNecVbTCzQFIclg9Y8IJaZkz/N35G4xqS91OQ8o6lfp23KHXMEplxsVI5yU3rR4Zm/3KR3o0FzgTplslQpqmAfNuSvvBmNu4d9HqyawhBSoRoSR4NvIJnjwlacF6GnMt2t9jhnHyWpNeZb3cJJzWtqekhdGXxDmspD07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZMUhxRqYlt1pkSjnFz8UAPCJwMDyuLsgssZ9TwAcrTg=; b=hLVsEeTn4mLeiY6V+VUwdcIrqP6u2TytiWdHA5ZQJ5f/dSQ3r8wD4XnQMam4Ar/bvx5eqC2HulVHVTqHu1nOAOK81zYvoEYGWO8kC9TI4RinnsT5W+jFEfRr2R3YyXImHl+dr46XZnTqh7F4Cop0zHti2RBBMpOs1FxiwyLhx/osTVDD+TusyoRbo5pRax0p8chttrQs27MUFCkxBeJb/wutvOib3V2Mf/iDQFpv1NI0vK8GPOStXYYKeSn+N/LWjL8p4cINu6xJFL65Xl99mW00NWv5Qcs5cQOmN8BoR8yqWbGnAKo1WS5rJn63iMx2wOjfhPk6bCqbJRSkkhUOTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZMUhxRqYlt1pkSjnFz8UAPCJwMDyuLsgssZ9TwAcrTg=; b=dlWCFGepVkEPO0pT7fgXorRQ5CaH914Ng+/4d3hkKbsrlS/bAmF/lP2ffeej0NyasFgijZJL3ZkaRQeM6O8hrK+VcswpAUwNetfFRTPXCxMrhNf/lZtF7fXF5y6o8gZQDe3lbxgkLsWxxRM/alueBxKGXsoyGYl17n4XyMoCJ/upJRGOdik6A7Mgxr53k1vVLP/ux9wQ8j9PIGxyCEnJcmlZftGCyfcnp0sbMkCs6qztf/Sgqah5vugys4iKr5wjezOn3ndf9otVSdNqcCPLGpCsMcK7BtOFSa4lePYz0pEderrPGQz9HgHLt893rgG4CBHGvW1qkrH+jXZO8IN4oQ== Received: from DM6PR21CA0015.namprd21.prod.outlook.com (2603:10b6:5:174::25) by SN7PR12MB6960.namprd12.prod.outlook.com (2603:10b6:806:260::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.11; Wed, 30 Jul 2025 07:12:06 +0000 Received: from CY4PEPF0000EE3B.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::15) by DM6PR21CA0015.outlook.office365.com (2603:10b6:5:174::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9009.4 via Frontend Transport; Wed, 30 Jul 2025 07:12:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3B.mail.protection.outlook.com (10.167.242.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:12:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:11:46 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:11:42 -0700 From: Xueming Li To: Rakesh Kudurumalla CC: Xueming Li , Akhil Goyal , "dpdk stable" Subject: patch 'examples/ipsec-secgw: fix crash in event vector mode' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:20 +0800 Message-ID: <20250730071045.136672-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3B:EE_|SN7PR12MB6960:EE_ X-MS-Office365-Filtering-Correlation-Id: a8bf4c65-af5c-484c-2678-08ddcf3863e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bty+21ZwHqtuEC/1aVCV15LqmU1sheg1Zi8t3BK0wsyC8cbS9X1hYQiE8ADC?= =?us-ascii?Q?w3gGci+0QFz1CsyzP5KZMDeBmJCRongylfTe8pG3MLDNKs1YeIdl2LCnPwuf?= =?us-ascii?Q?oN1Q3QGxgsp5h2piNNxWa0kXJ7f70VGv1PFkxh723aRY1ZaUYHzoWIzAjTIN?= =?us-ascii?Q?c6uyVmu6LI2pbDgBwKVzDSZa1EGknto8ZDHTyd6HllZ/SROuNwBz5tpfJPFg?= =?us-ascii?Q?1/TbIJ9vjaH/xGABRaSkb0nK8xJMDfqlHxiCyXdrdQIzHgESg2tzr1/DZO/j?= =?us-ascii?Q?x/U9g/m9bdMls9UUE5RV+QNVMD0qoZkh5qAgG+wEyMUjUrN0uhPSsxo7geaU?= =?us-ascii?Q?XT+VuOn/L4Yiwk0s6JRGiMwPAgHSpvMGfrVRpLbx3RFhiczYsQwgEU2xXwYS?= =?us-ascii?Q?ExhxqyhWqqxzilRQSD/Dj1+SdecPScwEIAioiNg2SDxeqkDlj0AjYcyZsbgM?= =?us-ascii?Q?8r7UrdLrGEhiH1KtI1sXZfhAondKZqpCpTpAB276dTSTjM7topv4xi68gU0J?= =?us-ascii?Q?bmlBp3MdcKrX125IAicIKckc1F8moL0qpN3LC2LNlhKN1NVYpPNY+tPqpcO6?= =?us-ascii?Q?cPv17mIMxhRdiKDtH98hIC4cGzWquq8SIKtIJQo6EJUGnOAECxXjePfUrpdA?= =?us-ascii?Q?6GxICitgDlgdjfntuZBt8thYP/nrKzQ1jKnREAXMauJ0ktxTY0dcjAvXiayU?= =?us-ascii?Q?WEsxYsfh+L7UkybWFm/M0WfDC7mWg7lbvayQmkBdPdkndwApBiBhcdaeTn2x?= =?us-ascii?Q?ITeTV3Bfd8t6cP5fKLezTc2nigIlFbUPiUXoaOFAwB7TeFdz+zsNggYbFuKH?= =?us-ascii?Q?xoZCRCnOz5WTucxwuVke97X0Bl+6QFC/BdEoAdqxio6rmPgqXOyxJDqPJ4l1?= =?us-ascii?Q?yMpcDAoHRHSLiHBMUJyoHhKU6H6ZioTmsgLCU3U+lBa/xjOiMcN3lX630oVz?= =?us-ascii?Q?+TAYlf3FDU3RZMO0OVp/uUuznxaWPVcDNcTgmlWTzaYkhmYglF1wlHDWU+vL?= =?us-ascii?Q?Zj9JWVETrvUb/1yhpMVxa8v9xhlmfceE2BqbOd6qFEXlVmFu8OELDutge/VD?= =?us-ascii?Q?3lZO+cxKMx6XKLYfJsEIIGvdW7wvCc2HOyHtxooSiKoMW0JFSv9b/b/T/u+y?= =?us-ascii?Q?nOUqOBTI4nVLku9Duwt8d0cmQ0zLEOe0mMleN5bG8F06k1L+FELTBkoT8Svz?= =?us-ascii?Q?m8gZnhSIOTUrC/bVi7Yx2rHeTKghvD4rOXuH0ZYuxQudVMxMod91PKPfJhcT?= =?us-ascii?Q?Sa0Eh50qCC//+luv7J3TfoFYKTm1MdzuvivvJIFqMRPliCn6Lz1wgjfWMcOh?= =?us-ascii?Q?FUhS25FVgJGTEuvss1cj4a5tbjB5UvGVYkKJdnbnBIfim1Lle/MtZYSnN9AS?= =?us-ascii?Q?tSorp8OdUSwnlVRMmIBsuDJ5qL65kSsAafW7j0XKQOc6/t+AtQpHYv4qrFP7?= =?us-ascii?Q?h/ROAfjNbj/hTN05OA8Mm1GOWrDpXsMyPZhQTsj25kbInYauz4NJkAxJbUZK?= =?us-ascii?Q?h6s9bLumM5HMBxbJ10dgRt7O5JQuOUM7j3Uv?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:12:05.6050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8bf4c65-af5c-484c-2678-08ddcf3863e3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6960 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=905ff393d18b024b7663cec7cfde74f28200b59d Thanks. Xueming Li --- >From 905ff393d18b024b7663cec7cfde74f28200b59d Mon Sep 17 00:00:00 2001 From: Rakesh Kudurumalla Date: Wed, 18 Jun 2025 14:00:06 +0530 Subject: [PATCH] examples/ipsec-secgw: fix crash in event vector mode Cc: Xueming Li [ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ] Launching ipsec-secgw application in event vector mode after traffic has started results in segfault because we are receiving few IPSec packet and application is trying to decrypt IPsec packets using lookaside protocol. This contradicts inline event mode.This patch fixes the same by freeing IPsec packets and processing only plain packets. Fixes: 1d5078c6cf19 ("examples/ipsec-secgw: support event vector in lookaside mode") Signed-off-by: Rakesh Kudurumalla Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec_worker.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index c9c43ebd2b..7d45300192 100644 --- a/examples/ipsec-secgw/ipsec_worker.c +++ b/examples/ipsec-secgw/ipsec_worker.c @@ -705,6 +705,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, struct rte_ipsec_session *sess; struct rte_mbuf *pkt; struct ipsec_sa *sa; + uint8_t mask = (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) | + (1UL << RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL); + j = ipsec_ev_route_ip_pkts(vec, rt, t); @@ -712,7 +715,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, for (i = 0; i < t->ipsec.num; i++) { pkt = t->ipsec.pkts[i]; sa = ipsec_mask_saptr(t->ipsec.saptr[i]); - if (unlikely(sa == NULL)) { + if (unlikely(sa == NULL) || ((1UL << sa->sessions[0].type) & mask)) { free_pkts(&pkt, 1); continue; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.093606313 +0800 +++ 0009-examples-ipsec-secgw-fix-crash-in-event-vector-mode.patch 2025-07-30 15:02:12.774913471 +0800 @@ -1 +1 @@ -From 811383ef109d8dae04c0681b84de09c51f153543 Mon Sep 17 00:00:00 2001 +From 905ff393d18b024b7663cec7cfde74f28200b59d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 811383ef109d8dae04c0681b84de09c51f153543 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index e0690fc8d9..04609964cd 100644 +index c9c43ebd2b..7d45300192 100644 @@ -26 +28 @@ -@@ -700,6 +700,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, +@@ -705,6 +705,9 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, @@ -36 +38 @@ -@@ -707,7 +710,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec, +@@ -712,7 +715,7 @@ ipsec_ev_inbound_route_pkts(struct rte_event_vector *vec,