From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FCFB46C4D for ; Wed, 30 Jul 2025 09:12:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A49240E28; Wed, 30 Jul 2025 09:12:35 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2055.outbound.protection.outlook.com [40.107.212.55]) by mails.dpdk.org (Postfix) with ESMTP id 279AA4025E for ; Wed, 30 Jul 2025 09:12:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w2z2lCK8FavGfel4Dth+/UA2wmzdkVWkjrqnTSNyTv/+SisxX23U1hFfwN8NBrK9NolVLOci/kLkONOqwtbI5UKacOZs9mcPIF4zD0l/F9Yfa2wNU8th8VS6yRpVQOeZRJEOsPshn82YJVHzBHRIbpuq0hVm0ZwmDHXvC8z9YT/ZVQ0tkKR6Qxkoob6yDZJnhqbjpGSG+FKNYoRlsCEEptDoiem58RbgG1bxaovAsa2c6ovyp81aEEuKI6mxNoJYXirQSo/KkUnENku2zy2ciFVprTdA2Z9eyhI3Rf6tEIhO37KO1xaDCvKQih2L/9p++WVrPaSQunPJuPEUHstqPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IfMDFleZjC9uy/9jHg0YkejbaCSQLSbOab/3PqIeB+o=; b=VVPrPGbZkJZ3uaygCK10OY8Y3RRgJDSm/I7rrw5HnU0FcU2rXUBL09D5LmDoJO8oYMLLc0feahFYXMdp8D4igaqOin99/dRpCxMlIy4f3cs4BGJP9j0zvzF/hYNVWxi47zVVUw820TlbGpJwXhLz9vkRwImbt37tTNA5Au5K7+zmHEJ1fv3rmDcDAMXPz+rAAqYOeD6PZ14JyGwLzXckTCpQ6bNycBeA4Pyd8qQicorTwTgn4J3A8xySKWSiV/UTojQ+Zz7kRFHhXIO+KQzIfRf03Bpzmel0Dxj/XaTreBdEQFCVTOOpf3GamQtx/pmvgDljqj5JdGZVIa2UelvW4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfMDFleZjC9uy/9jHg0YkejbaCSQLSbOab/3PqIeB+o=; b=Hlp+H5T+UVH//NbLxj9l6sbAZEQA7n/z5Q4kSD3piAzuyGLRPSQPJDm9CyrB7LunsNqTInfTyzXwc/a4fL5xqgzNjYPgYacRCGh8Oag70IT74OuesOXVg3S6YVpfbvwAfWafWjk7+v+bFAHEuoxbOaYdjLI9L/+N7g+nc/KZ470Ng2Fpq9ccTz75Ex2owi/lQbhZ5Z1hbv3Yq+G5hZAdngAMDIvfO64kVDL8w6O08nYY6lArrZtPHqpUacfjfLFOxnO5GsPviwdrSBlOLHUG8TTCluUFr9zyJAnVipHn6uy3Njwtyvm7bxYoEjvYBsvpifOVJq7Gb4YVAHmU4sgNbw== Received: from MW4PR04CA0360.namprd04.prod.outlook.com (2603:10b6:303:8a::35) by SA1PR12MB6894.namprd12.prod.outlook.com (2603:10b6:806:24d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.26; Wed, 30 Jul 2025 07:12:28 +0000 Received: from BY1PEPF0001AE1D.namprd04.prod.outlook.com (2603:10b6:303:8a:cafe::3c) by MW4PR04CA0360.outlook.office365.com (2603:10b6:303:8a::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 07:12:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE1D.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:12:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:12:08 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:12:06 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: Xueming Li , dpdk stable Subject: patch 'crypto/openssl: include private exponent in RSA session' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:23 +0800 Message-ID: <20250730071045.136672-13-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE1D:EE_|SA1PR12MB6894:EE_ X-MS-Office365-Filtering-Correlation-Id: 9edb4918-e1f6-4628-4f84-08ddcf38717a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?g7mmMTj7u9DnyrO9s9RURGgbFT3G82W3zPX3lRWwH9CYTymguh5QJFiUVy6d?= =?us-ascii?Q?YWnoPlOOppUf7MAojagTTxl13nBRlSo0hkwUE58TES4xB2YQvrtCesdQi0EN?= =?us-ascii?Q?eY1frlMtFCXjWAnQeU+KEyoI4nL3SSywowWQmUlXFFXx+Q0X8cdObyGNvmi3?= =?us-ascii?Q?boa3t2LMaGgENB69IahhTmcDngQX+SCXuvs23uh1VTO3hn5k5CybCs55VhLt?= =?us-ascii?Q?qA4DhRAtq8/MBFpJSM4yS/Ydd1vN2Gy7KhlVuiS90JbDk984THNjNH0If0bB?= =?us-ascii?Q?HqK1N691UXlhU7onafbp/k6yanJw6vQYkMBJKYZn4QIZYMqBj5gwNbrdA3Pt?= =?us-ascii?Q?hDlrojIi6wj8gqURk+NNPVi30k88YVytl13aLJCkaT8J+pNnAABAqFn+vACp?= =?us-ascii?Q?4nDekOScW2oYsGVI5w0mzRUPJulPPiVVsmNRaSKB+9XXiACPQy2TqjOTdodu?= =?us-ascii?Q?NE83laKTLlFUnl9jCJQkw+fjmPVKG7AhOCmRs5gYoHnTBWYRgSaLcv4rRI6+?= =?us-ascii?Q?cn383n8L/LPzIiYq0NblhSKlaaaVVD6knBVwDja9+WkifLbf5SnlmwJnAldO?= =?us-ascii?Q?BQeE+YCi1ya4yi+jtHIMu/bOfhFQrnOQhI7spn16eteCIto4Cp4FpLBdGViZ?= =?us-ascii?Q?dr8DRdIpZ9ctmenCnTgxVhUZw5uvm4p/EUWbMtkklIgq3X7OiAdTFkb5RGIs?= =?us-ascii?Q?tDR53TnDj4BFyXoFAcmJWCP5BGtYHiuUP7m+XusQSFRwW274XnFN9Il8Ocm5?= =?us-ascii?Q?16cTVkODV2N4a+29sdRA2sw48QzD6FG72+L0kLiYZV3Wb61e2TH+G5raLHf8?= =?us-ascii?Q?SucNGM7QlbaS98RyUU7sU6vfGCoZQb2QgmqPV1jN9OrEzj8VFHa6AOqGk6Ie?= =?us-ascii?Q?0mxLqTUnQ2LrktluUYFU3yZSBQhVkTwzWP07skNFC43tb0pmkoCBratJxKHH?= =?us-ascii?Q?y8DcS+ovWyj5fr1lWqtevFMjtI/rN5K8ODQ83FARuollSwwSq5e+9EgM89D9?= =?us-ascii?Q?+ng4zIP+DQELX1ok4Y1YiJnGoQqTA8SsgZtfzs2ECrz5Skw5qAsDpfAkglxZ?= =?us-ascii?Q?nicGRIfS6fIiMS0QPyY5vLG+sqbuwg5NtnyOJMK0rBIQnMPZfBhVhzZxHg7e?= =?us-ascii?Q?eMas4iI9DhkF+9P3AfhuRHJBOv6uQmFyU31RG4TD9YElK6w+6WKSFOKDwOC0?= =?us-ascii?Q?/xpxsKP0AsBdW4EBdM4x8m85awZGY16cW+DUXG0QpM2CklH/eR8kBDqR7UvE?= =?us-ascii?Q?jmUufB5QvZOY/UeS5Iy78x2P+2N5F2NOY4dZDBf1gCQ5BmrbfMm40e68h6nN?= =?us-ascii?Q?z/T5MK/4f4A2P/KBHtf3N87CDWxMS1+/q0f+RIYMO3fmFVB0vqAlslOblYL4?= =?us-ascii?Q?V0fgBXeu5CX1QpG2AY2p0CTa0Cj1Ms5MdN7jLQ/dpXYV4cllaKY2T4fZmbmX?= =?us-ascii?Q?H4BJQvO1g1/NrKf+GxA5X35OqhfPNVEAheYFqsXRKFH/58sr0TO6Tu1cL0lK?= =?us-ascii?Q?UlovW5fqoBLmd/zdeOS5FyXpgiEzh1n1nMV9?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:12:28.4723 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9edb4918-e1f6-4628-4f84-08ddcf38717a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE1D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6894 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0659ada6baf6340011f666e70b4331bf0830b8a4 Thanks. Xueming Li --- >From 0659ada6baf6340011f666e70b4331bf0830b8a4 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Fri, 20 Jun 2025 13:49:16 +0530 Subject: [PATCH] crypto/openssl: include private exponent in RSA session Cc: Xueming Li [ upstream commit 9020477270c5dc93e1a347b90d5248b10e8cc4e3 ] If private exponent is available, it should be included within RSA session as per RFC 8017 (A.1.2). OpenSSL 1.1.1 implementation rely on this private exponent, to implicitly reject invalid cipher. Hence, check if it is available for session and include it. Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c index b7b612fc57..bb260c7c25 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c @@ -995,7 +995,7 @@ static int openssl_set_asym_session_parameters( if (rsa == NULL) goto err_rsa; - if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_EXP) { + if (xform->rsa.d.length > 0) { d = BN_bin2bn( (const unsigned char *)xform->rsa.d.data, xform->rsa.d.length, @@ -1004,7 +1004,9 @@ static int openssl_set_asym_session_parameters( RSA_free(rsa); goto err_rsa; } - } else { + } + + if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT) { p = BN_bin2bn((const unsigned char *) xform->rsa.qt.p.data, xform->rsa.qt.p.length, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.187966747 +0800 +++ 0012-crypto-openssl-include-private-exponent-in-RSA-sessi.patch 2025-07-30 15:02:12.789830816 +0800 @@ -1 +1 @@ -From 9020477270c5dc93e1a347b90d5248b10e8cc4e3 Mon Sep 17 00:00:00 2001 +From 0659ada6baf6340011f666e70b4331bf0830b8a4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9020477270c5dc93e1a347b90d5248b10e8cc4e3 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 04e018f3df..d3aa396c76 100644 +index b7b612fc57..bb260c7c25 100644 @@ -23 +25 @@ -@@ -1025,7 +1025,7 @@ static int openssl_set_asym_session_parameters( +@@ -995,7 +995,7 @@ static int openssl_set_asym_session_parameters( @@ -32 +34 @@ -@@ -1034,7 +1034,9 @@ static int openssl_set_asym_session_parameters( +@@ -1004,7 +1004,9 @@ static int openssl_set_asym_session_parameters(