From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27BA546C4D for ; Wed, 30 Jul 2025 09:13:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D53B4025E; Wed, 30 Jul 2025 09:13:00 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by mails.dpdk.org (Postfix) with ESMTP id 1A9644025E for ; Wed, 30 Jul 2025 09:12:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rPV2f4E9GBbbo6E5deSIMp4cbhw+ulrm45XVV+6Xf8BKNG6P6ICGpvzl/rRZojl3fvUN852bjH/BlwYgRVLOIqwtA47MQ9HPuakswfH5rlozSRFKrEKw2eIRrLgdlraMkkDD72YSV1UD2nrRt8T9Ba96blkg94zWn07EMIf+HaqC6LXy03M7arPoWjAxyARDnIBXaN64ozRAIcW9KuN6TwmABBVcIqbY3P2jsGRRk0QO6ev3e+aPoZu8MKfgcXl5ATHNk6oTfKq4dcL4duMTdFQYu1DT/lkeslWbXVrOnaz/Q9fdoepl/PcU7oC5xTVESGsvzfTNrSM4Y7ZgPYLllw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MzJCmUVvA9bBgqc2txCsAFc1LsfVOESoG/Wi/j/e0wg=; b=HZevEadDvFMKw4RUhif2kiklw0ePeSrDdGwA4xi1KxWFBcUnoM6ruUXMREoTaqQYvvyNRzV+yhQLAZ0Q1ClKSJ1tehvmAh/RFV9ftmP8FzGXBvgkdixgFb0iEiH1wY7eEzXkXHvk1h3G8qDFBLPQuGu0ELsPpHmtft1ycUUlb7pIbw56AX2y/xowjLIhSBvoG4XWGg5n7SvmCZz/fkwQoTi/j10DzAPQvL7kBztg/6yLSb/r3QbnkLsUqqwcp3WRPt+ZXuB5naqYwUEvQs76HI2S9IORGmm17meZfBrdJsKbmRzSpl6wd1cPe+V/aDzyYVQ++L134yYg0Eid/F4Pog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MzJCmUVvA9bBgqc2txCsAFc1LsfVOESoG/Wi/j/e0wg=; b=uV2Ye8T+e8MU63u7G9Dp8aX+TWuHJsZa90rCDfZmJOcied3vmOD03/F6oa3SXgfp02RCemdP/kL7W73DbKUnrTpY7z9tf5mW//gvwLr8ajnAZDe6U8Ebd+HweteBLTLbKwNOsC9FCjcA//gUBdnabXat5jTYD0b6Er9ihoQzHZRBcZGLmo8/QqdqF2T6GwRd6jLRiw8xqzbe+JPMC0z/ewQziYgtRisreNPcut+li4hALJ9UYkDjir19H3MfRms1Cq77dHZjsJxbFwZP97WsIT3vqZgF/NelvepLuBXjJw6UtJ9fWKDD+LZzkDTIfrZwmjoClnzbCSfSKKwSa1U3Kw== Received: from BYAPR11CA0054.namprd11.prod.outlook.com (2603:10b6:a03:80::31) by DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.11; Wed, 30 Jul 2025 07:12:55 +0000 Received: from SJ1PEPF00001CDF.namprd05.prod.outlook.com (2603:10b6:a03:80:cafe::7) by BYAPR11CA0054.outlook.office365.com (2603:10b6:a03:80::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 07:12:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00001CDF.mail.protection.outlook.com (10.167.242.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:12:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:12:32 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:12:30 -0700 From: Xueming Li To: Pravin Pathak CC: Xueming Li , dpdk stable Subject: patch 'event/dlb2: fix QID depth xstat' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:26 +0800 Message-ID: <20250730071045.136672-16-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDF:EE_|DM4PR12MB5745:EE_ X-MS-Office365-Filtering-Correlation-Id: 3144b952-3561-42e6-1b5d-08ddcf388155 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|376014|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?77OQ19ctY+/4cBrTsNQAtqnnLtKM3VA6Uz/p70o8wfBhcDAHMkxvVugSYvS1?= =?us-ascii?Q?2HpRpNEpjDR0V5+pfc+kETSXPfCurZnPs78cLCxujiG++vCGpEtRSx+BEL2Z?= =?us-ascii?Q?nQg0V2YNxQ+LoDszLQIIa3jDE/miS+kx/O1gJ7PTpbXTrlobdulnI3b1t9w0?= =?us-ascii?Q?NICWeu+8S+oWtCA01BU9pD1xHsO7yBVCD1KYBXPVMWQ8e4lT5HxLHB8FpNUV?= =?us-ascii?Q?jNRFTQIlkQ/Xc1iF9wdi+7k2KTH61N11Ce815ZKMwXDFpjngwpmzVQlLDm4A?= =?us-ascii?Q?p00ieDz7d7HvZu8wsBu7HXseN/oGZbS4+exAKJ5l5A7zSLu47CH5EDJQOwTj?= =?us-ascii?Q?yDjs/KNkP/Ey/HrF7haKeuxTnf0HTqpF/DwrgqX1KSAbkqmWbQkfaZODYch/?= =?us-ascii?Q?LSPhrCTwn2wdVkgkbQA1DFcFlo8SGAT8h/Cr8xN9e7D49u5xhNC3o/IZDG5q?= =?us-ascii?Q?MQlnQ2HdvMGBP4DruH8bbGRhzrwKWH5aFs+5PWt8jQ0qEWssscKZEgUwu6JA?= =?us-ascii?Q?Xqkc2fK6my+z0Kr88I6OAQa9Mq32hg1Id5Yp+en1oak0rCk5Pp9tDnLL3Bwg?= =?us-ascii?Q?PSi6KbDjn1g1WX+WTLheYgzYGkEvSvf/Qn+xBPXafNdXv1w+i1OiJm52kevU?= =?us-ascii?Q?0wwv7vg2NodcsK+Qbu/pCWZ1qGTBNcggu9HFHyB43QZhXQjLGRRtATx9AonT?= =?us-ascii?Q?W4hZW7LDne3H7rmYs43hFZmsgRJVvmEmdJL8epVJW6o1ArkPWvkUx7/ylvR1?= =?us-ascii?Q?AbXrzUgdGHla8xAAiuvAhjrI7nKC6N2aAmfzJXxuDhDyY/FuB/07RRY7AZf/?= =?us-ascii?Q?NyvgHTfwP0cegUYqgdoJAjYAjicr0sPKP/qAy3yD0I1o5vY1GZqEd0eT+UUO?= =?us-ascii?Q?FGGMKvUJupaw+vYmdLl6ULi2oxfOD1Qz/8F/zP4vpG9oWZk3IMG6p9dCZiyp?= =?us-ascii?Q?6BhW0lAbMuYm92yy+GpnsVTGqs0AjqkVuc5fDorIF5dFOmMNVP3OlRWeQpZ8?= =?us-ascii?Q?+XpRXmTjizlE/zIE49u6xr87wwiSzJ/RnaOi5HkELY7sb/Mrn44xe5ogx5Fu?= =?us-ascii?Q?8im483h6Fcbm0HO3R+JdvZivr3kYl1fWbEynlnnR+CPO6HniW1RMlkWsyDwH?= =?us-ascii?Q?yjK05iNSfXHeVuJ1tA7OoEGsrzvumWseK8OV3hzJetGzuzNF7Gk9OgIvYGte?= =?us-ascii?Q?O6y/I/U8JCebEEpBzXREtCwOuFc0VJKweFCVHFXAj9tzBd8S+vxSAfYF97Yj?= =?us-ascii?Q?AHh2JvhEdaVy8y8cJhIHUoRVxdh640d1MwjoO4qQwvA9/12fUBmKRZsqahJt?= =?us-ascii?Q?PSk87Omd7wBcGWtoX5jUknmQBn1a88sXS+ZrAMGu6BERhgItsbrsu4BxqWhX?= =?us-ascii?Q?P73H+NOZyABmjXqcxHIwOW00/Fj/sP+qXanhzkW4DyaVlj92uhIWi2HfXep0?= =?us-ascii?Q?bj+Hgb8L21owhhozBxocI3gO2aEQ68/RQF3p1nlY8s0CzFhgkvnwbc5vw+b9?= =?us-ascii?Q?WxK3OOVQsIfdojYks6Mc1YVIrUHTu3Ent18b?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:12:55.0082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3144b952-3561-42e6-1b5d-08ddcf388155 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5745 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=3a34eb71cd5e8f5c075586e714856e13b79c0a32 Thanks. Xueming Li --- >From 3a34eb71cd5e8f5c075586e714856e13b79c0a32 Mon Sep 17 00:00:00 2001 From: Pravin Pathak Date: Wed, 18 Jun 2025 23:03:15 -0500 Subject: [PATCH] event/dlb2: fix QID depth xstat Cc: Xueming Li [ upstream commit 9891a50af0693ffef8471fdb1fb09ff8799c39f6 ] update QID depth xstats counter in vector dequeue path Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Pravin Pathak --- drivers/event/dlb2/dlb2.c | 8 ++++++++ drivers/event/dlb2/rte_pmd_dlb2.h | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index fc709d699f..181c2c79d7 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -3828,12 +3828,16 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, _mm_storeu_si128((__m128i *)&events[3], v_ev_3); DLB2_INC_STAT(qm_port->ev_port->stats.rx_sched_cnt[hw_sched3], 1); + DLB2_INC_STAT(qm_port->ev_port->stats.queue[ev_qid3].\ + qid_depth[RTE_PMD_DLB2_GET_QID_DEPTH(&events[3])], 1); /* fallthrough */ case 3: v_ev_2 = _mm_unpacklo_epi64(v_unpk_ev_23, v_qe_2); _mm_storeu_si128((__m128i *)&events[2], v_ev_2); DLB2_INC_STAT(qm_port->ev_port->stats.rx_sched_cnt[hw_sched2], 1); + DLB2_INC_STAT(qm_port->ev_port->stats.queue[ev_qid2].\ + qid_depth[RTE_PMD_DLB2_GET_QID_DEPTH(&events[2])], 1); /* fallthrough */ case 2: v_ev_1 = _mm_blend_epi16(v_unpk_ev_01, v_qe_1, 0x0F); @@ -3841,12 +3845,16 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, _mm_storeu_si128((__m128i *)&events[1], v_ev_1); DLB2_INC_STAT(qm_port->ev_port->stats.rx_sched_cnt[hw_sched1], 1); + DLB2_INC_STAT(qm_port->ev_port->stats.queue[ev_qid1].\ + qid_depth[RTE_PMD_DLB2_GET_QID_DEPTH(&events[1])], 1); /* fallthrough */ case 1: v_ev_0 = _mm_unpacklo_epi64(v_unpk_ev_01, v_qe_0); _mm_storeu_si128((__m128i *)&events[0], v_ev_0); DLB2_INC_STAT(qm_port->ev_port->stats.rx_sched_cnt[hw_sched0], 1); + DLB2_INC_STAT(qm_port->ev_port->stats.queue[ev_qid0].\ + qid_depth[RTE_PMD_DLB2_GET_QID_DEPTH(&events[0])], 1); } } diff --git a/drivers/event/dlb2/rte_pmd_dlb2.h b/drivers/event/dlb2/rte_pmd_dlb2.h index 334c6c356d..45a224df04 100644 --- a/drivers/event/dlb2/rte_pmd_dlb2.h +++ b/drivers/event/dlb2/rte_pmd_dlb2.h @@ -19,6 +19,12 @@ extern "C" { #include +/** + * Macro function to get QID depth of rte_event metadata. + * Currently lower 2 bits of 'rsvd' field are used to store QID depth. + */ + #define RTE_PMD_DLB2_GET_QID_DEPTH(x) ((x)->rsvd & 0x3) + /** * @warning * @b EXPERIMENTAL: this API may change, or be removed, without prior notice -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.272438837 +0800 +++ 0015-event-dlb2-fix-QID-depth-xstat.patch 2025-07-30 15:02:12.801018824 +0800 @@ -1 +1 @@ -From 9891a50af0693ffef8471fdb1fb09ff8799c39f6 Mon Sep 17 00:00:00 2001 +From 3a34eb71cd5e8f5c075586e714856e13b79c0a32 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9891a50af0693ffef8471fdb1fb09ff8799c39f6 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org @@ -13,2 +15,3 @@ - drivers/event/dlb2/dlb2.c | 8 ++++++++ - 1 file changed, 8 insertions(+) + drivers/event/dlb2/dlb2.c | 8 ++++++++ + drivers/event/dlb2/rte_pmd_dlb2.h | 6 ++++++ + 2 files changed, 14 insertions(+) @@ -17 +20 @@ -index f9bdfb3503..fd8cc70f3c 100644 +index fc709d699f..181c2c79d7 100644 @@ -20 +23 @@ -@@ -4145,6 +4145,8 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, +@@ -3828,12 +3828,16 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, @@ -29 +31,0 @@ -@@ -4152,6 +4154,8 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, @@ -38 +40 @@ -@@ -4160,6 +4164,8 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, +@@ -3841,12 +3845,16 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, @@ -47 +48,0 @@ -@@ -4167,6 +4173,8 @@ _process_deq_qes_vec_impl(struct dlb2_port *qm_port, @@ -54 +54,0 @@ - qm_port->reorder_id += valid_events; @@ -55,0 +56,18 @@ + +diff --git a/drivers/event/dlb2/rte_pmd_dlb2.h b/drivers/event/dlb2/rte_pmd_dlb2.h +index 334c6c356d..45a224df04 100644 +--- a/drivers/event/dlb2/rte_pmd_dlb2.h ++++ b/drivers/event/dlb2/rte_pmd_dlb2.h +@@ -19,6 +19,12 @@ extern "C" { + + #include + ++/** ++ * Macro function to get QID depth of rte_event metadata. ++ * Currently lower 2 bits of 'rsvd' field are used to store QID depth. ++ */ ++ #define RTE_PMD_DLB2_GET_QID_DEPTH(x) ((x)->rsvd & 0x3) ++ + /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice