From: Xueming Li <xuemingl@nvidia.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: Xueming Li <xuemingl@nvidia.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/txgbe: fix MAC control frame forwarding' has been queued to stable release 23.11.5
Date: Wed, 30 Jul 2025 15:10:31 +0800 [thread overview]
Message-ID: <20250730071045.136672-21-xuemingl@nvidia.com> (raw)
In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com>
Hi,
FYI, your patch has been queued to stable release 23.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/10/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=500e6df319140e88897c7590344611d09a578dcd
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
From 500e6df319140e88897c7590344611d09a578dcd Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu@trustnetic.com>
Date: Fri, 13 Jun 2025 16:41:53 +0800
Subject: [PATCH] net/txgbe: fix MAC control frame forwarding
Cc: Xueming Li <xuemingl@nvidia.com>
[ upstream commit b71127393a37cda0de6ca088f9945ee1a148e712 ]
Test Failure on the case "test_pause_fwd_port_stop_start", which expect
MAC control frame forwarding setting still working after port stop/start.
Fix the bug to pass the test case.
Fixes: 69ce8c8a4ce3 ("net/txgbe: support flow control")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/txgbe/base/txgbe_hw.c | 9 +++++++++
drivers/net/txgbe/base/txgbe_type.h | 1 +
drivers/net/txgbe/txgbe_ethdev.c | 1 +
3 files changed, 11 insertions(+)
diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c
index 7094551fee..64a39f46c8 100644
--- a/drivers/net/txgbe/base/txgbe_hw.c
+++ b/drivers/net/txgbe/base/txgbe_hw.c
@@ -176,6 +176,15 @@ s32 txgbe_setup_fc(struct txgbe_hw *hw)
TXGBE_MD_DEV_AUTO_NEG, reg_cu);
}
+ /*
+ * Reconfig mac ctrl frame fwd rule to make sure it still
+ * working after port stop/start.
+ */
+ wr32m(hw, TXGBE_MACRXFLT, TXGBE_MACRXFLT_CTL_MASK,
+ (hw->fc.mac_ctrl_frame_fwd ?
+ TXGBE_MACRXFLT_CTL_NOPS : TXGBE_MACRXFLT_CTL_DROP));
+ txgbe_flush(hw);
+
DEBUGOUT("Set up FC; reg = 0x%08X", reg);
out:
return err;
diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/base/txgbe_type.h
index f52736cae9..89f6017937 100644
--- a/drivers/net/txgbe/base/txgbe_type.h
+++ b/drivers/net/txgbe/base/txgbe_type.h
@@ -307,6 +307,7 @@ struct txgbe_fc_info {
u32 high_water[TXGBE_DCB_TC_MAX]; /* Flow Ctrl High-water */
u32 low_water[TXGBE_DCB_TC_MAX]; /* Flow Ctrl Low-water */
u16 pause_time; /* Flow Control Pause timer */
+ u8 mac_ctrl_frame_fwd; /* Forward MAC control frames */
bool send_xon; /* Flow control send XON */
bool strict_ieee; /* Strict IEEE mode */
bool disable_fc_autoneg; /* Do not autonegotiate FC */
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 25b657d0ff..add056125b 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -3501,6 +3501,7 @@ txgbe_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
hw->fc.low_water[0] = fc_conf->low_water;
hw->fc.send_xon = fc_conf->send_xon;
hw->fc.disable_fc_autoneg = !fc_conf->autoneg;
+ hw->fc.mac_ctrl_frame_fwd = fc_conf->mac_ctrl_frame_fwd;
err = txgbe_fc_enable(hw);
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-07-30 15:02:13.398176690 +0800
+++ 0020-net-txgbe-fix-MAC-control-frame-forwarding.patch 2025-07-30 15:02:12.819665505 +0800
@@ -1 +1 @@
-From b71127393a37cda0de6ca088f9945ee1a148e712 Mon Sep 17 00:00:00 2001
+From 500e6df319140e88897c7590344611d09a578dcd Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl@nvidia.com>
+
+[ upstream commit b71127393a37cda0de6ca088f9945ee1a148e712 ]
@@ -11 +13,0 @@
-Cc: stable@dpdk.org
@@ -21 +23 @@
-index 76b9ee3c0a..42cd0e0e2c 100644
+index 7094551fee..64a39f46c8 100644
@@ -24 +26 @@
-@@ -226,6 +226,15 @@ s32 txgbe_setup_fc(struct txgbe_hw *hw)
+@@ -176,6 +176,15 @@ s32 txgbe_setup_fc(struct txgbe_hw *hw)
@@ -41 +43 @@
-index 383438ea3c..65527a22e7 100644
+index f52736cae9..89f6017937 100644
@@ -44 +46 @@
-@@ -299,6 +299,7 @@ struct txgbe_fc_info {
+@@ -307,6 +307,7 @@ struct txgbe_fc_info {
@@ -53 +55 @@
-index e5736bf387..b68a0557be 100644
+index 25b657d0ff..add056125b 100644
@@ -56 +58 @@
-@@ -3586,6 +3586,7 @@ txgbe_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
+@@ -3501,6 +3501,7 @@ txgbe_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
next prev parent reply other threads:[~2025-07-30 7:13 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 12:00 patch " Xueming Li
2025-06-26 12:00 ` patch 'ethdev: convert string initialization' " Xueming Li
2025-06-26 12:00 ` patch 'net/fm10k/base: fix compilation warnings' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe/base: correct definition of endianness macro' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe/base: fix compilation warnings' " Xueming Li
2025-06-26 12:00 ` patch 'net/i40e/base: fix unused value " Xueming Li
2025-06-26 12:00 ` patch 'net/i40e/base: fix compiler " Xueming Li
2025-06-26 12:00 ` patch 'acl: fix build with GCC 15 on aarch64' " Xueming Li
2025-06-26 12:00 ` patch 'eal/linux: improve ASLR check' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix xstats name' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix EEPROM dump' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe: enable ethertype filter for E610' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe: fix port mask default value in filter' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix igb Tx queue offloads capability' " Xueming Li
2025-06-26 12:00 ` patch 'net/ice: fix flow creation failure' " Xueming Li
2025-06-26 12:00 ` patch 'vhost: fix wrapping on control virtqueue rings' " Xueming Li
2025-06-26 12:00 ` patch 'vhost/crypto: fix cipher data length' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/virtio: fix cipher data source " Xueming Li
2025-06-26 12:00 ` patch 'app/crypto-perf: fix AAD offset alignment' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/qat: fix out-of-place header bytes in AEAD raw API' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/qat: fix out-of-place chain/cipher/auth headers' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix header modify action on group 0' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: validate GTP PSC QFI width' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix counter service cleanup on init failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5/hws: fix send queue drain on FW WQE destroy' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: remove unsupported flow meter action in HWS' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix maximal queue size query' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix mark action with shared Rx queue' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: align PF and VF/SF MAC address handling' " Xueming Li
2025-06-26 12:00 ` patch 'net/sfc: fix action order on start failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/nfp: fix crash with null RSS hash key' " Xueming Li
2025-06-26 12:00 ` patch 'net/nfp: fix hash key length logic' " Xueming Li
2025-06-26 12:00 ` patch 'app/testpmd: fix RSS hash key update' " Xueming Li
2025-06-26 12:00 ` patch 'net/af_xdp: fix use after free in zero-copy Tx' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix integer overflow in interrupt unmap' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix memory leak on failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix extra wait for link up' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix memory leak for indirect flow action' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix interrupt rollback' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix divide by zero' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: fix resources release on reset' " Xueming Li
2025-06-26 12:01 ` patch 'net/nfp: standardize NFD3 Tx descriptor endianness' " Xueming Li
2025-06-26 12:01 ` patch 'net/nfp: standardize NFDk " Xueming Li
2025-06-26 12:01 ` patch 'net/qede: fix use after free' " Xueming Li
2025-06-26 12:01 ` patch 'bus/fslmc: " Xueming Li
2025-06-26 12:01 ` patch 'net/null: fix packet copy' " Xueming Li
2025-06-26 12:01 ` patch 'bus/vmbus: align ring buffer data to page boundary' " Xueming Li
2025-06-26 12:01 ` patch 'bus/vmbus: use Hyper-V page size' " Xueming Li
2025-06-26 12:01 ` patch 'net/netvsc: " Xueming Li
2025-06-26 12:01 ` patch 'net/netvsc: add stats counters from VF' " Xueming Li
2025-06-26 12:01 ` patch 'app/testpmd: relax number of TCs in DCB command' " Xueming Li
2025-06-26 12:01 ` patch 'net/mana: check vendor ID when probing RDMA device' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: fix CRC data segment' " Xueming Li
2025-06-26 12:01 ` patch 'net/tap: fix qdisc add failure handling' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: fix VLAN stripping on hairpin queue' " Xueming Li
2025-06-26 12:01 ` patch 'mem: fix lockup on address space shortage' " Xueming Li
2025-06-26 12:01 ` patch 'test/malloc: improve resiliency' " Xueming Li
2025-06-26 12:01 ` patch 'trace: fix overflow in per-lcore trace buffer' " Xueming Li
2025-06-26 12:01 ` patch 'common/cnxk: fix E-tag pattern parsing' " Xueming Li
2025-06-26 12:01 ` patch 'common/cnxk: fix CQ tail drop' " Xueming Li
2025-06-26 12:01 ` patch 'net/cnxk: fix descriptor count update on reconfig' " Xueming Li
2025-06-26 12:01 ` patch 'ethdev: fix error struct in flow configure' " Xueming Li
2025-06-26 12:01 ` patch 'net/ice/base: fix integer overflow' " Xueming Li
2025-06-26 12:01 ` patch 'net/ice/base: fix typo in device ID description' " Xueming Li
2025-06-26 12:01 ` patch 'common/dpaax: fix PDCP key command race condition' " Xueming Li
2025-06-26 12:01 ` patch 'common/dpaax: fix PDCP AES only 12-bit SN' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/dpaa2_sec: fix uninitialized variable' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: add request check on request side' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: fix driver cleanup' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: fix driver ID' " Xueming Li
2025-06-26 12:01 ` patch 'ethdev: keep promiscuous/allmulti value before disabling' " Xueming Li
2025-06-26 12:01 ` patch 'eal: fix return value of lcore role' " Xueming Li
2025-06-26 12:01 ` patch 'eal: warn if no lcore is available' " Xueming Li
2025-06-26 12:01 ` patch 'test/lcore: fix race in per-lcore test' " Xueming Li
2025-06-26 12:01 ` patch 'bus: cleanup device lists' " Xueming Li
2025-06-26 12:01 ` patch 'eal/linux: unregister alarm callback before free' " Xueming Li
2025-06-26 12:01 ` patch 'eal/freebsd: " Xueming Li
2025-06-26 12:01 ` patch 'bus/pci/bsd: fix device existence check' " Xueming Li
2025-06-26 12:01 ` patch 'power/intel_uncore: fix crash closing uninitialized driver' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/qat: fix size calculation for memset' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: avoid setting kernel MTU if not needed' " Xueming Li
2025-06-26 12:01 ` patch 'doc: add kernel options required for mlx5' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: fix hypervisor detection in VLAN workaround' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: check requirement for hardware GRO' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: allow Tx vector when fast free not enabled' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: allow Rx vector mode with VLAN filter' " Xueming Li
2025-07-30 7:10 ` patch " Xueming Li
2025-07-30 7:10 ` patch 'net/hns3: fix Rx packet without CRC data' " Xueming Li
2025-07-30 7:10 ` patch 'common/mlx5: fix extraction of auxiliary device name' " Xueming Li
2025-07-30 7:10 ` patch 'net/ice: fix handling empty DCF RSS hash' " Xueming Li
2025-07-30 7:10 ` patch 'common/cnxk: fix null pointer checks' " Xueming Li
2025-07-30 7:10 ` patch 'vhost: fix net control virtqueue used length' " Xueming Li
2025-07-30 7:10 ` patch 'eal/unix: fix log message for madvise failure' " Xueming Li
2025-07-30 7:10 ` patch 'buildtools/test: scan muti-line registrations' " Xueming Li
2025-07-30 7:10 ` patch 'examples/ipsec-secgw: fix crash with IPv6' " Xueming Li
2025-07-30 7:10 ` patch 'examples/ipsec-secgw: fix crash in event vector mode' " Xueming Li
2025-07-30 7:10 ` patch 'test/crypto: fix auth and cipher case IV length' " Xueming Li
2025-07-30 7:10 ` patch 'test/crypto: set to null after freeing operation' " Xueming Li
2025-07-30 7:10 ` patch 'crypto/openssl: include private exponent in RSA session' " Xueming Li
2025-07-30 7:10 ` patch 'event/dlb2: fix validaton of LDB port COS ID arguments' " Xueming Li
2025-07-30 7:10 ` patch 'event/dlb2: fix num single link ports for DLB2.5' " Xueming Li
2025-07-30 7:10 ` patch 'event/dlb2: fix QID depth xstat' " Xueming Li
2025-07-30 7:10 ` patch 'event/dlb2: fix public symbol namespace' " Xueming Li
2025-07-30 7:10 ` patch 'app/eventdev: fix number of releases sent during cleanup' " Xueming Li
2025-07-30 7:10 ` patch 'net/txgbe: fix ntuple filter parsing' " Xueming Li
2025-07-30 7:10 ` patch 'net/txgbe: fix raw pattern match for FDIR rule' " Xueming Li
2025-07-30 7:10 ` Xueming Li [this message]
2025-07-30 7:10 ` patch 'net/ngbe: fix MAC control frame forwarding' " Xueming Li
2025-07-30 7:10 ` patch 'net/txgbe: fix device statistics' " Xueming Li
2025-07-30 7:10 ` patch 'net/ngbe: " Xueming Li
2025-07-30 7:10 ` patch 'net/txgbe: restrict VLAN strip configuration on VF' " Xueming Li
2025-07-30 7:10 ` patch 'net/hns3: fix queue TC " Xueming Li
2025-07-30 7:10 ` patch 'net/bonding: avoid RSS RETA update in flow isolation mode' " Xueming Li
2025-07-30 7:10 ` patch 'net/octeon_ep: increase mailbox timeout' " Xueming Li
2025-07-30 7:10 ` patch 'bus/auxiliary: fix crash in cleanup' " Xueming Li
2025-07-30 7:10 ` patch 'examples/multi_process: fix ports cleanup on exit' " Xueming Li
2025-07-30 7:10 ` patch 'examples/flow_filtering: fix make clean' " Xueming Li
2025-07-30 7:10 ` patch 'dts: fix deterministic doc' " Xueming Li
2025-07-30 7:10 ` patch 'examples/multi_process: revert ports cleanup on exit' " Xueming Li
2025-07-30 7:10 ` patch 'doc: remove reference to deprecated --use-device option' " Xueming Li
2025-07-30 7:10 ` patch 'eal: add description of service corelist in usage' " Xueming Li
2025-07-30 14:56 ` patch " Xueming Li
2025-07-30 14:56 ` patch 'net/txgbe: fix packet type for FDIR filter' " Xueming Li
2025-07-30 14:56 ` patch 'net/txgbe: fix to create FDIR filter for SCTP packet' " Xueming Li
2025-07-30 14:56 ` patch 'net/txgbe: fix reserved extra FDIR headroom' " Xueming Li
2025-07-30 14:56 ` patch 'net/txgbe: add LRO flag in mbuf when enabled' " Xueming Li
2025-07-30 14:56 ` patch 'net/mlx5: fix crash in HWS counter pool destroy' " Xueming Li
2025-07-30 14:56 ` patch 'net/mlx5: fix crash on age query with indirect conntrack' " Xueming Li
2025-07-30 14:56 ` patch 'net/mlx5: fix WQE size calculation for Tx queue' " Xueming Li
2025-07-30 14:56 ` patch 'net/ixgbe: fix indentation' " Xueming Li
2025-07-30 14:56 ` patch 'net/ice: fix querying RSS hash for DCF' " Xueming Li
2025-07-30 14:56 ` patch 'net/iavf: fix VLAN strip setting after enabling filter' " Xueming Li
2025-07-30 15:23 ` Amiya Ranjan Mohakud
2025-07-31 6:04 ` Xueming Li
2025-07-30 14:56 ` patch 'vhost: search virtqueues driver data in read-only area' " Xueming Li
2025-07-30 14:56 ` patch 'net/virtio: fix check of threshold for Tx freeing' " Xueming Li
2025-07-30 14:56 ` patch 'common/cnxk: fix qsize in CPT iq enable' " Xueming Li
2025-07-30 14:56 ` patch 'test/crypto: fix RSA decrypt validation' " Xueming Li
2025-07-30 14:56 ` patch 'event/dlb2: fix dequeue with CQ depth <= 16' " Xueming Li
2025-07-30 14:56 ` patch 'event/dlb2: fix default credits based on HW version' " Xueming Li
2025-07-30 14:56 ` patch 'latencystats: fix receive sample race' " Xueming Li
2025-07-30 14:56 ` patch 'net/ice: fix inconsistency in Rx queue VLAN tag placement' " Xueming Li
2025-07-30 15:03 ` Richardson, Bruce
2025-07-31 6:07 ` Xueming Li
2025-07-30 14:56 ` patch 'net/i40e: fix RSS on plain IPv4' " Xueming Li
2025-07-30 14:56 ` patch 'net/virtio: revert Tx free threshold fix' " Xueming Li
2025-07-30 14:56 ` patch 'net/mlx5: fix masked indirect age action validation' " Xueming Li
2025-07-30 14:56 ` patch 'net/mlx5: fix out-of-order completions in ordinary Rx burst' " Xueming Li
2025-07-30 14:56 ` patch 'examples/ntb: check more heap allocations' " Xueming Li
2025-07-30 14:56 ` patch 'examples/ipsec-secgw: fix number of queue pairs' " Xueming Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730071045.136672-21-xuemingl@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).