From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5774A46C4D for ; Wed, 30 Jul 2025 09:13:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50CDB4025E; Wed, 30 Jul 2025 09:13:37 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) by mails.dpdk.org (Postfix) with ESMTP id 711944025E for ; Wed, 30 Jul 2025 09:13:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LjDZzC4LLoYNd0Le4lRGT358pc37AILLmKisGIaOh8Dd14wyJoBxt3HxpzV0qyEuauFIBkv0rz3gvmy0ETaL/Gn2tOkF+CxoiS6MXoRr+58/GYMsS/MGg6CCdNEAI1lSFS9gN2pUyA9FOVq9X+w/GZOZ4OfpTdMuMAep2r2S7k55ys+ggrNtrTmBOdJ4bnNd83zngrQCVs3O2wZJ5cozlyCtTtXuDIOThfSbVjMH4OD3hnvcbw7SGOieuNLAmimCafOkNovoo5VgXpx4MjM+CbIDG8VzD6LV6vCiiK0zGfY9CHTo3Hc+4s9lC0/bplc37bqaPBmQnlaWuq9NbxWSvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ob+pRzwjuQ4HTaNu77guMZgZ9/HFzq2F5PVlYeyLVns=; b=CDffKRqELRn3yQgmjmct+cx4vo0Pv6V4NgdDELVc9I9ueO36EIrm9QeheiK9sz33HXkGl2KBh4xMZ+P4qjBVkr6+fz2DjRTi9FoMR1QEwYM4YIViHfgnFHxxVoB3/vOrUk/+P4EPfddaO6jmzY70+aRrZ0sdETvI/JgyRQoBnxkcS7hntJ48ajMCpYB9g1IhbFpKdje6dboTTszgKwdnzDcYs0ESXHW+JgcB2J/ViOvPaikk1pAxJXvlO9C356SYPJXzgD4OtXQDJwt3EXyon8vjgF8UutsdOVRKh7/f8uN4LykmHrq6ZC2pM/XI/jE9qf+ekNtu+v/ARW0vPqDrhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ob+pRzwjuQ4HTaNu77guMZgZ9/HFzq2F5PVlYeyLVns=; b=cbg+Dtu+6gLd/7KfQzCURMunBVAbJVkRMv1UwhXVyscfwQSrUoplEY+A+QKjzL9FWafQs7XA43gspVhdSYYT6JP7e7mYWZkAX1ITGKljkv1Tcz6AcDyXpEStAlViWaPDecQZ9lBhEILHwppVv77Be8K6jWtlYb95RA9iZVcHNV7lmZ9EUVJgrXPzugpf+IOznQzXiLKAGAV5otgs/zAcq60QMdb8gcLRf9b9lIU9o+NHXTuYyxPboZc8cwzfMzzRzWskpApdZ/dBjGWezm2yCDf8M968Rw5fAM8LBNcaJSkem4v3nQ3JcrkY+CD5KvLpTZxGNBWUFXR2CXYkBOYRxg== Received: from BY5PR17CA0060.namprd17.prod.outlook.com (2603:10b6:a03:167::37) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.12; Wed, 30 Jul 2025 07:13:30 +0000 Received: from BY1PEPF0001AE1D.namprd04.prod.outlook.com (2603:10b6:a03:167:cafe::8d) by BY5PR17CA0060.outlook.office365.com (2603:10b6:a03:167::37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.26 via Frontend Transport; Wed, 30 Jul 2025 07:13:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE1D.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:13:30 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:11 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:09 -0700 From: Xueming Li To: Jiawen Wu CC: Xueming Li , dpdk stable Subject: patch 'net/ngbe: fix device statistics' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:34 +0800 Message-ID: <20250730071045.136672-24-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE1D:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: cb39b6ee-0a86-41d3-e195-08ddcf389644 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FOHrguEJlXSHaLLsa38GWPjFIuIWysgAwqXNC3L9EGCBZ25n2gg1xJQ5WnQg?= =?us-ascii?Q?LCsBvKlqRQVJ3TBrLEZnKst7RUG3m+7pJ8J+NSh61qBE0rQAlHMk6NoJtQh9?= =?us-ascii?Q?ZEMZXGf/wsH6NSM9bODkPlvdJUlrfSBUV3A1t8uJCjP5iawX6pdxoXBCG1+9?= =?us-ascii?Q?iUgKOpfc17Fh40hjHj2w/OBymbmsuFP6WCSNA1O4lWiyViI97uthCzSFj97Q?= =?us-ascii?Q?A1XzcYeS/cn8q9HlXbO8VQWAfDy73hT9kVSgLAYeu7TRSgGS/0PjuGXFqcro?= =?us-ascii?Q?AG4KtRP1cxojW+xCOR5a97YfKIxq09keTLJCkyu9vUhNbap0FrXrXp3SlkJg?= =?us-ascii?Q?bS9r5C9cQlD+w5VUiDMt8Ku7sQVeC3EDM3Nh/w/agkOj4OJRVzRSfT7kS8+2?= =?us-ascii?Q?PGTt+ia/0/YgfZTNTIV2kArOB/PUmnvfnTUxulkx6h9W2eB/jK92BxnjZ4z8?= =?us-ascii?Q?KNQLhyzctNdghsjApVUB1Q8nf21Tm8yEZxcIyZiIk7VC1kJiNqrj5m6gGerX?= =?us-ascii?Q?ljvup5ZnsJzZP/xNSQFJa2btMdjni/e3dyPwAly+4JbwmKgXI41rLTDr6AcE?= =?us-ascii?Q?gChmHzyi46ujlSh79YB58qNV51oDbexYPjWtbnqQDTWe/KmgmNkIGLphcijv?= =?us-ascii?Q?fiK/u04NYXIcBxh5/DTOzWYm8Q8HnEXqgm6YpRcwZPzvwwfsKG+AZNc/uENm?= =?us-ascii?Q?/m2HGc+7QW5VflTms457kou4dnoapogyW454wv759+Xi8MQQSsNtaDfg6kdd?= =?us-ascii?Q?o87abnFEzZQSk19q9P7TkrigwyJlC0g06YZhBGUfN2h+fHloc1NCSW2ncmYB?= =?us-ascii?Q?Bq1t/KOdVcnKXMaGBnqiUQiU98ttvzxz97IE6OyGEy/RgrfgiqZ/uCmXqKGx?= =?us-ascii?Q?l+dRKX/irUrcXkn2+xuEzxNQ5PY3NqD69rr7y+1lq2vDgFoDZEqeMGT4GfUs?= =?us-ascii?Q?6v6HmjTIcTCzI8RULFFqlI3uT6xvglXLrgxCxFANwPLYszCpSXXKZtd0nUlM?= =?us-ascii?Q?rjH+ZcNbko84ZEosBeF4SnBnOUKF6id/KryqxDSr0E4OkDaPazp9weG4suSq?= =?us-ascii?Q?25dDJuaVd+/sGtRS4DFDTY2d/02Rq3uZR/vb5bPzxUSuLuBVXQec5P9Ebvrx?= =?us-ascii?Q?VZ6qGJEa1EuVAKZCCG560xq0rVjiGN61guK8dTAnqxPBa5MzeyZI+yQb2bE0?= =?us-ascii?Q?UPEw+IwseEuTMhCnUT8fJoMEVPCDYXN2yaC/7qq96KhlA8ZtuNMryEFgqtyZ?= =?us-ascii?Q?kf0xNesXn8gTt+udXY9D7K1d13IcO7Ph83W1IFVpbCQF2MpisGkoBOnvngf4?= =?us-ascii?Q?FFwhJNfb+A3tSubsZ0hOQvZbseyWoAmvNbO3jK2wZQ8TRFvi/TS50JmtX4AA?= =?us-ascii?Q?ONeDYZGHo5yvzsh4t567PWgM7TwX9tm0n9HfKsOhvOFXYrexB+VzL1AVds6s?= =?us-ascii?Q?Iy2Q7FkzO+dCDDoDgOZqos3v3Ld1JshLy60kLv77H2+TKIpDf5ALD9TLS8De?= =?us-ascii?Q?HEmK+nCsz3HYRhsxrVQv/ZXBerBTAzz+8ZFS?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:13:30.1459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb39b6ee-0a86-41d3-e195-08ddcf389644 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE1D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=32b0db8d7e11a87470c77496c8f7ddb117e0c108 Thanks. Xueming Li --- >From 32b0db8d7e11a87470c77496c8f7ddb117e0c108 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Fri, 13 Jun 2025 16:41:56 +0800 Subject: [PATCH] net/ngbe: fix device statistics Cc: Xueming Li [ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] The extend statistic "rx_undersize_errors" is incorrectly read as the counter of frames received with a length error, which names "rx_length_error". And "rx_undersize_errors" is the counter of shorter-than-64B frames received without any errors. In addition, "tx_broadcast_packets" should use rd64() to get the full count on the low and high registers. Fixes: fdb1e851975a ("net/ngbe: support basic statistics") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index ae33bb5871..bce63d26b5 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1421,7 +1421,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->rx_total_bytes += rd64(hw, NGBE_MACRXGBOCTL); hw_stats->rx_broadcast_packets += rd64(hw, NGBE_MACRXOCTL); - hw_stats->tx_broadcast_packets += rd32(hw, NGBE_MACTXOCTL); + hw_stats->tx_broadcast_packets += rd64(hw, NGBE_MACTXOCTL); hw_stats->rx_size_64_packets += rd64(hw, NGBE_MACRX1TO64L); hw_stats->rx_size_65_to_127_packets += rd64(hw, NGBE_MACRX65TO127L); @@ -1440,7 +1440,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, hw_stats->tx_size_1024_to_max_packets += rd64(hw, NGBE_MACTX1024TOMAXL); - hw_stats->rx_undersize_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_length_errors += rd64(hw, NGBE_MACRXERRLENL); + hw_stats->rx_undersize_errors += rd32(hw, NGBE_MACRXUNDERSIZE); hw_stats->rx_oversize_cnt += rd32(hw, NGBE_MACRXOVERSIZE); hw_stats->rx_jabber_errors += rd32(hw, NGBE_MACRXJABBER); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.477812827 +0800 +++ 0023-net-ngbe-fix-device-statistics.patch 2025-07-30 15:02:12.827124178 +0800 @@ -1 +1 @@ -From a65009b7621a60faeb1bbefe65160eb5646925dc Mon Sep 17 00:00:00 2001 +From 32b0db8d7e11a87470c77496c8f7ddb117e0c108 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a65009b7621a60faeb1bbefe65160eb5646925dc ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index a8f847de8d..d3ac40299f 100644 +index ae33bb5871..bce63d26b5 100644 @@ -26 +28 @@ -@@ -1429,7 +1429,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, +@@ -1421,7 +1421,7 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, @@ -35 +37 @@ -@@ -1448,7 +1448,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw, +@@ -1440,7 +1440,8 @@ ngbe_read_stats_registers(struct ngbe_hw *hw,