From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B34A046C4D for ; Wed, 30 Jul 2025 09:14:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE5A44025E; Wed, 30 Jul 2025 09:14:06 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2081.outbound.protection.outlook.com [40.107.236.81]) by mails.dpdk.org (Postfix) with ESMTP id 358D54025E for ; Wed, 30 Jul 2025 09:14:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RvhKYCbDVGRwMQd/6/V8GA9DwiZWo+8BwU6r55az1pEctTCYJHzg0jhoKk0wgZg+FiszeE2bwo/uy2q6QRc5NaZzvgFZkeSTr4hAGLMA6aU9qwowCvsEsaddCBs6aL8UkXNkxLFGoHFP4uhj728mS51MEpcOo51XwZA7hV2THd62WHdqpHI3tdFis6ztJ5D65RplCevgErdMM83U3iWxjJLw6owNZLey7m8a6KixTrNuyfwf8ibHr3GD/afKDuH273v3EdF48WQVKXW/IlrOu5Kpk60+48/YIEEb6rFvqI8OhGHiqYMS/lYwnXoNOY3Jpx0QU0rQAYc+DuNmjNVp9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ef7PIR66SfPjqwtROLwa98TT4pe1yRVOtCt6De8qDog=; b=FgxspWb2nJiadufXT8+eJ+66cMxQMmsWmMwDCRjCzHDj5caL8XBXHE4liX0moei27/wuZqBmEH3ucTinbxtjNooSUEs1PZ/u18V/RRaORuijK/bbKYnpdaL2EHmtWzXflSzmclv0akwM9Q8ZurZLEsDVWpHWq3soRCP4y5cYIVOlqFbu9xGuKmjd4D2GAqim8/fqhsqCr3wbJ9F+YlFoRrOZSHJevGHou5hEDaBmw3azs1MuTdDOdDWr2cxsO8W1/C5bwhGflJTj+rRNis/GoDfZtl78r0KqKwNFcdL7lXJXG6MNX0OHVT7ibQrEaZ4bruB+rpKJfG9Kv/C7PoNo3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=oracle.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ef7PIR66SfPjqwtROLwa98TT4pe1yRVOtCt6De8qDog=; b=WOqf2A+27y8ey2gyaFpDQXwO1kB0USZbPTHlptYXpqYcZsij75gpOHk8GZHtWm+jI6eEx2Emaql867XTsrsdzsBGvZRx1Nehu75XWMrJBbClft2n1NkrN8w+hudD1I8BMSw1wBYuW6dJTDHpnHc/fF18uV9qf5d80LJ25Si+G5PpLdBTjs7JPRxY9LyQ/UGhyoH70Prs/VN4ZePul+F39KKIJBpYQX4oOS06Ep8n2dLQUd/wGLqyryrQlKNzV9OadKQjMbaGZZKyvO+ofG8Jo8ARuXIP8qHp1wclJpU+ubCEyxYgw7P4KzAZm+eFPRbcpBG0Q5QIO8K+VRRHSulmcg== Received: from BY5PR17CA0059.namprd17.prod.outlook.com (2603:10b6:a03:167::36) by CH2PR12MB4327.namprd12.prod.outlook.com (2603:10b6:610:7d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.27; Wed, 30 Jul 2025 07:14:01 +0000 Received: from BY1PEPF0001AE1D.namprd04.prod.outlook.com (2603:10b6:a03:167:cafe::b5) by BY5PR17CA0059.outlook.office365.com (2603:10b6:a03:167::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 07:14:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE1D.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:14:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:41 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:39 -0700 From: Xueming Li To: Madhuker Mythri CC: Xueming Li , dpdk stable Subject: patch 'net/bonding: avoid RSS RETA update in flow isolation mode' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:37 +0800 Message-ID: <20250730071045.136672-27-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE1D:EE_|CH2PR12MB4327:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c105be-2a91-4db3-9b11-08ddcf38a8d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?c/Sev9XwdnOsMsG5d9gJJWcT2+afetKv7UXBn1rax/LuMk8X4/HbWmIPohNw?= =?us-ascii?Q?JKvteVqPqn8wE4fZLbrx8l0RIxVG4KCmhVV/o3ik0qIHBD5uddU1zzK6cqau?= =?us-ascii?Q?h0pjcXbV+zthSFSK/7YCz6EjiaPyidIPs8uzez1TXzSjvFdQ28T9vvHsIEZE?= =?us-ascii?Q?9SjpeuHLaRbMRKq/LzdSnIWmKn9sNdSjmF2IHagOG4ddsPwm8qxfmwKb0Rdm?= =?us-ascii?Q?HCznhRl12a0tqCUFFSA215urpAwtieQ5E2330OuC20CrYUnqYGIy/3cwRpdW?= =?us-ascii?Q?/A6zvfohzi5tFvg71+u3jzDxWvHBx3bsJ2ZOLpXu3fXy8WpMgbB7AhrgCZ0y?= =?us-ascii?Q?MoC27wugp5Is0n6mfVy89jAT82x5tIFt0f1UWyV64oVB6Ndr0e+rmus82SnB?= =?us-ascii?Q?F8pVFE22JUKpQvgegVRLE7GS3LOJ5WoBHExeJHkLDjyn7ywgnW9YeFnvJm0Q?= =?us-ascii?Q?HE9fKiRyTpBlJNaiwKbGYCWJ7TNu1NV1IOLIGkHIMN4CA89UnFOvdfdMggD+?= =?us-ascii?Q?u93P+FQhFK/0kjC6Y+ox8LFDKSrkFjQvU3gdnIjZ4FnnK3+AnbRB+1OAKiQb?= =?us-ascii?Q?HIUgyAKqEEckyIzXQPjU1SxYCwm8aZhQHnfPW46Crq580xwNCGpCYVRpTNfm?= =?us-ascii?Q?hbBYmOhC7ICqgcpMyYF+xM5SSu0I4AP27nzT7h4YO32LB2b7yWDs7E1tYuv8?= =?us-ascii?Q?7qfSBkB7XoUQI1Xk6pXXCvS4uJMTnFvchxS+QRMH9Bt7Jk6vL+3/JJbBFMM8?= =?us-ascii?Q?/hbe/lTP0NQulmLlHQ5epSJvNUCYeSj0u9Ce0+S+LqZfL6Y5Z90jR6+jQ2zj?= =?us-ascii?Q?jtqnEWlrM3VqUc87Ct7ulKDYttwJxSA9MVbeBSD6zqSM8kLChx983wOjVdhp?= =?us-ascii?Q?xkw9qn0dbjAY12CX3szkjS6uhJzPVDbTpLUr4oT67jZkZfaJ2GxjcKH6Upnm?= =?us-ascii?Q?kVygKDmo3wJearf4nEi8FcpzKDIAb2KcVVkExMfdo1IrYa469CeEyAn754UU?= =?us-ascii?Q?82lczA6xrvjybJQeRUbRWAzaUPgBDa3QjQzblaLSmqPC+Ng9Tva++MmWQAkz?= =?us-ascii?Q?0RccfkOqvT2+AW5xFB2dXZvQnPFt3DYl3mAWxA4r/sMiDY0qRQ/MGGs4OxC9?= =?us-ascii?Q?/Db4NTUDjyPx1khBqBE/m5MSrE99zERJVaPDnIwWeIoiyfK6HKph/Cz8B1cK?= =?us-ascii?Q?jNJRq3O6cAVUp6593M6Z7s0FGqaB0xl25koX8Nc5guC3d3Q+hj9kMtOqILq8?= =?us-ascii?Q?HIotb/6kt9y2KSe7tpKopFj9HErodRMrUAYZQQ1ScV2DXsKagi8TLkWgXzV9?= =?us-ascii?Q?0hPNYz+SQXHIz19IJ7nye9My4e1CwvnemOCJDv8t7GpBLu3HAyYkdWQurSS2?= =?us-ascii?Q?eGQZMkfP2Ulv4s23r72KEWN7+tpBOkDSBzv1n+pA3sP2xIvT6Scrz8nT6h3v?= =?us-ascii?Q?YYymkBfn3LWsLjFDveyrsIksVCgHU8hUzQlt7oPJ8ACMRnA9BKFCC/bdC9Sm?= =?us-ascii?Q?hRFsGvs+VmbZ4NcU3uWw8aCRrIu5n1BiXQEE?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:14:01.3013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5c105be-2a91-4db3-9b11-08ddcf38a8d8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE1D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4327 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=573996eb24ed400327fd5ee2c76ce233f0fee80d Thanks. Xueming Li --- >From 573996eb24ed400327fd5ee2c76ce233f0fee80d Mon Sep 17 00:00:00 2001 From: Madhuker Mythri Date: Fri, 4 Jul 2025 19:20:31 +0530 Subject: [PATCH] net/bonding: avoid RSS RETA update in flow isolation mode Cc: Xueming Li [ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] In bonding PMD, member_start() function checks whether RSS(mq_mode) is enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which is returning error in-case of device configured in flow isolation-mode. When the device configured with flow isolation mode RSS reta update is not required and the API was not supported. For example in-case of mlx5 PMD, RSS reta update API was not supported, when the device is configured in flow isolation-mode. So, added check to verify if the device is configured in flow-isolation mode, then do not call the rte_eth_dev_rss_reta_update() API. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Signed-off-by: Madhuker Mythri --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index c3a761d0d4..bf6a811ead 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1905,12 +1905,13 @@ member_start(struct rte_eth_dev *bonding_eth_dev, } } - /* If RSS is enabled for bonding, synchronize RETA */ - if (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) { + /* + * If flow-isolation is not enabled, then check whether RSS is enabled for + * bonding, synchronize RETA + */ + if (internals->flow_isolated_valid == 0 && + (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) { int i; - struct bond_dev_private *internals; - - internals = bonding_eth_dev->data->dev_private; for (i = 0; i < internals->member_count; i++) { if (internals->members[i].port_id == member_port_id) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.551518388 +0800 +++ 0026-net-bonding-avoid-RSS-RETA-update-in-flow-isolation-.patch 2025-07-30 15:02:12.838312186 +0800 @@ -1 +1 @@ -From a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f Mon Sep 17 00:00:00 2001 +From 573996eb24ed400327fd5ee2c76ce233f0fee80d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a0000859ffbaaaf90bbb9c0f2f5bb7a3d4f5bc9f ] @@ -18 +20,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 83339bae3d..4906701a95 100644 +index c3a761d0d4..bf6a811ead 100644 @@ -29 +31 @@ -@@ -1904,12 +1904,13 @@ member_start(struct rte_eth_dev *bonding_eth_dev, +@@ -1905,12 +1905,13 @@ member_start(struct rte_eth_dev *bonding_eth_dev,