From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2A4046C4D for ; Wed, 30 Jul 2025 09:14:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC3A04025E; Wed, 30 Jul 2025 09:14:09 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2052.outbound.protection.outlook.com [40.107.95.52]) by mails.dpdk.org (Postfix) with ESMTP id D1D3B4025E for ; Wed, 30 Jul 2025 09:14:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LK+gJBApzTE+rtpE8AT0nIAYS+xRfbGFqTMZYZ6DEIdVl3sbxHiGnGfCLCljO2yoUopHr2aREvDfM3js5bn+dPq9sSxTwo5KmQIba8s8zfyu1P7wd7rTQw4kVRtDyaSVTxjNsHmW4kwfYzgxYE1sbwDyVBO7VN8PUhCyMqlCJlTVmec3gxyI6SylI3QNxqXYa5EFIZHzqdMpYMYfZppXoK9XGdhTwPknLi/n7Oz1vw+d1qFSaiJ0jop2yGjaZw7Ptf6g4rL8UyB3t6UC2cvkHbe8ca2PbSA0YF2EelNLDcA6YWISRTrwIMB37Yk/+9C2SExFsG39GJH0CwNQ6rB3EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pwm8cTMRy6yZCxLGKwpEaLyNCv4q/j0lcOZj3IdDhjM=; b=tk40Us4VbCC/4eexRfjJrYqwFW4i/qSebDcwvPpAmx269aW9LicMg9vKKdwZzW0W0fMAbm2zbLH3c4Pvfeg1LiPK5x99sRL+7UmWtxexW+wHJ+XfVokTzVELV57kMp7KOFMqLPj0kPph6t9jPzEDkPIver/iNBQfMH/4TvV/oJk4EcYh/QNDXdMWG8M1Zsz2EiJ8+Czf9JuUhOdLLOifS5pavIaM3vby522e7JgoEzBGt+udqI6I4caQd7yLZcXOocFL7lUwMrT6swSs9ADP0KXJsmxig8dEvIdXRXV5YwhK12yDrWdj4avDfCh7w7gXbjBYsS7Zx6rA7IfbwQxRIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pwm8cTMRy6yZCxLGKwpEaLyNCv4q/j0lcOZj3IdDhjM=; b=a2rQMc6AoyW6Kpgxb7wKakC+3UJdbUFpW3bgZ02P2q48rsIPDY9OT5aR0gHenq5fFRI462BblYbxk+okJwXi2CQIiCSHEEE7z0zejDKZcrCJrTezUHQ8VnH4KWrqBf2rF5xJw9uArUG4NWOelsICIiaR1NBAdztLeSSTL0m8ZenDCY7T/LYfMlOeGZs8DL8K/kOQ7YEYBbT7zrW7j2uBC4ehq9FaebpunhzphSW7pOjPqRdHjLZJVvm28z2FoENvxODYYWcfHuLOh9w1YGsvcTbPbRZYz6qhkE6Ct7HeBi6uLBAoAZlTTYGCAZIBECOxYcKK1Yjd+GB0R+95JOY7aw== Received: from BY5PR04CA0025.namprd04.prod.outlook.com (2603:10b6:a03:1d0::35) by DM4PR12MB6326.namprd12.prod.outlook.com (2603:10b6:8:a3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.26; Wed, 30 Jul 2025 07:14:05 +0000 Received: from SJ1PEPF00001CE1.namprd05.prod.outlook.com (2603:10b6:a03:1d0:cafe::7e) by BY5PR04CA0025.outlook.office365.com (2603:10b6:a03:1d0::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 07:14:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00001CE1.mail.protection.outlook.com (10.167.242.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:14:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:45 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:43 -0700 From: Xueming Li To: Gregory Etelson CC: Xueming Li , Dariusz Sosnowski , dpdk stable Subject: patch 'bus/auxiliary: fix crash in cleanup' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:39 +0800 Message-ID: <20250730071045.136672-29-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE1:EE_|DM4PR12MB6326:EE_ X-MS-Office365-Filtering-Correlation-Id: ce368201-d58c-4a9d-58f1-08ddcf38ab53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cwnG0uWct2nMT9jVVlmOTkqPf8QdwFzxAd6wokmzftu9B8G38Oat8BgJOau2?= =?us-ascii?Q?O/E0x6gp3q08OPjzNkpUZeEbbXxUgvssRPoALl9Y1DqKZ2FY1iBBYztOzkjS?= =?us-ascii?Q?m2CBJjOBcasWN+1GpK2j4SNrdM0Bg5KOrff8FksobFsS4Bj2KGZl2d3oU/1D?= =?us-ascii?Q?MjaD2eBuvFOiioodhHkb0CO5uJZuZ+Isqyyq2zvdfwWbhe8Fns5Fb0SgxK04?= =?us-ascii?Q?vuLRGcng7Y2CFNzJhiTw2vPir3xpID7xoHRu+jp3PezdwiNi21y36bL1TFPw?= =?us-ascii?Q?ZjS5HIGvbKK8T1OLM1X6643ALN/zq+TdXHGYHUrth2eqAXmq8DWxtr4xLRNX?= =?us-ascii?Q?hCYczhG5FKfwY+p0OSGO8eVck2NdW5KIxFIB6u9213lcaIL3pDQQEzjWth07?= =?us-ascii?Q?B0Ur7r/5aJO4/OLtX9e+SKznz8FCF9fuUobth5lwYju8AUxcwIBc4yCjuYg5?= =?us-ascii?Q?aWNS8crkxZRxVcp2pY2xtuQuuOvvQZmIHgqDLkYU8X9KaRgHwQq9fIUDuO5x?= =?us-ascii?Q?ar73FkwQS8SP57KfCjEOT9b14ysp3M+aMULRhWm6lWwR9TPFJCv+5TwOwBpS?= =?us-ascii?Q?2VWMXV0Y8zBq5KztbgY3fKx3AQHN6UzZOqYZwcHkiJskcePba5amyLZy/k60?= =?us-ascii?Q?JkJMNYbHFxWmDVelQLczsdhN+MkQtnrqZosj7uqmNT7Ns1oOlbXYHRknL+vR?= =?us-ascii?Q?jxni4jfK5sIJ3N47sShDY2oO152nlpxdGHkvybHTgTj3SJxl7nOwsXEVScKy?= =?us-ascii?Q?ATCvKILrEYqE4g/r1qMqZrpwyesLu97vX0s1rl5ORi584LEwWz4I7hYiBucA?= =?us-ascii?Q?gALtB7TpaqQfEePtn6mNRxdz3QYqc4M45n0a1ryMnfDDaSYv4ew0mm22AFWq?= =?us-ascii?Q?U+e81Too0uI7LrmCD5nKutbuzJ9y9WtxtPA3Ci4kdO5lFmQCRL9soeFAJSv2?= =?us-ascii?Q?WC7zBsC1jvuaCZfvWZg9oG9UVLPUfFdpL9rkY9PduENaNGM8kwSRN2BTq/hS?= =?us-ascii?Q?OhLl+2SQnXpmf4Zs07DPIaVy/Ac2GsD8owouSwhNHpLbRCtceR74pTNp6art?= =?us-ascii?Q?PlbGXkBXmcF6Q5QRqMGz4GEDO895EJypv/bejYW5MMhCW2VKkVFpl8gCaYrk?= =?us-ascii?Q?VmkLX0Eqjlxz94i0mT6muvkUB3bSA4Af/gS5LDFu+/r2Q1wNv4ehcAMFAtKJ?= =?us-ascii?Q?aI9tB+nSFPI8mnpbyJTb/meeFYPPo7PzdHClH/294wcnMK670Qj7UfG7lRFu?= =?us-ascii?Q?JCUpZ6ToQBsYnvXqyLuVp+5ewUXswwQjVty12FtU+pJ5SSDfpaZ05kXJdgbv?= =?us-ascii?Q?JILZKQtoDwXNVUemZuT7VntNGGy/HO1q4+/TtdF6T2ZyCKEzA8Z5dZcesVE1?= =?us-ascii?Q?OWNV4ElQzgTEildEuAlYJp9dT7uzgN8eiUiB9Wlk3OEmB24nEVeEh3SZ1UAj?= =?us-ascii?Q?x5DUaHzr8c+POPLeGddpToMnlxZdHCNgaGMzA1WbqAan8hUq6XSSgqQdnFp5?= =?us-ascii?Q?YUVweoZRUrSuKX1NBas1kx3r1nLCn1dD3t/o?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:14:05.4712 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce368201-d58c-4a9d-58f1-08ddcf38ab53 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6326 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2c80d3ec275fb326a69c2521e1907d29219deafa Thanks. Xueming Li --- >From 2c80d3ec275fb326a69c2521e1907d29219deafa Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Mon, 7 Jul 2025 13:06:48 +0300 Subject: [PATCH] bus/auxiliary: fix crash in cleanup Cc: Xueming Li [ upstream commit f03c01f601b1b8d90f62c8a5acead72c04797d7a ] DPDK auxiliary bus first creates a list of known devices in the `auxiliary_bus.device_list` and then tries to attach a driver to each device on that list. If the driver attachment has failed, a device will remain on the list. The device destruction did not validate driver existence and crashed. The patch validates auxiliary device driver before accessing driver related resources. Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/bus/auxiliary/auxiliary_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index 29f99342a7..7bbbfa6754 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -160,6 +160,8 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev) return -EINVAL; drv = dev->driver; + if (drv == NULL) + return 0; AUXILIARY_LOG(DEBUG, "Driver %s remove auxiliary device %s on NUMA node %i", drv->driver.name, dev->name, dev->device.numa_node); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.598746340 +0800 +++ 0028-bus-auxiliary-fix-crash-in-cleanup.patch 2025-07-30 15:02:12.842041523 +0800 @@ -1 +1 @@ -From f03c01f601b1b8d90f62c8a5acead72c04797d7a Mon Sep 17 00:00:00 2001 +From 2c80d3ec275fb326a69c2521e1907d29219deafa Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f03c01f601b1b8d90f62c8a5acead72c04797d7a ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index 5c6c6b0ef2..ac766e283e 100644 +index 29f99342a7..7bbbfa6754 100644 @@ -31 +33 @@ -@@ -163,6 +163,8 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev) +@@ -160,6 +160,8 @@ rte_auxiliary_driver_remove_dev(struct rte_auxiliary_device *dev)