From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B19E46C4D for ; Wed, 30 Jul 2025 09:14:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 147374025E; Wed, 30 Jul 2025 09:14:19 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86]) by mails.dpdk.org (Postfix) with ESMTP id 743D34025E for ; Wed, 30 Jul 2025 09:14:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eOhIFyzRFH8X3TkI80v9NN75earoXaanCtkbzM3gMsxCWRWL54jFhFDgldYYIg3XwNaoyxISRjy+ZcMD2WrVSkQxnQPozkVzF0Y0LOIXBG/23G3FXRqQTawvsmRrc9dTQaEHpu4nODRgJYN+DNarWDxyKIBSGNJ6enAAo3QgXMKTIUBNymECRkY5N5OUdCm92WZlw6qobbCdrM5pukY5g2w0LO0PXg0lYCF3DOCXGSSs4RTpNFGy9NyNvWuIA0HmF/QvKJfn4Pcft7LkSTt7+oXl2gxVhdJBjKjEgAdM1yoARyzjRVBb7YOSFPG+d7cJYEoWy3ioMclCimp33yvZ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=95U4HstenhH/lukgs2gnXb5wMCpeukk6naoudyD6PtE=; b=xRhpoUB+tLFV9v/sSfPdR++fyiZa8WkaYRG4DsYMPeaNBXIT/vxAaIgw1M2aLOH2deiGw6cd0MSra+HuZvUBNHrBVZZnpueaXt+Gf0AVLe5oy7Ss/Avwk1eT7vK6nRSvgRquAMqs6Yke0suD2u1F0LSIn7rL5iZ8XHPrPbrYfZ/c8YlnxM6EC1Y/a9dYD3QlzpbCj5izmhXcGifRWaQB4EmS2iqZEKK1CfRQ2UZvx8gMXazDs9cjPT9//gQWbbsp6mytfTk7EBuMYZqIoHmTHyU0llohcmOd6z3b/YYw6wvMmu4F9VvUMBAjPH0N+TQmQgL2hT2pzHX4cM7la+BldA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=95U4HstenhH/lukgs2gnXb5wMCpeukk6naoudyD6PtE=; b=V7nt4YLKPeTusNA5wdK4auUn10c+QNI3QkyPWpcprZ3YPG3NLtrsO63Z5X3YaL1Rbr9zII6NyfEOFxUEVGrU/+GLp8n94EkzWRXNTRdx0IcONr4Flov60LSDxDNxOCjpJNOOG7bnuXqERwaqo/i+3YVaLQ03VJFwKzxId/4AzCxnYUXgSyVb7hFBAxGxgz/DjVbTXSZqYnbY+DNWXtbJqCTo3TqyOzEbsLfwQdZrkAc+qTZfo/+hEROS2Kqa83r8gabSk/2Ow4YkWXx3KUbq6vm14CtWgVHn7UHewZiXwfEdFwet8D9C+cArOPyD3Da2AKNkC2zv00wH7fWxG5pM+g== Received: from MW4PR02CA0023.namprd02.prod.outlook.com (2603:10b6:303:16d::16) by SA3PR12MB7829.namprd12.prod.outlook.com (2603:10b6:806:316::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.11; Wed, 30 Jul 2025 07:14:12 +0000 Received: from BY1PEPF0001AE17.namprd04.prod.outlook.com (2603:10b6:303:16d:cafe::91) by MW4PR02CA0023.outlook.office365.com (2603:10b6:303:16d::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 07:14:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BY1PEPF0001AE17.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 07:14:12 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:47 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 00:13:45 -0700 From: Xueming Li To: Maayan Kashani CC: Xueming Li , Anatoly Burakov , dpdk stable Subject: patch 'examples/multi_process: fix ports cleanup on exit' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 15:10:40 +0800 Message-ID: <20250730071045.136672-30-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730071045.136672-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730071045.136672-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE17:EE_|SA3PR12MB7829:EE_ X-MS-Office365-Filtering-Correlation-Id: 300dc41a-4b01-4f89-8d10-08ddcf38af71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?goRt/jd36miaMjeyXPs/YgN8/MgCydGEnjvbdj5HtVD/xZhb0NcP+G5E53cK?= =?us-ascii?Q?8bKF1VOI0hD1BXoLhAIVoawlwPh8rp2C8liL4KDjOt+adZESmYwdHKebyjYi?= =?us-ascii?Q?emhi69aNr5lelmNWF8nunvFa0AzEQrY2MlFUK23nkuFkEzGIVwqcHTDS5exC?= =?us-ascii?Q?Td0I6BS3/KJPVXOj0rOy4e9gAVBlWtgguM+jF5SzZBIi+Ii6cpCPRff1gdif?= =?us-ascii?Q?9Gy8I5EQm7FwocLsOIS28oPAp2ZI7pp/iruUjGmT2umSXw4s9vb21vVI8lTI?= =?us-ascii?Q?yB0xpiIKltfNrkvbu9KAaZDwa53OAEB4hRVAUwGd6DbgDMj8ykBF9H7na42T?= =?us-ascii?Q?9x3zmhCoojI+W+DxLXVq7mwTqR8AMk2SuxKRTUSEt2c0NhhI7bvSV7xY1tgn?= =?us-ascii?Q?FpdLisWFwmSGnik7rWIyD2jb0Jt1cbt94qogyjSteRjPFe/myUaWa2JCMS5y?= =?us-ascii?Q?JzxMnGDpb8xOqMZAWRYndzDHlRxgkDnL9A8x4CvEBCEBkG3+xDMrKpUW7kN2?= =?us-ascii?Q?dutj5DmTd5c9WNBWja+9zCV64jvU7ojBP0SuvjE5GJx7CIeJLPbHvyGb/klx?= =?us-ascii?Q?36BK6YJV2tGas6MJI6bXqBAZ6kjH7fXrC9QL9QvYqzq/ujihYBi/J/Chhc97?= =?us-ascii?Q?s47DltDJOyiavMHx2Y1XP8hn0XTHHZqkcG22RSiOdgIqYszM2/SqW7Ht71gJ?= =?us-ascii?Q?Yfzbb7E+pK+yWK9zBVk86E0VVfir/AnCHRGGfxsbu6hcERjin5AhEUvvLvf5?= =?us-ascii?Q?uMmFt3LFZh6bODAYZnk7mOqvRTlgk9pcKhyMLzaZhljBKMfGyTaQM0wRRCHj?= =?us-ascii?Q?cGmYhvi0m0OrBYbxAzQQT5ILeEyXy3slAr+vMI4juswkOTHl7XlAKhDms1dU?= =?us-ascii?Q?TQ1z77e0eiC7Ox+vOgfpDchUD15plRWg2Nq0ec8UEqHCKdIY3lehNMAjW2aF?= =?us-ascii?Q?AlH7ei4NRA+AzjawTCSZF2BJ0rQQ9oDhNyrSLuZ58FWtrWq7l0nAN9aDh10X?= =?us-ascii?Q?arcVispPmbSYu+mgwO0+0JCT/YF2o9+mf+e5ptdvipXU/FFmryZfGYWSXZ+1?= =?us-ascii?Q?5Caw+flfBMZhDrffPnOae3J4/Hm8fOdO7yLjGHwWws77QE9QDomNMtNHSeQL?= =?us-ascii?Q?JI4+4OusMpUOKVhWfA9xspK/g6ZbcHaNZqnB4Mwe2EXZklfF40qFaObw47AM?= =?us-ascii?Q?bvRbYZ/G+6hYLiGv3R6UpIPT+aE0WTadNH3aKWZCDfvkNiaiackBOwluSphp?= =?us-ascii?Q?cXbBNcQgiOD2gBW8YjoyoMkkbCVO38TACVjlCkRmJlK9WIEnWP42pNb9R/sE?= =?us-ascii?Q?UnCxpJ0ngfvkCxm5sdj8qAyl7H3vyd8bDCBJx0wCrKjx/7RYZ4x2gyqlhGZR?= =?us-ascii?Q?ZWLUIHirNGkf2lle2UHpfoq5qSAHh9zsKSRjFiBJv7hKCSi3I5AC+k7EtO5k?= =?us-ascii?Q?0VqQXptgqHJr9RJaGmom/Svuf5TdqB8pDDPP4HE6n6b5EQv1N2fCisSovaKY?= =?us-ascii?Q?BTfMI4jr9mdI0le3f1XlHZZJxZOk7qoQauqR?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 07:14:12.4161 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 300dc41a-4b01-4f89-8d10-08ddcf38af71 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE17.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7829 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2a8ea062d0d0128b790efcbf6298753ad27d9df8 Thanks. Xueming Li --- >From 2a8ea062d0d0128b790efcbf6298753ad27d9df8 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Tue, 8 Jul 2025 10:09:54 +0300 Subject: [PATCH] examples/multi_process: fix ports cleanup on exit Cc: Xueming Li [ upstream commit 4382d58097b41d1e1229ce5fc2943994bf44bd83 ] Device was started but not stopped on exit signal. Added port stop and close on exit. Fixes: af75078fece3 ("first public release") Signed-off-by: Maayan Kashani Acked-by: Anatoly Burakov --- examples/multi_process/symmetric_mp/main.c | 27 ++++++++++++++++++---- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 1ff85875df..2dbbaa06f5 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -92,6 +92,25 @@ smp_usage(const char *prgname, const char *errmsg) exit(1); } +static void +exit_cleanup(void) +{ + unsigned int i; + + RTE_LOG(INFO, APP, "Close ports.\n"); + for (i = 0; i < num_ports; i++) { + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { + if (rte_eth_dev_stop(ports[i])) + rte_exit(EXIT_FAILURE, "Error stopping ports\n"); + if (rte_eth_dev_close(ports[i])) + rte_exit(EXIT_FAILURE, "Error closing ports\n"); + } + } + + /* clean up the EAL */ + rte_eal_cleanup(); + exit(0); +} /* signal handler configured for SIGTERM and SIGINT to print stats on exit */ static void @@ -104,9 +123,10 @@ print_stats(int signum) printf("Port %u: RX - %u, TX - %u, Drop - %u\n", (unsigned)p_num, pstats[p_num].rx, pstats[p_num].tx, pstats[p_num].drop); } - exit(0); + exit_cleanup(); } + /* Parse the argument given in the command line of the application */ static int smp_parse_args(int argc, char **argv) @@ -486,8 +506,5 @@ main(int argc, char **argv) rte_eal_mp_remote_launch(lcore_main, NULL, CALL_MAIN); - /* clean up the EAL */ - rte_eal_cleanup(); - - return 0; + exit_cleanup(); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 15:02:13.622247762 +0800 +++ 0029-examples-multi_process-fix-ports-cleanup-on-exit.patch 2025-07-30 15:02:12.842041523 +0800 @@ -1 +1 @@ -From 4382d58097b41d1e1229ce5fc2943994bf44bd83 Mon Sep 17 00:00:00 2001 +From 2a8ea062d0d0128b790efcbf6298753ad27d9df8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4382d58097b41d1e1229ce5fc2943994bf44bd83 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index f7d8439cd4..de16608a0f 100644 +index 1ff85875df..2dbbaa06f5 100644