From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A3B646C54 for ; Wed, 30 Jul 2025 17:00:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53CBD402C3; Wed, 30 Jul 2025 17:00:21 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id 15A62402C3 for ; Wed, 30 Jul 2025 17:00:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uR3XUQTKKbIjI7I3HRS8acxoARwn2LZUi0UtK153Z17SjvZu0NbHP33vJsYI5CLbJT0xRm5N370litMRn7VQah+E4PkRV2iRTxlR/54n/JGpWc+ZkVM8YVDbB+celtCkC9Et3hq/WVSQ111kx++OWmR5Uo349tNlzaupr9absZuNVfKpoplYzFbRcTKt04UIswcH1k1j0D196q63QP/c2epve1SaBpsxyUP8j1O356AorrE8BntBQ+empGIek1li5Sfju6LZTryy+Z6Al9eiBNFdpUWaNp7g4DHQQfGcqZnUqF87qNSwFvXiODisQUdx6qF6Lpyz0hhupRHW2r3Z4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ePBVnGqaCaB1TofPSgXFX3pyDzJZM0jJeCUahFm7Y4=; b=SiEDaH2WLMIk8Pqn0hsI//bkv0GRL7/hNnkNf2VcjqUuHNd0ShiAgAnNgZ8zaOlt1LXiATYrTtcchxpCYfaSNcRNTIrGg4qMVifg1Obi2KfJpk3mO7xrNwJ5c0pIuV54BctFGGI5yZ1wVADGea1/kANpqPpmHy/a+YjmC6FMMRSFyes0PD8L5IuFwCrapsXC8M/TLHw9ASf1ZNMxawTUzJD2hXDWGmWJD/ls+08W7DON8PwS4IKueHmaW9bXKyWIS7lfg8UTkFV4h1NBziRB7YimphVW0awNWptg+QA8RxcDaL6+0gCZQaktHdGKOg/CYrEafaY1DFnb8R87IPX5wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ePBVnGqaCaB1TofPSgXFX3pyDzJZM0jJeCUahFm7Y4=; b=mK0vgSPil+A2GN4OcXQ/3CXSDDsa1QUYhmxSxQL4o/ZgADpgboGL6uDTVIfjvQY2n/Qt71YiMg5NQkDDUmvwFPYVAskX6+KFzPHt9SEtVkMaqRUTSwcmzzSBy13z4Om1WkCF6I5R6R26o8ETP3VLvFWUm2kd0j/7bmcKaacsfTcEYesAiNSLuY4wmNxLsV0Y2ISah41HRig1tyy72ezV4WLIHnRf16IqcrfxbNjZLAkkxSGClABZHkmmFLb2kWnW0hDTbMMvMNUkzlyMLEu7FFyN7was3VAo+3mcnKbLJzaWfPndrH9Dr0DwYqdj8Hfobgl0pH3M8MsW1eJMOCLuAA== Received: from BN9PR03CA0685.namprd03.prod.outlook.com (2603:10b6:408:10e::30) by SA3PR12MB9159.namprd12.prod.outlook.com (2603:10b6:806:3a0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.11; Wed, 30 Jul 2025 15:00:16 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:408:10e:cafe::8b) by BN9PR03CA0685.outlook.office365.com (2603:10b6:408:10e::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 15:00:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 15:00:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:59:53 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:59:42 -0700 From: Xueming Li To: Amiya Ranjan Mohakud CC: Xueming Li , Ciara Loftus , dpdk stable Subject: patch 'net/iavf: fix VLAN strip setting after enabling filter' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:19 +0800 Message-ID: <20250730145633.245984-11-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|SA3PR12MB9159:EE_ X-MS-Office365-Filtering-Correlation-Id: 99f66953-f422-4152-a853-08ddcf79cb52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k8tyh8sEfAAhOjduwzugPVQ+nWs8gzM7sqzNmZfkIj0USRktA1tAqzDLTSJ3?= =?us-ascii?Q?SXdp3o8vRVT8MwT9kmaUmAzbTCcGFZqvUiILyl2LcwU3HgBWPJpFI+op31TG?= =?us-ascii?Q?8JmjKl6Ri0hbQPy1UPH7faciLiJ0Y+5anP7RbbZHCWni9eyXSJ7F3xw5qcjt?= =?us-ascii?Q?kOuSyCCRDfUNS9qU0IrZ8bBvhKpmdVfw98sD6EfgAaf7D8OhL7C/q54Uls1o?= =?us-ascii?Q?yr60v8IXg9MYOG4xO5Zn5Dv+rnUUtX/Jj3QPKccDSXq0Z0Qii37i0gVPznI+?= =?us-ascii?Q?UvzFDk2bXBIQACwK5OeYVDjsuSqnHRZX7dlswskCTnPhJwNSBNHiGVORwqbc?= =?us-ascii?Q?wIWsMIR4I9VXXIFKkgRvdsYmOpFBXE4Mu/doOv9AO0Qo+2C3TE84cCN/xvVs?= =?us-ascii?Q?pFGos9jjK34KB5M1VEkR+jUv+5U+XGStQGQDkGutvI3DG4ck/M6TgvB26G/K?= =?us-ascii?Q?rjAHYj7snLTZavSY+KxXNtGf7UsPMsxz90AFNcQJ2GE7zlzfHpj8f0zWt5NJ?= =?us-ascii?Q?DfLX5g0fW6u7jPadEkxERqxLhFgcP32ZYqJ5iHz4FPEZz9WMjiKBe1lQbzPK?= =?us-ascii?Q?ypH9mSCl0iBHkEhVxpV2HpKhIHE8qQ+69OWd0BIjsWx31PurfwzfaOy2fx8x?= =?us-ascii?Q?jjA9xd3ZuKifoeBJDwd606vgTBWVWyR5nJpMRgFg3WGo9JVUCKOwwUYMjrPt?= =?us-ascii?Q?WiKOTwCgy/L8iVaFJDR64T5mEbstMpP1PEzqLu6ie81ETI8PzIsvbhCYISLp?= =?us-ascii?Q?WE9N6L563TjFFiXVwtpRnFOpFFRj2oYWjBegASon9gXAduSoLsLrTTerkqRO?= =?us-ascii?Q?UYZJFIvM/YcLAtI7TgwEWhjYyR3uX46jOUPbmukmdM3C1xftfEYwlYPe5odA?= =?us-ascii?Q?aabTNqfbLuWt31kjVoHRdGSIc051wlxdXwpXFPzhSmWkIjTXnS47bQlP1Byf?= =?us-ascii?Q?w0BgIbtsqs0xGdgJMOLKEQNJPxr4liG4OWCddAaaygLQvVCmQu5BQZ2diEUQ?= =?us-ascii?Q?TGNoM/MnJDJn3IHPJS/C9N0U0QdLnJmTmQaqZTmbAiycE6ZYPL0AG3+pq3kL?= =?us-ascii?Q?Z12uVXeknirBOQBTP4AfETfdxxbOvNMI0deHdxZ1c+26bYidAAzoqm84IXIs?= =?us-ascii?Q?XMLsnhS3Ai7qeDzRd9Z7rq3fSfFwShWfAbgPmVBY7y8igdIcliTKOQrI36vS?= =?us-ascii?Q?SmH7lNx4vW2D98Gl8NTa1PmHs7e07wXfneWNnQVPrV9Pjap5eRuzn6EKv5hY?= =?us-ascii?Q?twokgAGEzgOTRu9UaTnkXQp+nJLP9+6uauYCNpNFsNByGkPmuWImsRvZo7Vw?= =?us-ascii?Q?4HSS9QEjm8FUL3+x0AGv3vQesuKqvr6Sq2Ara63uxbGkvStSgGU84nYFb641?= =?us-ascii?Q?QD1DAvPQwUeHyBD4OkbFSiJ0s/ZbezTnVjeplK76SU9l1h8faZ4THjiWpcDd?= =?us-ascii?Q?fG3D4Rc+QzpKZZbTmyQ3zhjTAdVV+D836lyC+TcMmbz02E77hlYcZQpJvBPW?= =?us-ascii?Q?JMYeMmgm/89z2rDXgFn8+nx6m4WUeKG8eLj4?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 15:00:16.2622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99f66953-f422-4152-a853-08ddcf79cb52 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9159 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f2c11a141c46c6a9d461493b70490940d8147680 Thanks. Xueming Li --- >From f2c11a141c46c6a9d461493b70490940d8147680 Mon Sep 17 00:00:00 2001 From: Amiya Ranjan Mohakud Date: Mon, 23 Jun 2025 23:41:36 +0530 Subject: [PATCH] net/iavf: fix VLAN strip setting after enabling filter Cc: Xueming Li [ upstream commit 3bfad066f9b4764981c9ad90a750fa6f1afcf15a ] For i40e kernel drivers which support either vlan(v1) or vlan(v2) VIRTCHNL OP, it will set strip on when setting filter on. But DPDK side will not change strip flag. To be consistent with DPDL side, explicitly disable strip again. Bugzilla ID: 1725 Fixes: e25c7ed114b2 ("net/iavf: fix VLAN offload strip flag") Cc: stable@dpdk.org Signed-off-by: Amiya Ranjan Mohakud Reviewed-by: Ciara Loftus --- .mailmap | 1 + drivers/net/iavf/iavf_ethdev.c | 48 ++++++++++++++++++++-------------- 2 files changed, 30 insertions(+), 19 deletions(-) diff --git a/.mailmap b/.mailmap index e17823a260..80c6f855dc 100644 --- a/.mailmap +++ b/.mailmap @@ -84,6 +84,7 @@ Amir Avivi Amit Bernstein Amit Gupta Amit Prakash Shukla +Amiya Ranjan Mohakud Amr Mokhtar Amruta Zende Amrutha Sampath diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 4472fd2c2d..391ba2c812 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1364,13 +1364,38 @@ iavf_dev_del_mac_addr(struct rte_eth_dev *dev, uint32_t index) vf->mac_num--; } +static int +iavf_disable_vlan_strip_ex(struct rte_eth_dev *dev, int on) +{ + /* For i40e kernel drivers which supports both vlan(v1 & v2) VIRTCHNL OP, + * it will set strip on when setting filter on but dpdk side will not + * change strip flag. To be consistent with dpdk side, explicitly disable + * strip again. + * + */ + struct iavf_adapter *adapter = + IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); + struct rte_eth_conf *dev_conf = &dev->data->dev_conf; + int err; + + if (adapter->hw.mac.type == IAVF_MAC_XL710 || + adapter->hw.mac.type == IAVF_MAC_VF || + adapter->hw.mac.type == IAVF_MAC_X722_VF) { + if (on && !(dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) { + err = iavf_disable_vlan_strip(adapter); + if (err) + return -EIO; + } + } + return 0; +} + static int iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) { struct iavf_adapter *adapter = IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter); - struct rte_eth_conf *dev_conf = &dev->data->dev_conf; int err; if (adapter->closed) @@ -1380,7 +1405,8 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) err = iavf_add_del_vlan_v2(adapter, vlan_id, on); if (err) return -EIO; - return 0; + + return iavf_disable_vlan_strip_ex(dev, on); } if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)) @@ -1390,23 +1416,7 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) if (err) return -EIO; - /* For i40e kernel driver which only supports vlan(v1) VIRTCHNL OP, - * it will set strip on when setting filter on but dpdk side will not - * change strip flag. To be consistent with dpdk side, disable strip - * again. - * - * For i40e kernel driver which supports vlan v2, dpdk will invoke vlan v2 - * related function, so it won't go through here. - */ - if (adapter->hw.mac.type == IAVF_MAC_XL710 || - adapter->hw.mac.type == IAVF_MAC_X722_VF) { - if (on && !(dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) { - err = iavf_disable_vlan_strip(adapter); - if (err) - return -EIO; - } - } - return 0; + return iavf_disable_vlan_strip_ex(dev, on); } static void -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:03.776876738 +0800 +++ 0010-net-iavf-fix-VLAN-strip-setting-after-enabling-filte.patch 2025-07-30 22:50:03.000752668 +0800 @@ -1 +1 @@ -From 3bfad066f9b4764981c9ad90a750fa6f1afcf15a Mon Sep 17 00:00:00 2001 +From f2c11a141c46c6a9d461493b70490940d8147680 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3bfad066f9b4764981c9ad90a750fa6f1afcf15a ] @@ -18,2 +21,2 @@ - .mailmap | 1 + - drivers/net/intel/iavf/iavf_ethdev.c | 48 +++++++++++++++++----------- + .mailmap | 1 + + drivers/net/iavf/iavf_ethdev.c | 48 ++++++++++++++++++++-------------- @@ -23 +26 @@ -index c6d72058bb..1b238970fb 100644 +index e17823a260..80c6f855dc 100644 @@ -26 +29 @@ -@@ -88,6 +88,7 @@ Amir Avivi +@@ -84,6 +84,7 @@ Amir Avivi @@ -34,5 +37,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 02649c19b2..c33fdd9069 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -1377,13 +1377,38 @@ iavf_dev_del_mac_addr(struct rte_eth_dev *dev, uint32_t index) +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 4472fd2c2d..391ba2c812 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -1364,13 +1364,38 @@ iavf_dev_del_mac_addr(struct rte_eth_dev *dev, uint32_t index) @@ -78 +81 @@ -@@ -1393,7 +1418,8 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) +@@ -1380,7 +1405,8 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) @@ -88 +91 @@ -@@ -1403,23 +1429,7 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) +@@ -1390,23 +1416,7 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)