From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7665D46C54 for ; Wed, 30 Jul 2025 17:00:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 716D4402C3; Wed, 30 Jul 2025 17:00:30 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id 85C71402C3 for ; Wed, 30 Jul 2025 17:00:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rUYmTrpaYA9TtnXoo6nJpKNorS6i7rkJBwwAnKIPir3TDTW0vxpy0FppIysjRYlKP7zKmMoYJTkyY3ycvN4rH0ahsLh24GtBgX5vKeewlmnQJoom4dr70rHwG8kzFb7ErZTjGCwSK2skiHw+QDndk2SQI6fhWhVIx0ziGoa0N7SOr9pIdKaz3cWIE6HiZ0i/wDNcRh+RvQzLzDGmTXOeCt7/PCfuXAFGYtfo+OstCWFSfiTcQGnwz8+0R87OC8ce8dPIdstyyonTctxQ84rP6K3xcLZLfk6z6UTiQAeQevS6KEZC67Gt2URlSoNW2YzYhySODDvEDwU8ZvbgDc4N7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTPcgCc7n6jR5sirsZyOA1XXwsVcMXscvM/z4UDZkMg=; b=uJyp8p9v/ecMbfyYWtY3pP6JCDM0ZzwHvkBzqbhKhTuTkdeGQvAgE2KrXOOlR2FaJBBRrnlxwl1lxlxexls13fRObbroI2a8QGTqO9mlC1mkPEBLQSnMc2Y8cWpwUhyHFBriaQzjOwNUWVmbRsxy4F4RLfoTiy9AgMwMsNHGyNodNZ0iuF3F40qGiDkNPJzvxSib3aCpisEpoMv0IOFNhGqi/5stYeS8maktra+CXDHfIoT+WSEzSX3Aowtzw7uMliYGLmUzU53T/oasSX9Bl+Gp7G9gRvW+eJgNJfbHcaLsYh1gfOHbWFTq8EMJOnWnb0wJacS7nrS/Qbedkjebdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTPcgCc7n6jR5sirsZyOA1XXwsVcMXscvM/z4UDZkMg=; b=ZnO1GUVJoQxdC3oK0EMGh5nII/ML5KCx3xHOh5EZlGMgmCzlqBcVxYTYLHTOPwtYlLZ86GCPUT8u9wb1uJp69IIXMhi6TQ8VYIqWi5wzVEDA+o8GDY0HichKIstrQUZxoRJ933Pu2y/Y2v0G5NcSef77lDqaN8DuSn+q8T7pQFG2ol/8UyEu99ayiaBAaAyvrEavpB46giOZKRjpZ0vw9egsJGbFhBJF3GtkxmTXrCN7BxxOHy8RMesYB02tI5cB86+5J8YR/UUeis0kYa0JGJJGMYZpAHmZ2zQO341DzxJ4h6W2asqq75mdzP1Tj/mP4D++mqeYF3XojaRzUvgOtA== Received: from MN0P222CA0022.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:531::29) by MN0PR12MB6319.namprd12.prod.outlook.com (2603:10b6:208:3c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.11; Wed, 30 Jul 2025 15:00:24 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:208:531:cafe::a6) by MN0P222CA0022.outlook.office365.com (2603:10b6:208:531::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.12 via Frontend Transport; Wed, 30 Jul 2025 15:00:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 15:00:24 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:00:04 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:59:53 -0700 From: Xueming Li To: =?UTF-8?q?Eugenio=20P=C3=A9rez?= CC: Xueming Li , Maxime Coquelin , dpdk stable Subject: patch 'vhost: search virtqueues driver data in read-only area' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:20 +0800 Message-ID: <20250730145633.245984-12-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|MN0PR12MB6319:EE_ X-MS-Office365-Filtering-Correlation-Id: c9177cde-00c6-498d-b498-08ddcf79d036 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UnRpUVpJZjZmQytac3M0VGk0Y2dGTk53SkNGSnZ6aTNISFpyWEFBUExpNWF3?= =?utf-8?B?VzE5NXJtQzVGb0FrME1WYzAwY3BMNHhKTDFHNmVNNUhxMllvd2RQVWlnTFZq?= =?utf-8?B?dk1NbVNob1paOEJIaFNsQlA5YldXZldWQlBMZUpPaUFSbFJVTHF4eExqVlBv?= =?utf-8?B?blJ2VWNUOXFoaFV3L1pqanBHclY4eUFBeDA0MUszYWNzOFVhYmVEK1h1MTRs?= =?utf-8?B?RkFYSXhXcENObjlLTGV1VjVWLysvZ2JpdFBMNUdIOUdaQ2k3dVloQ05YTUhv?= =?utf-8?B?TklwS2Qxcndrby85KzN0ZUdweDVrY1czMnZpUDZ0Y0FJTGtVTEVpeklpOGp4?= =?utf-8?B?V2t6Wi8xVWZFM2xCYmFiV1o2UTkwbUREeWJnaXlZZ2xUVUxXUG95a2FUOVN1?= =?utf-8?B?aGNmaGpWampiamRueVNKWkZkSnBJZURmc2NjWnBGTlM0RVVHNXdyd2Y2NEtC?= =?utf-8?B?VTM1VEwrUmNqRTViclg3OUNYMFZwSkFIY2V0MVgxRmdocmg5M1J6MWdkamY3?= =?utf-8?B?cVhWV1NCemFqMXhudWxXTnd3dXpPMzZnck1SazlYMkRvV3cxMVhRVXUvUGVW?= =?utf-8?B?OVlScVR5dHR3cnhKWVVaYkR3MmQwUTR1dDNqREJHV1B2a0RZL24yR2d6SVUz?= =?utf-8?B?aHh1SjJLb0FEc1BVbm85aVBWRDhBOGJjQzhnbm9wODRTOWcwMkRYdkxKaTM1?= =?utf-8?B?M3crTTFwWG1aSmJ1UU5xclB4OWw5Ymo0MWtjRlp3U2RoQlJYdXVha01yRzB2?= =?utf-8?B?SEpnZFFsQ0luTDhnTE9UUjMvemJqU1ArY2VHd3YyN1AvSmFYR1dmY2pKaXJk?= =?utf-8?B?UVhJM0dncXJpeVlhQWtkWldnYm15QU04WnFCRGJMMVpCcVZWNFBlMmJGVFpO?= =?utf-8?B?T1ZvdERzdW5zUjZRMzd5MHFCWGZndm5ZenJOMlBTYmdxSFFheVVockpDa2F4?= =?utf-8?B?Zy9CL1dUVXlsRGVmbVFWL2syZ0FuTU5iaStPUWRHNnhLNDhUNDVXeUtWczJ4?= =?utf-8?B?ZVJVYzVTRC8vVXZVOEh2azh1OE9FOVFQcVIvdUpSNnljWjh1bnV4c2xRZFBW?= =?utf-8?B?WW1LNDNJZXR2Q0RiUW5YbnBzWGdLUnBwVTg0dVM3TEpPUkRkUWxtbDREOUg5?= =?utf-8?B?aGpmbVU4eVptV3R4VUU0V1JCUUVwQzRpRUtPQndtSnlDMTZzczdlamNHek84?= =?utf-8?B?Y1BKSGJweGEwRlJHbXdzL0dXL2ZuK1VmOE1vWDBvaW41REFuVnF2aUlLTVdj?= =?utf-8?B?amg2c1FkOEhhOTU0MnRPTGtkVTc2U0JueGZJSTRob2Z4TDFvc0g4Qkg2ZTdJ?= =?utf-8?B?d3VBbVFCS1lyNXBGMEZ3cjltS29iSUZCbW10UXdoMGxZKzFmSzdHVW1xQW9B?= =?utf-8?B?UUFGaFEvY2lOS1pxNDAwck82dkxHNzM0cWh6T3hpWHREeGNDa2t2aGozMlBj?= =?utf-8?B?WlN1R3ZFQmg1eDJkWGtTZlJIK1haQnN4NG1aRmVNYmJEdXVkZnZlRGhNeEpy?= =?utf-8?B?bnl2MjdNMWo5VUppSDY4MVpmb2orTk5zYWZTbzh0amxDM2ZIQ2E4eStGYyt4?= =?utf-8?B?dGJCSTgxMm5PdFpQWi95QXllN04xQlhzREVnUHdRcVNFNXpmZ0RYcjdtd0p1?= =?utf-8?B?UkNkS3lDK1ljR0JGSjlLS1lLSHZVWmpwOWFIdldpNUhLVC85RTJCLzd6L3lM?= =?utf-8?B?RUdLUk85cFZLdUxUMVIrcVhBZ3grdTRidFNoeGYwNFlWWjlFQW9iNDlvRFRy?= =?utf-8?B?NTZ2R2d3VWN2eEl2dVR5THBlbHV3QjJBSGhGSG5tM0xMdXg5TmRiU09JNEwx?= =?utf-8?B?ZG43WVFFME5NRmFlaEdyNU15M2E0Ym9RaXlEYUI2NmJVb2pJV01QS0cybzU1?= =?utf-8?B?Q214ZmxNUmNJaWNmeWlyZEZSbE0xQXlDSjJ2aTZLUHpON1I2QUJQZEdmZEk1?= =?utf-8?B?d3NuVjNDVXhzV1RqSGM5Uk5wZ0ZxaHFPU2xoRDU3TCs1Rkh5K0g0cmxpa0R1?= =?utf-8?B?UXB5WEY2YmwxaFozY0dhajNqVDZ3anB6QkFsMFFoeWVBbzNYeWNzUmNKaTZG?= =?utf-8?B?TE1qTmtzcElweXN6dFVrNytJdjJ3aVBjR1NYdz09?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 15:00:24.5070 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9177cde-00c6-498d-b498-08ddcf79d036 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6319 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a02ed54577eb2ae1640355dadf9e2ad817c30ec2 Thanks. Xueming Li --- >From a02ed54577eb2ae1640355dadf9e2ad817c30ec2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= Date: Thu, 5 Jun 2025 13:35:51 +0200 Subject: [PATCH] vhost: search virtqueues driver data in read-only area MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 3bd0c97b56c8e3c198d604871f35c125afdc4dc4 ] The virtqueues driver areas are read-only for the device. While they are exposed as Read/Write to Vhost-user and regular VDUSE backends, they are only exposed as Read-only when the control Virtqueue is shadowed by QEMU with VDUSE backend. This patch makes the backend to request these areas as Read-only, so that it can be accessed in all the configurations. Fixes: eefac9536a90 ("vhost: postpone device creation until rings are mapped") Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed queues") Cc: stable@dpdk.org Signed-off-by: Eugenio Pérez Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 276c5f12b7..29d2d4d205 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -495,7 +495,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) size = req_size; vq->desc = (struct vring_desc *)(uintptr_t)vhost_iova_to_vva(dev, vq, vq->ring_addrs.desc_user_addr, - &size, VHOST_ACCESS_RW); + &size, VHOST_ACCESS_RO); if (!vq->desc || size != req_size) return -1; @@ -506,7 +506,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) size = req_size; vq->avail = (struct vring_avail *)(uintptr_t)vhost_iova_to_vva(dev, vq, vq->ring_addrs.avail_user_addr, - &size, VHOST_ACCESS_RW); + &size, VHOST_ACCESS_RO); if (!vq->avail || size != req_size) return -1; @@ -542,7 +542,7 @@ vring_translate_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) size = req_size; vq->driver_event = (struct vring_packed_desc_event *)(uintptr_t) vhost_iova_to_vva(dev, vq, vq->ring_addrs.avail_user_addr, - &size, VHOST_ACCESS_RW); + &size, VHOST_ACCESS_RO); if (!vq->driver_event || size != req_size) return -1; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:03.839294499 +0800 +++ 0011-vhost-search-virtqueues-driver-data-in-read-only-are.patch 2025-07-30 22:50:03.004753249 +0800 @@ -1 +1 @@ -From 3bd0c97b56c8e3c198d604871f35c125afdc4dc4 Mon Sep 17 00:00:00 2001 +From a02ed54577eb2ae1640355dadf9e2ad817c30ec2 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 3bd0c97b56c8e3c198d604871f35c125afdc4dc4 ] @@ -30 +33 @@ -index 0353a04dc8..a2e3e2635d 100644 +index 276c5f12b7..29d2d4d205 100644 @@ -33 +36 @@ -@@ -497,7 +497,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) +@@ -495,7 +495,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) @@ -42 +45 @@ -@@ -508,7 +508,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) +@@ -506,7 +506,7 @@ vring_translate_split(struct virtio_net *dev, struct vhost_virtqueue *vq) @@ -51 +54 @@ -@@ -544,7 +544,7 @@ vring_translate_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) +@@ -542,7 +542,7 @@ vring_translate_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)