From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF59346C54 for ; Wed, 30 Jul 2025 17:01:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA893402C3; Wed, 30 Jul 2025 17:01:02 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2089.outbound.protection.outlook.com [40.107.94.89]) by mails.dpdk.org (Postfix) with ESMTP id 7F866402C3 for ; Wed, 30 Jul 2025 17:01:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=liZ7mwM1Isif6L9GtIoDIQ5C/J8dmJ86fPKSbZpn91nxZ7OJnygjyptz5wew+3g/vl6tPquvT+g7TuMseh4srk/7p1LRcvGdQa9739XYIctHP/6jOVvNJN5bI4DEviTMwzEttb7kuwrLLCcSqxAV1Q2Xd68Jwob/rBKBU7VEmo+m91bgsQTd8FnTJ4Yspak9kNfkPUwxYGo317hs/xpR4xpJA1MUQXpdO4nvn9DWf0iz4EmySiOvYOu4cj700eg3qzHy4B6NzIkKyylwjhYuHnrU+3WFGMDaT1ELtBVWth+5IZSKlKbWrPk/eAwqyLp8PD7bRvsQmZzeG8/ySwx09Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QQ/OCC+UyVng5/uVUfCr5gep9UdtVvmUslzpQO/nIGY=; b=pYN2W8/OD7SDw98xafNvH7ywB27nWLOsIOWtw6QhZ2LwVxCZ91Nab18M/WKufIaezj7cZsmurFVZc1vh3pMMhDwrRi6og5y4eUYdbGxnPTOY1NluWpRuTCZT08PZmukC087tENlZI6dsDBRJv3DnGVA2vmTCA8An+d0MwDj5lFgVJWEpXVVH7n8mb6XQwbJqWWT15Gzs8R74iMmxdzrijD0wf0injWstX8TpcIvEs/LN5HBCUXHQh15l4GhDtOciT3I8y/uVUdpDYv9XGL9BsZBbYcGO7R0skzcyAsDOASc9me08BpHzMY4i+7bZ69FqXNbRWbfUldqSqXrnhftjQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQ/OCC+UyVng5/uVUfCr5gep9UdtVvmUslzpQO/nIGY=; b=bbkq22i+NhApJ8+Peyi28NrufkzNiLW2s2ez9/XWXnoUiM3+O/+Qg98F32g1IY0EzCPPFFHkmtZQMiTZLeYjdvyC/NezG7RoYCVaff6PAtGvemmkXOYyWEb9QiJXbrfYnQkzT1e/o6DpVZKqBZQQkZDnbOvcgx/83Eln0tnr7V0zud0JDSdurA/+xxSDYWdvreyYKuYZExtgbW5zAiGQRvXQKAF4S0OS1rboRYVQG53cO18+38yBCZpDh0sFw7iokIyyFqURYBscTDscNY/tL7PSo5h51F/7o+nmmGXBX4AO9ixyfc1MYM4stheNolmqioKAKR65JdBU8KNtuLLovw== Received: from SJ0PR13CA0211.namprd13.prod.outlook.com (2603:10b6:a03:2c1::6) by SJ5PPF0529573EF.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::987) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Wed, 30 Jul 2025 15:00:53 +0000 Received: from SJ1PEPF00001CE6.namprd03.prod.outlook.com (2603:10b6:a03:2c1:cafe::66) by SJ0PR13CA0211.outlook.office365.com (2603:10b6:a03:2c1::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 15:00:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CE6.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 15:00:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:00:27 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:00:24 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: Xueming Li , dpdk stable Subject: patch 'test/crypto: fix RSA decrypt validation' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:23 +0800 Message-ID: <20250730145633.245984-15-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE6:EE_|SJ5PPF0529573EF:EE_ X-MS-Office365-Filtering-Correlation-Id: cdacee97-1834-4e25-e8f6-08ddcf79e159 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CAdjKeP1mPHrcv/3YF0J2132Xhp5oyxs+TgkFppUw5H3tj8EGeWJ88EGNEjD?= =?us-ascii?Q?wQPEzRYIYaL6JW4YQ5kMk9Mp6oA2fSRMR+CZHY9jtu3SJ2dO2kP/FCp5N3B0?= =?us-ascii?Q?QLjQm+BbR45bSm2xB1xIpq8j1rEBl74Te0Yr7PbWuXBDXXL9Aty2u2epRqWW?= =?us-ascii?Q?soe2qCIbALlERKRlWvzmdTbhYHS8TcQRIWY+yzm5KbueTv6sDb150elzhL89?= =?us-ascii?Q?2HqG3P9w8NIxr+q2A+O2kXfhy1v7MvcK34rg0oTiC3rg8m91hNoidD3I3kSw?= =?us-ascii?Q?lT1FirsHCwaJuhL5TFkVkvivV3/YeyPDFzAwE7bCOwDN/TzSwOIRSW8D0u5n?= =?us-ascii?Q?tlUtkIEwlakYvzJ9Pf8h/3ZFReUq9joLxwEC3VITVQ64gshNtRqKiZPsRj5q?= =?us-ascii?Q?QSpW85tj9NISZIK8UlAetflF9r9PI9zxWrEeyMWxdD0A9AN1BFuYxOvQA/iI?= =?us-ascii?Q?v4MileQfV60meYIBpJsQJ24CVek6HA1MjyxiJMKIvdrQpdqdYmd1r8UwSYvR?= =?us-ascii?Q?oljXKYWtsg9/y5SsR2dAgzPE0NeGbAn4z5sxdzSRk9dNncu1YvidKjO75j1E?= =?us-ascii?Q?VdyBUfEdGp66tqx/CBUOeU7cWYcRcyUS0wrMOySmwJPcOAI4hFo41k+VjTX9?= =?us-ascii?Q?jFml54+tRYOw1da0TyMSVzm8l7/nx5vUnzBqVe9MiNkvsMLlfp8gq2BSpEoB?= =?us-ascii?Q?ACWfqI3vymD/7csqNCXOLhBlNDaLhMsHxHjsJ9ItqpRSoNqIt4xEr9iIZx4f?= =?us-ascii?Q?uDXb7K2217a+2aK37/oAHZhPnDWrlRSqoxpTkh/QrI/SLKdJMbbcKjPV5LLs?= =?us-ascii?Q?iH8IwAmri49KP3g1K95F7dXhmgZdOQ6lbUlBT5DC+cPPn79K2vzMDLMXzLKa?= =?us-ascii?Q?+E8Wfb8z4HgG6STQA3DMBC+lLnVwy2j4j8Rqm7w/N5COzmp5CcTHVn2H6ars?= =?us-ascii?Q?DhpMINGmLWhXzIYuo7nX7dIr9Rg+O7CWoeViN8PQ4EN9PO0LlTucnAr78C+X?= =?us-ascii?Q?pg1blVUjydOb8PRyoblgvabjz/uG30DSnxsZatv5bkgxAHAqjVDzAVIxTrZA?= =?us-ascii?Q?8yqWlqMqqH4ISfVU/ZVHBKCujSN/PpackxWraaymp1KTVKV0uFBlSMJ0HMr/?= =?us-ascii?Q?JTKEP7FmUt/D35L/4kwHbS9fUH3okYHeJrnN12NqJAndmGQgOKB6k3+Hib6C?= =?us-ascii?Q?y+NpZrBCP/11kx+uvNE/6kK3S9rg5H2MQml1cxE54SSzQ5FjS3f3OpoGKyuA?= =?us-ascii?Q?INxuj8psnJcii3OyWJ7sBEm16q+vScu/Dle2psKSRPWZOQlKOz9PFVCcLy2t?= =?us-ascii?Q?0LqhzxLT22ntFguMVzwEEdjra71whtlyfQ8fZoXFQoVcZ93ACeRC60kLlLr8?= =?us-ascii?Q?aA9g81TxAFPRiQ2G6dpq1pe73WfJa2p5D589qZW2YrJImDJPTSTG14M8XOOX?= =?us-ascii?Q?BkFlcR8QogbDV3C90F9Zj2QKcMTLd3Tm4GmgpsBGIKFAgNzqg6qJbuI3kt1+?= =?us-ascii?Q?lTJ6sRbnVSy6NX6nhJGRqmNirEAOL3DDuLKi?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 15:00:53.4668 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdacee97-1834-4e25-e8f6-08ddcf79e159 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF0529573EF X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7bd19c617ce3c4979b95e65368e5537ca0777bd5 Thanks. Xueming Li --- >From 7bd19c617ce3c4979b95e65368e5537ca0777bd5 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Fri, 20 Jun 2025 13:49:18 +0530 Subject: [PATCH] test/crypto: fix RSA decrypt validation Cc: Xueming Li [ upstream commit 9af3fa536ec23d254d15fea4ec0e58442e56409e ] Following RSA encrypt op, same plaintext buffer is used as output buffer for decrypt op, hence comparing plaintext buffer against same buffer pointer in crypto op always succeed irrespective of whether decrypt op succeeds or not. This patch fixes this issue with a local buffer for crypto op. Fixes: 5ae36995f10f ("test/crypto: move RSA enqueue/dequeue into functions") Cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 3b57a0249b..d9a8aa0984 100644 --- a/app/test/test_cryptodev_asym.c +++ b/app/test/test_cryptodev_asym.c @@ -152,7 +152,10 @@ queue_ops_rsa_enc_dec(void *sess) struct rte_crypto_op *op, *result_op; struct rte_crypto_asym_op *asym_op; uint8_t cipher_buf[TEST_DATA_SIZE] = {0}; - int ret, status = TEST_SUCCESS; + uint8_t msg_buf[TEST_DATA_SIZE] = {0}; + int ret, status; + + memcpy(msg_buf, rsaplaintext.data, rsaplaintext.len); /* Set up crypto op data structure */ op = rte_crypto_op_alloc(op_mpool, RTE_CRYPTO_OP_TYPE_ASYMMETRIC); @@ -167,7 +170,7 @@ queue_ops_rsa_enc_dec(void *sess) /* Compute encryption on the test vector */ asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_ENCRYPT; - asym_op->rsa.message.data = rsaplaintext.data; + asym_op->rsa.message.data = msg_buf; asym_op->rsa.cipher.data = cipher_buf; asym_op->rsa.cipher.length = RTE_DIM(rsa_n); asym_op->rsa.message.length = rsaplaintext.len; @@ -204,6 +207,7 @@ queue_ops_rsa_enc_dec(void *sess) asym_op->rsa.message.length = RTE_DIM(rsa_n); asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT; asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5; + memset(asym_op->rsa.message.data, 0, asym_op->rsa.message.length); /* Process crypto operation */ if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) { @@ -220,11 +224,20 @@ queue_ops_rsa_enc_dec(void *sess) status = TEST_FAILED; goto error_exit; } - status = TEST_SUCCESS; + + if (result_op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) { + RTE_LOG(ERR, USER1, "Expected crypto op to succeed\n"); + status = TEST_FAILED; + goto error_exit; + } + ret = rsa_verify(&rsaplaintext, result_op); - if (ret) + if (ret) { status = TEST_FAILED; + goto error_exit; + } + status = TEST_SUCCESS; error_exit: rte_crypto_op_free(op); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:04.002885838 +0800 +++ 0014-test-crypto-fix-RSA-decrypt-validation.patch 2025-07-30 22:50:03.016754986 +0800 @@ -1 +1 @@ -From 9af3fa536ec23d254d15fea4ec0e58442e56409e Mon Sep 17 00:00:00 2001 +From 7bd19c617ce3c4979b95e65368e5537ca0777bd5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9af3fa536ec23d254d15fea4ec0e58442e56409e ] @@ -21 +24 @@ -index 87c26322d0..20afb5e98b 100644 +index 3b57a0249b..d9a8aa0984 100644 @@ -24 +27 @@ -@@ -175,7 +175,10 @@ queue_ops_rsa_enc_dec(void *sess) +@@ -152,7 +152,10 @@ queue_ops_rsa_enc_dec(void *sess) @@ -36 +39 @@ -@@ -190,7 +193,7 @@ queue_ops_rsa_enc_dec(void *sess) +@@ -167,7 +170,7 @@ queue_ops_rsa_enc_dec(void *sess) @@ -45,2 +48 @@ -@@ -225,6 +228,7 @@ queue_ops_rsa_enc_dec(void *sess) - asym_op = result_op->asym; +@@ -204,6 +207,7 @@ queue_ops_rsa_enc_dec(void *sess) @@ -48,0 +51 @@ + asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5; @@ -53 +56 @@ -@@ -241,11 +245,20 @@ queue_ops_rsa_enc_dec(void *sess) +@@ -220,11 +224,20 @@ queue_ops_rsa_enc_dec(void *sess)