patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Xueming Li <xuemingl@nvidia.com>
To: Pravin Pathak <pravin.pathak@intel.com>
Cc: Xueming Li <xuemingl@nvidia.com>,
	Tirthendu Sarkar <tirthendu.sarkar@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'event/dlb2: fix dequeue with CQ depth <= 16' has been queued to stable release 23.11.5
Date: Wed, 30 Jul 2025 22:56:24 +0800	[thread overview]
Message-ID: <20250730145633.245984-16-xuemingl@nvidia.com> (raw)
In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com>

Hi,

FYI, your patch has been queued to stable release 23.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/10/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=3712f69908613ff983eca0ec51096b5323e34be0

Thanks.

Xueming Li <xuemingl@nvidia.com>

---
From 3712f69908613ff983eca0ec51096b5323e34be0 Mon Sep 17 00:00:00 2001
From: Pravin Pathak <pravin.pathak@intel.com>
Date: Wed, 18 Jun 2025 23:03:10 -0500
Subject: [PATCH] event/dlb2: fix dequeue with CQ depth <= 16
Cc: Xueming Li <xuemingl@nvidia.com>

[ upstream commit 0b92203cdae06dee0626e46e62b9c34450e776d8 ]

When application configures a DIR port with CQ depth less than 8, DLB PMD
sets port's cq_depth as 8 and token reservation is used to make the
effective cq_depth smaller. However, while setting port's cq_depth_mask
application configured CQ depth was used resulting in reading incorrect
cachelines while dequeuing. Use PMD calculated CQ depth for cq_depth_mask
calculation.

Fixes: 3a6d0c04e7fb3e ("event/dlb2: add port setup")
Cc: stable@dpdk.org

Signed-off-by: Pravin Pathak <pravin.pathak@intel.com>
Signed-off-by: Tirthendu Sarkar <tirthendu.sarkar@intel.com>
---
 drivers/event/dlb2/dlb2.c       | 4 ++--
 drivers/event/dlb2/pf/dlb2_pf.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index cb25be6959..b252e9cac8 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -1858,9 +1858,9 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2,
 	qm_port->cq_idx_unmasked = 0;
 
 	if (dlb2->poll_mode == DLB2_CQ_POLL_MODE_SPARSE)
-		qm_port->cq_depth_mask = (cfg.cq_depth * 4) - 1;
+		qm_port->cq_depth_mask = (qm_port->cq_depth * 4) - 1;
 	else
-		qm_port->cq_depth_mask = cfg.cq_depth - 1;
+		qm_port->cq_depth_mask = qm_port->cq_depth - 1;
 
 	qm_port->gen_bit_shift = rte_popcount32(qm_port->cq_depth_mask);
 	/* starting value of gen bit - it toggles at wrap time */
diff --git a/drivers/event/dlb2/pf/dlb2_pf.c b/drivers/event/dlb2/pf/dlb2_pf.c
index 019e90f7e7..3ce8178135 100644
--- a/drivers/event/dlb2/pf/dlb2_pf.c
+++ b/drivers/event/dlb2/pf/dlb2_pf.c
@@ -400,7 +400,7 @@ dlb2_pf_dir_port_create(struct dlb2_hw_dev *handle,
 	/* Calculate the port memory required, and round up to the nearest
 	 * cache line.
 	 */
-	alloc_sz = cfg->cq_depth * qe_sz;
+	alloc_sz = RTE_MAX(cfg->cq_depth, DLB2_MIN_HARDWARE_CQ_DEPTH) * qe_sz;
 	alloc_sz = RTE_CACHE_LINE_ROUNDUP(alloc_sz);
 
 	port_base = dlb2_alloc_coherent_aligned(&mz, &cq_base, alloc_sz,
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-07-30 22:50:04.065310440 +0800
+++ 0015-event-dlb2-fix-dequeue-with-CQ-depth-16.patch	2025-07-30 22:50:03.028756723 +0800
@@ -1 +1 @@
-From 0b92203cdae06dee0626e46e62b9c34450e776d8 Mon Sep 17 00:00:00 2001
+From 3712f69908613ff983eca0ec51096b5323e34be0 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl@nvidia.com>
+
+[ upstream commit 0b92203cdae06dee0626e46e62b9c34450e776d8 ]
@@ -24 +27 @@
-index 08291b10b8..bec1e88074 100644
+index cb25be6959..b252e9cac8 100644
@@ -27 +30 @@
-@@ -1951,9 +1951,9 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2,
+@@ -1858,9 +1858,9 @@ dlb2_hw_create_dir_port(struct dlb2_eventdev *dlb2,
@@ -40 +43 @@
-index ac432b81ad..cd2788c035 100644
+index 019e90f7e7..3ce8178135 100644
@@ -43 +46 @@
-@@ -427,7 +427,7 @@ dlb2_pf_dir_port_create(struct dlb2_hw_dev *handle,
+@@ -400,7 +400,7 @@ dlb2_pf_dir_port_create(struct dlb2_hw_dev *handle,

  parent reply	other threads:[~2025-07-30 15:01 UTC|newest]

Thread overview: 150+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 12:00 patch " Xueming Li
2025-06-26 12:00 ` patch 'ethdev: convert string initialization' " Xueming Li
2025-06-26 12:00 ` patch 'net/fm10k/base: fix compilation warnings' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe/base: correct definition of endianness macro' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe/base: fix compilation warnings' " Xueming Li
2025-06-26 12:00 ` patch 'net/i40e/base: fix unused value " Xueming Li
2025-06-26 12:00 ` patch 'net/i40e/base: fix compiler " Xueming Li
2025-06-26 12:00 ` patch 'acl: fix build with GCC 15 on aarch64' " Xueming Li
2025-06-26 12:00 ` patch 'eal/linux: improve ASLR check' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix xstats name' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix EEPROM dump' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe: enable ethertype filter for E610' " Xueming Li
2025-06-26 12:00 ` patch 'net/ixgbe: fix port mask default value in filter' " Xueming Li
2025-06-26 12:00 ` patch 'net/e1000: fix igb Tx queue offloads capability' " Xueming Li
2025-06-26 12:00 ` patch 'net/ice: fix flow creation failure' " Xueming Li
2025-06-26 12:00 ` patch 'vhost: fix wrapping on control virtqueue rings' " Xueming Li
2025-06-26 12:00 ` patch 'vhost/crypto: fix cipher data length' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/virtio: fix cipher data source " Xueming Li
2025-06-26 12:00 ` patch 'app/crypto-perf: fix AAD offset alignment' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/qat: fix out-of-place header bytes in AEAD raw API' " Xueming Li
2025-06-26 12:00 ` patch 'crypto/qat: fix out-of-place chain/cipher/auth headers' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix header modify action on group 0' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: validate GTP PSC QFI width' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix counter service cleanup on init failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5/hws: fix send queue drain on FW WQE destroy' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: remove unsupported flow meter action in HWS' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix maximal queue size query' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: fix mark action with shared Rx queue' " Xueming Li
2025-06-26 12:00 ` patch 'net/mlx5: align PF and VF/SF MAC address handling' " Xueming Li
2025-06-26 12:00 ` patch 'net/sfc: fix action order on start failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/nfp: fix crash with null RSS hash key' " Xueming Li
2025-06-26 12:00 ` patch 'net/nfp: fix hash key length logic' " Xueming Li
2025-06-26 12:00 ` patch 'app/testpmd: fix RSS hash key update' " Xueming Li
2025-06-26 12:00 ` patch 'net/af_xdp: fix use after free in zero-copy Tx' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix integer overflow in interrupt unmap' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix memory leak on failure' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix extra wait for link up' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix memory leak for indirect flow action' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix interrupt rollback' " Xueming Li
2025-06-26 12:00 ` patch 'net/hns3: fix divide by zero' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: fix resources release on reset' " Xueming Li
2025-06-26 12:01 ` patch 'net/nfp: standardize NFD3 Tx descriptor endianness' " Xueming Li
2025-06-26 12:01 ` patch 'net/nfp: standardize NFDk " Xueming Li
2025-06-26 12:01 ` patch 'net/qede: fix use after free' " Xueming Li
2025-06-26 12:01 ` patch 'bus/fslmc: " Xueming Li
2025-06-26 12:01 ` patch 'net/null: fix packet copy' " Xueming Li
2025-06-26 12:01 ` patch 'bus/vmbus: align ring buffer data to page boundary' " Xueming Li
2025-06-26 12:01 ` patch 'bus/vmbus: use Hyper-V page size' " Xueming Li
2025-06-26 12:01 ` patch 'net/netvsc: " Xueming Li
2025-06-26 12:01 ` patch 'net/netvsc: add stats counters from VF' " Xueming Li
2025-06-26 12:01 ` patch 'app/testpmd: relax number of TCs in DCB command' " Xueming Li
2025-06-26 12:01 ` patch 'net/mana: check vendor ID when probing RDMA device' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: fix CRC data segment' " Xueming Li
2025-06-26 12:01 ` patch 'net/tap: fix qdisc add failure handling' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: fix VLAN stripping on hairpin queue' " Xueming Li
2025-06-26 12:01 ` patch 'mem: fix lockup on address space shortage' " Xueming Li
2025-06-26 12:01 ` patch 'test/malloc: improve resiliency' " Xueming Li
2025-06-26 12:01 ` patch 'trace: fix overflow in per-lcore trace buffer' " Xueming Li
2025-06-26 12:01 ` patch 'common/cnxk: fix E-tag pattern parsing' " Xueming Li
2025-06-26 12:01 ` patch 'common/cnxk: fix CQ tail drop' " Xueming Li
2025-06-26 12:01 ` patch 'net/cnxk: fix descriptor count update on reconfig' " Xueming Li
2025-06-26 12:01 ` patch 'ethdev: fix error struct in flow configure' " Xueming Li
2025-06-26 12:01 ` patch 'net/ice/base: fix integer overflow' " Xueming Li
2025-06-26 12:01 ` patch 'net/ice/base: fix typo in device ID description' " Xueming Li
2025-06-26 12:01 ` patch 'common/dpaax: fix PDCP key command race condition' " Xueming Li
2025-06-26 12:01 ` patch 'common/dpaax: fix PDCP AES only 12-bit SN' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/dpaa2_sec: fix uninitialized variable' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: add request check on request side' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: fix driver cleanup' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/virtio: fix driver ID' " Xueming Li
2025-06-26 12:01 ` patch 'ethdev: keep promiscuous/allmulti value before disabling' " Xueming Li
2025-06-26 12:01 ` patch 'eal: fix return value of lcore role' " Xueming Li
2025-06-26 12:01 ` patch 'eal: warn if no lcore is available' " Xueming Li
2025-06-26 12:01 ` patch 'test/lcore: fix race in per-lcore test' " Xueming Li
2025-06-26 12:01 ` patch 'bus: cleanup device lists' " Xueming Li
2025-06-26 12:01 ` patch 'eal/linux: unregister alarm callback before free' " Xueming Li
2025-06-26 12:01 ` patch 'eal/freebsd: " Xueming Li
2025-06-26 12:01 ` patch 'bus/pci/bsd: fix device existence check' " Xueming Li
2025-06-26 12:01 ` patch 'power/intel_uncore: fix crash closing uninitialized driver' " Xueming Li
2025-06-26 12:01 ` patch 'crypto/qat: fix size calculation for memset' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: avoid setting kernel MTU if not needed' " Xueming Li
2025-06-26 12:01 ` patch 'doc: add kernel options required for mlx5' " Xueming Li
2025-06-26 12:01 ` patch 'net/mlx5: fix hypervisor detection in VLAN workaround' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: check requirement for hardware GRO' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: allow Tx vector when fast free not enabled' " Xueming Li
2025-06-26 12:01 ` patch 'net/hns3: allow Rx vector mode with VLAN filter' " Xueming Li
2025-07-30  7:10 ` patch " Xueming Li
2025-07-30  7:10   ` patch 'net/hns3: fix Rx packet without CRC data' " Xueming Li
2025-07-30  7:10   ` patch 'common/mlx5: fix extraction of auxiliary device name' " Xueming Li
2025-07-30  7:10   ` patch 'net/ice: fix handling empty DCF RSS hash' " Xueming Li
2025-07-30  7:10   ` patch 'common/cnxk: fix null pointer checks' " Xueming Li
2025-07-30  7:10   ` patch 'vhost: fix net control virtqueue used length' " Xueming Li
2025-07-30  7:10   ` patch 'eal/unix: fix log message for madvise failure' " Xueming Li
2025-07-30  7:10   ` patch 'buildtools/test: scan muti-line registrations' " Xueming Li
2025-07-30  7:10   ` patch 'examples/ipsec-secgw: fix crash with IPv6' " Xueming Li
2025-07-30  7:10   ` patch 'examples/ipsec-secgw: fix crash in event vector mode' " Xueming Li
2025-07-30  7:10   ` patch 'test/crypto: fix auth and cipher case IV length' " Xueming Li
2025-07-30  7:10   ` patch 'test/crypto: set to null after freeing operation' " Xueming Li
2025-07-30  7:10   ` patch 'crypto/openssl: include private exponent in RSA session' " Xueming Li
2025-07-30  7:10   ` patch 'event/dlb2: fix validaton of LDB port COS ID arguments' " Xueming Li
2025-07-30  7:10   ` patch 'event/dlb2: fix num single link ports for DLB2.5' " Xueming Li
2025-07-30  7:10   ` patch 'event/dlb2: fix QID depth xstat' " Xueming Li
2025-07-30  7:10   ` patch 'event/dlb2: fix public symbol namespace' " Xueming Li
2025-07-30  7:10   ` patch 'app/eventdev: fix number of releases sent during cleanup' " Xueming Li
2025-07-30  7:10   ` patch 'net/txgbe: fix ntuple filter parsing' " Xueming Li
2025-07-30  7:10   ` patch 'net/txgbe: fix raw pattern match for FDIR rule' " Xueming Li
2025-07-30  7:10   ` patch 'net/txgbe: fix MAC control frame forwarding' " Xueming Li
2025-07-30  7:10   ` patch 'net/ngbe: " Xueming Li
2025-07-30  7:10   ` patch 'net/txgbe: fix device statistics' " Xueming Li
2025-07-30  7:10   ` patch 'net/ngbe: " Xueming Li
2025-07-30  7:10   ` patch 'net/txgbe: restrict VLAN strip configuration on VF' " Xueming Li
2025-07-30  7:10   ` patch 'net/hns3: fix queue TC " Xueming Li
2025-07-30  7:10   ` patch 'net/bonding: avoid RSS RETA update in flow isolation mode' " Xueming Li
2025-07-30  7:10   ` patch 'net/octeon_ep: increase mailbox timeout' " Xueming Li
2025-07-30  7:10   ` patch 'bus/auxiliary: fix crash in cleanup' " Xueming Li
2025-07-30  7:10   ` patch 'examples/multi_process: fix ports cleanup on exit' " Xueming Li
2025-07-30  7:10   ` patch 'examples/flow_filtering: fix make clean' " Xueming Li
2025-07-30  7:10   ` patch 'dts: fix deterministic doc' " Xueming Li
2025-07-30  7:10   ` patch 'examples/multi_process: revert ports cleanup on exit' " Xueming Li
2025-07-30  7:10   ` patch 'doc: remove reference to deprecated --use-device option' " Xueming Li
2025-07-30  7:10   ` patch 'eal: add description of service corelist in usage' " Xueming Li
2025-07-30 14:56 ` patch " Xueming Li
2025-07-30 14:56   ` patch 'net/txgbe: fix packet type for FDIR filter' " Xueming Li
2025-07-30 14:56   ` patch 'net/txgbe: fix to create FDIR filter for SCTP packet' " Xueming Li
2025-07-30 14:56   ` patch 'net/txgbe: fix reserved extra FDIR headroom' " Xueming Li
2025-07-30 14:56   ` patch 'net/txgbe: add LRO flag in mbuf when enabled' " Xueming Li
2025-07-30 14:56   ` patch 'net/mlx5: fix crash in HWS counter pool destroy' " Xueming Li
2025-07-30 14:56   ` patch 'net/mlx5: fix crash on age query with indirect conntrack' " Xueming Li
2025-07-30 14:56   ` patch 'net/mlx5: fix WQE size calculation for Tx queue' " Xueming Li
2025-07-30 14:56   ` patch 'net/ixgbe: fix indentation' " Xueming Li
2025-07-30 14:56   ` patch 'net/ice: fix querying RSS hash for DCF' " Xueming Li
2025-07-30 14:56   ` patch 'net/iavf: fix VLAN strip setting after enabling filter' " Xueming Li
2025-07-30 15:23     ` Amiya Ranjan Mohakud
2025-07-31  6:04       ` Xueming Li
2025-07-30 14:56   ` patch 'vhost: search virtqueues driver data in read-only area' " Xueming Li
2025-07-30 14:56   ` patch 'net/virtio: fix check of threshold for Tx freeing' " Xueming Li
2025-07-30 14:56   ` patch 'common/cnxk: fix qsize in CPT iq enable' " Xueming Li
2025-07-30 14:56   ` patch 'test/crypto: fix RSA decrypt validation' " Xueming Li
2025-07-30 14:56   ` Xueming Li [this message]
2025-07-30 14:56   ` patch 'event/dlb2: fix default credits based on HW version' " Xueming Li
2025-07-30 14:56   ` patch 'latencystats: fix receive sample race' " Xueming Li
2025-07-30 14:56   ` patch 'net/ice: fix inconsistency in Rx queue VLAN tag placement' " Xueming Li
2025-07-30 15:03     ` Richardson, Bruce
2025-07-31  6:07       ` Xueming Li
2025-07-30 14:56   ` patch 'net/i40e: fix RSS on plain IPv4' " Xueming Li
2025-07-30 14:56   ` patch 'net/virtio: revert Tx free threshold fix' " Xueming Li
2025-07-30 14:56   ` patch 'net/mlx5: fix masked indirect age action validation' " Xueming Li
2025-07-30 14:56   ` patch 'net/mlx5: fix out-of-order completions in ordinary Rx burst' " Xueming Li
2025-07-30 14:56   ` patch 'examples/ntb: check more heap allocations' " Xueming Li
2025-07-30 14:56   ` patch 'examples/ipsec-secgw: fix number of queue pairs' " Xueming Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250730145633.245984-16-xuemingl@nvidia.com \
    --to=xuemingl@nvidia.com \
    --cc=pravin.pathak@intel.com \
    --cc=stable@dpdk.org \
    --cc=tirthendu.sarkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).