From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC2F346C54 for ; Wed, 30 Jul 2025 17:02:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7DBD402C3; Wed, 30 Jul 2025 17:02:36 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2042.outbound.protection.outlook.com [40.107.244.42]) by mails.dpdk.org (Postfix) with ESMTP id CF134402C3 for ; Wed, 30 Jul 2025 17:02:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gp1rfjMWroH4EKoGCyVUlqiJNIgz1Rz9SPjmi9tayNAji1EJtVMfd56a9O39k/GWZmmxsSTkPVBO5fajweiXT/wfOk8/RibRPNXxBl9H0qQgBxMnHivhzvjzQRkmzEEgozZewvNteczZtRr5HbIHDLHbN/oxZCiG2UjQicka4GwxatdU4wR9Dwr+PEt8OqO+E6O31xDcsUFz+QneJsND5QAJsjqFNeQAu0/dsQww6+r43gVeJqu/+meyHRbS9dOrxR4tF5NSbMpN5JboKYI8Mrzz0HMWx8eNc9HNrumg5Rk46ZISsbf4H2e1qqHDN6TV7PrF4Wc6BULOWRIMAzMf7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FWCPUt77chrHVtYq6yoyEStakH6AgOhEix0Fz5jcq50=; b=qjneoaty6tPdnx44rZNDsIGP+v8xMPaLKW7qFpjL0EyA6u0r+QHbkY1G4/mHxnLxETabZ2wjgXC1ge6/7G/U4eKah3XRDt1Vslw1IW8JWEMm0Tcxu8vu1c50KUvcyipTpRoEWsYil/Q4wmcp8wW1dxI7n0QNo2jU8+8/MpJM/ZsAUd5JhuzMgIe2RJN/tDJ6SevbZSCtJq92S+qDKHgLU6Oogq2WClgWmvHeY3jFTjSM84na/70DE6FTyPQ6AxeQePxExpHU1+VYTIVoF8Y19soPdLmLbfvDJlH56T0g84npCXGJjnu2h38mjbIBLS8VLTPrkY9hcVPOjV0j7AAwKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FWCPUt77chrHVtYq6yoyEStakH6AgOhEix0Fz5jcq50=; b=L4MNJ5jYN2SBPdkvgT6X+XwL05M5dX11sfICJY+0YlU77swAbLB0S+uV+nD0cDRQVaqfxPcLwjvmGOzosXoFY3pLhnOQVwWtBYD3RJ/pmol6RIuOobEFpGaDLW+xAYZIp1un2oyOprs6DjrJilq7bb7+5bXt0aVsG3ud3hWIC95SvHgXvBhf0pfjk0ZozRTfmrwS/Qm4aWsZJqHNYOUMMMtnWhofczMPFDXW3Ho5NVgbYV0YRT1BlpdDdCe2QwW6QqAKxJCFA09nQRCtl+jaKvJemedeYY5pNkwhd+9kHHdFYjBcjJsXUyBHAIykBwZjgB1Rv8KZ8589MKwJMFsguQ== Received: from SJ2PR07CA0007.namprd07.prod.outlook.com (2603:10b6:a03:505::12) by CH3PR12MB8212.namprd12.prod.outlook.com (2603:10b6:610:120::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.27; Wed, 30 Jul 2025 15:02:32 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:505:cafe::a8) by SJ2PR07CA0007.outlook.office365.com (2603:10b6:a03:505::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.12 via Frontend Transport; Wed, 30 Jul 2025 15:02:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 15:02:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:02:09 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:02:06 -0700 From: Xueming Li To: David Marchand CC: Xueming Li , Hengqi Chen , dpdk stable Subject: patch 'net/virtio: revert Tx free threshold fix' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:29 +0800 Message-ID: <20250730145633.245984-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|CH3PR12MB8212:EE_ X-MS-Office365-Filtering-Correlation-Id: 3659fd8c-ae93-48c6-7c1b-08ddcf7a1c67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BcPTygRaJz/oKyjSb6g86MmAqPBGehnIy6Tt+v4OyDz191Z1GtY7NIGVTzHQ?= =?us-ascii?Q?zE+thMmkor6OmH12xFNQpDlO7jq8pMLaTVTT4UbVELkjAmBDQpBZSwGbueOR?= =?us-ascii?Q?lwVN29LCZMMYHoBhjOpUELALpBjKWgH02ODrIJsR1OVQ7BJ+M4hdX8y9IIqj?= =?us-ascii?Q?sqiHD6K6fZ8mrUgXrKOvrTVOuIs+spxOPozF+DhYODe25YuKQY0U/L2ClxsD?= =?us-ascii?Q?uOhdtbhH3qoenWZYHdCd/Is0+6bSymDS+cyc9+9WFSVeOfY+jm3mnjtde7Z5?= =?us-ascii?Q?kqzlYKTO9HZ0UrpNjz+JAegDBRUZpK5P0KDYnFwSji5fj+zrJwluTYIq7gH+?= =?us-ascii?Q?xiO/1XBxXrDiThzIhl1AYXFAxW/r9PQM7dU3YhsusKlfj0w9j43l8L87A9Nf?= =?us-ascii?Q?c5RxgoayD59XwsszS6ag9WG3TOwvIZq8AfPBOKrTj3Ud1GTNez3QTjVYjIOU?= =?us-ascii?Q?E9CeTipr8MXFQmsX3xfrU6cVyd0Sz9TqfArBCAIVuDlqUhO6jKGTlsSIIr3b?= =?us-ascii?Q?8f+Y+MduXaDgH7uGcHRsmraKpEO4z/1+FctVJpf5c5YeiAta99Er2IypBXdf?= =?us-ascii?Q?sNRU2Rv0rJ1vcGHxGVoaW/QBZMEg2xYWf7aBoSSs/ovbrGGz1RDTNL1C2G7y?= =?us-ascii?Q?pe6vDTeRsNYZDBkbEtalX5i3T+JiRcfxrGqCwbp+u6YJZUqUgvAm1lrHm/Fg?= =?us-ascii?Q?z1cJM2QUCr/XdQHjILIuOHJ1qvkkDFkiT9kMYcoCDQboJ555p2eDKOdmgbBw?= =?us-ascii?Q?tXJ+JtmjDsXtyTcTsJgYYduqMiuWNE63/ncka6tKdC/JwYsMwRLdU2TU/tSX?= =?us-ascii?Q?0GCiOZ4UZOzaN0SORBVgIDvSlwQH6+Lw+begw3t9PNJK+7OMeoSQGoKQphe+?= =?us-ascii?Q?YrmdDMhyFzevZNCmrvlJiUtaQcajFHUD3yFG6dk78AE5orBX7eQpL28pqE9L?= =?us-ascii?Q?d3+Z5/IghMYxpL79yKf+GQv2OsY783sF4XWKpuurVWjdTXA5ri6J7jX6Zf7Y?= =?us-ascii?Q?lujwbK1qPh7DC+vaaZBijxchRiMI6UD/c/aR6jxR1poOU7bNXvW0lFPhIYeN?= =?us-ascii?Q?vJIwZzkQAugw45S2vYepDmK5qd2jigzUpRFTyMLFQNbPB4QVMh4yCrTo8Xvs?= =?us-ascii?Q?GCUIuYDMhv7sOr7pSB1JCv1N7CGmCLv0fHOxvBM6tij0Nisulva2FT5PY69D?= =?us-ascii?Q?ZEoYclQpfjbPuU956UWiWF4lTjqA15Xg240hoAeDH6WMi06KUmmPI24Y2Ke7?= =?us-ascii?Q?B8KdhZdl2HadMUrIWpo0YsrJMpWtojRR1DnCuFuuIGkQijliNUosbhzrB2Vk?= =?us-ascii?Q?R+xwKQOuuQ+WocuiSktO1oJfulvBuWbY2CeAjwiBlzVZuirPk5u2xyvpdluc?= =?us-ascii?Q?asT+WFJWrGPOfr1QP4IuVEyWVnC0mWLBYKIPRlmsMiAHvvCdfbJ3y6AKgozH?= =?us-ascii?Q?p53AvOtWpFy+tnmPM4Fxvprq74BHpHvMoklvQFBsJjViV6/62Ty9p3R6B+zd?= =?us-ascii?Q?yivZb1+z11znQ3rm/AbG3GgbU07beH9LmRWs?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 15:02:32.5667 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3659fd8c-ae93-48c6-7c1b-08ddcf7a1c67 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8212 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=5dce28bed67705d012acb4670ed99d547b7c96f6 Thanks. Xueming Li --- >From 5dce28bed67705d012acb4670ed99d547b7c96f6 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 8 Jul 2025 16:07:09 +0200 Subject: [PATCH] net/virtio: revert Tx free threshold fix Cc: Xueming Li [ upstream commit 5a117f05fc5ad200ec61837fa21d946c6a209822 ] This fix introduced a performance regression. The problem is under investigation, but we are too close to the release (and the virtio/vhost maintainer is not available) to get a fix before the v25.07 release. Revert this change for now, we can revisit during v25.11. Bugzilla ID: 1747 Fixes: 3e3c7f3fa5ac ("net/virtio: fix check of threshold for Tx freeing") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Hengqi Chen --- drivers/net/virtio/virtio_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index a13df4952d..99b95194cd 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1863,7 +1863,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) nb_used = virtqueue_nused(vq); - if (likely(vq->vq_free_cnt < vq->vq_free_thresh)) + if (likely(nb_used > vq->vq_nentries - vq->vq_free_thresh)) virtio_xmit_cleanup(vq, nb_used); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:04.356999507 +0800 +++ 0020-net-virtio-revert-Tx-free-threshold-fix.patch 2025-07-30 22:50:03.052760197 +0800 @@ -1 +1 @@ -From 5a117f05fc5ad200ec61837fa21d946c6a209822 Mon Sep 17 00:00:00 2001 +From 5dce28bed67705d012acb4670ed99d547b7c96f6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5a117f05fc5ad200ec61837fa21d946c6a209822 ] @@ -25 +28 @@ -index ab97f03d7d..edecd2011f 100644 +index a13df4952d..99b95194cd 100644 @@ -28 +31 @@ -@@ -1873,7 +1873,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) +@@ -1863,7 +1863,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)