From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B12646C54 for ; Wed, 30 Jul 2025 17:02:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0385E40E78; Wed, 30 Jul 2025 17:02:48 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2077.outbound.protection.outlook.com [40.107.212.77]) by mails.dpdk.org (Postfix) with ESMTP id BED6840E96 for ; Wed, 30 Jul 2025 17:02:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vVt3xevnXjuUm67jc6WgGrZvGBYlVgT0NCJAPTP239pJiG5HRwUvnyJ3OlzF40ai95+1bftWh4JUmytX98JF1rAzv3zdUpGnDl3aZfJWVMReDpX9fHfWYsy0Fxi7m7AIaGqJpx3XLIV4raiyzgBMCXPKM7gJkfWXnZBCiu2LtxwedYUgMaQOlVJvBEINQVnZDmXmq56o/o4zrwJpZJqYcSxHu4mLWAWiPbGiB1t8vPV17aqCrDMWwUed5Qj8aLLX8Y8VM8n22I29Ijd1NK9/pmiZTyDvJq3cyl3jqGNX56hzPuHWFQvVeS1av7WbT/ZN0xdiTV/43a84pkO3Q8Uv8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yM4Sce3aBYyUXi1q8CqTa7OMtbd7PUbWvldzMsx5RKY=; b=XHrjNdalhcrNNZ3LDVFaYvfGp9OSSCBETFJdwsRa7J+nYdlGy/htphcP4IDY7SfVag9YL6YLPJ9GrlNvsGnrEseWWuthrF7ipq2EHveDH5ckJ7OZA2S8aTYLXsc4abzeX47CGwiBNafGsTo34cnCKqXJHonHNZjUOBwwq2IdFJiP8fjmoTvBtPfslTNoti7Lhmji2K4zNRb2DcXMzXSNX9MvMq5ar4Yrc6+mUokaVJRxu+hZfDbRH6pmngbTKS6mryziniPbEsIPixRnHpEP/JhOGmnw+ebLVrJ2OjrbYEYVOxdYFTlmcRelOvB0xrW9Huw6DzcvAg7uxTSynyC0Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yM4Sce3aBYyUXi1q8CqTa7OMtbd7PUbWvldzMsx5RKY=; b=C9Gyfea/nISNWcJR6ukwPUlOYNvBtQFwievN96zCJruLalwJa7pW3tYeB6gyoDLwLv1v/bUcAmMXTzAMGllPEKkMiNOksoqs07rHdOnmRPR6UU7U0f+5kz+KRB1wf/uCRGNOnIDrhPompfSPxc2SD2WqicHVFPS84RyEbHA/YWj+PJOf+nyQKQrk9Mb6P+gJXrqiXbMadFmfPvwSBMRglQzqxQu2O/siu4wbjGjHQpYVt5XSBnqdxFthGtNyZSyTqjjkSrIAOLazPkBD7K4zMYil4aj5em54erf42W0tGs6UgW6WELDQiIk8IWYyOsBWlrkFNoBDjaC22mnnMkI+Pw== Received: from SJ2PR07CA0012.namprd07.prod.outlook.com (2603:10b6:a03:505::13) by DS7PR12MB9550.namprd12.prod.outlook.com (2603:10b6:8:24e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.12; Wed, 30 Jul 2025 15:02:40 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:505:cafe::5a) by SJ2PR07CA0012.outlook.office365.com (2603:10b6:a03:505::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.12 via Frontend Transport; Wed, 30 Jul 2025 15:02:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 15:02:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:02:16 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 08:02:14 -0700 From: Xueming Li To: Bing Zhao CC: Xueming Li , dpdk stable Subject: patch 'examples/ntb: check more heap allocations' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:32 +0800 Message-ID: <20250730145633.245984-24-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|DS7PR12MB9550:EE_ X-MS-Office365-Filtering-Correlation-Id: a4dff88c-47b5-4200-c364-08ddcf7a20ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NHfFdbt31iP5QJkUdsA+lmWpCPdpo64lGdmP24t8RFvjwkrGEgmG0OVN5fe2?= =?us-ascii?Q?b+qZs5/yBvgqOa9nF0HGQ9POQ1xiokeAEK0mJF1sL0mljBipfX+93qxFIWJd?= =?us-ascii?Q?TCwaMYVhqqq3TVv+zEvJBEP8nPICi0EEvfjEXPM5crWAXdxjv+Eqnp1ZPEJ4?= =?us-ascii?Q?i/Dq9AL8dhKhvcaFvSwDVYNWMmrk+LDxn3eDItoekj2ckrgbs9n14RGJCsL/?= =?us-ascii?Q?COjIoMuV/a5nR07PliczEh9js4n1xCFYQUasdsFsEb3s6bUO765F4vY6SVaJ?= =?us-ascii?Q?oNB/KwIebGrB7LeQYqM0A4z+hIK0pmO/OwTnJMXcnJamc0pzpH51dCYk38Kq?= =?us-ascii?Q?m/GZdQe3D/9i5PrxoxyCpjpeT36x5ugGUljFcFCrQj1+mPnOAfQGO8TEcyeg?= =?us-ascii?Q?k/YytNrPdLwILUIEwiRuH7mMx4KAuhZmkiC9hrwGDWLKfw1v36Whp/+s+SPv?= =?us-ascii?Q?0L1RhvM2o/yqynwaz1C7aefcPAkFBoNoKgS2GJaf35GUdd65he9StOTXnF/D?= =?us-ascii?Q?mmPg9cgSUoZDfAE8mfm1+f1IcKIGyvvLefAMtcbwdicYqMM2stAJMRfE8o9k?= =?us-ascii?Q?ntqRi8qxcerDzx0oPrLPBvbiRfDP4oifoD1sWsWCGCJJOkoMSxAyoX8kcsbP?= =?us-ascii?Q?V3Cab16C9C5rOFEQtr+gyPAGj5mgFl9ra4R1Q4hQe9fQdoYTFNklFP4FIve7?= =?us-ascii?Q?O9IheRdH3fYkHzWyycGHcaNykBfyU2SzibijQVtTMYvCNB4cFNudg5SPZ6OV?= =?us-ascii?Q?XwIJYTbHppg4wbgcgegaesKR1beo1B5jutPkdFVOb7ScoLj+V8bzPdKfOGfa?= =?us-ascii?Q?28pY9BmesNopJfl9qM/wWo0MmGG2RbKWVjCJCtD/ogbrxuwarl4UuHLp99Yq?= =?us-ascii?Q?d9lm8+M93zFpLyMTDWmppodF0JIBhYxs+ChtEI7JPbYHA0JXMEu7UliENg+f?= =?us-ascii?Q?5vk/HErvWsCotEHeZnZz4fFWFMJaWu6N9SJjUd81MIiuW+0wrCHibbrnV+Ss?= =?us-ascii?Q?FC4hoge/sz3T2nQVyeiSTPyMucsJN9CWoZcSOWfkL5Wu1TZlkq/Pz2UyYJMA?= =?us-ascii?Q?mHn53yE9f0xxFvmU1ClN+G++qcbTrsQCydEtQSixi+cPj2PtNXNvDM7u3rW0?= =?us-ascii?Q?nbdiUrEZURnwajAQRhn0zDOxzoiCSx1fz/M+zI4txGecDjqLPll+VIuA7OVs?= =?us-ascii?Q?Hdxqf0WWP10pVbUL4QmH/Dp/d+9b3Mu+AitXCWl8yYnEwDGHh/s+Dh/orVQS?= =?us-ascii?Q?/QK8KcJJJyJWLqdFfCLxPipMg0MuwvGwK5aL4tgHSCIbvbqQSmllY6RU8Wrz?= =?us-ascii?Q?GcJ9iKiZX1mgYoHt671rslcYSSVgrDynwx9x3/RHGOkiKLaH0Hq8GvXtRcxp?= =?us-ascii?Q?GpeOgKb09Rhf1Uflz5HYDpfEtB0lLWNjaLpprFdHZe7TofwgL84Xm7z+BbYX?= =?us-ascii?Q?i86i903h/Eg9N76bfNLzxt0MvheRe6svYDrXkYtBojp+wfX/kW8QxKzg3o9X?= =?us-ascii?Q?+yxkKXHtumWX7NijOW7K11SPAVXXd/pV3UBN?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 15:02:39.7027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4dff88c-47b5-4200-c364-08ddcf7a20ae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9550 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=bf7357a972228374eb9146ad5870b21fb95f034b Thanks. Xueming Li --- >From bf7357a972228374eb9146ad5870b21fb95f034b Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 21 May 2025 20:23:33 +0300 Subject: [PATCH] examples/ntb: check more heap allocations Cc: Xueming Li [ upstream commit 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 ] In some rare case, the libc memory heap allocation may fail and return NULL pointer. Before accessing the memory via the pointer, the NULL pointer check should be done to ensure the code locates in the safe side and no crash. Some newer GCC version will check this by default and report warning on this. Adding the NULL pointer check will help to get rid of such warning. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Cc: stable@dpdk.org Signed-off-by: Bing Zhao --- examples/ntb/ntb_fwd.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index fcf0ec9b56..9a43ca4a3e 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -774,6 +774,10 @@ ntb_stats_clear(void) return; } ids = malloc(sizeof(uint32_t) * nb_ids); + if (ids == NULL) { + printf("Cannot allocate memory for statistics IDs\n"); + return; + } for (i = 0; i < nb_ids; i++) ids[i] = i; rte_rawdev_xstats_reset(dev_id, ids, nb_ids); @@ -843,9 +847,20 @@ ntb_stats_display(void) return; } ids = malloc(sizeof(uint32_t) * nb_ids); + if (ids == NULL) { + printf("Cannot allocate memory for statistics IDs\n"); + free(xstats_names); + return; + } for (i = 0; i < nb_ids; i++) ids[i] = i; values = malloc(sizeof(uint64_t) * nb_ids); + if (values == NULL) { + printf("Cannot allocate memory to save fetching values\n"); + free(xstats_names); + free(ids); + return; + } if (nb_ids != rte_rawdev_xstats_get(dev_id, ids, values, nb_ids)) { printf("Error: Unable to get xstats\n"); free(xstats_names); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:04.553107618 +0800 +++ 0023-examples-ntb-check-more-heap-allocations.patch 2025-07-30 22:50:03.096766566 +0800 @@ -1 +1 @@ -From 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 Mon Sep 17 00:00:00 2001 +From bf7357a972228374eb9146ad5870b21fb95f034b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0c1a5ff96bfca1ac513b64f081a20f4992c6fcc0 ] @@ -24 +27 @@ -index 37d60208e3..33f3c1ef17 100644 +index fcf0ec9b56..9a43ca4a3e 100644