From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C8A846C54 for ; Wed, 30 Jul 2025 16:58:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 660E2402C3; Wed, 30 Jul 2025 16:58:47 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2078.outbound.protection.outlook.com [40.107.236.78]) by mails.dpdk.org (Postfix) with ESMTP id 87B83402C3 for ; Wed, 30 Jul 2025 16:58:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KwBDtPzD8IIlOgpPaOCpvzcCc43dRASuV5ke0ctlkczgMfOd0+KfyVvsJl5m0Ei8yuMRJ56NY2OK0Q+NciyG1THXKVwd624kip1FFimZRNK3anUcaQRIMNteIpjwxZqHBw6FoBKlfCvLwGt+KDiG1tFx1Ba1iqQlKabMRP4NNoviF/rcnFsFpJ0ClyODDgIG0Qfx4CN4oqWOHbIki0MhyLFxPqgTJQiFN2Rs2huLoczdgBzxjd2FrZdBOs/hZAdIS74OtWfrjqKuHJy2P1FCtkfbNjyaYDi990GGjWEMhLvO1keawotilwCblucj2CnzWEi4DzBKVa7F45OWk+S1mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nmQO88fcW1tzttlwlnbb+nSdkFAAgjuQxGSKsirAlIc=; b=jAzZjEyZqfy3OP5wQu3CjsLd/2XlGkCV4QsQCvl8YIws/IzL/MR3uax5RbEPxr6KSRzETTsQXDgpUOU73FJSZk5afs1U+nXwz71oiJ0DDoC9XemEYIzx8pTHLbITHVVNO53pu3h1wFc0ExWbqFHhIR2FX5UZJD/EFhHi2CxH17FwPaESZRpdAJegK+iS/pshkP7Vp7y9vBoXsQ51TGNQkAU//nB9Cfvg17qHkMmKN2r2B9CNvNAwztue8C1SlDq74xnYgi8d/A3OJXnuriLbe3+iPL9kgMKgKLaJ4TPXnYU/Y5CimXQ8yBZ6fIMzuZWJVehiocRcNGqAXP1PPNgj/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=temperror action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmQO88fcW1tzttlwlnbb+nSdkFAAgjuQxGSKsirAlIc=; b=ZAJE9LcZQNqJiJlEsM/Mq/lHCiwWwqf6iXlw6ZciBjgJwsY1JfNCiGPBSBG/HUAHJ18dA+FFgtYc+STZv4OkDZuqenUFJ7R3QpG8v25rRNFgwmF+WW0hB0YtHpiyN1VqW38Ud1CDA2FqgAC0x7fsZpjlih2UlL1xzEZ5RUWzMCoWZoruJ+pJQkkIAy1G4FoPBCXqDIa5qGEnsZusZ2qXve36t2wbKeUf9ncqP03BuY87JISEtcbSlmF+le8AZh5tIcmGBJE+T/1UC+n1qROe0KiiY+Jml36HhlMyXaECUZYA7Oewk6q1OBc46Oqtg9AZIE3Z9RPIuk10Y1f06Vgg0g== Received: from BYAPR07CA0012.namprd07.prod.outlook.com (2603:10b6:a02:bc::25) by SJ2PR12MB7962.namprd12.prod.outlook.com (2603:10b6:a03:4c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.23; Wed, 30 Jul 2025 14:58:42 +0000 Received: from SJ5PEPF00000207.namprd05.prod.outlook.com (2603:10b6:a02:bc:cafe::1e) by BYAPR07CA0012.outlook.office365.com (2603:10b6:a02:bc::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.13 via Frontend Transport; Wed, 30 Jul 2025 14:58:42 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=temperror action=none header.from=nvidia.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of nvidia.com: DNS Timeout) Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000207.mail.protection.outlook.com (10.167.244.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.10 via Frontend Transport; Wed, 30 Jul 2025 14:58:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:58:23 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:58:16 -0700 From: Xueming Li To: Maayan Kashani CC: Xueming Li , Bing Zhao , "dpdk stable" Subject: patch 'net/mlx5: fix crash in HWS counter pool destroy' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:14 +0800 Message-ID: <20250730145633.245984-6-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000207:EE_|SJ2PR12MB7962:EE_ X-MS-Office365-Filtering-Correlation-Id: c0035ad4-763b-40b3-878a-08ddcf79923c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AUx5zuO0r0s4LtFJe9seM5lw0Z1nZNxlStiWvqJ8X+8Yr8b17ONG9pJVl6YO?= =?us-ascii?Q?6Ly4IBkI+/wB8G2c73N7grfH3sfs/Rk64PBFXYDcnrbAerZpf3bOuvMKUvnR?= =?us-ascii?Q?02UsrLi1ggIr3bUMllbJtbgpC5ksEJ2/ETcDqWV3XDJurCoy3q7P00R0klKd?= =?us-ascii?Q?6aPJPdlFWg/8ROPWtYTjVqmo0R8gXX4kmkRuw39st1ZtV94E73n4y8y468OP?= =?us-ascii?Q?ZAkxQI7nDZxbW5m7kFZP3FMScMVdS1FaOXRLHHc7MPfA44Uny7WjS6T/eU+n?= =?us-ascii?Q?Ba0LPEKD48BhPALJmke7unA+/+UMA3NYqLQxXOusEXB0qfhEDdboIX3+wqmo?= =?us-ascii?Q?QLT8zqRX0xFes8jWRqHP6vU9e4Ft4DgN6Kg2aPf7QG902P2KxdtDU/JJQGSp?= =?us-ascii?Q?541RT+SQ05pPMahhSGnfDgHGNNNtRSH1xGezPOWmDIB9yQt+KiLZQeHy5BQz?= =?us-ascii?Q?zBf0caZzGL0Y365UB1kxqqTi1XHbgoTIyqNrsw4kBR4jdxT/YBGK6zGxi+I8?= =?us-ascii?Q?9wiWGP8hK9NKXZWZUIc2ddIb51m0m6BsA7sI5jOVoAXts+eYii/9pho86Cq8?= =?us-ascii?Q?t405auxmBfb4Ms4Y0ELrojqvcGW93uZkFEY+ZrmdcyJighp89IeXLy8W+kmk?= =?us-ascii?Q?XnTVmINnhUYwxlPbRrQRlsQ8O3Uot1cIQguUcht6xRs54X2i2PCi+VewZo03?= =?us-ascii?Q?mhAJT793AgQUQYprzbU92WX4uWqNwCHu+ilglvdd+ppHC1nptK1MfCnc08bm?= =?us-ascii?Q?j0allmwzzcudzVkiPzDF19M9owRDw60u9IHUHE9UF9ueBtW2rAUqsTZT7vbp?= =?us-ascii?Q?61KJA7UBIa75rNj1HpUd/XmONY22f/62Q6CasKW5Ffd63JQjbKmq8F4ZrEDr?= =?us-ascii?Q?ua8xMDc6KNbWMfr3sfdbDMjs0m7Jk9Wk9dIIpoSVFcN58xdMt4R2+1xW1z2E?= =?us-ascii?Q?ALT/kL9uvuNdOWoavH69M6hPLVMCv9rTGOV3ofbdjjd7jVqEGLj3SBovLWH7?= =?us-ascii?Q?/8OJHQXAVDsp+wjdrdHMDJn+06+fd/MTSsCc96m2mQY47AJtR49oAEduwXr+?= =?us-ascii?Q?ZNeJIilXIcQSPMhee95fTp8emLTStTm0W5txRj6n2romqmYu2+7MfqYELFE9?= =?us-ascii?Q?fk0hqv3JdTk7NbLjICRSgjS8j6elGF/hafxAjesUaUzA3pOecJyjStkRRVYx?= =?us-ascii?Q?M1YaQBwQm55IuK390olXeTxjqBrDU73X6OGfvrye8YHbH2dJy4LtjNe65bgr?= =?us-ascii?Q?pdPC9Qb+FCbQHE//1P8P28PwjOwg1SKkTkIMXMYBUuVyYT0qFU3rPto6Pqtj?= =?us-ascii?Q?1NBpXCBWxbAZgfMKC2y0FiazxNLCekUPwSx6eYac6R/IfJUY+zUVM6DCgGVy?= =?us-ascii?Q?rx5YzGkwDvTvG89+mDpQAK1jVVcsa1kNUSefn4Q6iqDuSHOwwsKhM5fjlo2t?= =?us-ascii?Q?sHhBskBpXNgWWptT0ZUjl6DKvifUtrk9dwxNS1oL562g37jj9p2fK9yx8drZ?= =?us-ascii?Q?uU30fNhUlwK0RbSRVeaz8M1sruWWHA0dvaG2?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 14:58:40.6878 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0035ad4-763b-40b3-878a-08ddcf79923c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000207.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7962 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9c2d8da172e6def2bc3abd5d18ffee416e795766 Thanks. Xueming Li --- >From 9c2d8da172e6def2bc3abd5d18ffee416e795766 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Wed, 25 Jun 2025 12:32:47 +0300 Subject: [PATCH] net/mlx5: fix crash in HWS counter pool destroy Cc: Xueming Li [ upstream commit 0aa0d0e85011116d545318b79e28cb177f5da825 ] When there is not enough memory, counter pool creation fails. As a result, the pool is being destroyed. Since not all pointers were initialized during creation, Need to check for null pointer in destruction. Fixes: 13ea6bdcc7ee ("net/mlx5: support counters in cross port shared mode") Cc: stable@dpdk.org Signed-off-by: Maayan Kashani Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_hws_cnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 7e33568622..a47ac098cb 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -733,7 +733,7 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh, LIST_REMOVE(cpool, next); rte_spinlock_unlock(&sh->cpool_lock); if (cpool->cfg.host_cpool == NULL) { - if (--sh->cnt_svc->refcnt == 0) + if (sh->cnt_svc && --sh->cnt_svc->refcnt == 0) mlx5_hws_cnt_svc_deinit(sh); } mlx5_hws_cnt_pool_action_destroy(cpool); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:03.468048383 +0800 +++ 0005-net-mlx5-fix-crash-in-HWS-counter-pool-destroy.patch 2025-07-30 22:50:02.940743311 +0800 @@ -1 +1 @@ -From 0aa0d0e85011116d545318b79e28cb177f5da825 Mon Sep 17 00:00:00 2001 +From 9c2d8da172e6def2bc3abd5d18ffee416e795766 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0aa0d0e85011116d545318b79e28cb177f5da825 ] @@ -21 +24 @@ -index 83db242bf9..fce7a7e815 100644 +index 7e33568622..a47ac098cb 100644 @@ -24 +27 @@ -@@ -810,7 +810,7 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh, +@@ -733,7 +733,7 @@ mlx5_hws_cnt_pool_destroy(struct mlx5_dev_ctx_shared *sh,