From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90F8E46C54 for ; Wed, 30 Jul 2025 16:58:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B6EC402C3; Wed, 30 Jul 2025 16:58:52 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2067.outbound.protection.outlook.com [40.107.96.67]) by mails.dpdk.org (Postfix) with ESMTP id 86346402C3 for ; Wed, 30 Jul 2025 16:58:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vhMUeR4zc7AeO87XHts78Fxy9BhyD3OeiH4LSTpkvfTKR5lYVkNLlJsomDbdXwauKWxwEo28xkAPMpzH45ADSutOzNGHdA4Stl42eGFECj+yfWXDokJWqVCTRHHwRXaWd4fObMv8wivokKI5jUrUQtcNwQyL8OeO+WH5NysVOld2ct6Hqrif4PTwd7hHOk1/lDq765z4CAFR6+9k7F57/R3IUuw6PihzxfUQ6aV301vleeSx6PVLajPdRlIuUrI8npdzpdRcv0+3si2cVrOJxpPZvz8t6Gyc+2G/eZ09K8IywvDpiNA4I8fGcRDWjyTGmPHd6eLz9cbK8aHbXf8/cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XdHsGZjLcm+OJB2M9h4F2rzyWIQFBS5DMbOZRTtLhnA=; b=MGal00Z7v4366CDsOt5D6vKVFoFvI/r0fxR7H1FOyHixM9JtjHh7nQhQAeHvdtrX9ysUTdphNpluO8dzSyeZZbmsE4jqETc0Qs653rOLDYMqQ5Z4CMFrXrolQUj8JS/BB6Q54Hpzoi6HFAY17gBx+a22lfoU1WisOzxQYL0OHTjFbJmr4vuQXOqYe8DJrLYTUjKnHF8mpD9+mS9+z5274757o1mp8n8PI5++QT0iK6Ojn6ok6Jo+2fVIroZt2CjANM8lBW1eyeYVMLEyRQ5O97B8RACgF3ah18DGdPNu5hne9BGjyeznmC2Hra41mPv7mDwbvW+MqCtpql62s8c2Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=uetpeshawar.edu.pk smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdHsGZjLcm+OJB2M9h4F2rzyWIQFBS5DMbOZRTtLhnA=; b=A2Q05cTIppOEe/MB49HuOl/hN6bWuQVtFYRxXFhK/DYaEOxQL6qfriFKzs6IJxMo7i7aPQas/knAGb9QVh4EqogOC2zvFoHwk3nx8bfg7m21TS27KbEKkok2E/oOw/6GCPwTmONtMq9N1fuupQgb28Uv5nfc4Y0KT+iu1i4xqSgsXgINC+6u79umA1kjkycKYEPXmlaEN/b94UNJL5CaINpAZ+okIR6l7F3SZDMfXEGwxTlPgtpUOKkgGZH93wYaeddqjDo5l5UdiaHx2REUa4NwCE/TOBhwn4Um3R2S++EKj9jfjeVa5B6LFv7BrVUnDVhQh8NMdVMtHZmtfEZo5w== Received: from MW4PR03CA0093.namprd03.prod.outlook.com (2603:10b6:303:b7::8) by PH8PR12MB6794.namprd12.prod.outlook.com (2603:10b6:510:1c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.26; Wed, 30 Jul 2025 14:58:47 +0000 Received: from CO1PEPF000044F7.namprd21.prod.outlook.com (2603:10b6:303:b7:cafe::37) by MW4PR03CA0093.outlook.office365.com (2603:10b6:303:b7::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8989.11 via Frontend Transport; Wed, 30 Jul 2025 14:58:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F7.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.0 via Frontend Transport; Wed, 30 Jul 2025 14:58:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:58:33 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 30 Jul 2025 07:58:24 -0700 From: Xueming Li To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> CC: Xueming Li , Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix crash on age query with indirect conntrack' has been queued to stable release 23.11.5 Date: Wed, 30 Jul 2025 22:56:15 +0800 Message-ID: <20250730145633.245984-7-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730145633.245984-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> <20250730145633.245984-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F7:EE_|PH8PR12MB6794:EE_ X-MS-Office365-Filtering-Correlation-Id: 294fe176-98a9-4b6b-f74f-08ddcf79959e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dXuJ3VQc2M1ZjPhlbEYgaS+am3r1q4+ltyzr3wV5feaEc6bvXHI9KXXp6Awt?= =?us-ascii?Q?EXKn1pgSyZrik/G9JfIa1PJmGDGCt21ztQWebPgzCXXGRujOg4v0cZEykdPI?= =?us-ascii?Q?Dmn/DdrDNh4yWWjraPUamOEI0Oin6JYSJBcYe7harqjuxbJYMWOmZdzbk9rJ?= =?us-ascii?Q?lr2+l9baNmoUV3cvsI+5k30ymuORoIOypWjH5mdh5UhCxl2rhRLI0z/U1Nac?= =?us-ascii?Q?T2JncdtvMIx26jJXuqLtaQqviNJFylZzcljOOj2IXsD8EtjoA4Ua477EDE7k?= =?us-ascii?Q?z9QkRThTRnvAZ9vXozLQZE8QcPrF7u1V4RLMcz/196u0N/iPXInEJBeAtaW2?= =?us-ascii?Q?Z83e6jDHh2X9OiZR66zLEy1/ykI7pcPY9GhAmsIgwogqnlwKLdU9tKOiGWGu?= =?us-ascii?Q?ZZeL/l4gjUsRVrkxh/qjhUFQC5iFwPNvn/EYNqFPkCtRB6PtSz8sc2QUAhJn?= =?us-ascii?Q?Bp8GYIF7xeXuKuGSmi42gOBl0f9GCdMbsQ6eUj/gzPLMEdSuOKFogQHnPpt4?= =?us-ascii?Q?jIWpcLjxBdfhPjy+cdVYPsT52wWtiLwQ17dpc3cDMTlRUpzH8bNFzCVdPBHO?= =?us-ascii?Q?2duETEW/5YxGjtwZz3bg2SJV/TdkTVhIabquE4FS1RQZD7FSSjUrLKZHqQ2R?= =?us-ascii?Q?mxWuIA2B/NGpzlGUaS4LzpsHtjqvUqpvckdiVyUuhhiuoJy+ejSwzLL5nTTu?= =?us-ascii?Q?+TvsynsL/Hr6sxnHHMU2l04M6gS80rhOqdu/aZS2Pt9dXBAAWrBMTFrV7onw?= =?us-ascii?Q?uEpSYyRdOQcYtKF1YtaU0ZXpFKj9ef1lVcw2zFnL3I1JEmm13kgoEhr61oqE?= =?us-ascii?Q?HvBrjEdw7yLbUFMABK/tlTl+YdTv55mM2P+2E4iKVrt5WAMea04Expu7S/4H?= =?us-ascii?Q?aMgH7PnqnLnWF/rYrkbdG2SX0a4Hy2s0j+9kxm/2YveX666waalxAbMzK7ku?= =?us-ascii?Q?DFwfGiXGOqF0ark9bn8aK0MKRmqLE6r2iHmT4dCaPMmNHr4mhvRTlNPd05/k?= =?us-ascii?Q?VyJxGb9BPLmix/nESQL/vqdcBtOF2tTTPneVIeLKUs6hkW+j5ONZcb0t8PLr?= =?us-ascii?Q?sMTF8NMAI/D75+KQs4l1s1GH9PEAyKMAYIMY6cYaqxouTU3nU/io6ixwf9Ez?= =?us-ascii?Q?IHUlkDT20heR3Qlry8WCww+7/+lE6yoaoaJ2AzZtn8VZuOfGsC7kQ1ACy37c?= =?us-ascii?Q?2MpmcI3zZrXNE11HxNtIB3xYV1HG8S0NdBgI+aERrHWNvUw7IBS+FmnY0TEB?= =?us-ascii?Q?YcqV5yiZuxsUXs7pKkFxooC0BTbFZs7BtHfZCchihP6F2gEXIGMxRhXnjbA9?= =?us-ascii?Q?afeMLvt1AP9KeJci63uwdZzeqD6Gu8HwASO41AmWU3EFZl2/sIo7m736+cq9?= =?us-ascii?Q?N6/x89JPlIJ3lnOgCUokX4YixWTIbceDj3Dix45UTUa7cgXPfMjPERvdSVXx?= =?us-ascii?Q?NogtVk+1Kw2qtjOQp/BzPNIGZGwE53WqpeT69KqpF1d5jLJGmyzNMRXF2fcL?= =?us-ascii?Q?gclaudxKh8Q8qxSXF4jHLRA8TZ9XrAH/dh6P?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 14:58:46.2540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 294fe176-98a9-4b6b-f74f-08ddcf79959e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F7.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6794 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=193daed63a08e2642824f10e6a85044a756de73a Thanks. Xueming Li --- >From 193daed63a08e2642824f10e6a85044a756de73a Mon Sep 17 00:00:00 2001 From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Date: Thu, 26 Jun 2025 09:07:02 -0400 Subject: [PATCH] net/mlx5: fix crash on age query with indirect conntrack Cc: Xueming Li [ upstream commit 3bb6e3bf05284f0668e2ac14ce4b90a2909dff99 ] This patch fixes a segmentation fault that occurs when querying the AGE action of a flow rule that uses indirect connection tracking (CT). Background: AGE and CT indices share a union in the mlx5 flow struct. When using CT without age, the age index is invalid. Querying AGE in this case leads to a crash due to reading an invalid pointer. Solution: Add a check in `flow_dv_query()` to prevent AGE queries on indirect CT actions. This is the correct fix rather than null-checking the pool. Steps to reproduce: 1. Create an indirect CT action: flow indirect_action 0 create ingress action conntrack / end 2. Create a root rule with jump: flow create 0 ingress pattern eth / ipv4 / tcp / end actions jump group 3 / end 3. Create a group 3 rule using the indirect action: flow create 0 group 3 ingress pattern eth / ipv4 / tcp / end actions indirect 0 / jump group 5 / end 4. Create a group 5 rule matching CT state: flow create 0 group 5 ingress pattern eth / ipv4 / tcp / conntrack is 1 / end actions queue index 5 / end 5. Querying the first rule causes segfault: flow query 0 1 age Fixes: 2d084f69aa26 ("net/mlx5: add translation of connection tracking action") Cc: stable@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Acked-by: Dariusz Sosnowski --- .mailmap | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/.mailmap b/.mailmap index ddf58a13f4..e17823a260 100644 --- a/.mailmap +++ b/.mailmap @@ -768,6 +768,7 @@ Kevin Scott Kevin Traynor Ke Xu Ke Zhang +Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Khoa To Kiran KN Kiran Kumar K diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 5938ca0c02..3d93ab640c 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -17460,6 +17460,11 @@ flow_dv_query(struct rte_eth_dev *dev, error); break; case RTE_FLOW_ACTION_TYPE_AGE: + if (flow->indirect_type == MLX5_INDIRECT_ACTION_TYPE_CT) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "age not available"); ret = flow_dv_query_age(dev, flow, data, error); break; default: -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-07-30 22:50:03.524763775 +0800 +++ 0006-net-mlx5-fix-crash-on-age-query-with-indirect-conntr.patch 2025-07-30 22:50:02.976748902 +0800 @@ -1 +1 @@ -From 3bb6e3bf05284f0668e2ac14ce4b90a2909dff99 Mon Sep 17 00:00:00 2001 +From 193daed63a08e2642824f10e6a85044a756de73a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3bb6e3bf05284f0668e2ac14ce4b90a2909dff99 ] @@ -45 +48 @@ -index 8483d96ec5..6126f7e472 100644 +index ddf58a13f4..e17823a260 100644 @@ -48 +51 @@ -@@ -812,6 +812,7 @@ Kevin Scott +@@ -768,6 +768,7 @@ Kevin Scott @@ -55 +58 @@ - Kiran Kumar K + Kiran Kumar K @@ -57 +60 @@ -index d555a9cdcb..7b9e5018b8 100644 +index 5938ca0c02..3d93ab640c 100644 @@ -60 +63 @@ -@@ -18146,6 +18146,11 @@ flow_dv_query(struct rte_eth_dev *dev, +@@ -17460,6 +17460,11 @@ flow_dv_query(struct rte_eth_dev *dev,