From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 888E546C77 for ; Sat, 2 Aug 2025 00:55:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D8544028F; Sat, 2 Aug 2025 00:55:56 +0200 (CEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id C8D4840298 for ; Sat, 2 Aug 2025 00:55:54 +0200 (CEST) Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e75668006b9so1434823276.3 for ; Fri, 01 Aug 2025 15:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1754088954; x=1754693754; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=V1+cvAz+BUAoVHy4NWc1s/YyDI+i5+RKkHsYxjgrwRI=; b=bMEjvgEmtWu9B6q10H7UYrCvVpw9gLNF5HL9unktFUQd1nOzS3JX+t9QlVjG6naadQ 0m27/UkemaqGFAcNQBoa9mvvfr+/bNYKr5RSgu/IIeaxoxf/Pl6rA5s26pvx6+uUeTk+ sVIbRujrU96Cy6E0F/N+47sNJqlFMepIJfFI/Pw/4QZF7fCHbCs9N2TK3Thf86Xwr986 bis1Sv2xZLGdRBMKqZh7yqZyFJK/Z9U8mL5c3HnpljvCpXtmAE94ZFXwSNy+x6r/OlHa pVPNsZFYs8dUbOaE5z21wbD1vBOyAWT1/ohFZuG4TUm9nJYXJIqlVFArwVLqc28Fdsii v42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754088954; x=1754693754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V1+cvAz+BUAoVHy4NWc1s/YyDI+i5+RKkHsYxjgrwRI=; b=BIVKEwmBcTIzhVcVJEA5/Dtcbgw9ClOBV3zTZZWr02mHGAGYmYcrEY4mhH4aqsXNju y91Uie/3qgu6KYOm8hIBgn+NTPBUjhKkvdbU2gyTyDRiiP02zMuBSji4iGBQKtkDytI+ Nrp5ii4zHuyXgD2mSYjoWd31BwsWgMIu+qgHljmXi7MwrTsTd1n7WikE6Jm1SUcu9VO0 8Is2U9fAqM3HuiXgI4DKVTVtc7REisLwGMWZmZZXx2CkhlJ8B3X/Q2aK0QiXpPV4deHQ PCU+RpcuKtKWlxx9AsEFKbspFyJtr/wXHTneip/R9zutUBfN8ubn33f09WSf3uXi9tOs yoOw== X-Forwarded-Encrypted: i=1; AJvYcCUhiynyq1BkYkJ1vne3jdtpL4a5huM7erDywtmyPcxnVEBZVOv1cXJzN8Dej6Oi1uFaicXUlLY=@dpdk.org X-Gm-Message-State: AOJu0YwAiozkq/OQB2i+656fYqiAqZl/TCjwHkkjXNwi986oJUIJOJgH KCpYEIC2m+WzhU8etAz5/Rivjm2eAY62zWWEdaHxL6ZD66xiHxjLmOi8T1VH16IeGsg= X-Gm-Gg: ASbGncv4O/hG8dKxkJHziwHxRtK68eFHG1WDNIMl1KNEK3DuSEN3n87XG3fOZg2eNDK hfiYCvYmFpKE6zOkWDajJ5a6QW8yJ7Z01yYZdz/VcSfQxPqnZ3yeh/9tdzpbf2FGxbbBJovY+Xj N7FduHBBZueSGJRB6JIBE9Y1PQ1ArAOHFW0TCo20bGXf774hwF8CqLGvsRyGQkDDQJKjmBN5oGz vvwcwKBS11XqJzJUWZl0HQnif4czgjLXS36H8/hsV1EuhSPFVcRwtOQBc2k808GXO8l4jim//BC ARYXV3ddIot/ReoqQNaQJqw5UVW2FYpeNFfxsy31TUGcvbML4AorkKMWaBLuNVtBbXFXBuo822U Ng0kolexe3YBOC5W+aAdDPzTvjBwmjOglLp7gcGyJlWS/MpatT0HbriNCXJEp6ARi+eyCozCslZ 4= X-Google-Smtp-Source: AGHT+IHfBy5bB0GWaxGY+0JUm31gpBcIulzS8uKz10lYpw3cwJqZ4SLtvO9gvDXV3PiBMEAFmXAvjA== X-Received: by 2002:a05:6902:4106:b0:e8d:b3b5:cb83 with SMTP id 3f1490d57ef6-e8fee1b5174mr1708213276.29.1754088954028; Fri, 01 Aug 2025 15:55:54 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e8fd38c3ccdsm1829907276.45.2025.08.01.15.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 15:55:53 -0700 (PDT) Date: Fri, 1 Aug 2025 15:55:50 -0700 From: Stephen Hemminger To: Maayan Kashani Cc: , , , "Dariusz Sosnowski" , Ori Kam , Aman Singh , Gregory Etelson Subject: Re: [PATCH] app/testpmd: fix mask in random flow item definition Message-ID: <20250801155550.41558656@hermes.local> In-Reply-To: <20250730113243.197386-1-mkashani@nvidia.com> References: <20250730113243.197386-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 30 Jul 2025 14:32:43 +0300 Maayan Kashani wrote: > A previous patch addressing an ASAN global-buffer-overflow issue > inadvertently degraded the random mask value translation. > Specifically, changing the mask from 0xffff to 0x0000ffff caused > the value to be shifted left by 16 bits, since Testpmd > defines arg::mask as a byte array. > > Independent of the ASAN fix, the random item mask specification > was invalid at the API level: random items require a 32-bit mask, > but only a 16-bit mask was being used. > > The correct mask for this use case is 0xffffffff. > This fix restores the correct random value translation > by applying the proper 32-bit mask and > addresses the original ASAN issue. > > Fixes: 9a18070e3fe4 ("app/testpmd: fix flow random item token") > Cc: stable@dpdk.org > > Signed-off-by: Maayan Kashani > Acked-by: Dariusz Sosnowski > --- > app/test-pmd/cmdline_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 83d398f8eea..38e751f3f3c 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -5591,7 +5591,7 @@ static const struct token token_list[] = { > .next = NEXT(item_random, NEXT_ENTRY(COMMON_UNSIGNED), > item_param), > .args = ARGS(ARGS_ENTRY_MASK(struct rte_flow_item_random, > - value, "\x00\x00\xff\xff")), > + value, "\xff\xff\xff\xff")), > }, > [ITEM_GRE_KEY] = { > .name = "gre_key", Applied to next-net Using initialized strings as proxy for a byte array has lead to overflow bugs and warnings on some compilers. Perhaps this might cause problems later.