From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0E2A46D01 for ; Mon, 11 Aug 2025 23:36:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AF44402E6; Mon, 11 Aug 2025 23:36:43 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id DA20D402CC for ; Mon, 11 Aug 2025 23:36:41 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3b783ea502eso3365067f8f.1 for ; Mon, 11 Aug 2025 14:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1754948201; x=1755553001; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sA/EpXKlhQzBl31sFngWbdTwJUI3gmNFarNwZwwyqls=; b=jB7sbD3k1nidbjIuqTBFVw4quAISVzUhOQZrmHequSb2tti+d7Wyjfk5z2Zut9Ki1m rIQbL/PI6wur2V6/mhnfjUbkQ+WEEOxw2nut96OM2mUf13h2Qq76VyY/v8iUj2gNEjRm A8oGnU/daSYiGbYyhVuRgSiRsO1Fd0dcWzToKWJxti6sdVzrJofVriq3f4rkPYR/J/Zj FlOQSwG+eejNIWelU9908PUDTLhFY1oTJAAgBPIDlx3V2TMPxzLaYMwD0dy7dN1TVDlc LS+9b/owgrsQkgSvv81zLJumHQUf/1g+C8YOG4giMNjApCl5iplTck1uoVDGcsJdDTeb MDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754948201; x=1755553001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sA/EpXKlhQzBl31sFngWbdTwJUI3gmNFarNwZwwyqls=; b=VC+F1DSGPZEhxsWcVvSfQSBtkdZp5pbWIZ0t/5zSo0PuX7O5ptVUuSKpwIDvGE/Lpv pkXLwViTtpcogMwh59WFBCRPJNU9NETzR+aIXYFyZpqnbsridxbe3ZnYYjFmlI2UvKCw HNmYIt789KB1S/tiAsdKy3lzAClfATfZVLUSsqtbVKXhENIAKjZdT2anvSyT1pMiMVf6 4jrvL868zj57eO8evgbbGhTjhYBlhYS364032Y0gtQGZHLz1f/paPO4WH+9+hbnQHDvX 9GvcBiu1FQCeCMKKrMwJ6iRo/oTVkElKeTiCkGlspvJOi1x3qSnPaqhf9Udg5Y8/MB7/ 3vyg== X-Forwarded-Encrypted: i=1; AJvYcCWCaB/rwwAa6h4QTENm/1OqTvdSNRQTsU0MbPhHALOScpPzYr1KJ+5mKQ9AGZFQ0tvPzeVhOU4=@dpdk.org X-Gm-Message-State: AOJu0YwpAC/UPcCQC0neqza1w8kvhxq6k0p7ckORMkOHp2wrTAIz9bAi Gfs/JEPMb58vL3UDwiF+PGY2vHJ63EGON5L4cGJYcKLRHb/aoPRe+S0Znp1yW0eC7a0= X-Gm-Gg: ASbGncupCGnl7PpATcZxFfGBkhd+ZXbbUQzR8Mt0ej1v7RyMyp0h8qY2q0LZ+n1Jf3y Nsyu+Okv5YFa6azXBrVQXPsp8WarOA/C8TB6x/7/L8eJalAYZ7sAyxgeOhWKiZOjaB4WiOCgeRf fPrEIERjYy6cTAbdsl8qXUBM3eYq6ZzOZ543mLrkKzCDbtxqfLnRXJDNfCUIBBvRfr+5+as6xCy CcJdsG++ZQAS9KBRub9QfFE523GWsLb40DsfHJG/4UHcam48nWY07rU1i43zDZtTkoAYT1tLocU vnSHy7T2oRM12nAq5JHsTH2dcmbag0830vi/zTUVNq9zi+NjxukLNcyyXnQ4Z0SqyAm22/Hi/f8 uXeIvEbOfBKc5ov9oiDALHZ4J+hvNvlL14ide2Ft8XqQu5M2UNdpf0UIl6s8EWxCL8gj6WJpt X-Google-Smtp-Source: AGHT+IGIDVoep/tNCV5Z41a9CggvI3GcYkeh30qa+NvN4oFMqT/hnapcB+2yDX6lC81DlbNsUugzxA== X-Received: by 2002:a05:6000:2507:b0:3b7:8aa2:9fcb with SMTP id ffacd0b85a97d-3b9111c5874mr778341f8f.14.1754948201468; Mon, 11 Aug 2025 14:36:41 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a053a9019sm84661445e9.21.2025.08.11.14.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 14:36:41 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Subject: [RFC 2/6] pdump: handle primary process exit Date: Mon, 11 Aug 2025 14:35:00 -0700 Message-ID: <20250811213632.16023-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250811213632.16023-1-stephen@networkplumber.org> References: <20250811213632.16023-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index fa85859703..1741d7e709 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1028,13 +1028,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.47.2