From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E094146F01 for ; Mon, 15 Sep 2025 17:43:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4FF740684; Mon, 15 Sep 2025 17:43:51 +0200 (CEST) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by mails.dpdk.org (Postfix) with ESMTP id 0FA42402E3 for ; Mon, 15 Sep 2025 17:43:49 +0200 (CEST) Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-80e2c52703bso384032885a.1 for ; Mon, 15 Sep 2025 08:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1757951029; x=1758555829; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nlKPhLKSmOR25vcXniZSM5YK0dKkNzmF22NNwJchpQQ=; b=aIp7BdeALruCQlOGHv/5+MHMS/wNQY1sqQ1P1dtb/ZBrK/QnCa7V4GiBLFark+7igx 4x9qk6eNAvxuCsUfU5U2zFe89CY1POUSc7gInEnqnmb4gWWmFXIQ5pIKrK4QRCC5BJM6 wQxhumsmMVHABrUZegVkhZ+q45KL5ahh9NMk+L8uDb5xNAPR3YsKLA0um1Mc3uPZdA1y At2jyM5Gv/Q1L9vrdmQDbMw5sK8j0SLfafyp7X8QRe9G+ET2inLpJ8n6D6NwZZF4Whmq Ot6DV1GDsnK+uhKjRAgHTQAoL0LC3k9gZYyFTlOaekkO/bkTM/TKIYKtMpiH1U1H11Y2 I0Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757951029; x=1758555829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlKPhLKSmOR25vcXniZSM5YK0dKkNzmF22NNwJchpQQ=; b=ERuRt/s/167lQiZ+FNG5m6tznTCuLTBNPeVfx5m7UH774jkXWEuePXw5susVI/RS3r v4wqmiw6pSqe6ySL01ngDT1ByuITRMBsRJA2Qs5THkFNJSzmc9UWHtLfi6Hd5s/w7TCa 07WfHOKc0OOT2gLUtWFdkfaJZVlD9KuLaBCfBw8BnOEroyixb6mR29/68uzoC6LMlOkd +pufTPXHtep/WxcsObgLU54HhivVeGOuhy+oSD3yw6/qil/cANR7VhehT0/kubQd+2LT ix3o8qVxOkXrByQJ8BOpt3Y9RvTos0BDx3VRT3yRhiwBwa3YT4uy9wW3BlZj6j7UsMl2 n9MQ== X-Forwarded-Encrypted: i=1; AJvYcCUsmamMKgb0xK7J1imySt2TibnkikHnanw1LQB6ZNtzF4PH2E5bE+WSJriz+yx0gcfVn3ddsns=@dpdk.org X-Gm-Message-State: AOJu0Yw/BamJ6t2To//uV+Bd8J3bAKVrjwOq7DdAOvAfoiJus5glMUyb RJmwGY0ukWr8PfkMwlv9rPCulEIA+JS0moW3iHw9lVlegymVL/PNTnmA/Nd5jWguS2c= X-Gm-Gg: ASbGncvjsdXNneO72J/BEOvhaS2ABX40O+g8kVBrqJjFQNyoHmyvIjNMSMx+adLzFlz Y1PEb0EM+/3B9AvGENf8ybPu7BWFWv3S35fMzHR63KxaR1/7nqTZSEGH5Fe9HZWJr3S3ij3tntU o1jdqEkxzFMLaxf/9pp9azk6eS1Ol5hLTA5+IHsh7Q2s5YbVbezPsSI0u0Vjcvf0/dzR9/OJHiB jxj8P+DNDMCGZUya3Pba4Cc5a7tIBnwGvbhXHqXsS8qqv6wntj1o++j9qIHms1L+KJxgloxgtfX epPaXFWkCu8gVZklqnTvIbW+wW6z1YWOsZ6zxdVMmZMtCqyvIr2DGe7WiUA4P9PrI9PjD1xNaaI AzLfdEYTDZocrtD1FYnIVVpk79j4XXbxpUz8dg+RWmMbJniGa2STsNwX7lrEBJ8Twf+cKv5KpOR FJ2kguVAPN4A== X-Google-Smtp-Source: AGHT+IGcbhmrzrjZQ92R7rl0Sf8qzntGt/QDgc3AzaCZzfaAR1nqQQIy7mi7tQjjiylY2ZYJCj/rww== X-Received: by 2002:a05:620a:40c8:b0:7fe:8292:187e with SMTP id af79cd13be357-82403498667mr1615023685a.60.1757951028760; Mon, 15 Sep 2025 08:43:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b639b997c4sm68467391cf.2.2025.09.15.08.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 08:43:48 -0700 (PDT) Date: Mon, 15 Sep 2025 08:43:44 -0700 From: Stephen Hemminger To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Cc: Aman Singh , Tyler Retzlaff , Anatoly Burakov , Lijun Ou , Ferruh Yigit , Xiaoyun Li , Ajit Khaparde , dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v3] app/testpmd: stop secondary process fwd_lcores during primary teardown Message-ID: <20250915084344.5c95a47e@hermes.local> In-Reply-To: <20250915112513.496136-1-14pwcse1224@uetpeshawar.edu.pk> References: <20250804113322.53650-1-14pwcse1224@uetpeshawar.edu.pk> <20250915112513.496136-1-14pwcse1224@uetpeshawar.edu.pk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 15 Sep 2025 04:25:13 -0700 Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote: > +#ifndef RTE_EXEC_ENV_WINDOWS > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > + printf("Stopping secondary process...\n"); > + struct eal_dev_mp_req req; > + memset(&req, 0, sizeof(req)); > + req.t = EAL_DEV_REQ_TYPE_STOP; > + eal_dev_hotplug_request_to_secondary(&req); > + } > +#endif > } This could be improved: 1. The structure can just be iniatialised as: struct eal_dev_mp_req req = { .t = EAL_DEV_REQ_TYPE_STOP }; 2. Check the result of sending request to secondary 3. This is really a different MP request path, please don't overload hotplug for this. Register a new type with rte_mp_action_register() 4. If done right, you should be able to drop the #ifdef around WINDOWS. For now, there will be no secondary on Windows so the request to send will just succeed as a nop. The other issue is that stopping the secondary would be faster if you used existing f_stop flag to break out of the forwarding loop.