From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B8B146EFF for ; Mon, 15 Sep 2025 12:23:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 941A740656; Mon, 15 Sep 2025 12:23:30 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id AA1CC4064F for ; Mon, 15 Sep 2025 12:23:28 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-32b863ed6b6so3333704a91.2 for ; Mon, 15 Sep 2025 03:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1757931808; x=1758536608; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zZAYaaQW6z5a37oKs6YY67/XQjP0ubG5rHOPh8ZU2B4=; b=WsPHqTHp2Gai1MvI0aT45WNJjsSUbEnZEavq1i4aGBB1PSir/7An/EioSawi8pDcFo jv/AYjcWjCt1nvtO+P0FAzaBFPCuMfcfH3Vzt1h6wgn4jlzBWYH9m43bWmzBtWk18Mxe 1qyhT+htI6xcpY1QtBxonxyFb01nbSXIFsg9qaOQB77MpoRQyqYGp57N2V7R+WvrpsIf b3wW87shcOsV1WC0FI3M2xeQyKYnn3C2Ax9AJRpFzFQFIr3tpUt2hVTNi4p+LRJ/ijdk GV2aQ/aj33eUa0RlPh4YNT/JVd6esT1sUZQMdTB3+a/hSLGGLaAP8GMAHqK21fdndBsq ULqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757931808; x=1758536608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zZAYaaQW6z5a37oKs6YY67/XQjP0ubG5rHOPh8ZU2B4=; b=f8jhgqqXzhINxeqOHosklPTCtHJmZdm8KZxFQWpT1cY9qGMVv4Kvv1F21sWN7/6ZCU mO4PuytZcEs+VMpA7t/Le7En1Nf7kUSVgQO2I0v7t7sqkcPZgxXVl9Cp6BUtzGcxo0wn dPlEf4eJsKnuM9op5PF9VYYv+LaVUSkGTAzXoYWpiNcmyXRPIdhcl09tDfsBGi3SkojI D1DPuFJmgpu4t7fF85eye4SA5vuVaKf4VI/XOd4zI6TbrBl8mFvURaF+VUHoXtlVB5TE VvvAWfm1X9PuXz/h1gnVyep8SpN6N9U4O4g2wZmxL30avZfsgvy//6U8kr1ukCOtyojH xyuw== X-Forwarded-Encrypted: i=1; AJvYcCWYmPYgskL4GJoAN7V5k2GTpZZxhCSCUfAyro8fVSynJi9jISY9wS5zh/l51+RXC1156SwSjOM=@dpdk.org X-Gm-Message-State: AOJu0YwJUTX1jxbAeR5BUR0Y7AuUodHuqmK4SLqEVJoMDyzOyCWKifaL AkOQ/t14sTSVuuGj/9d5RknhQZw1YQwAJl2mHmpN6kQfcmIbZsAA+/3/pJOy8xNC6Ws= X-Gm-Gg: ASbGncvkKu/aRNxgxLZMrmNNBsp7MizWztgL3zxhuXTrsh35r1yeGivqPPizolxQZNT mkyu+Ag8nOW2ddiaTO7ivQ7V9sJi1fFGFdbupkBYj6uVK0bH8Ss7jAgYtoy1kF8qmzMAqXqFdsL ajZCcchgQ0pDd0Oalw+ZqhHLSYZlz9CBpvbJUWlgh4jOI8zNCclsqp0QXimy+vIv08gjzl7Nnti dG/Un1LMtq2H0aumbBHkIVX1ujJoVMf0Eve5MU6rx9g+ebJ4Turk1nEg5MyBEwt1yCIXMXUxgsp E+02lzbR9uj0UWR2a2Ge92VQaYk3hfZ1ZZmhqAct0vKqP6OMoww89Dz7kOyrPGpbX1t/VLY2a4R Blos4zqlqip3Lys0vR55pIOev/wDjbf26MUeAuigfV9SfCWuCquVa8MjTXEPZ5g2OUcEyDG9LCG UvK6jvLEEd90jzmpOmXssfRqh872HxfKvRaAV4wEq3mIQeWAm0muw+8SZ9Sm+i3n1MDVt78/ADE t+aYCwQA3nYWCJmHRKA70rkPkznLEqkterO8yQjNMdQ X-Google-Smtp-Source: AGHT+IGWk4elazYppLWTMZ/6lteIjg0A6PJqUHRo4jhtrQ4fHzbhnhiVqv1bnzFD9v5V8He4XfC/EQ== X-Received: by 2002:a17:90b:4cc9:b0:32e:59ef:f403 with SMTP id 98e67ed59e1d1-32e59f01354mr4272996a91.17.1757931807662; Mon, 15 Sep 2025 03:23:27 -0700 (PDT) Received: from localhost.localdomain (108-92-19-205.lightspeed.sntcca.sbcglobal.net. [108.92.19.205]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32df14d224asm9908190a91.5.2025.09.15.03.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 03:23:27 -0700 (PDT) From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> To: Aman Singh , Tyler Retzlaff , Anatoly Burakov , Andrew Rybchenko , Xiaoyun Li , Ajit Khaparde , Lijun Ou Cc: dev@dpdk.org, Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, stable@dpdk.org, Stephen Hemminger Subject: [PATCH v3] app/testpmd: stop secondary process fwd_lcores during primary teardown Date: Mon, 15 Sep 2025 03:23:12 -0700 Message-Id: <20250915102312.495221-1-14pwcse1224@uetpeshawar.edu.pk> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20250804113322.53650-1-14pwcse1224@uetpeshawar.edu.pk> References: <20250804113322.53650-1-14pwcse1224@uetpeshawar.edu.pk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When the secondary process testpmd application running any fwd_engine and after that primary has exited will cause a crash. This patch forces secondary process forwarding lcores in fwd_engine to stop before the primary process exits. Fixes: a550baf24af90f ("app/testpmd: support multi-process") Cc: stable@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Signed-off-by: Stephen Hemminger --- app/test-pmd/testpmd.c | 25 ++++++++++++++++++++++--- lib/eal/common/hotplug_mp.c | 4 ++++ lib/eal/common/hotplug_mp.h | 2 ++ 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 0f58a31eb5..f385bf920d 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -11,6 +11,7 @@ #include #ifndef RTE_EXEC_ENV_WINDOWS #include +#include "hotplug_mp.h" #endif #include #include @@ -103,7 +104,7 @@ uint16_t verbose_level = 0; /**< Silent by default. */ int testpmd_logtype; /**< Log type for testpmd logs */ /* Maximum delay for exiting after primary process. */ -#define MONITOR_INTERVAL (500 * 1000) +#define MONITOR_INTERVAL (500) /* use main core for command line ? */ uint8_t interactive = 0; @@ -2563,7 +2564,12 @@ stop_packet_forwarding(void) for (lc_id = 0; lc_id < cur_fwd_config.nb_fwd_lcores; lc_id++) fwd_lcores[lc_id]->stopped = 1; printf("\nWaiting for lcores to finish...\n"); - rte_eal_mp_wait_lcore(); +#ifndef RTE_EXEC_ENV_WINDOWS + if (rte_eal_process_type() == RTE_PROC_PRIMARY) + rte_eal_mp_wait_lcore(); +#else + rte_eal_mp_wait_lcore(); +#endif port_fwd_end = cur_fwd_config.fwd_eng->port_fwd_end; if (port_fwd_end != NULL) { for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) { @@ -3634,6 +3640,13 @@ pmd_test_exit(void) printf("\nStopping port %d...\n", pt_id); fflush(stdout); stop_port(pt_id); +#ifndef RTE_EXEC_ENV_WINDOWS + printf("Stopping secondary process...\n"); + struct eal_dev_mp_req req; + memset(&req, 0, sizeof(req)); + req.t = EAL_DEV_REQ_TYPE_STOP; + eal_dev_hotplug_request_to_secondary(&req); +#endif } RTE_ETH_FOREACH_DEV(pt_id) { printf("\nShutting down port %d...\n", pt_id); @@ -4371,7 +4384,13 @@ static void monitor_primary(void *arg __rte_unused) { if (rte_eal_primary_proc_alive(NULL)) { - rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, NULL); + if (f_exit_sec) { + stop_packet_forwarding(); + fprintf(stderr, "\nPrimary process is no longer active, exiting...\n"); + exit(EXIT_FAILURE); + } else { + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, NULL); + } } else { /* * If primary process exits, then all the device information diff --git a/lib/eal/common/hotplug_mp.c b/lib/eal/common/hotplug_mp.c index 17089ca3db..d1913c50db 100644 --- a/lib/eal/common/hotplug_mp.c +++ b/lib/eal/common/hotplug_mp.c @@ -15,6 +15,7 @@ #include "eal_private.h" #define MP_TIMEOUT_S 5 /**< 5 seconds timeouts */ +uint8_t f_exit_sec; struct mp_reply_bundle { struct rte_mp_msg msg; @@ -239,6 +240,9 @@ static void __handle_primary_request(void *param) memset(&mp_resp, 0, sizeof(mp_resp)); switch (req->t) { + case EAL_DEV_REQ_TYPE_STOP: + f_exit_sec = 1; + break; case EAL_DEV_REQ_TYPE_ATTACH: case EAL_DEV_REQ_TYPE_DETACH_ROLLBACK: ret = local_dev_probe(req->devargs, &dev); diff --git a/lib/eal/common/hotplug_mp.h b/lib/eal/common/hotplug_mp.h index 7221284286..a33e3cbcc5 100644 --- a/lib/eal/common/hotplug_mp.h +++ b/lib/eal/common/hotplug_mp.h @@ -9,6 +9,7 @@ #define EAL_DEV_MP_ACTION_REQUEST "eal_dev_mp_request" #define EAL_DEV_MP_ACTION_RESPONSE "eal_dev_mp_response" +extern uint8_t f_exit_sec; #define EAL_DEV_MP_DEV_NAME_MAX_LEN RTE_DEV_NAME_MAX_LEN #define EAL_DEV_MP_BUS_NAME_MAX_LEN 32 @@ -19,6 +20,7 @@ enum eal_dev_req_type { EAL_DEV_REQ_TYPE_DETACH, EAL_DEV_REQ_TYPE_ATTACH_ROLLBACK, EAL_DEV_REQ_TYPE_DETACH_ROLLBACK, + EAL_DEV_REQ_TYPE_STOP, }; struct eal_dev_mp_req { -- 2.27.0