From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDD1346F29 for ; Thu, 18 Sep 2025 09:32:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B73774027A; Thu, 18 Sep 2025 09:32:07 +0200 (CEST) Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) by mails.dpdk.org (Postfix) with ESMTP id A85B54027A; Thu, 18 Sep 2025 09:32:06 +0200 (CEST) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 43B101400234; Thu, 18 Sep 2025 03:32:06 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Thu, 18 Sep 2025 03:32:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1758180726; x= 1758267126; bh=51fguQeFqArwy85wukflxmiVYLUMFSobjee5Kjxb720=; b=Z mnYqeqKq06C2gkH6oZtKnJoIf4XHohOywuaFpkCnlcSqpRcjYMXGFTPvdoReDRbm pcwxm4jyMYxcOMP311KhzXbCt8/c2xwWtGNHXOhX1OgP2740+Xnx1BsI8tO9sLds vf6ZA33RGubwbtoBq+2Ro9Mbtie1/bepcXUVbjTKRecgbjcq/VeZHiDGO4jYS03/ MgngUm3/tggNZIvwGgNb60vzsNNZmvep1/xpXNPRsgqJKMroC8c1KboGlfu88evq CAgJMAa8Ash9xWRYjsvgcPLUWQ3M7yrftgbKYoAfxgyLYK7ZYC9KV2c5QN7eNDl8 43jirpCHIg0gvpwOO1neA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1758180726; x=1758267126; bh=5 1fguQeFqArwy85wukflxmiVYLUMFSobjee5Kjxb720=; b=WniJxmdm9eFbrz3DK 0RKfS7WWtngXYENnoeVRUpt00v4piW0v6dHUuVQ04kU8rjIbCWuS8oKwXL5AG+qp vyu3rsBVsxpkCAGBrQizjWCoyTh07vWfvM+/wNCaWffD4vEE/WrCTNbEcrCm61hc n6ZH/TGd2Bv4o1paap/fvKeSr9N1Qu7ti6QTU0mNP6jV4g7k0rmVHpIE3qmeRig5 N6aTFn16/iUSs46sbosAivuhnDxfW4ZH19Z2oUtzyWIEhq9xsyxjgGGwmybhXFZK hA/XDb9wHs06TNp33cJwqtiuz8K7mGfR6tnSWPklbqJNmudstoq9NAjdToCv5DWK OiKGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdegheejfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveekhefh ieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepledpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpth htohepsghruhgtvgdrrhhitghhrghrughsohhnsehinhhtvghlrdgtohhmpdhrtghpthht ohepshhtrggslhgvseguphgukhdrohhrghdprhgtphhtthhopegshihrohhnrdhmrghroh hhnhesihhnthgvlhdrtghomhdprhgtphhtthhopeihihhpvghnghdurdifrghnghesihhn thgvlhdrtghomhdprhgtphhtthhopehkvghithhhrdifihhlvghssehinhhtvghlrdgtoh hmpdhrtghpthhtoheplhhutggrrdgsohgttggrshhsihesmhhitghrohhsohhfthdrtgho mhdprhgtphhtthhopehhrghrrhihrdhvrghnrdhhrggrrhgvnhesihhnthgvlhdrtghomh dprhgtphhtthhopehsvggrnhdrmhhorhhrihhsshgvhiesihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 Sep 2025 03:32:04 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, stable@dpdk.org, Byron Marohn , Yipeng Wang , Keith Wiles , Luca Boccassi , Harry van Haaren , Sean Morrissey Subject: [PATCH 1/3] efd: fix AVX2 support Date: Thu, 18 Sep 2025 09:28:03 +0200 Message-ID: <20250918073135.1273767-2-thomas@monjalon.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250918073135.1273767-1-thomas@monjalon.net> References: <20250918073135.1273767-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When switching to Meson build, the compilation check on CC_SUPPORT_AVX2 became obsolete, thus the case EFD_LOOKUP_AVX2 became dead. The function efd_lookup_internal_avx2() was never called, and its header include rte_efd_x86.h has been removed later. AVX2 is assumed to be always supported on x86 with supported compilers, so the checks for AVX2 are simply removed, and the include is added back. Fixes: 5b9656b157d3 ("lib: build with meson") Fixes: 30a1de105a5f ("lib: remove unneeded header includes") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- lib/efd/rte_efd.c | 3 ++- lib/efd/rte_efd_x86.h | 10 ---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index b0e44e5c51..ebf1e0655f 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.c @@ -26,6 +26,7 @@ #include "rte_efd.h" #if defined(RTE_ARCH_X86) +#include "rte_efd_x86.h" #elif defined(RTE_ARCH_ARM64) #include "rte_efd_arm64.h" #endif @@ -1279,7 +1280,7 @@ efd_lookup_internal(const struct efd_online_group_entry * const group, switch (lookup_fn) { -#if defined(RTE_ARCH_X86) && defined(CC_SUPPORT_AVX2) +#if defined(RTE_ARCH_X86) case EFD_LOOKUP_AVX2: return efd_lookup_internal_avx2(group->hash_idx, group->lookup_table, diff --git a/lib/efd/rte_efd_x86.h b/lib/efd/rte_efd_x86.h index e2f9dcca88..f7776db8a5 100644 --- a/lib/efd/rte_efd_x86.h +++ b/lib/efd/rte_efd_x86.h @@ -19,7 +19,6 @@ efd_lookup_internal_avx2(const efd_hashfunc_t *group_hash_idx, const efd_lookuptbl_t *group_lookup_table, const uint32_t hash_val_a, const uint32_t hash_val_b) { -#ifdef __AVX2__ efd_value_t value = 0; uint32_t i = 0; __m256i vhash_val_a = _mm256_set1_epi32(hash_val_a); @@ -45,13 +44,4 @@ efd_lookup_internal_avx2(const efd_hashfunc_t *group_hash_idx, } return value; -#else - RTE_SET_USED(group_hash_idx); - RTE_SET_USED(group_lookup_table); - RTE_SET_USED(hash_val_a); - RTE_SET_USED(hash_val_b); - /* Return dummy value, only to avoid compilation breakage */ - return 0; -#endif - } -- 2.51.0