patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>
Cc: Aman Singh <aman.deep.singh@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Lijun Ou <oulijun@huawei.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v5] app/testpmd: stop secondary process fwd_lcores during primary teardown
Date: Thu, 18 Sep 2025 08:08:31 -0700	[thread overview]
Message-ID: <20250918080831.1057b4a4@hermes.local> (raw)
In-Reply-To: <20250918064703.528973-1-14pwcse1224@uetpeshawar.edu.pk>

On Wed, 17 Sep 2025 23:47:03 -0700
Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> wrote:

> @@ -3628,6 +3709,7 @@ pmd_test_exit(void)
>  		}
>  	}
>  #endif
> +
>  	if (ports != NULL) {
>  		no_link_check = 1;
>  		RTE_ETH_FOREACH_DEV(pt_id) {

I will drop that extra newline... Sorry

> +
> +static int
> +handle_testpmd_request(const struct rte_mp_msg *request, const void *peer)
> +{
> +	const struct testpmd_mp_req *req = (const struct testpmd_mp_req *)request->param;
> +
> +	if (req->t == TESTPMD_REQ_TYPE_EXIT) {
> +		printf("\nReceived notification of primary exiting\n");
> +		fflush(stdout);
> +
> +		/* Response is sent after forwarding loop exits */
> +		rte_atomic_store_explicit(&primary_name, peer, rte_memory_order_relaxed);
> +
> +		kill(getpid(), SIGINT);

Needed to use kill() here to force end of read when testpmd is in interactive mode.
Only other option would be closing stdin, but that seemed less safe.

  reply	other threads:[~2025-09-18 15:08 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 11:54 [PATCH] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Khadem Ullah
2025-07-22 13:39 ` Stephen Hemminger
2025-07-22 14:30   ` Khadem Ullah
2025-07-22 15:42     ` Stephen Hemminger
2025-07-22 16:01       ` Khadem Ullah
2025-07-22 16:13         ` Bruce Richardson
2025-07-22 17:04           ` Khadem Ullah
2025-07-22 17:38             ` Stephen Hemminger
2025-07-22 17:53               ` Khadem Ullah
2025-07-22 18:21                 ` Stephen Hemminger
2025-07-22 19:03                   ` Khadem Ullah
2025-07-22 19:05                   ` Ivan Malov
2025-07-22 22:28                     ` Stephen Hemminger
2025-07-23  4:29 ` Khadem Ullah
2025-07-23  4:50 ` [PATCH v2] " Khadem Ullah
2025-07-23 12:19   ` Khadem Ullah
2025-07-23 13:13     ` Khadem Ullah
2025-07-23 13:24       ` Ivan Malov
2025-07-23 13:26         ` Khadem Ullah
2025-07-23 13:31           ` Ivan Malov
2025-07-23 13:10   ` [PATCH] [PATCH v3] " Khadem Ullah
2025-07-23 13:19     ` Ivan Malov
2025-07-23 13:34       ` Khadem Ullah
2025-07-23 14:22         ` Stephen Hemminger
2025-07-24  5:49           ` Khadem Ullah
2025-07-25 13:00           ` Khadem Ullah
2025-07-25 12:55     ` [PATCH] [PATCH v4] " Khadem Ullah
2025-07-28 21:45       ` Stephen Hemminger
2025-07-29  5:42         ` Khadem Ullah
2025-07-29 21:34           ` Stephen Hemminger
2025-07-30  5:07             ` Khadem Ullah
2025-08-08  3:49               ` Varghese, Vipin
2025-08-08 15:32                 ` Stephen Hemminger
2025-08-11 10:19                   ` Varghese, Vipin
2025-08-11 10:28                     ` Khadem Ullah
2025-08-11 10:39                       ` Varghese, Vipin
2025-07-29  6:39       ` [PATCH] app/testpmd: fix segfault in secondary process by monitoring primary Khadem Ullah
2025-07-29  6:39         ` [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Khadem Ullah
2025-07-29  6:39         ` [PATCH] [PATCH v5] app/testpmd: fix segfault in secondary process by monitoring primary Khadem Ullah
2025-07-29 14:48           ` Stephen Hemminger
2025-07-29 21:48           ` Stephen Hemminger
2025-07-30  5:24             ` Khadem Ullah
2025-08-08  3:44               ` Varghese, Vipin
2025-08-08 16:17                 ` Stephen Hemminger
2025-08-11 10:23                   ` Varghese, Vipin
2025-08-11 10:27                     ` Khadem Ullah
2025-07-30  5:56           ` [PATCH] app/testpmd: monitor state of primary process when using secondary Khadem Ullah
2025-07-30  6:08           ` [PATCH v6] " Khadem Ullah
2025-08-01 22:50             ` Stephen Hemminger
2025-08-04  7:54           ` [PATCH v7] " Khadem Ullah
2025-08-04 11:33           ` Khadem Ullah
2025-08-04 15:44             ` Stephen Hemminger
2025-08-05  0:50             ` fengchengwen
2025-08-08  3:23             ` Varghese, Vipin
2025-08-08 16:10               ` Stephen Hemminger
2025-09-15  8:10             ` [PATCH v3] app/testpmd: stop secondary process fwd_lcores during primary teardown Khadem Ullah
2025-09-15  9:29             ` Khadem Ullah
2025-09-15 10:23             ` Khadem Ullah
2025-09-15 11:25             ` Khadem Ullah
2025-09-15 15:43               ` Stephen Hemminger
2025-09-17 11:36               ` [PATCH v4] " Khadem Ullah
2025-09-17 20:54                 ` Stephen Hemminger
2025-09-18  6:47                 ` [PATCH v5] " Khadem Ullah
2025-09-18 15:08                   ` Stephen Hemminger [this message]
2025-09-18 16:45                   ` Stephen Hemminger
2025-07-23 14:21   ` [PATCH v2] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250918080831.1057b4a4@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=14pwcse1224@uetpeshawar.edu.pk \
    --cc=ajit.khaparde@broadcom.com \
    --cc=aman.deep.singh@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=oulijun@huawei.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).