* [PATCH] examples/ip_reassembly: remove conflicting Tx offload
@ 2025-09-19 7:12 Zhichao Zeng
2025-09-19 7:13 ` Konstantin Ananyev
0 siblings, 1 reply; 2+ messages in thread
From: Zhichao Zeng @ 2025-09-19 7:12 UTC (permalink / raw)
To: dev; +Cc: stable, Zhichao Zeng, Konstantin Ananyev, Ferruh Yigit, Shahaf Shuler
IP packet reassembly requires the MULTI_SEGS offload to be enabled in order
to handle fragmented packets across multiple memory segments. However, the
MBUF_FAST_FREE offload conflicts with MULTI_SEGS and cannot be enabled
simultaneously.
Remove the MBUF_FAST_FREE offload to avoid conflicts with MULTI_SEGS.
Fixes: 9df56e69ee3f ("examples/ip_reassembly: convert to new ethdev offloads API")
Cc: stable@dpdk.org
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
examples/ip_reassembly/main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
index 17ae76d4ba..294fd38889 100644
--- a/examples/ip_reassembly/main.c
+++ b/examples/ip_reassembly/main.c
@@ -1093,9 +1093,6 @@ main(int argc, char **argv)
n_tx_queue = nb_lcores;
if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
n_tx_queue = MAX_TX_QUEUE_PER_PORT;
- if (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)
- local_port_conf.txmode.offloads |=
- RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
dev_info.flow_type_rss_offloads;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] examples/ip_reassembly: remove conflicting Tx offload
2025-09-19 7:12 [PATCH] examples/ip_reassembly: remove conflicting Tx offload Zhichao Zeng
@ 2025-09-19 7:13 ` Konstantin Ananyev
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Ananyev @ 2025-09-19 7:13 UTC (permalink / raw)
To: Zhichao Zeng, dev; +Cc: stable, Ferruh Yigit, Shahaf Shuler
>
> IP packet reassembly requires the MULTI_SEGS offload to be enabled in order
> to handle fragmented packets across multiple memory segments. However, the
> MBUF_FAST_FREE offload conflicts with MULTI_SEGS and cannot be enabled
> simultaneously.
>
> Remove the MBUF_FAST_FREE offload to avoid conflicts with MULTI_SEGS.
>
> Fixes: 9df56e69ee3f ("examples/ip_reassembly: convert to new ethdev offloads
> API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> ---
> examples/ip_reassembly/main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
> index 17ae76d4ba..294fd38889 100644
> --- a/examples/ip_reassembly/main.c
> +++ b/examples/ip_reassembly/main.c
> @@ -1093,9 +1093,6 @@ main(int argc, char **argv)
> n_tx_queue = nb_lcores;
> if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
> n_tx_queue = MAX_TX_QUEUE_PER_PORT;
> - if (dev_info.tx_offload_capa &
> RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)
> - local_port_conf.txmode.offloads |=
> - RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
>
> local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
> dev_info.flow_type_rss_offloads;
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-19 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-19 7:12 [PATCH] examples/ip_reassembly: remove conflicting Tx offload Zhichao Zeng
2025-09-19 7:13 ` Konstantin Ananyev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).