* [PATCH v3 5/5] net/dpaa: fix resource leak coverity issue [not found] ` <20251014101716.2885563-1-g.singh@nxp.com> @ 2025-10-14 10:17 ` Gagandeep Singh [not found] ` <20251017044256.3264737-1-g.singh@nxp.com> 1 sibling, 0 replies; 4+ messages in thread From: Gagandeep Singh @ 2025-10-14 10:17 UTC (permalink / raw) To: dev, Hemant Agrawal, Sachin Saxena; +Cc: Vanshika Shukla, stable From: Vanshika Shukla <vanshika.shukla@nxp.com> Fix CID:362787 issue. This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks. Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Cc: sachin.saxena@nxp.com Cc: stable@dpdk.org Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com> --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 2a22b23c8f..417b9b6fbb 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021-2024 NXP + * Copyright 2017-2019,2021-2025 NXP */ /* System headers */ @@ -889,9 +889,9 @@ int dpaa_fm_init(void) /* FM PCD Enable */ ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20251017044256.3264737-1-g.singh@nxp.com>]
* [PATCH v4 6/6] net/dpaa: fix resource leak coverity issue [not found] ` <20251017044256.3264737-1-g.singh@nxp.com> @ 2025-10-17 4:42 ` Gagandeep Singh [not found] ` <20251017044848.3269627-1-g.singh@nxp.com> 1 sibling, 0 replies; 4+ messages in thread From: Gagandeep Singh @ 2025-10-17 4:42 UTC (permalink / raw) To: dev, Hemant Agrawal, Sachin Saxena; +Cc: Vanshika Shukla, stable From: Vanshika Shukla <vanshika.shukla@nxp.com> Fix CID:362787 issue. This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks. Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Cc: sachin.saxena@nxp.com Cc: stable@dpdk.org Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com> --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 2a22b23c8f..417b9b6fbb 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021-2024 NXP + * Copyright 2017-2019,2021-2025 NXP */ /* System headers */ @@ -889,9 +889,9 @@ int dpaa_fm_init(void) /* FM PCD Enable */ ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20251017044848.3269627-1-g.singh@nxp.com>]
* [PATCH v5 6/6] net/dpaa: fix resource leak coverity issue [not found] ` <20251017044848.3269627-1-g.singh@nxp.com> @ 2025-10-17 4:48 ` Gagandeep Singh 2025-10-18 1:53 ` Stephen Hemminger 0 siblings, 1 reply; 4+ messages in thread From: Gagandeep Singh @ 2025-10-17 4:48 UTC (permalink / raw) To: dev, Hemant Agrawal, Sachin Saxena; +Cc: Vanshika Shukla, stable From: Vanshika Shukla <vanshika.shukla@nxp.com> Fix CID:362787 issue. This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks. Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Cc: sachin.saxena@nxp.com Cc: stable@dpdk.org Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com> --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 2a22b23c8f..417b9b6fbb 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021-2024 NXP + * Copyright 2017-2019,2021-2025 NXP */ /* System headers */ @@ -889,9 +889,9 @@ int dpaa_fm_init(void) /* FM PCD Enable */ ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 6/6] net/dpaa: fix resource leak coverity issue 2025-10-17 4:48 ` [PATCH v5 " Gagandeep Singh @ 2025-10-18 1:53 ` Stephen Hemminger 0 siblings, 0 replies; 4+ messages in thread From: Stephen Hemminger @ 2025-10-18 1:53 UTC (permalink / raw) To: Gagandeep Singh Cc: dev, Hemant Agrawal, Sachin Saxena, Vanshika Shukla, stable On Fri, 17 Oct 2025 10:18:48 +0530 Gagandeep Singh <g.singh@nxp.com> wrote: > From: Vanshika Shukla <vanshika.shukla@nxp.com> > > Fix CID:362787 issue. This patch correct the cleanup > order of PCD and FMan handles to prevent resource leaks. > > Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") > Cc: sachin.saxena@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com> Patches that fix Coverity issues should use standard tag. Coverity ID: 362787 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-17 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20251008043519.2461707-1-g.singh@nxp.com>
[not found] ` <20251014101716.2885563-1-g.singh@nxp.com>
2025-10-14 10:17 ` [PATCH v3 5/5] net/dpaa: fix resource leak coverity issue Gagandeep Singh
[not found] ` <20251017044256.3264737-1-g.singh@nxp.com>
2025-10-17 4:42 ` [PATCH v4 6/6] " Gagandeep Singh
[not found] ` <20251017044848.3269627-1-g.singh@nxp.com>
2025-10-17 4:48 ` [PATCH v5 " Gagandeep Singh
2025-10-18 1:53 ` Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).