From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63A8F4897F for ; Sun, 19 Oct 2025 18:57:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F59C427E8; Sun, 19 Oct 2025 18:57:37 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id E9EAB4013F for ; Sun, 19 Oct 2025 18:57:33 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-27ee41e0798so57515495ad.1 for ; Sun, 19 Oct 2025 09:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1760893053; x=1761497853; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=40lnV69UwbIVxryHObxRQHARRLz50lT+fAtg323Hyng=; b=C3wIx6IBhr7JPMIp5A0COI6yZ0jv39EYdiPWeexE1VAZ/5m41xi+lRp6Hw9B8syMQf DkqmTaFVqM6DrPxCbIcIeC4KF/jhm23s1kcXdzPlN8yXeivQsw2rRtLSn2uMvHDbJwa3 s2deDC3HjaB045b3Xt8K4WjL9vmzXl2y09RWH6BhMREynrt8wR5/1g9x4WUnSEnlA06j Gr/fb/QUDxP+lV6I6JYoJTvdupPyfccUoufI2bD0UI2Mn7Ad0hbUmHdzZt0GtOZQsC7H +5uc1WP/54kZJHK0M0lq8UiQS6+O3xw2ssBCh7fYZVsge66DaiLH7kFEn7jEDR4p4oBu ya4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760893053; x=1761497853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=40lnV69UwbIVxryHObxRQHARRLz50lT+fAtg323Hyng=; b=csEdLtpZbjwhnzfIgTxKq6AOtZZcPwIGw8Y3Qjz4c2Uikale3ISScHFqUnq9Gewj1v QipTIH3EejQXR9vB4YD37Q3yoy96mc4rmkbRkN3DUEAge2TO7vVKzPzJwEtOJ1zK9zOt 3dmg8ZdZ7DC6NWPyqXJg6/lrNdF3S5Z1jwc4vHr1XF1SCen+OjWsYT0sB3zoJ3c1+3ho kfPTh+v9HdHXVOMYCuqRmwuA+kOCGDhj+ke34wsL6xfVVczIVGojKk80x4QqtZ7s/0Fa 0ad3p0e/jdsH5ndwQPIr0LJZA/VnRe4KS6pOtpJy9n2F4kV+wajdgPAf6dUCKJzwZZO2 Py7Q== X-Forwarded-Encrypted: i=1; AJvYcCWlKq8HvopzjbkxMJ8Lvif3u2YLpDHKTBERQlJY8AQsz9bRnRwNsZyGay6uY01SocEWdMiWJ8E=@dpdk.org X-Gm-Message-State: AOJu0YzCWGUjUw7Wse1tDRjwi3+/PbOUXwM7oRFzodVo4J4cph4sQ7P5 s8wPF65oabLLv7TrsB2ErE4ybJ2Be2xD8SgrSeqsdsKD4dS7utf6Tm7i3qxGjM7tK9Y= X-Gm-Gg: ASbGnctZbOU01jF9BD48HijPmVXRVBgGsp6X5tnXcyqqnBQy1o34eNFVeh4hzR5sOyU eQZnoXKqnz16A72QsJoApXLeLEBeYEMdmxJf+5TUAHEFyAALCiBzAO5wqlYeugUwlLCfIpLiGcF LM2r+tNAAaNnA2DV0ALfVSDzjp+iuzYoSNgpHYHlZptryDS/UTJS4WAtiZV+i31MOq6cFHEzKxI jUM9dkptvZaVgm1gGH7F+LQtXp1GjNQCWxDNKvYHgNSD64YHv81ckcfaS7Q8llUHuvi0nLXZs2k 921W6V0kR072UjkSpk6c69g2gWjr2R0EsIvSVmRySPVBut/5Yft9PiY5Im4hmPZ10MgBjXMY1cz 3l5DwPOfxPi6FEBX+8W4scKs5tZMkdjmDSV3HRWrB/bjRVIN9fdLShTqtJsftBzu9gmmWHtfasz h3DqIzi/hiCNMsdb5mBvYUZZ6LWcHV32ecM4eSz8k+Ys5h9UB/nw== X-Google-Smtp-Source: AGHT+IHWwRRp4X4fFPZP9L4XTHbDrJvqi/fyEzBUlVpRob5QIkw04Fvh1kpnMpDUwK7gniL0jtTSTQ== X-Received: by 2002:a17:903:2b0d:b0:272:f9c3:31f7 with SMTP id d9443c01a7336-290cbe2ae83mr122545415ad.50.1760893053116; Sun, 19 Oct 2025 09:57:33 -0700 (PDT) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2924721b6fdsm56940455ad.118.2025.10.19.09.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Oct 2025 09:57:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Reshma Pattan , Suanming Mou , Anatoly Burakov Subject: [PATCH v3 2/8] pdump: handle primary process exit Date: Sun, 19 Oct 2025 09:56:09 -0700 Message-ID: <20251019165728.164929-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251019165728.164929-1-stephen@networkplumber.org> References: <250811213632.16023-1-stephen@networkplumber.org> <20251019165728.164929-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index fa85859703..1741d7e709 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1028,13 +1028,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.51.0