From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 917A048AE3 for ; Tue, 11 Nov 2025 23:19:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86E5940662; Tue, 11 Nov 2025 23:19:07 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id D5839402EB for ; Tue, 11 Nov 2025 23:19:03 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7b0246b27b2so264254b3a.0 for ; Tue, 11 Nov 2025 14:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1762899543; x=1763504343; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MonaQP1LjuvQRMKWbmuTBsl8mIS88e1arwah1zLJjck=; b=CdufmIFo6TjyBZcoha8dtvw7qscZmUXiGOsFglLW0pbO1HBGuUGvSO9ktDokD2VyUP A1DgmE+WGr/ompBXnW+rAvMEf39rTkOnLMLLBDJ8p5Mz52aaYTgDIwRLYFBsXVxCMxuM u9xJy0gBwznQGJTxHFZo8Y46TeQdbMx3Qu5BLAZbkIC/QsUEh4rbXXsBsBv3QFMAr+AH H3VHkXyQBPVMU9f2Yd03o9mYpLi0Gad/kd9+hGMN24WxS/Xy6oUej4gjwQ+T7Ur6h9yM hfRGSI9KpOWorwASpjuRMzasXz8uBTnFuUyId0+w+7WjKOyQwraOJcSX9KYGAGDBjGAl Jwbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762899543; x=1763504343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MonaQP1LjuvQRMKWbmuTBsl8mIS88e1arwah1zLJjck=; b=beqcHeal2/LTwI9cyR0nPx628cVcxuUjtkCvqYcGK0/KiCeEjYKpIk2bvdx8TijwlB CVHjRQ6QJuf9AMd8WvoJct2udaCY0aB8a9pSxTrX8KPw6pqlkf0IW64/a4slRqkwrE2A lnoLcxMURhOiCsXZ0tFvz3oODKlRwhKp0nVim0AIq2yIEwA/ylBQ0x7bOp/fegc00VtK vHtmArEnrm6fLi4Oc3/rr+hB9tNTvs9GI33zVE+QUB3olZ4QV3TtCPfxXkrrcUQ0R/JS ZG7atYF66ZW4nuETuMbFcvueqxsZJfRqcYagJeRgCFjSC75GZB3TCsOgkkNekBZwqo7r L4ZA== X-Forwarded-Encrypted: i=1; AJvYcCX2vAp88p1tvasAEUuMJmt1MHrH38mzhvM+U48nJoevxI/NSLgRuWERNEV8TFrSMTT+hRQAxtQ=@dpdk.org X-Gm-Message-State: AOJu0YysZ7ejLKluFWm0mdidA4r7wTSsrNAnY0xiEK8WYQx4YrtGLQ33 CrFv2rsilbFIw459dHyEuCQfL+5L3GQezdDXc38JBjlB6V8QdYb7fa+DSweZo7WB7+w= X-Gm-Gg: ASbGnctTeaAB0rEby0w/WJ7BPMdsjJ/M+L6vLYkCvCgxbdPkTau9vtpWW+UJizlPg4X 7SvMm8UjdkmCRwHLWauwWgTEJAFJ2l/Kvgog6VZycbwvQ2ipGHDA7h4ptyvMpoDleifjyAG/5Lu KH456jp5dQ5iiwTwt8Io7FMIzm59z5erDZsh+6KJi5q8iEY9oG6cqwPpFSoY7zPvOaUc42QPbU7 Vw+osQtfn/21lBpdlyT3/f8vDFYX4sdOtMHJdiqI3d2IK1QuIyYWJAM0vtJKPa/dI8bOK3RzIC6 AdMkKcHNRgZzNhN2E+GvDFsKn4KD+2RJZx/1+0ACKXttCN74dILm1687l4x4p7EQChRosumLGtC GJLZWEWV0aFGfNKHBaOEMQWrVkLodfhY9lZDKdSBr2JXOt8Ijh89hx3/khX9lYj2UswVsrkHI8Q NHng+KuyucNN197Cqj55MdtYnYcvtZRNIDte6xY2M= X-Google-Smtp-Source: AGHT+IE5nRQGzklLgfqWIj+R6Y81sIz8lA7wwJom4x5Y9xkIJHvpHViK1kJJjq1HJ+v9xOr4oZ5q0Q== X-Received: by 2002:a17:90b:4f45:b0:334:cb89:bde6 with SMTP id 98e67ed59e1d1-343dddbb353mr999835a91.4.1762899542922; Tue, 11 Nov 2025 14:19:02 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343e072e5a5sm157001a91.11.2025.11.11.14.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 14:19:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , maxime.coquelin@redhat.com, stable@dpdk.org, Chenbo Xia , Adrian Moreno Subject: [PATCH v2 2/7] examples/vdpa: fix format overflow warning Date: Tue, 11 Nov 2025 14:17:19 -0800 Message-ID: <20251111221857.443752-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251111221857.443752-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251111221857.443752-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The ifname is limited to 128 characters, but it would allow up to 128 characters as prefix then could overflow creating ifname. Change to limit path prefix to 124 (128 - sizeof("1024")) to avoid possible format overflow Fixes: 38f8ab0bbc8d ("vhost: make vDPA framework bus agnostic") Cc: maxime.coquelin@redhat.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- examples/vdpa/main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c index 289db26498..7fd0e55b20 100644 --- a/examples/vdpa/main.c +++ b/examples/vdpa/main.c @@ -22,6 +22,8 @@ #define MAX_PATH_LEN 128 #define MAX_VDPA_SAMPLE_PORTS 1024 +#define stringify(x) (#x) +#define MAX_VDPA_STR_LEN sizeof(stringify(MAX_VDPA_SAMPLE_PORTS)) #define RTE_LOGTYPE_VDPA RTE_LOGTYPE_USER1 struct vdpa_port { @@ -36,7 +38,7 @@ struct vdpa_port { static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS]; -static char iface[MAX_PATH_LEN]; +static char iface[MAX_PATH_LEN - MAX_VDPA_STR_LEN]; static int devcnt; static int interactive; static int client_mode; @@ -74,9 +76,8 @@ parse_args(int argc, char **argv) break; /* long options */ case 0: - if (strncmp(long_option[idx].name, "iface", - MAX_PATH_LEN) == 0) { - rte_strscpy(iface, optarg, MAX_PATH_LEN); + if (!strcmp(long_option[idx].name, "iface")) { + rte_strscpy(iface, optarg, sizeof(iface)); printf("iface %s\n", iface); } if (!strcmp(long_option[idx].name, "interactive")) { -- 2.51.0