From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C381848AEF for ; Wed, 12 Nov 2025 17:54:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDC02402A0; Wed, 12 Nov 2025 17:54:04 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id 85BE8402A0 for ; Wed, 12 Nov 2025 17:54:03 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477775d3728so9539655e9.2 for ; Wed, 12 Nov 2025 08:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762966443; x=1763571243; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wh5wvlSF+CLSH1cu1+NMLa00HHo3JT6PSK0l/UYOr2c=; b=DGunL/dmMmuVmdDdy/5e5AAbXqKnXu9IOVrYDkZish6JsgVU1fhn6PiJ7UqBU5JHxq KLauqBb2K/VGGMFBvqeos66gh4NdxMudUInzDfez9JhrFGo9k23IUIdH4FUDZKD+Gx41 yNeAyMbADIi4JNbSQOJbwh02Jddon6e1xLMt9WIv5xshwT3OdbgrmD+Hm96AwRDdOYQX Ts2noyiBDTVyuOxsZX1sowIJWGa0xf+Vm8nlRYZ4FMHv0jcLSAj26BwalFTyNLxWsy5E 3aPWHptGxYrWvz0nXLbqpGGcfqK+nSg7ONmboKiq0XZLBmoSAzEaz1O81svHmKoqL1xb EGwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966443; x=1763571243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wh5wvlSF+CLSH1cu1+NMLa00HHo3JT6PSK0l/UYOr2c=; b=oGonf7eyBeEs9kj23DgrQBp89NSW7ckGJC4fqLiearlW6wRRcYxnA+f0BartxR2Ogh 2O628xYdts4qOA6U4RzR1ot3ay4xMVQvS0PrlzkOINSQmWe9WyiaXknzG5rA4LzqFucS mue0n5ET04lWZPNbfROBVnDv3OXf8PgvAvCm/JzliUm/XGGTA6N41KRl3KqK3Ty2FGEp Owd5y7x7POzmLaIgQaa0lB324cHc9sW0iVOpeb9Fe2QaWkh1rfMFt1IXJWzZVIkMPcXq m6f1F5XOW0ispSsgsnOxQvgfgvGaWChQrcZfdi0bNnkUnmihVXGYenMkDLmFyHVS+WgZ S9nA== X-Gm-Message-State: AOJu0Ywbwg+cIZosxVvMKu2/r/YVVxcE6jftsqnm6iFeH9WgqsPQXWPR p62UZ5mmkooFoMNeMtZ0r8REVGOH79OKpX7lR8Liy1VV1mlgZHwDZB3OJt2fvQ== X-Gm-Gg: ASbGncsuzv31wuT5aJz9+xEa1mRntjvYcJJlhdVnWCHQ498qQWgwFfpktyLZKAY8NWP GyxzVdXvV2nPXpSs8qfzL42gh2iWjyopYEQ0mChk2Njgz1r6/u6X6NkMnve3njgd0zVkz3Vq7Bm tGMllPkWfKLuGhKHG5WrHVozoTB2NnqZDDua18IV7V6fzmS22txJEuE+9ZW/ZU+s0bnWc2MtxM8 P57+4syLpaMRtVq+XSvzOUARw69gv18CLvxANOK+WUnJDmNyffL6H6NzqVNBxQdprTz9m525hWa 57NR9QcoPEDH4xKKygR2ya71M0FWDYPG2jW1bC7jLxxrTLkPGjRqtfXvQQ7gb1JooRPD8W7eJOZ OqT3P12x/k8F1HJNaHBIo9HVIfnYOAmV2dEOVR1ExG8J4OtRKsnfwESV/bzavG7RZZwMf0IrdJV q1O7r+bA== X-Google-Smtp-Source: AGHT+IF72B0LfRC36f588zfFE1PZWpTqmLZUaBG0CiuSTglRSBxqxvjsFNjV80axCkh5zQThrEAk6Q== X-Received: by 2002:a05:600c:4fc9:b0:45b:80ff:58f7 with SMTP id 5b1f17b1804b1-477870b5e1fmr30249305e9.36.1762966442060; Wed, 12 Nov 2025 08:54:02 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:a397:14bc:5982:5745]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47787e486fbsm42830465e9.5.2025.11.12.08.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 08:54:01 -0800 (PST) From: luca.boccassi@gmail.com To: Vanshika Shukla Cc: dpdk stable Subject: patch 'net/dpaa: fix resource leak' has been queued to stable release 22.11.11 Date: Wed, 12 Nov 2025 16:52:30 +0000 Message-ID: <20251112165308.1618107-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112165308.1618107-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-79-luca.boccassi@gmail.com> <20251112165308.1618107-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a97f1d45efd3e0de4e092fc6cd8e1c408d2ed92a Thanks. Luca Boccassi --- >From a97f1d45efd3e0de4e092fc6cd8e1c408d2ed92a Mon Sep 17 00:00:00 2001 From: Vanshika Shukla Date: Fri, 24 Oct 2025 11:49:06 +0530 Subject: [PATCH] net/dpaa: fix resource leak [ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks reported by coverity tool. Coverity issue: 362787 Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Signed-off-by: Vanshika Shukla --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 690ba6bcb3..4ce8e88d66 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021 NXP + * Copyright 2017-2019,2021-2025 NXP */ /* System headers */ @@ -889,9 +889,9 @@ int dpaa_fm_init(void) /* FM PCD Enable */ ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-12 16:20:41.577371001 +0000 +++ 0016-net-dpaa-fix-resource-leak.patch 2025-11-12 16:20:40.899716256 +0000 @@ -1 +1 @@ -From e7665de896836e99866ef8016bbaa12223e1cfb7 Mon Sep 17 00:00:00 2001 +From a97f1d45efd3e0de4e092fc6cd8e1c408d2ed92a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 2a22b23c8f..417b9b6fbb 100644 +index 690ba6bcb3..4ce8e88d66 100644 @@ -25 +26 @@ -- * Copyright 2017-2019,2021-2024 NXP +- * Copyright 2017-2019,2021 NXP