From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E45FC48AEF for ; Wed, 12 Nov 2025 17:54:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF0040B9B; Wed, 12 Nov 2025 17:54:04 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 98F9D40B99 for ; Wed, 12 Nov 2025 17:54:03 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-42b32ff5d10so659567f8f.1 for ; Wed, 12 Nov 2025 08:54:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762966443; x=1763571243; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SGry3vYZBg2lJUPNd5tmruLoyPV/IyYOK/5+uQhqV0M=; b=htEMFFQugov+YV3aNJyIh2yzoybgatj0Xq3X/GgZ/Id0Ude0TDNJgmdjr+4UxDMupz wazs2g3zLff7UMaPtI/Jh534ahbrMq5SkR+EHxL5ZWbVG9LoIttN53QfRyjPzhgBxVuF esahM6xjMOG24vdc41hH0bmxRgK24jwVRliOg2WHBOl2woKyCfoAcpwdNLPgWDYRXwTB F1K15waeH8NX6uNzECjCc11rVpogQcBzC+ulpo/wsmUltZzg5WX4ODZ6vV5oqAqtAYBL KHBsG2x6dph9SJpw9sahF5UwjmGNmNKaOIS9ZdOfzWEvmbSI2St5K5XxO49wHq6hkw2J e/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966443; x=1763571243; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SGry3vYZBg2lJUPNd5tmruLoyPV/IyYOK/5+uQhqV0M=; b=LtyXkMNgGPCusPFfZGqUdgfLjSaaABvEtXyFhae5akw/xCjocdjCGlV4SznszT5hL9 +5d2pCAxDOF65KfmUzQHeoScGzIM5//yZSLmLnPGpiM7sARCoEGaTdgch5zDNDi4LK32 jshuDtuTB/YzbDF0r8ssM3ddw6u3BjOxijOJbzi1Z3z4kjpQFCiI8IGZ5I18Hvfar+ci 4bxmJD43UHqq+VOcDKkfeW+R/Uo1boaCzqucWc72Cy5PgbwlnoOhFLrtQTcOrTUXvAOD ywBVwjC6alU0GheKZoiyp27WkSKtU3h+30NM/xhATc/7+5Dznx7EOPTvLoHmlHdcYNsY nkAg== X-Gm-Message-State: AOJu0YxhhiKDmEjVt9LNAa9NeR7zKPzEJ59a4P6PXrvG7BMlFci+SJA/ vKfwmEaWrTwyoxfdmyjwgeS5bmw0UF5S8RYOAomYRB2bokT9ChnsPi2oYYPsIg== X-Gm-Gg: ASbGncvuGMBL9lgONudLHVPWjHtmNfMIAAxjh/7zWOKmhCpAgRTFEi3S+lgaFIxwi0+ 0bWZjt+/WCr/iHUVTowzkN7cu2ten+pEaN44O7B9M0MxXfpOXxcwE4aeO8VSrr7QX7hPRk8Yx53 BK7sIzev8tuBsmYcVGoqpL0qaNk4efk9F1NKZ7aI0Qj3dI/BlfQ0xnodiGtTvgek3UooAzohO/C 7TV8W+BIc8R7g+h40YsLoSdclhTmsC4GsdKFRjPnHPR+CWu3Y+iikLoWLGp55V7bLMb3BTdS2E7 VASFt7NsvGuKE+oWvkAARQPcnLqnkafnNaTMWY7sG/jO2qXdhT6biPVm/uprbuVtpo36mu2Az2P ZpLKkbBSYmp5cDJ7hrnuLRVZAGkw38MJQsfRikOcUHENyEVYlmY+Ig+0KfmlU7dHBYmLRhxtV/q UmO7+4og== X-Google-Smtp-Source: AGHT+IEZ4y8V4//xEysNXJBEiu1HtH1WTPnHHggsx5cWdZUonLIboeE0cBHPGhBv5LfN+xNs1SCnpA== X-Received: by 2002:a05:6000:4006:b0:428:56ed:c68e with SMTP id ffacd0b85a97d-42b527bdb18mr117511f8f.9.1762966443097; Wed, 12 Nov 2025 08:54:03 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:a397:14bc:5982:5745]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47787e95327sm43062415e9.12.2025.11.12.08.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 08:54:02 -0800 (PST) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: reduce memory size of ring descriptors' has been queued to stable release 22.11.11 Date: Wed, 12 Nov 2025 16:52:31 +0000 Message-ID: <20251112165308.1618107-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112165308.1618107-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-79-luca.boccassi@gmail.com> <20251112165308.1618107-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2a9e0fee2c790e0be322edf404d141eec6d54251 Thanks. Luca Boccassi --- >From 2a9e0fee2c790e0be322edf404d141eec6d54251 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 27 Oct 2025 11:15:26 +0800 Subject: [PATCH] net/txgbe: reduce memory size of ring descriptors [ upstream commit 843c59d1c2cef10a75037ebc73460f2ed28f9839 ] The memory of ring descriptors was allocated in size of the maximum ring size. It seems not friendly to our hardware on some domestic platforms. Change it to allocate in size of the real ring size. Fixes: 226bf98eda87 ("net/txgbe: add Rx and Tx queues setup and release") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index 5074587e14..f2a7fcf313 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -2335,13 +2335,9 @@ txgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, if (txq == NULL) return -ENOMEM; - /* - * Allocate TX ring hardware descriptors. A memzone large enough to - * handle the maximum ring size is allocated in order to allow for - * resizing in later calls to the queue setup function. - */ + /* Allocate TX ring hardware descriptors. */ tz = rte_eth_dma_zone_reserve(dev, "tx_ring", queue_idx, - sizeof(struct txgbe_tx_desc) * TXGBE_RING_DESC_MAX, + sizeof(struct txgbe_tx_desc) * nb_desc, TXGBE_ALIGN, socket_id); if (tz == NULL) { txgbe_tx_queue_release(txq); @@ -2579,6 +2575,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t len; struct txgbe_adapter *adapter = TXGBE_DEV_ADAPTER(dev); uint64_t offloads; + uint32_t size; PMD_INIT_FUNC_TRACE(); hw = TXGBE_DEV_HW(dev); @@ -2629,13 +2626,10 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, */ rxq->pkt_type_mask = TXGBE_PTID_MASK; - /* - * Allocate RX ring hardware descriptors. A memzone large enough to - * handle the maximum ring size is allocated in order to allow for - * resizing in later calls to the queue setup function. - */ + /* Allocate RX ring hardware descriptors. */ + size = (nb_desc + RTE_PMD_TXGBE_RX_MAX_BURST) * sizeof(struct txgbe_rx_desc); rz = rte_eth_dma_zone_reserve(dev, "rx_ring", queue_idx, - RX_RING_SZ, TXGBE_ALIGN, socket_id); + size, TXGBE_ALIGN, socket_id); if (rz == NULL) { txgbe_rx_queue_release(rxq); return -ENOMEM; @@ -2645,7 +2639,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, /* * Zero init all the descriptors in the ring. */ - memset(rz->addr, 0, RX_RING_SZ); + memset(rz->addr, 0, size); /* * Modified to setup VFRDT for Virtual Function -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-12 16:20:41.608163882 +0000 +++ 0017-net-txgbe-reduce-memory-size-of-ring-descriptors.patch 2025-11-12 16:20:40.899716256 +0000 @@ -1 +1 @@ -From 843c59d1c2cef10a75037ebc73460f2ed28f9839 Mon Sep 17 00:00:00 2001 +From 2a9e0fee2c790e0be322edf404d141eec6d54251 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 843c59d1c2cef10a75037ebc73460f2ed28f9839 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index c606180741..d77db1efa2 100644 +index 5074587e14..f2a7fcf313 100644 @@ -22 +23 @@ -@@ -2521,13 +2521,9 @@ txgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, +@@ -2335,13 +2335,9 @@ txgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, @@ -38 +39 @@ -@@ -2781,6 +2777,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, +@@ -2579,6 +2575,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, @@ -46 +47 @@ -@@ -2831,13 +2828,10 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, +@@ -2629,13 +2626,10 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, @@ -63 +64 @@ -@@ -2847,7 +2841,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, +@@ -2645,7 +2639,7 @@ txgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,