From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA82F48AEF for ; Wed, 12 Nov 2025 17:54:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A569840BA6; Wed, 12 Nov 2025 17:54:41 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 4481740BA6 for ; Wed, 12 Nov 2025 17:54:40 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47778b23f64so7925195e9.0 for ; Wed, 12 Nov 2025 08:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762966480; x=1763571280; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fJDhLzbcRkQH90bs8YboI47+ntKyx1oRA7GTXhpQsmY=; b=AQCk3IeMCIp7l5EqU99a5PJgU5eZd/vjpptCtWWLGasVU6/lme9T7Ik5bsqDCZeOsO muF7Y/xNbIdO0Om5e3seJOG497kD6ypYXGJYCrfndqT4152GsA1SDi5/5YWrYL++RNsZ LEaPe0x83kRrVxzMjPp6pWg2BEXgRNThlwzSwPhINAxD1tzz7zBIj6bMSG/OxW9V+6VM tT4j5flFpNoLG0+HXHd6Z3zMDVrOwbZgKYKCkpB4PELALkg1d8s4RqWE4UD4NtICm0cu G8/3wbfRQRWBBt6DNn4vLU0EGnhezAvCUcXxb9B/k1i4crGs0QRdCwK/PsobNhTUGBJI ilww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966480; x=1763571280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fJDhLzbcRkQH90bs8YboI47+ntKyx1oRA7GTXhpQsmY=; b=NOdK9BYf0Zq+IcYHAHSjJkpHYWkmP3DoburYU5YttywojJhvW9ecUn2F1YForanlt6 AA76uNCqn4k0C0/ACBg2yYXXe9PeuKbHTkUCIH0quEZKj8F1sU6P0fRxpq78hUR+aycM zKzOOFbbrp7p1yJv1uMeaZFqX7HdAwcJpUSq/Py5tUyBRACTPuty4eUoTunDxzj4xBnb ToQTS+TWwN+3QLoGGGWVvZLC87iV1ybqz8duMoydTS1EUmcheB37vdCI1jGXikoufsq1 1e/1aersI2dtDkk2SQKl8+LhAyb8iO2OOCvwF4WwMPvlBXjLxJDTEuYStXZohEBFhxf/ bLxQ== X-Gm-Message-State: AOJu0Yz84/3uX2UdsMTpMlggrrof7PveZsGMhS/GUPDl5onjEpYEWLJE lUzm6c3jGMeu/dJ/F6NZXqV2sYL3uO6ACmStFKNDUucy8lW3a0iH/KRqDlDdYg== X-Gm-Gg: ASbGncuZiK/deIv4rOgdkLIOBm/sQAxjMUy+KxadgSVGaxkkFm028eM6C9Gp4KW1ab+ CIun0R8FKXlW/+xSijxmIvy+ZDEAIMZ/XyF56mHtgl+JynQx8Dl0u9ZbsrUygrCGyxINeuBB5Ql kim+mAasXlFnh7cuo3kwASMytLZv59IqcebJrUVrzgt71Vf39kybEx8KhHMi3Wb/hmltlS17pAR QDc6BFOkmNa+JP9nAmA6OmHaxwmDsaHoUV+4Ztr7+jZAPz7o6IgPzVloYxRaUF8pbyjSWJoQBo3 D/miM052+YXlG17IZGiUKYDppH0aBc9FPPfnBkVBCl9jRc+FZD+e+hHJG896OwpqOe2OmMfUvn8 IdPLe39hi3BeFxtbQ6bxY3qmOdpqHSsDvlPgREgCKImSazEbjY8bDRfA+5dVOwxZVY9zO3YUHap 5cNxFaRXJ57/kOy4rG X-Google-Smtp-Source: AGHT+IF17/ruymAJBL9XaAe7UDRhVobOVSV4uii2VPlySbvEjebif84btuZUOfolp+kpp/bCD8VmvA== X-Received: by 2002:a05:600c:450d:b0:46e:2cfe:971c with SMTP id 5b1f17b1804b1-47787001e9dmr28671815e9.0.1762966479491; Wed, 12 Nov 2025 08:54:39 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:a397:14bc:5982:5745]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42b2c6d3f67sm28826421f8f.37.2025.11.12.08.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 08:54:38 -0800 (PST) From: luca.boccassi@gmail.com To: Shani Peretz Cc: dpdk stable Subject: patch 'net/bonding: fix MAC address propagation in 802.3ad mode' has been queued to stable release 22.11.11 Date: Wed, 12 Nov 2025 16:52:44 +0000 Message-ID: <20251112165308.1618107-30-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112165308.1618107-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-79-luca.boccassi@gmail.com> <20251112165308.1618107-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/171bfa4f2e8f727a334a54a76386f809a2b97955 Thanks. Luca Boccassi --- >From 171bfa4f2e8f727a334a54a76386f809a2b97955 Mon Sep 17 00:00:00 2001 From: Shani Peretz Date: Wed, 5 Nov 2025 20:01:35 +0200 Subject: [PATCH] net/bonding: fix MAC address propagation in 802.3ad mode [ upstream commit 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 ] When changing the MAC address of a bonding device in 802.3ad mode, the new MAC was not propagated to the physical member NIC. This caused the physical NIC to drop all data packets sent to the new MAC address, resulting in connectivity loss. It happens because the MAC update function only updated the LACP layer (actor.system) but not the physical NIC hardware MAC addresses. This fix adds a call to rte_eth_dev_default_mac_addr_set() to update the hardware MAC on each member port. Bugzilla ID: 1158 Fixes: 46fb43683679 ("bond: add mode 4") Signed-off-by: Shani Peretz --- drivers/net/bonding/rte_eth_bond_8023ad.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 2a81ab5bf3..8ac51a3573 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1183,6 +1183,14 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev) continue; rte_ether_addr_copy(&internals->mode4.mac_addr, &slave->actor.system); + + /* Update physical NIC hardware MAC address to match bonding device. */ + if (rte_eth_dev_default_mac_addr_set(slave_id, &internals->mode4.mac_addr) != 0) { + RTE_BOND_LOG(ERR, + "Failed to update MAC address on member port %u", + slave_id); + } + /* Do nothing if this port is not an aggregator. In other case * Set NTT flag on every port that use this aggregator. */ if (slave->aggregator_port_id != slave_id) -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-12 16:20:42.085206983 +0000 +++ 0030-net-bonding-fix-MAC-address-propagation-in-802.3ad-m.patch 2025-11-12 16:20:40.927716946 +0000 @@ -1 +1 @@ -From 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 Mon Sep 17 00:00:00 2001 +From 171bfa4f2e8f727a334a54a76386f809a2b97955 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a2f21630658a7f3ff5c7564b9a2bcb0b681fb55 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 1677615435..ba88f6d261 100644 +index 2a81ab5bf3..8ac51a3573 100644 @@ -31 +32 @@ -@@ -1186,6 +1186,14 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev) +@@ -1183,6 +1183,14 @@ bond_mode_8023ad_mac_address_update(struct rte_eth_dev *bond_dev) @@ -34 +35 @@ - rte_ether_addr_copy(&internals->mode4.mac_addr, &member->actor.system); + rte_ether_addr_copy(&internals->mode4.mac_addr, &slave->actor.system); @@ -37 +38 @@ -+ if (rte_eth_dev_default_mac_addr_set(member_id, &internals->mode4.mac_addr) != 0) { ++ if (rte_eth_dev_default_mac_addr_set(slave_id, &internals->mode4.mac_addr) != 0) { @@ -40 +41 @@ -+ member_id); ++ slave_id); @@ -45 +46 @@ - if (member->aggregator_port_id != member_id) + if (slave->aggregator_port_id != slave_id)