From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 202D248AEF for ; Wed, 12 Nov 2025 17:54:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19E4040DD1; Wed, 12 Nov 2025 17:54:55 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id B17F740BA6 for ; Wed, 12 Nov 2025 17:54:53 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47754e9cc7fso6810265e9.2 for ; Wed, 12 Nov 2025 08:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762966493; x=1763571293; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sxeGCXzGV/ki74xvZu9PDS0Hrk1nEf//Lwr5vobILYA=; b=jR9yjSsgHrL6mrQpbD/dYuK+MqzRg6QByKz1k5ju/Q7J3tmf5g+C4u7sc2YMouJUNM om8Ps6tIGAOA2lQMSkN4mc6/DRXN+vyWe0gCUOFAEYlcc0L3StPXBWhBeAt349QK0b2+ l4O5lUFahNNG8rI7zYVyeGKxxsgKbpqoJiZ8dm9qgOiJuaRzSsVpVYrEzBhjUtoap7Oz hmqbSMr88FspiZakCqY/OsE6/ohR3+bzJB5mLCzA3bSJAhCookb2MpoL7txXjjz4CLwr pTgIUT2ZURZda+7JGrTneuS95+ALP+HrggwiPEErFmhnZ+8TwNQP5S7PZYYrfaB1LlCo 1eDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966493; x=1763571293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sxeGCXzGV/ki74xvZu9PDS0Hrk1nEf//Lwr5vobILYA=; b=B9x7/96WcEHBbqFQZOTIs+ToLSqxbJV8ci5blctxsK34qsR1ji4MT5NlJ6xMB9Ma/P SooVD62TMgzcTviruf8RD6lfrWNNz/obZRvIW5KAZN9XRog8MMdht2cgfT91cuAp4Idw BQgB6dpnUGZJsg5i94wJCbEnFRr8HzzziPK0wRkbEF2MygAb3URprdG/N5NYWMNKkcPS TFoDPRH4kVr274rkYLxlzNTFhmq4I3iGOc3yB86xnYexrTeg+KT9Jb2kIV249iq+rl5U ZKmnEYwhoyf3LjN3SfLPA0bJ/zCc4lDv/zFc1vB4Lh84yt6dItDKJWOdBCKdoRmvZr8H oAOg== X-Forwarded-Encrypted: i=1; AJvYcCWeTdskWLgt+wepRYTAf7lb3MqsfWXuVIm3rjP8D7rW38rluDkRypYvw441kgwtUqVeEQ+SLyc=@dpdk.org X-Gm-Message-State: AOJu0Yx3CcjsSlFct2dZ/D3RygLrftV7Cd0XzRbp/ERXIwjnRQUSHb8D XVQjCjIEzdORwKVjs1vkcJsJlZJepRIREzAm9SoOFZ5HoplFzvV6yYYQyL4LRw== X-Gm-Gg: ASbGnctCeZsIky9qLeiuwQn8gl/lY54793Pqq7lkklHrJ9EJnWgSImarD4/J/pGla0Y DA0pVvbsoJwGn+fMKcKxA5N2wOLPRsy7IFj8Gij5YQ+8bIVZnX/qRrsnw8inNKRJz072jt2gLtW he7DUJRSyp3Y3icyBA4cpNxrGdLYTBBAy8ENlt6pgvb6oW4hS5CdJeac7fGmFCltmXWYJelv1X7 GzA9/Yyn7v6AqQbeRzLF5+yFtITvgQscus50tdiO+SnkxCwS16btcTdts01cGswlTz54NdzYXIF yecFuvrzaMazQ5JPxOoJ6u6GoB3c9b2IUwDr8XAs1MhsY7jSEpqZ9RKHT6W3BGlzgUKza0kmYCV L3bSVH4DQr6ZAMOPj3omE07T1p3+KhuNR4oxFKNoVk009RQ3GAP+PUurp/G9PYWc1Svc8La1fLB zEBAYtAA== X-Google-Smtp-Source: AGHT+IFX5MQioFzadivHDePwbtDBVJWzj1p3TJcXu7jpn3nSfRLAggbd58zKOTFmjK3qZdhUO3ZwXw== X-Received: by 2002:a05:600c:3145:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-477870718b7mr32849695e9.7.1762966493159; Wed, 12 Nov 2025 08:54:53 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:a397:14bc:5982:5745]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47787e87cedsm42244685e9.14.2025.11.12.08.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 08:54:52 -0800 (PST) From: luca.boccassi@gmail.com To: Ciara Loftus Cc: Thierry Herbelot , dpdk stable Subject: patch 'net/e1000/base: fix crash on init with GCC 13' has been queued to stable release 22.11.11 Date: Wed, 12 Nov 2025 16:52:47 +0000 Message-ID: <20251112165308.1618107-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112165308.1618107-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-79-luca.boccassi@gmail.com> <20251112165308.1618107-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/6a53c0dc6d2334297e95c96048cc056c243ae71a Thanks. Luca Boccassi --- >From 6a53c0dc6d2334297e95c96048cc056c243ae71a Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Fri, 10 Oct 2025 12:58:48 +0000 Subject: [PATCH] net/e1000/base: fix crash on init with GCC 13 [ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] The e1000 PMD crashes during initialisation in a Ubuntu 24.04 VM when compiled with gcc-13 with -O3 optimisations. This patch introduces a compiler barrier after the register read that was causing the issue. Bugzilla ID: 1691 Fixes: af75078fece3 ("first public release") Signed-off-by: Ciara Loftus Tested-by: Thierry Herbelot --- drivers/net/e1000/base/e1000_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c index 5bb77d9e09..1ab5db98f2 100644 --- a/drivers/net/e1000/base/e1000_mac.c +++ b/drivers/net/e1000/base/e1000_mac.c @@ -1826,6 +1826,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) return ret_val; mac->ledctl_default = E1000_READ_REG(hw, E1000_LEDCTL); + rte_compiler_barrier(); mac->ledctl_mode1 = mac->ledctl_default; mac->ledctl_mode2 = mac->ledctl_default; -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-12 16:20:42.194331786 +0000 +++ 0033-net-e1000-base-fix-crash-on-init-with-GCC-13.patch 2025-11-12 16:20:40.935717143 +0000 @@ -1 +1 @@ -From 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 Mon Sep 17 00:00:00 2001 +From 6a53c0dc6d2334297e95c96048cc056c243ae71a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/e1000/base/e1000_mac.c | 1 + + drivers/net/e1000/base/e1000_mac.c | 1 + @@ -20,5 +21,5 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_mac.c b/drivers/net/intel/e1000/base/e1000_mac.c -index 2fa97d12a9..41aae86ffe 100644 ---- a/drivers/net/intel/e1000/base/e1000_mac.c -+++ b/drivers/net/intel/e1000/base/e1000_mac.c -@@ -1842,6 +1842,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) +diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c +index 5bb77d9e09..1ab5db98f2 100644 +--- a/drivers/net/e1000/base/e1000_mac.c ++++ b/drivers/net/e1000/base/e1000_mac.c +@@ -1826,6 +1826,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw)