From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA29F48AEF for ; Wed, 12 Nov 2025 17:55:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A561040DDD; Wed, 12 Nov 2025 17:55:30 +0100 (CET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mails.dpdk.org (Postfix) with ESMTP id 7DE9640DDD for ; Wed, 12 Nov 2025 17:55:29 +0100 (CET) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477632cc932so5048875e9.3 for ; Wed, 12 Nov 2025 08:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762966529; x=1763571329; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bqw3iowbOtExBqVaPumobJhtr0yWEO7uMFBGUToX1XE=; b=ZI035TyYMYbalDSS14wBY+kAoioy6m7X2B6dm/lMdquBrXtiet/2Q90H25qbHrqpQc tDkthYNZNpoGgtRc26/aQwqG7V32B3VWn6XNEDsxJZJOgtuQlosdbCgMW9TsRvT8QZip jpMMR0PDghN+FUti/YokNf+qOAopBBNZPtSua/qP9kNwFNZWzMmHtGDY9gdE/y2WiZRH PgeEfQVO3RCQv4gS9pOMWqqO1sDMtdiTUlbbFCFt8Ci5cJmYoBoUr7UdjrAdGBF2Ru8b jUMs6PFLjtNcMswplgjOaAiMA8TJpyHCgLrbf+P6OMZPET+YinYMhXDmIGIFvM4K8j8k CWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762966529; x=1763571329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bqw3iowbOtExBqVaPumobJhtr0yWEO7uMFBGUToX1XE=; b=SSSLS7+1F62LrmXwNmZjXZTT8xSk0w6QiI4GXSO0XfDbZBpGeJopMx7aw+A9708x/g HYWEO6dm0rtscUiBBZtgdP7iBwkS9WqYJ/2ZL0n+xqqLjIMJkacJZniCGDZ1A2iJ0GaV d039Hy209y+eYNj/MGjFKrmmBV94NB868sL7BVWfh2aEGrxj6aT9iJtrVV0G/ZhW0BTI IiVB20ArPk0QXAFbUmXZl4jcRxx7fuEYv1FJZHrIw4N92BXiuunkaAEV5Ca5XJSpugMQ wzIaY5+w3/V0jV+BNGvyoC1+u77BFxp/Y2nhSboyVm2bwJhlfwP5qBfeDPSiXlA7cN8B N9nQ== X-Forwarded-Encrypted: i=1; AJvYcCUv7kHoe7CjJZC3IJYzBzt1/wWoH1cbZM4S7VJq2oQf2stfQYGL0wwvVLQ0a5DA6wJ5bBUu3/A=@dpdk.org X-Gm-Message-State: AOJu0YwCPfx8keSueXAjtYAvWJaAV0KOvvC9apxUnwj4Qhi21ygYxhJh pjTQbWHaOkPxuDhspyL+DG9JbWJey5AweCBWxU9Yi4wZNeedFd/8xqc0xgk4yA== X-Gm-Gg: ASbGncv4lWq23FDq6QeOXq6E+ZTeQDMV5gAv4rbQsdtK0KWOrQGsw9d/iInZG/9m1RX OTDTdLFs3lgJj1CEFci13kqSLhvswD1Njg7UVR5Uylfa+Ha0Mhg0xxAop2qWH8v25dzxJuLHbwD YoQEkv/i3YICfYjZHYCjZ4/kC4p0qu7W8d2IglP1Qhfayqv0Ft46DFDJ8XaXR5na9DYVH5F7R7T f3A5SX/ssJPjiYWzi45gLikA0Zlnx/Rdqej5HCIxDsQ3U4xiP7D+c3Aq0ReDUEYVh/xNO6gvpK/ Q3/jLSjzfBF7TboU7Yla3RQmg/oeqTWygn7O03Nqye+DAPgqokjwYeOgzlwhaQGSBLhGHTZaW/U 472B1mpyMr+A73tc75fwcIHCjn0JtuHi28ionr/PIzVGgH9kAVEc7PpmvfjyTfjXXIYC4TNGIjl b/wy9Jxw== X-Google-Smtp-Source: AGHT+IFbmfGoQoESl6Lrr5nEZSPdQ56lqm7ueI67tZmUozWvtsT2FAcdF9ENbBUJy8SO1LnajCm8Yw== X-Received: by 2002:a05:600c:1391:b0:46f:b42e:e392 with SMTP id 5b1f17b1804b1-477871eb75fmr34777295e9.39.1762966528885; Wed, 12 Nov 2025 08:55:28 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:a397:14bc:5982:5745]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42b30f1cc4esm25666203f8f.36.2025.11.12.08.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 08:55:28 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, dpdk stable Subject: patch 'pdump: handle primary process exit' has been queued to stable release 22.11.11 Date: Wed, 12 Nov 2025 16:52:59 +0000 Message-ID: <20251112165308.1618107-45-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251112165308.1618107-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-79-luca.boccassi@gmail.com> <20251112165308.1618107-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c027cd1107e24036399b888ebbc9f6db7bbe1395 Thanks. Luca Boccassi --- >From c027cd1107e24036399b888ebbc9f6db7bbe1395 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 4 Nov 2025 10:07:05 -0800 Subject: [PATCH] pdump: handle primary process exit [ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ] If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/dumpcap/main.c | 4 ++++ app/pdump/main.c | 12 +++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 0b6432ad4d..c4a556af40 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -894,6 +894,10 @@ int main(int argc, char **argv) else pcap_dump_close(out.dumper); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; + cleanup_pdump_resources(); rte_ring_free(r); diff --git a/app/pdump/main.c b/app/pdump/main.c index 460642055f..b3b90c90e6 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1023,13 +1023,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-12 16:20:42.686707386 +0000 +++ 0045-pdump-handle-primary-process-exit.patch 2025-11-12 16:20:41.007718917 +0000 @@ -1 +1 @@ -From cefd5edce236e69496693ea0ecbf3e61434ff348 Mon Sep 17 00:00:00 2001 +From c027cd1107e24036399b888ebbc9f6db7bbe1395 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index e5ba36350b..3621c0ebe3 100644 +index 0b6432ad4d..c4a556af40 100644 @@ -27 +28 @@ -@@ -1059,6 +1059,10 @@ int main(int argc, char **argv) +@@ -894,6 +894,10 @@ int main(int argc, char **argv) @@ -39 +40 @@ -index 89347d70dc..7cbf1b8c34 100644 +index 460642055f..b3b90c90e6 100644 @@ -42 +43 @@ -@@ -1027,13 +1027,15 @@ main(int argc, char **argv) +@@ -1023,13 +1023,15 @@ main(int argc, char **argv)