From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3887848AFB for ; Thu, 13 Nov 2025 17:33:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C70A40151; Thu, 13 Nov 2025 17:33:07 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id F12C640151 for ; Thu, 13 Nov 2025 17:33:05 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-ba599137cf8so690514a12.0 for ; Thu, 13 Nov 2025 08:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763051585; x=1763656385; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/MagE56ECz05/LPmrk+mHwNDyA+OB2TCKa6N9w4HI/U=; b=jxTYJiF3tQg0tnObY6LAiek7m9hqcGipnpu6pqfuCY38LSVF6rhnB0fUkUVBwiZjuD +Y8HotidbWNa8qUy/mU7z4dXUz7cRAHM+l/b1NRY1+RNUxitdhz9PBJNI8t5pxZzwKIo FMDPZTl7NbVmO8Jalac+z3Eanruyq8kiRGgiy92NmYD6uEXEEgaipyJ/lYaFRmjRyh2B EXCQPvJRU6hgU6nY57Mq0LVRLs/9M467eOIU0B+66SR/IUisi+dsm0RnsMmjhLCNm2g4 A5LUMa5uMRKgZNOKVDmAZMaTTcPPYtZlXXau7E9mVr/lkVIZ/Ct18nsLLbtdQeLQaEd6 qLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763051585; x=1763656385; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/MagE56ECz05/LPmrk+mHwNDyA+OB2TCKa6N9w4HI/U=; b=s4GNK93V93bhxyBd5XvGMFBOJIio1HLef+XlHcWYws4sartmYgOqlpUCyNSQ9HRg83 QS7jWcvwBlyKrdJu+Nbl65u5EZ9lnFG8NxwhaVYv8Pyke3NcOIAfcYXVtEnjs/XXU2o2 ZExobRmuAQ/VOjwwIy3qwO3VOCDSOEGNWsN903B4/qjJFZ7DqzE0N4Tpwb1NHbxYDZvP 1OvsYdOhQM3GjL1ivNA0QvC/Kmhpc0k+lhjjU1fXWpJtI2nh5qSSGv7IstAHBlqjvTAR fGg1tIASais9nu8a1XCEp++9XUpUUrl0+k9BIGZu7GOkQ+WpfZNQKMfyeOswSvUaXsio jlng== X-Forwarded-Encrypted: i=1; AJvYcCW4ybANjdXajAO7IqrkcqIOJw6e6mGAsXoLqwI6x7RgKouRm8ha8tUoVLWknMU3QDpP0xjRMOE=@dpdk.org X-Gm-Message-State: AOJu0YyCdnnQzmaCE6haFuHhT15yldWN7jORVc6+52Aa0aPVVlHXG3m8 Kfuw4e8NCXTybehJyP0jQ2us2C4fX6+qYeyboAs+pqTKavcbZmFW0SJWUOvKDkSKV1A= X-Gm-Gg: ASbGncs5loJiOXo6/fjyC/VWoMdhozAOVdIgcOVD2k+3AEpU7LooD0XtazBx4YqY8ZV UImPL+FxjowlZKibTUQv+MKwl1ghK9fTSKxTajC2/igaK6+7zzOAMHi0vwi80P9m3SPdtK6h0cD toUF/TxB1Xoj5H1xDVQlaTmwJ16LWStFEwScbnC1OumGo5qVDxDdVosibuaEIP7B9aH3QRBfIcw iXdBns2oeY+Aw9mattA3fJswtkGT4VSmf701DEjEjyGn0/2OvNbFu1YKwNZH8GB89ubRxqLTr+O e7ZgiUrLugQmPbn9kiCmfngMNCzfrhJzEFZBtScJYL176soYyC72ep4iutfYC5MQRvJrw7iKZmb UX018YDeJLwwdScxL0Lbm+sb7CV+XHCS9zrACKN3FcenEdfIC9DUjvq3TB38nVt7huSsKeN/boI U/sbCEw9EUmvvskQFckYMet6oMZimji5TThuHkAqw= X-Google-Smtp-Source: AGHT+IF5JtSGZzWXF2Il41lt0gOCOOoMDY4wTpwgK1dRF5iicRNXGkntW4qy5jvSiQCSfhSCaoG71Q== X-Received: by 2002:a05:701b:2901:b0:11a:4ffa:bb8f with SMTP id a92af1059eb24-11b033ae656mr61564c88.5.1763051584788; Thu, 13 Nov 2025 08:33:04 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49db4a36asm276012eec.5.2025.11.13.08.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 08:33:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Ophir Munk Subject: [PATCH] net/mlx5: fix uninitialized warning Date: Thu, 13 Nov 2025 08:33:01 -0800 Message-ID: <20251113163301.285550-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Gcc-16 detects use of uninitialized variable. ./drivers/net/mlx5/linux/mlx5_ethdev_os.c: In function ‘mlx5_link_update’: ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:539:15: warning: ‘*(long unsigned int *)((char *)&dev_link + offsetof(struct rte_eth_link, ))’ may be used uninitialized [-Wmaybe-uninitialized] 539 | ret = !!memcmp(&dev->data->dev_link, &dev_link, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 540 | sizeof(struct rte_eth_link)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:515:29: note: ‘*(long unsigned int *)((char *)&dev_link + offsetof(struct rte_eth_link, ))’ was declared here 515 | struct rte_eth_link dev_link; | If the retry loop exits the code would do memcmp against unintialized stack value. Resolve by intializing to zero. Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 4d8fbed188..d4a544e1a6 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -512,7 +512,7 @@ int mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) { int ret; - struct rte_eth_link dev_link; + struct rte_eth_link dev_link = { }; time_t start_time = time(NULL); int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT; -- 2.51.0