From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FB5748B1D for ; Sat, 15 Nov 2025 20:37:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7694841153; Sat, 15 Nov 2025 20:37:59 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id CAFBF40A89 for ; Sat, 15 Nov 2025 20:37:54 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ba2450aba80so1757819a12.1 for ; Sat, 15 Nov 2025 11:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763235474; x=1763840274; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DXcx0/e40zWSpv0HdJY3T5V6v0mTRv2tMcQZs6xwfQs=; b=FGGzPOUXN5s16+v7EKyYXA4ckHeKZp2L1q3RBw7snFwWR4SGfA74dcNsE7nMgOiGi0 Eeh7J9LTeQKBceD4RuNtkMoe+Iq0E7zABL621WqXqhH8udn0nOF2Yk4XadzDBrL+AYws yWYIP3U+F/1POvAWDxt8z/3kueeNGt2LV8ZaKUbwo7mcXz8Yb9hFS0HB+OeC/92wQhqh Yw1mcoIiS46du/3ZoIkZ836qo/qTnD7YxVKJYAjtwdsG7Ov68MTa6keYFWurTflgQWGo /QTpTSNECBhoQPXeBVk5D+3mAWnu5mm4fbq98byvVLESzzRvvcUKsH/CF5axErCQZZ1R ZLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763235474; x=1763840274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DXcx0/e40zWSpv0HdJY3T5V6v0mTRv2tMcQZs6xwfQs=; b=Gd7M+iNyszz8k5Gqn6a670mHzmHfLH0xLPSwZn6oPysju45k7KsEyl3LZXaq5fhnf1 m9ZqN8jz0zPUFTZudkA9xTsihbsKQF7+8xcupVmFXuOwr97opq1hoj0igJRLOct04DGn QD7KTKrKk65L//+ilu3zkZobJJJvjwv6C4l7NelsU4YpOJyV/8/6S0y0Knpj5MoKOebH bAmKvGKgo846cqRY//SsnXF0+SwIPhlwwResGmuc22AV7s28K6dLlPc4tjBVN1Qf4Sjs SOEvOrJvS2q4kt11JlrruqVZfz3na7lUME3J61iaD0oTrZK3QfXCYFrp0KOGBj5dlWY0 8TXw== X-Forwarded-Encrypted: i=1; AJvYcCVq6NE3WooPOW52htbPwPY5JV/9xLrhkgk092f2ocz4l+r1t+8N6ZCR8/rROxQnwkyOVA6wsYQ=@dpdk.org X-Gm-Message-State: AOJu0Yx/iJIGap+QXvfdSmU0zt15YOWbkCGE8375kxIGkrHoIx6iTg5H minVFgv40C/AynkG5wxAP/lw5R1E6azyqlpkVfBqueYbYVxa/i1f8o6MV5/N+gFxTg0= X-Gm-Gg: ASbGncuCtlw1PwHXoAB/WhiX2NyYP9aYKNaeNsUc8FXb3kL4ANp4S5rlLQSSa9BZuJt wU0lUBG+T+W2ENJNDTpa9ZDpzWBmpU4OVajwh+CAUE//uINRPwIYCjGc3RaGEIzAanG/7y6H0kB kpuq5SiLoHOWsOo7QsgaF6bO+yVbt6M++PXLIsaeUmAYMEwkGgK9yH1YbU5cBcYopNBv4rU9uh8 QkQ999OA4zcovGaRPlvKwhtCdFURkr1dBOR5myxZ9twnf1VYEFYSVsuv5/17tRK1PPpKNughYIG LtcNLn6+VOEpO+n1/8YXmLfC8ZVeabSJpuhlxEL0GtOQdEiWvri92VSE0LeiId+VT0k/pY5T6Kz iE23xqHxeptU/kUHwOeUDinNatMyfPvFCH/g2SHkfR4T7vA9tzci0bwVV683nlWc86JhvAQup95 qa6eamX7Ys6L3kpeBGFo7v7MXVofVtEnlloc7cHTSVqy5cExNmVetiNHngCugH X-Google-Smtp-Source: AGHT+IFrmSymY/xcaAaX+bmLY0xwY20dWMtKWcHAltXyFOtEXsGtrRdnrIQugXYvjTsm0KEq2Q7lFA== X-Received: by 2002:a05:693c:805c:b0:2a4:5ce8:44d0 with SMTP id 5a478bee46e88-2a4abd7764bmr3522984eec.38.1763235473855; Sat, 15 Nov 2025 11:37:53 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm28753833eec.0.2025.11.15.11.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 11:37:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Subject: [PATCH v3 1/4] examples/server_node_efd: fix format overflow Date: Sat, 15 Nov 2025 11:36:36 -0800 Message-ID: <20251115193749.101355-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251115193749.101355-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251115193749.101355-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If format-truncation is enabled, the compiler detects a string overflow since the snprintf() is putting ethernet address and new line in buffer only sized for the address. Since get_rx_queue_name() is used to create a ring name. The buffer should be sized to be a valid ring name. This fixes some format-overflow warnings and also corrects for future errors. In file included from ../examples/server_node_efd/efd_server/main.c:31: In function ‘get_printable_mac_addr’, inlined from ‘do_stats_display’ at ../examples/server_node_efd/efd_server/main.c:136:3: ../lib/net/rte_ether.h:248:36: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=] 248 | #define RTE_ETHER_ADDR_PRT_FMT "%02X:%02X:%02X:%02X:%02X:%02X" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../examples/server_node_efd/efd_server/main.c:86:33: note: in expansion of macro ‘RTE_ETHER_ADDR_PRT_FMT’ 86 | RTE_ETHER_ADDR_PRT_FMT "\n", | ^~~~~~~~~~~~~~~~~~~~~~ ../examples/server_node_efd/efd_server/main.c: In function ‘do_stats_display’: ../examples/server_node_efd/efd_server/main.c:86:59: note: format string is defined here 86 | RTE_ETHER_ADDR_PRT_FMT "\n", | Fixes: 39aad0e88c58 ("examples/flow_distributor: new example to demonstrate EFD") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- examples/server_node_efd/efd_server/main.c | 2 +- examples/server_node_efd/shared/common.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/server_node_efd/efd_server/main.c b/examples/server_node_efd/efd_server/main.c index 75ff0ea532..62c3f4a16d 100644 --- a/examples/server_node_efd/efd_server/main.c +++ b/examples/server_node_efd/efd_server/main.c @@ -68,7 +68,7 @@ static const char * get_printable_mac_addr(uint16_t port) { static const char err_address[] = "00:00:00:00:00:00"; - static char addresses[RTE_MAX_ETHPORTS][sizeof(err_address)]; + static char addresses[RTE_MAX_ETHPORTS][RTE_ETHER_ADDR_FMT_SIZE + 1]; struct rte_ether_addr mac; int ret; diff --git a/examples/server_node_efd/shared/common.h b/examples/server_node_efd/shared/common.h index e1ab7e62b7..6726e2031e 100644 --- a/examples/server_node_efd/shared/common.h +++ b/examples/server_node_efd/shared/common.h @@ -58,8 +58,9 @@ get_rx_queue_name(unsigned int id) /* * Buffer for return value. Size calculated by %u being replaced * by maximum 3 digits (plus an extra byte for safety) + * Used as ring name, so upper limit is ring name size. */ - static char buffer[sizeof(MP_NODE_RXQ_NAME) + 2]; + static char buffer[RTE_RING_NAMESIZE]; snprintf(buffer, sizeof(buffer), MP_NODE_RXQ_NAME, id); return buffer; -- 2.51.0