patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'crypto/caam_jr: fix const pointer in UIO filename parsing' has been queued to stable release 24.11.4
Date: Mon,  1 Dec 2025 14:41:05 +0000	[thread overview]
Message-ID: <20251201144112.633118-6-ktraynor@redhat.com> (raw)
In-Reply-To: <20251201144112.633118-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 24.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/03/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/dc21f5fbfcf6167aa8c923a13dae0c33ed24e6ef

Thanks.

Kevin

---
From dc21f5fbfcf6167aa8c923a13dae0c33ed24e6ef Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 28 Nov 2025 14:56:12 +0100
Subject: [PATCH] crypto/caam_jr: fix const pointer in UIO filename parsing

[ upstream commit 507132927cfd2e51ca509419285434b08ca2ea7c ]

With latest glibc (Fedora Rawhide):
../drivers/crypto/caam_jr/caam_jr_uio.c: In function
	'file_name_match_extract':
../drivers/crypto/caam_jr/caam_jr_uio.c:111:16: warning: assignment
	discards 'const' qualifier from pointer target type
	[-Wdiscarded-qualifiers]
  111 |         substr = strstr(filename, match);
      |                ^

Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/crypto/caam_jr/caam_jr_uio.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c b/drivers/crypto/caam_jr/caam_jr_uio.c
index 8956f7750d..43357091e1 100644
--- a/drivers/crypto/caam_jr/caam_jr_uio.c
+++ b/drivers/crypto/caam_jr/caam_jr_uio.c
@@ -107,17 +107,9 @@ static bool
 file_name_match_extract(const char filename[], const char match[], int *number)
 {
-	char *substr = NULL;
-
-	substr = strstr(filename, match);
-	if (substr == NULL)
-		return false;
-
 	/* substring <match> was found in <filename>
 	 * read number following <match> substring in <filename>
 	 */
-	if (sscanf(filename + strlen(match), "%d", number) <= 0)
-		return false;
-
-	return true;
+	return strstr(filename, match) != NULL &&
+		sscanf(filename + strlen(match), "%d", number) > 0;
 }
 
-- 
2.51.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-12-01 11:18:48.827974193 +0000
+++ 0006-crypto-caam_jr-fix-const-pointer-in-UIO-filename-par.patch	2025-12-01 11:18:48.577735521 +0000
@@ -1 +1 @@
-From 507132927cfd2e51ca509419285434b08ca2ea7c Mon Sep 17 00:00:00 2001
+From dc21f5fbfcf6167aa8c923a13dae0c33ed24e6ef Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 507132927cfd2e51ca509419285434b08ca2ea7c ]
+
@@ -16 +17,0 @@
-Cc: stable@dpdk.org


  parent reply	other threads:[~2025-12-01 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 14:41 patch 'test/debug: fix IOVA mode on PPC64 without huge pages' " Kevin Traynor
2025-12-01 14:41 ` patch 'bus/fslmc: fix const pointer in device name parsing' " Kevin Traynor
2025-12-01 14:41 ` patch 'bus/ifpga: " Kevin Traynor
2025-12-01 14:41 ` patch 'bus/uacce: fix const pointer in device matching' " Kevin Traynor
2025-12-01 14:41 ` patch 'common/qat: fix some const pointers' " Kevin Traynor
2025-12-01 14:41 ` Kevin Traynor [this message]
2025-12-01 14:41 ` patch 'net/enetfec: fix const pointer in UIO filename parsing' " Kevin Traynor
2025-12-01 14:41 ` patch 'net/memif: fix const pointer in socket check' " Kevin Traynor
2025-12-01 14:41 ` patch 'app/procinfo: fix const pointer in collectd format' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251201144112.633118-6-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).