From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A679A48BFA for ; Mon, 1 Dec 2025 15:41:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A492402EF; Mon, 1 Dec 2025 15:41:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1DB004021F for ; Mon, 1 Dec 2025 15:41:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764600097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7wKimNwLJicYUTOL57SB59Nyqjv3zPhxI/xWxVDeMU0=; b=hidFsUwpXC8mg160JkAHCTR/1uEn4jlWgynKr4ipZYWr0BX1YNRb/GboHIPyWbE7rABjto Ki6S2Z0vNpa7SORXOrpKnagdb3t0GC7HNSZ06ou81Y/CtIgf4hWkfH63TBAeLXjtf5Scej eTkZOtlFOp29RSF1+sUo4qMm6yYA8mg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-lxtxPHCOM9WlxFzx07GuXA-1; Mon, 01 Dec 2025 09:41:36 -0500 X-MC-Unique: lxtxPHCOM9WlxFzx07GuXA-1 X-Mimecast-MFC-AGG-ID: lxtxPHCOM9WlxFzx07GuXA_1764600094 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6FA7619560B2; Mon, 1 Dec 2025 14:41:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.204]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 170CA180047F; Mon, 1 Dec 2025 14:41:32 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Chengwen Feng , dpdk stable Subject: patch 'app/procinfo: fix const pointer in collectd format' has been queued to stable release 24.11.4 Date: Mon, 1 Dec 2025 14:41:08 +0000 Message-ID: <20251201144112.633118-9-ktraynor@redhat.com> In-Reply-To: <20251201144112.633118-1-ktraynor@redhat.com> References: <20251201144112.633118-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zSbwzLCTQ5qowK8dToeN-6zQdcZ3JQ0CsK5-oZeoHXQ_1764600094 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/03/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5e42ff7946f3ecbd2c11d8ab3dd6912cf517dd82 Thanks. Kevin --- >From 5e42ff7946f3ecbd2c11d8ab3dd6912cf517dd82 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 28 Nov 2025 14:56:15 +0100 Subject: [PATCH] app/procinfo: fix const pointer in collectd format [ upstream commit 11a64ff198cf3d380c00f08d3895cd06dcd90d44 ] With latest glibc (Fedora Rawhide): ../app/proc-info/main.c: In function 'collectd_resolve_cnt_type': ../app/proc-info/main.c:689:26: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 689 | char *type_end = strrchr(cnt_name, '_'); | ^~~~~~~ Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") Signed-off-by: David Marchand Reviewed-by: Chengwen Feng --- app/proc-info/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index e1272164b1..5a092b127b 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -697,5 +697,5 @@ nic_stats_clear(uint16_t port_id) static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, const char *cnt_name) { - char *type_end = strrchr(cnt_name, '_'); + const char *type_end = strrchr(cnt_name, '_'); if ((type_end != NULL) && -- 2.51.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-01 11:18:48.947823461 +0000 +++ 0009-app-procinfo-fix-const-pointer-in-collectd-format.patch 2025-12-01 11:18:48.584735535 +0000 @@ -1 +1 @@ -From 11a64ff198cf3d380c00f08d3895cd06dcd90d44 Mon Sep 17 00:00:00 2001 +From 5e42ff7946f3ecbd2c11d8ab3dd6912cf517dd82 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 11a64ff198cf3d380c00f08d3895cd06dcd90d44 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index b09c03ab35..5925bbb765 100644 +index e1272164b1..5a092b127b 100644 @@ -26 +27 @@ -@@ -687,5 +687,5 @@ nic_stats_clear(uint16_t port_id) +@@ -697,5 +697,5 @@ nic_stats_clear(uint16_t port_id)