From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABD8048BFE for ; Mon, 1 Dec 2025 23:04:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F0A94066C; Mon, 1 Dec 2025 23:04:35 +0100 (CET) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id 36FD14065E for ; Mon, 1 Dec 2025 23:04:34 +0100 (CET) Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8b2ea2b9631so437277385a.3 for ; Mon, 01 Dec 2025 14:04:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1764626673; x=1765231473; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=AqVE5nyt/TJYSueNjqaaItddM2KsGGdC9TUHJprmoXLfMNS+7fOoWo1bfZ/N9LVF+X Q4c6rwEEeITTZ1NI+i8YLJJqfEEUYrhVBALTjfSVVbZXazWq3TLduTSpSBZRKJhR7ASI aGqELb16QaJaP23ata3LTxZr25ewfiyKdzqS7yLB/b2tph/+5ogvy+L1DRSKvQ+tn31H J8FgFmaGwDYJYe6CBo7ExOo1H227yuqufaOrIO003fNwUuOkbrOidF3P/Pg0pLdu4Psr +nhH2D7a2BOGP9JzrR9UfTkZKY+3u+MDeKSqOrCIopbyu7NL8R3nrxoahIamK53I5YkT ouIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764626673; x=1765231473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=JWuro9H6L8vV1I+AsFYu4q3ACZb9lL+/7Zqeim00xq8jWLGuPE/YoS698u3oGpBCml MsI86Brlp+YmjoZRFPsmGlZRvZI7OCbmkPvJQgNG6/Mu/yKf0s2TeJlv30MSqfm1FaAp 44Ve0bjz847deOlp0dxb7rLx+FeuWSdX8b9DqajkV8mTafIUXQMol8UrWFplpdBSFjRm 6WF2JB9nJmTH+J6XWKGMARD6DEC9vLzk/LdBmLNg4Kqp1sPBpurjn2YCDebQBUZWI64c Ps/OMUlWmwrYazMWDMZFoHfprvtK2A/Xkgey/o1HTxIItxqmIgxiU040TmOmVCrQTQ94 slPA== X-Forwarded-Encrypted: i=1; AJvYcCVncK+HnPGEvAyG8vTMCo/GcCeFa764H75IfO4kSCzR/N4IkhRAsKjqPZ0ywsVhDTd2G96mRs8=@dpdk.org X-Gm-Message-State: AOJu0YzCqbQ/eQs5Q1WBb5kBjr13nkiwcaURUgO9tfDMefI/ojy2oJ7J auoJ3yPgiDmWXvXVg7JNLk3Ph+9yQolY57n2txhmluKgfyGOaoaGhp26itnj688/7Gk= X-Gm-Gg: ASbGncvgZhRnwAzwYOwDmIr0UEjCYyXPXLylVG2eMZQsKNvu9JSKo21w4O8FGIJEaR4 fyysUXzqDadwwDdQ7LnItZUt4yAaTkjDGSZh7rMXNXr4OrHu34U3jRNAAX0ghQRmPtAvslgfnLa E3rPQkBqVRhEFh8Drc6LlXBH6lSNLayqs9W9s2v1QUEWosQXGWkG7bK32GTACVnax2TYOYCmbFU ZmmVQf84ny0Y+af1e7CdL/smJTkgTTHmBGkW6i4uv3uM3x5vVQlZ8HgIL32OAhAgpdDGMDHEUGd IarJs6hLqGQIZritYOiyartvgKJYkZcw2ZWzN87XUer6ovQyjzY+aaE+NCtT/kOM2ts3gPQsjGX 3hWwYgaRtcv1B+H6jW0VSeCCeD3TmSEP45QBbkfJtiPgLqRrGMzkNWIAnqRYiED4nUeeiA3KGH4 xeRlaI4zbW4wcesz0ZmDHgGNmAHPzEnzdCWyGbaioiaONqrUoHnQ== X-Google-Smtp-Source: AGHT+IHMMcxdFoGDySJIAr+4A5AcbymGHe7AojaOegORppsaeHpTB8pBeMr0SSek1x3Q2UzfyaZgdA== X-Received: by 2002:a05:620a:2682:b0:827:7a5a:2dcb with SMTP id af79cd13be357-8b4ebd5294fmr3900029585a.16.1764626673529; Mon, 01 Dec 2025 14:04:33 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b52a1cad4esm934398885a.45.2025.12.01.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 14:04:33 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Anatoly Burakov , Cristian Dumitrescu , Bruce Richardson Subject: [PATCH v9 6/9] test: fix impossible format-truncation in cfgfiles Date: Mon, 1 Dec 2025 14:02:04 -0800 Message-ID: <20251201220421.207285-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251201220421.207285-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251201220421.207285-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Although, it is not possible on Linux (which always uses /tmp) the compiler complains about possible snprintf() truncation. Use existing code to make empty tmp file which puts the OS specific code in one spot and avoids any races if two tests are run at once. Fixes: be22019a58c4 ("test: restore cfgfile tests") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- app/test/test_cfgfile.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c index b189d9d7a5..eabf155404 100644 --- a/app/test/test_cfgfile.c +++ b/app/test/test_cfgfile.c @@ -178,12 +178,8 @@ test_cfgfile_realloc_sections(void) ret = remove(filename); TEST_ASSERT_SUCCESS(ret, "Failed to remove file"); - char tmp[PATH_MAX] = "/tmp/"; -#ifdef RTE_EXEC_ENV_WINDOWS - ret = GetTempPathA(sizeof(tmp), tmp); - TEST_ASSERT(ret > 0, "Failed to get tmp directory"); -#endif - snprintf(filename, sizeof(filename), "%s%s", tmp, "cfg_save.ini"); + ret = make_tmp_file(filename, "save", ""); + TEST_ASSERT(ret == 0, "Failed to make empty tmp filename for save"); ret = rte_cfgfile_save(cfgfile, filename); TEST_ASSERT_SUCCESS(ret, "Failed to save to %s", filename); -- 2.51.0