From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81A1548C0F for ; Wed, 3 Dec 2025 00:48:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A4A1402CA; Wed, 3 Dec 2025 00:48:47 +0100 (CET) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mails.dpdk.org (Postfix) with ESMTP id 5A3B04021F for ; Wed, 3 Dec 2025 00:48:45 +0100 (CET) Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8b22b1d3e7fso571655285a.3 for ; Tue, 02 Dec 2025 15:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1764719324; x=1765324124; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JjRU9PFyjVj+6xY+zmq3/I995FZAm0KPuHRNNhAXSjo=; b=wCKpYJEa0LHWs+/uhEC+mBkjpd0Uh4Ma4PfxCwOuJG0mie5MvFeWEe0PSNihQ4eTCv 58VpXza57annIrGdGtppSQy+Y/Ga36mXoj0WMtTdexz97lCfEnGx5+FJ2SLDOBAebOeP vt4hZac8D9459Mc905nucyhGBGl9j1uhEmCBZhWy8JlbO1RGvKzkMKkFMnfcvEPkhjlk z2kwkJI6uXuswdm570AlEtO8+T9kMSGTlDWs+fWJBKAsoBYb5pkhqOg87c3yHjXZ53zM 4jwGDT6eUbWhIlzD2FYMU4+5xegE5gOCH5mC1MtvBrKsXIcyTgdDM1OsAjfLYXdZfkYA gvkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764719324; x=1765324124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JjRU9PFyjVj+6xY+zmq3/I995FZAm0KPuHRNNhAXSjo=; b=jfSGiBaECMnO4Lgv63mFqu+fv6r5qtcxtLX31Veqg8qwYn/2jshTt7QpTJirs7qknO pLUuko9bELLsBTfigcOKTLzJINwUn74HXMDnFIi7VOF4zb0bKlSshUbYNWtq7Fisxkix 1T+AmPllYYxewiZKPMlOzvRbtX+ryvfDpAl7eaGBED9P5ExTfkLR1NTHdvlvFpwbAVVq 2Jq+oi952YpPe1T3RW4FOuKnWKNIgwWHSF61LvIganuzGNb5qfW4apGEfHHlmM43Q+DH Dg/EQL/ylJnY3wD3ruljbwkNTvAgVSUj4BoLUWMxblPfB9TzPa4q/wmFG9QSGaXAj87k C8CQ== X-Forwarded-Encrypted: i=1; AJvYcCWPDMcPtNXi4qKr0Z5WumBnls4HRu5Hq71DXo6eHADE6pPDtzm3sGJbQCQ2IDTfLhkDw+i/W5w=@dpdk.org X-Gm-Message-State: AOJu0YxKSQy9VZHscFZvqkUf1+1EUjKzq9AD5eJtXRjgv8Lgtox9ogrw sUscV0enrhDFOqDto2QfwVfvl/MrmTOETQlYroa9OslQ/ycgDEBInXUQfM1XVdiVAgc= X-Gm-Gg: ASbGnctN0hHRVinnKDzVCcyAkeUekMGxdeOpaMSLOSzqEB+mOoqrNrTXV7rtm9gnEv1 j+KSY6rJLJeX4QJGXhpdbHf6RHBhqURI1xVsKbmmYXg/YB8Y6K3cD9MFoSxjzFt0AnJW5EIBmWb TWjPi91EMG5sLGfZFUfH+0dwRseKPnphshdywz0zQO6GY4IXKPBYYu7okY6Q/wRZ4mzH6y25Mmf 5wJ29WTqhf5Eqt/emLbFjGSb0/fk2iA36UI189var7iiurHCpzbI5MTpbvFb3iuYCdKAZPLu6RY kIFQP/+9v3CtYTeNtP0ce5UPA8tWR66RW+cLYeMbTbQa52OO8OkbJL1MkxaeFBM8++AMJSu4kAS QuPSoj42D5YQV0nD6fpipG9GQA0KzHLWpGTZpMiUQ8LngiyKm/QTl/tVzKcCMkEqWtRz45GBPVM XRrbbm+fxno9KzO+iq5X3LtHncxw7R5YjfzfxwtCwXD+9KeXGighF6 X-Google-Smtp-Source: AGHT+IG98ZXItFi191ZuXuf/eMvu4skqQzu/iBuU+y/QdVJ08bIwYAUx1yYPQogS5f6dxErPcbeaGQ== X-Received: by 2002:a05:620a:4416:b0:8b5:5a03:36df with SMTP id af79cd13be357-8b5e47d0452mr43093785a.3.1764719324401; Tue, 02 Dec 2025 15:48:44 -0800 (PST) Received: from phoenix.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b529994c8fsm1197494485a.6.2025.12.02.15.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 15:48:44 -0800 (PST) Date: Tue, 2 Dec 2025 15:48:40 -0800 From: Stephen Hemminger To: Shani Peretz Cc: , , Aman Singh , Gregory Etelson , Dariusz Sosnowski Subject: Re: [PATCH] app/testpmd: fix memory leak in port attach Message-ID: <20251202154840.5579f76a@phoenix.local> In-Reply-To: <20251202095720.264195-1-shperetz@nvidia.com> References: <20251202095720.264195-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 2 Dec 2025 11:57:20 +0200 Shani Peretz wrote: > The convert_pci_address_format() function was leaking memory because > rte_devargs_parse() allocates memory internally via strdup(), but the > function never called rte_devargs_reset() to free it. > > Add a cleanup label to ensure rte_devargs_reset() is called on all > return paths. > > Fixes: 12c2405989f6 ("app/testpmd: canonicalize short PCI name format") > Fixes: acbff64ea5b1 ("app/testpmd: fix devargs format in port attach") > Cc: stable@dpdk.org > > Signed-off-by: Shani Peretz Queued to next-net for 26.03