From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [PATCH v3 04/11] app/test: fix timer loop hang on secondary process failure
Date: Mon, 8 Dec 2025 11:52:38 +0000 [thread overview]
Message-ID: <20251208115245.3809624-5-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251208115245.3809624-1-bruce.richardson@intel.com>
When the secondary process run from timer_secontary_autotest fails, the
timer loop is never stopped so the whole process hangs until timeout.
Fix this by setting the stop flag before checking for success or failure
of the secondary process.
Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_timer_secondary.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test/test_timer_secondary.c b/app/test/test_timer_secondary.c
index ee2675a821..8580880a56 100644
--- a/app/test/test_timer_secondary.c
+++ b/app/test/test_timer_secondary.c
@@ -160,11 +160,12 @@ test_timer_secondary(void)
TEST_ASSERT_SUCCESS(ret, "Failed to launch timer manage loop");
ret = timer_secondary_spawn_wait(*sec_lcorep);
- TEST_ASSERT_SUCCESS(ret, "Secondary process execution failed");
+ /* must set exit flag even on error case, so check ret later */
rte_delay_ms(500);
-
test_info->exit_flag = 1;
+
+ TEST_ASSERT_SUCCESS(ret, "Secondary process execution failed");
rte_eal_wait_lcore(*mgr_lcorep);
#ifdef RTE_LIBRTE_TIMER_DEBUG
--
2.51.0
next prev parent reply other threads:[~2025-12-08 11:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251202154948.1757169-1-bruce.richardson@intel.com>
[not found] ` <20251204182047.3154429-1-bruce.richardson@intel.com>
2025-12-04 18:20 ` [PATCH v2 02/10] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-05 10:25 ` Marat Khalili
2025-12-04 18:20 ` [PATCH v2 04/10] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 10/10] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-05 10:29 ` Marat Khalili
[not found] ` <20251208115245.3809624-1-bruce.richardson@intel.com>
2025-12-08 11:52 ` [PATCH v3 02/11] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-08 11:52 ` Bruce Richardson [this message]
2025-12-08 11:52 ` [PATCH v3 10/11] buildtools/get-test-suites: suppress empty output Bruce Richardson
[not found] ` <20251211171709.714229-1-bruce.richardson@intel.com>
2025-12-11 17:17 ` [PATCH v4 02/11] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 04/11] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-11 17:17 ` [PATCH v4 10/11] buildtools/get-test-suites: suppress empty output Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251208115245.3809624-5-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).