From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 214F7470AE for ; Sun, 21 Dec 2025 16:00:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B227402EB; Sun, 21 Dec 2025 16:00:25 +0100 (CET) Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010055.outbound.protection.outlook.com [52.101.85.55]) by mails.dpdk.org (Postfix) with ESMTP id 98A744025F for ; Sun, 21 Dec 2025 16:00:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FI1JsllJmqnp2Q09/BNdy98APDThYDyMTW/M5QN7UHFZRgwoFNpS1yOyeqepqIixmDhHTq7LAWDY0+vAqqW/aRpmOB82wjcXNso0ooLD9JTtNL2mnwaaO+4XXCpFIR3T1cSILL9EXCijULnsO4Kn0lkmLXBXP/htAme7AT8FmSBphpAgv0z8aPuROGGFG3Z6jVA0xy7XJiUiMDrhMyL9y7fpXJbEwnn0ZR8r8DMUevq0Wip3vvNIPdhOsAApDHyGaF9dBt+IFF2RJWUz4RREM6r9TbnSq/UKDjQpMjWDs5+AdRYRqJ554UM49KmGYGU3E3H1F9JX4QQ5z94mQPE2Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VpiiDaL+Toou3f6yqEoQxgCwkLyn0kPHXNdWiICVPn0=; b=XSlb0R8mHZkdbJUafo0awW0zkprk2mt6Ud52MRVs+DcZtxBKZwOscw8yE40gWbPDB7kDP+8OFcezzDOkpOHxaRforPbmkUO8OTyuKO/SQuYlRxCDlLvu+KDdAkJY8a7PaBh1exT4F6TSenhCB+F/RxMI9KjK9XE4qY4tP7TAm5l+Pm6Zx8UOUDShWByTeBZLTao6zVMAc6IZIEMmdjNL4984GJVG9iT7K1UqQNuCH1Bot7jYnY/+LJn01FocIwt3U+UBXiELzLMuZhorUO4c4MVoZDncbSCnsLZC3ClVMIX31BeI3Bihb1fKlJLzfki1AxOxZ6SoQBe9vjDSXZj7eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VpiiDaL+Toou3f6yqEoQxgCwkLyn0kPHXNdWiICVPn0=; b=cabS2m4mETui576ESol/tGy+bsZjGT3RkxlP5v+eFaozNZ7+8E3eV89rWMDRQyyI5e7/7gaBhaUzS4l2U/5C0db8loU7j0uGGpayOXenZ6EbHUmbD0Ah2tNHdeGoBkmzSTisWlekVx6m3A07fcsnb1qhUEtHnQF+LzYVrF1/scnL/whIZHEaFcAq4JbDzXw14x7V/ksuZwJdWY3qsv2hcOMxk5dHM5+iqA3rO2O0Z8ps4p7qY2yn34gIzY1QU4GWYwYP725peNfdpbUIJg+9kDiJv5M8nTCcYQG6YFqgGlKwMNuDolBthUsvvrlVucQp1G59Ne9I1B5p8PTirHvZpg== Received: from BL1P223CA0031.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::6) by SA3PR12MB9132.namprd12.prod.outlook.com (2603:10b6:806:394::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:00:12 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:208:5b6:cafe::25) by BL1P223CA0031.outlook.office365.com (2603:10b6:208:5b6::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:00:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.0 via Frontend Transport; Sun, 21 Dec 2025 15:00:12 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 06:59:58 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 06:59:58 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 06:59:56 -0800 From: Shani Peretz To: Joshua Washington CC: Ankit Garg , Ziwei Xiao , "dpdk stable" Subject: patch 'net/gve: free Rx mbufs if allocation fails on ring setup' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:07 +0200 Message-ID: <20251221145746.763179-19-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|SA3PR12MB9132:EE_ X-MS-Office365-Filtering-Correlation-Id: 94d8d9ae-c2a2-4dd8-e697-08de40a1a462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?L/yR24CxK+B4uacpLv9Ti2/t3nfHZsR57QUjvc1474JMxumzlUMLqXGJRzom?= =?us-ascii?Q?3ZXKPjtqg4Ndj8+SEuGgyPUdz17oSBaVJLlhZxJqKyJyGpvfOAE48Jf4caWq?= =?us-ascii?Q?pYh/Mqb1EbisbKeYZ4q7oIt7QjOBDQB5szOZf5VJPYxsmLcsP2cKd16yA+3Y?= =?us-ascii?Q?guV0/oJ0XQP42JvRDGkS0S4myfTcBz74t7z68cqZugPPO92/5oZOP7TWwwKh?= =?us-ascii?Q?vWt1MP9GxGdIaFcutKZOwBTDoxf6+l6UDe3u/o8NY+7m+npRRXLF0E0iNxm+?= =?us-ascii?Q?1VHrb8jwsduSknGnNEvvSPfT169/T4jg0E6lZzd3zjeRyH+AYWopGWGs6wdn?= =?us-ascii?Q?PDeG/y63VrrNgRkrxyrw8bQ11YFZurC23SgN3vOkLcwOjNtXlvY+zB2HwD2S?= =?us-ascii?Q?ZOY1P9xnfgPM8bBWbBTohzGGuRhPgX9h/eXlZSsjMP7U+72VqOjPJEA6ECSf?= =?us-ascii?Q?bbrHuLGBeWsAVZPDb1P46/70TCR86SULdgaYIGDdE0sukej4tL5SS2c61s24?= =?us-ascii?Q?9gdB9NHrAy0esFX+Ss2BQZYsZWNtDLx8RNJUsL/reeKtnHow/c1ei355wSuM?= =?us-ascii?Q?pFfEFeQdTFuTd2x/vikhcNVl1woqNe3nfPtQEuqOKCLXuXLP/oDccyzuwHws?= =?us-ascii?Q?Gz5k7rNl0doS+6opdEyitNhmEfwkekEF3+E/JvSfqcMT7DqCw9BmAWK8dg0G?= =?us-ascii?Q?ShTx3wUT2kkfrRJYPGQ0w1ZpLp24QuFXw74pf7l50aVif8NCBMwZV8KjSRIz?= =?us-ascii?Q?ANRbDqZxkGiuf2yrGguS7CcJv3KIOOxenD/aQITyTA0Pp8Tjfm8YqFF5FKP/?= =?us-ascii?Q?aDNE4AeB8OKAhelFbbRev/Kd7nWQB/54AqLeK5EhCwdxe7o2oWe1E+qTpCsr?= =?us-ascii?Q?SnAcZI50ESVNNiOzefsQOmxWTcQYlX7HBwItTrThAzcExErG3WAuyf4h8yR9?= =?us-ascii?Q?i5em7CxnGN3z7jrVybXyMmNaQuZcydrfSFLf0Wz1U+BgtfE814qq/Tj1y9ek?= =?us-ascii?Q?S9fws8LnYCVbPOo4NASIre1GgFHCoH2bHQo3DHZM7/Cwf2mG/vCasqSl8gQu?= =?us-ascii?Q?3OGM4XaUUowefvKdyPgRmbYSSGDv4z2T7Cf1l4ltqAM0Rzh6JTsq9C9Pxa3Q?= =?us-ascii?Q?7Xauzi/hvBIwpzeZdaPF7Aqccy+ndhDkRmq7oWnhs1wcJ2ox+AgXvooiuNQQ?= =?us-ascii?Q?Q6LJKXH4sXT+12eN8JHLD4dXzm6rpcAud7k9489lzC85c0uvf2H9WDKo4HzO?= =?us-ascii?Q?gWzmEuomcGWupSrPAOFm5kdo6tsBYwfEfn6LIK25q4Yjkn4yEDAbhFHv26Z6?= =?us-ascii?Q?Hn4KNUsl8/Oh4TXjJDpGw6jWTLvOMNwGmOnlcsdp0bxXKcWrNSE+HGHxr+y0?= =?us-ascii?Q?yMTmg8t0GW2gGYAunzJ2JNiwA10cWRmZUNXtNVwoHBq8HNsyMk+MoJRzULVw?= =?us-ascii?Q?JdgZw74qFd8ty1pRt84pl5rYY4alPPS2iCtiLD8MhYkRaeddxOgvVmtwOL7U?= =?us-ascii?Q?U+kW3+flHwLDakASl72vto2tOaJNyPzVRJTpGOi/yecndUlKG9/xNZ5dlAxF?= =?us-ascii?Q?OQPtwhHAz3ddb0juak6cByGDARtHdXFUdoRb05D6?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:00:12.3269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94d8d9ae-c2a2-4dd8-e697-08de40a1a462 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9132 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/d2a825390dc8437192bcb6b78e850a74bc7dce88 Thanks. Shani --- >From d2a825390dc8437192bcb6b78e850a74bc7dce88 Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 25 Aug 2025 17:03:34 -0700 Subject: [PATCH] net/gve: free Rx mbufs if allocation fails on ring setup [ upstream commit fa48f964253ba018b4a3054246a6e26b31b5c8b0 ] When creating new RX rings, one less than the number of buffers in the ring need to be allocated. It is possible that only a part of the allocation is successful, resulting in a failure to create the rings. In this case, the driver should free the buffers which were successfully allocated to avoid a memory leak in case the application does not automatically exit. Fixes: 265daac8a53a ("net/gve: fix mbuf allocation memory leak for DQ Rx") Signed-off-by: Joshua Washington Reviewed-by: Ankit Garg Reviewed-by: Ziwei Xiao --- drivers/net/gve/gve_rx_dqo.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c index bf8b3dbd36..d5c770d7af 100644 --- a/drivers/net/gve/gve_rx_dqo.c +++ b/drivers/net/gve/gve_rx_dqo.c @@ -316,14 +316,13 @@ gve_rxq_mbufs_alloc_dqo(struct gve_rx_queue *rxq) rxq->stats.no_mbufs_bulk++; for (i = 0; i < rx_mask; i++) { nmb = rte_pktmbuf_alloc(rxq->mpool); - if (!nmb) - break; + if (!nmb) { + rxq->stats.no_mbufs++; + gve_release_rxq_mbufs_dqo(rxq); + return -ENOMEM; + } rxq->sw_ring[i] = nmb; } - if (i < rxq->nb_rx_desc - 1) { - rxq->stats.no_mbufs += rx_mask - i; - return -ENOMEM; - } } for (i = 0; i < rx_mask; i++) { -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:18.318106610 +0200 +++ 0019-net-gve-free-Rx-mbufs-if-allocation-fails-on-ring-se.patch 2025-12-21 16:54:16.745086000 +0200 @@ -1 +1 @@ -From fa48f964253ba018b4a3054246a6e26b31b5c8b0 Mon Sep 17 00:00:00 2001 +From d2a825390dc8437192bcb6b78e850a74bc7dce88 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fa48f964253ba018b4a3054246a6e26b31b5c8b0 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 0103add985..cd85d90bb6 100644 +index bf8b3dbd36..d5c770d7af 100644 @@ -27 +28 @@ -@@ -376,14 +376,13 @@ gve_rxq_mbufs_alloc_dqo(struct gve_rx_queue *rxq) +@@ -316,14 +316,13 @@ gve_rxq_mbufs_alloc_dqo(struct gve_rx_queue *rxq)