From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E19F6470AE for ; Sun, 21 Dec 2025 16:00:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAFE04025F; Sun, 21 Dec 2025 16:00:20 +0100 (CET) Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011034.outbound.protection.outlook.com [40.107.208.34]) by mails.dpdk.org (Postfix) with ESMTP id BC7FE4025F for ; Sun, 21 Dec 2025 16:00:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o8wlX+pcm/ZI8b6J7RqHT3B82vn11cYpDJGDwvqP1CqGD6X24xmBHgh+a2elcjUeeOAyMDRrdUtrcIqmJNSx47H1D/LcguXQFlitIdm4r5vOPVhFf4R+nE/NcAOajgfiOP+T+jokDQ2gTQmhGKNZS20BeUr3qe+b72HPUsTqPJiEqPeG9Lp3RZm0gKMUXSuZ34fWYz5AcpFDvpS80u70bfOJBbNS1x2V0Wz+3CYMhde+mtLA3UrauvFowN3XGgSfoTyyWgvQvSoH124Nqz6YdzZ+4UV7GlqUbNu15WQDPIyItyTA8DD6W/ya6OyRW92tAIfX1xiu+9K+rUkOcTt6RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f+sutuejTKfVS8H9uynWxklPExxGYIUYg/hvIcZOa9I=; b=ObWMmwEdLAKTQHfk5L+k0Iuat1wxaK93+MmLG932o4L857rIR9Jo7vy6bwjNfysg6C6TC2nTMQGml6fgKpd+aGIYXcswhmIZ6b9moouGuFSKLFrs60zrVr9dsJtAdv/BG3e5ToNXbgOgt0Gs+5EHHnDq8aA+Hljd5SaCTZawFpvr+LV9npr+GdRieIxZWf3UodGZ62ES6rafjaJeGmrlwasmysPW0dmpR3EoR0ngh02c25V6KXteqwj1mGgxnHOh9726WOFJLK8GvdaFJw6/Y4l6OwrTbV3NNchtTSGSQglZAAdXd3I2f3gXwyn6vIkhNsX66cssbBiJIFaT4HyLsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=uetpeshawar.edu.pk smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f+sutuejTKfVS8H9uynWxklPExxGYIUYg/hvIcZOa9I=; b=tqqGnKDsYZdbG6pcRxLk8i/9k7YpkV7230TwDqDLCfnDRwnXG8NC33sPEuC7ECH4Grp5B0GL8vou94H6Ds4HXWh4GH1+toUMcvE/pxJhFFc/z1M52V/SMeF1+Jq3OcubJTerGJxXHhD4Hm6Uqadz53fFNcNnFTf7exBVLpkMYDQypn1ZGEc0f6afrUEb4RTXN+jOtamEIMAhUE6GyXQda2fBOb1Tzo0I/7qI7/6zgTEfbMLbfupLao2x5+DoAIGouEaTiCKd6VziJcqjj6zHjk3DMd7jTUHFUmPWQyB3ylx1h8y1cKVzKa/N3S6ipRfc3524gVQVR7xdaKTi0t1nuw== Received: from MN2PR17CA0025.namprd17.prod.outlook.com (2603:10b6:208:15e::38) by CY3PR12MB9579.namprd12.prod.outlook.com (2603:10b6:930:10a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:00:12 +0000 Received: from BL6PEPF00022572.namprd02.prod.outlook.com (2603:10b6:208:15e:cafe::fa) by MN2PR17CA0025.outlook.office365.com (2603:10b6:208:15e::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.6 via Frontend Transport; Sun, 21 Dec 2025 15:00:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00022572.mail.protection.outlook.com (10.167.249.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:00:10 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:00 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 06:59:59 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 06:59:59 -0800 From: Shani Peretz To: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> CC: dpdk stable Subject: patch 'app/testpmd: validate DSCP and VLAN for meter creation' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:08 +0200 Message-ID: <20251221145746.763179-20-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022572:EE_|CY3PR12MB9579:EE_ X-MS-Office365-Filtering-Correlation-Id: f64b4cca-87d5-49b3-06e8-08de40a1a399 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?W7ZGdMSEoMnyUXDCpzLm72H0McjddnfiQerX33gNf/ZgdhNtRY03aj1117cK?= =?us-ascii?Q?AelTbXwPHWjcLJ7hL4EC9yjOAnr+n9ic4zpljPSlcREPseiXdp5DtSEbMYJ6?= =?us-ascii?Q?eNW4UmWD5+C1pC7EH2oM3aASbgp3iikl+O9IGbB5Db9EoCnFPwOVE999AbSZ?= =?us-ascii?Q?t+/5/c9SkK6fwIUAmk6ryNCF3bhEV6q5+QCCbnA5j69WwwssAWa2n+dta1Tl?= =?us-ascii?Q?6LLDZZ1avRLnuYymHFEdhkfCrElqa29iw3pK8pf/7uUueB/TvMLQezpg9wWj?= =?us-ascii?Q?wyeLwtYxouYtz4MfR/Y7SV3VeQoIBLmXY6/rwJClm5tySwfDYgSovHIXgRzN?= =?us-ascii?Q?evf2nntZzk6CPd5OZ+gnQGV5HXhaJ1DP5RyBOyebA49bvZm1mrdGO9aBFO9o?= =?us-ascii?Q?nE5bFc/xcapSItHc82kYk961KL21qmxBi7XGbEbZmoKabsSDy3M4erpNg4Ke?= =?us-ascii?Q?mF6cPAE8VCIrBoz44KpgwhTdd3I7RdpuVBikQ6qTCIup88gpenqrizL7siGb?= =?us-ascii?Q?QsbQ/QkIVuNn4JtqHAJoWdU45yfI2jbR5doMVqUd8PAfGPXq9hQ7ud4fJVI+?= =?us-ascii?Q?Ovdnw29hqHCi+s8WxYnJnq9a0p1u3p3TLR/v7EZoVCcKPZUHHqT1+Vgz06dg?= =?us-ascii?Q?suOXcJl94GQ1PjiJsk67KvwHhJfoHi/yO0cQ0FqNMfURT9mF2hJF2El0uQek?= =?us-ascii?Q?oxjP+J6aJAX9aYy8n0c05R7vwAFkaEKEgaTOsLeu0YE+F1y8U2WTV2bpBRF0?= =?us-ascii?Q?r8M3bnHOFjeINYiZQNMRUCfVB9SINFP3c5/nvkVXU3MP3VniAbw9P04XtOs/?= =?us-ascii?Q?35+9uLFveLLZ+zF4T6RtzFYXc9yGCzscYVnpHS59GiT/TS/7xS/XxPO9HANF?= =?us-ascii?Q?cKrFJq72qQ7ZhEZvVVuqdTGrWR5puQy8KfCO9BQF8OUreg0kL7bj0c9GZbV4?= =?us-ascii?Q?XqInLgR9Ln7n78YqTDicW6gatyb9n4Oy7BSOME0SdcVcBTjuFzl2hjM9RfLV?= =?us-ascii?Q?v39rql+/n9sIbbkAd6yx/JC+njiXPJDOLBjyWMurUInRrLjKctDHCH1UpAD/?= =?us-ascii?Q?yF2CEh1Z8LU0Y/WcQzOpDYrpOfFSzlEqG8yWImh6r1LxSE0zJ9ncl2J1IVMr?= =?us-ascii?Q?qLRpCYuvIwOCet7ik8iYHLn1dCB61i/rjpqEHH4/1jszW6kEC2/7Usa6G7fr?= =?us-ascii?Q?sSx4fxdmKcBsxzpVaAo71u3PLlTwagtcrxac6+KN/E2syieLQ0pmR0jW3Myb?= =?us-ascii?Q?Kb+wnQsxZ49auKmLCtzDpRYJ+RCDvQhTbuPPynRdrRN/d4r+bk59yZLw7Rar?= =?us-ascii?Q?zD4spoM/MDkg+jRWiRfQryTx2x7O12JPqNmQbqEvObC4eOZPGdfbo98iBZyD?= =?us-ascii?Q?24Q2lVHbhnzO1x8fq/buFO+zxkdFYjDZkOpgCSVyL3fPISG3emUq1RIDgT//?= =?us-ascii?Q?2xCKY6mvNN7Vt/MgpyOLim4gEX5iG0kL3erj96braDayk9kHHoXMqsNZXL9t?= =?us-ascii?Q?TjHhtqqdZ8PdpKwnyUwgJTbyp6cz/8KfIVPun5XCls8ojx5YdcMMe5aTaXI/?= =?us-ascii?Q?3G4n01df5BGIZlyAhXdhhxTYusIt4QGEXD5UEs3Q?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:00:10.9873 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f64b4cca-87d5-49b3-06e8-08de40a1a399 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022572.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY3PR12MB9579 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/c5f6a63d8abe7a665bbd9e98e42a02e0a41ace9d Thanks. Shani --- >From c5f6a63d8abe7a665bbd9e98e42a02e0a41ace9d Mon Sep 17 00:00:00 2001 From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Date: Thu, 28 Aug 2025 01:29:01 -0400 Subject: [PATCH] app/testpmd: validate DSCP and VLAN for meter creation [ upstream commit 00092e969aad2fb2a2017b7eec86f033d4527950 ] Add validation mechanism for meter creation. The maximum possible entries are [ ...] [ ... ]. Currently, testpmd allows any input table entries for DSCP and VLAN tables. This patch validates the maximum possible DSCP and VLAN table entries for meter creation. Fixes: 9f5488e326d3b ("app/testpmd: support different input color method") Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/test-pmd/cmdline_mtr.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index e16c5b268f..0c5897ada8 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -85,15 +85,35 @@ parse_uint(uint64_t *value, const char *str) return 0; } +static int +validate_input_color_table_entries(char *str) +{ + char *saveptr; + char *token = strtok_r(str, PARSE_DELIMITER, &saveptr); + for (int i = 0; token != NULL; i++) { + if (i > ((MAX_DSCP_TABLE_ENTRIES + MAX_VLAN_TABLE_ENTRIES) - 1)) + return -1; + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); + } + return 0; +} + static int parse_input_color_table_entries(char *str, enum rte_color **dscp_table, enum rte_color **vlan_table) { enum rte_color *vlan, *dscp; - char *token; + char *token, *saveptr; + char *temp_str = strdup(str); int i = 0; - token = strtok_r(str, PARSE_DELIMITER, &str); + if (validate_input_color_table_entries(temp_str)) { + free(temp_str); + return -1; + } + free(temp_str); + + token = strtok_r(str, PARSE_DELIMITER, &saveptr); if (token == NULL) return 0; @@ -117,7 +137,7 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, if (i == MAX_DSCP_TABLE_ENTRIES) break; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) { free(dscp); return -1; @@ -126,7 +146,7 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, *dscp_table = dscp; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) return 0; @@ -154,7 +174,7 @@ parse_input_color_table_entries(char *str, enum rte_color **dscp_table, if (i == MAX_VLAN_TABLE_ENTRIES) break; - token = strtok_r(str, PARSE_DELIMITER, &str); + token = strtok_r(NULL, PARSE_DELIMITER, &saveptr); if (token == NULL) { free(vlan); free(*dscp_table); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:18.361896464 +0200 +++ 0020-app-testpmd-validate-DSCP-and-VLAN-for-meter-creatio.patch 2025-12-21 16:54:16.750089000 +0200 @@ -1 +1 @@ -From 00092e969aad2fb2a2017b7eec86f033d4527950 Mon Sep 17 00:00:00 2001 +From c5f6a63d8abe7a665bbd9e98e42a02e0a41ace9d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 00092e969aad2fb2a2017b7eec86f033d4527950 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org