From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64E43470AE for ; Sun, 21 Dec 2025 16:00:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E8BF402EB; Sun, 21 Dec 2025 16:00:43 +0100 (CET) Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012021.outbound.protection.outlook.com [52.101.53.21]) by mails.dpdk.org (Postfix) with ESMTP id 81C284025F for ; Sun, 21 Dec 2025 16:00:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KArPus+kkVRQ4bedtjNbIbPT+2ofO1xSvUotT8P/aWe+GEgsgJ8Qc9RZ9I8/dfE898Cvil870M0PN5VvCFIKspr264GnsmvzeE4VGRFuPxFI9YlXzVSXghJRY9gJ4JS/+4NWO40vkX4R7B7Nf7CgkUbLo+xtJHncRnJcB0GnbnEy96x8iPVr0i5RmvSgn7H5LJiDmtKt6PGmGsYTwb9RMs880BMmwwpIFJgrieK19tHax28QTWPE9KLr41WfAzc9ZmHDcxTrODM4s9bM3uQVfCR8mDzSE6ZklOu/LwBHx3ffn7TEvPS40xvYmLzrbtrKa1QVr4KA6oMUuNUdnCXzow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekGJbN3JcQj457/iufiM8AJWIsz4Cpz846w1iNDgAHU=; b=TN3FdHAHc2jHgHnC6z88JvcFUNgH108c3hggIsp+Iw4nFT4N8K8LAR/Vth6GqI7Vc6xPVPmtGDZ6dzeduwSoa42Q+4JYLlaHHvy8Ind1jQjs8JYq3tGYSlcbgtSInkPoxyCBpwumGI3fa/oP9DHDwd93eQ19WL6fjuyORsw00aL8jur63/PrnlgxKAw0X+TpDUmjWMe4Shamjx4G/vSTLmC6a7OOcoesNV1wjUFkIpKWzUn7BHoM0SlfzkyrtmN54GPrJ8gdRpP9FqvRnnp6ANcv4IsLlFq1Bxj1k+2kivp+rf8JBxaWE83IefY/gRnWbojvRRjKPoMf0plmS0LRMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekGJbN3JcQj457/iufiM8AJWIsz4Cpz846w1iNDgAHU=; b=PfAYqSSfFnFpoM+3mJmtSf/tfq5mxm92L1agOZt0VrMpocMzauaUTYODNRI5as060Tbpv85vV5/4qV7UHjApC+Pbn+XU4IfqXA8BjawCBWhlAQ9eYnsX/M68yu5M3GPK9RSNBrBD9oOy/YD3QDYm/PgOJYgLllXyPAge651y45RtMi4dVp7rfMy8VLXE8KfMibC87IrSLtQ42WH3utBlVaqORhByoMaUR1c0Ztg74clQBNIRbV45dlmnIsvS36IJMdo3vgfriRpdBuZPKD5N3B+0YALMZKBojfv5cB25hPlvbT/gI8b6VMTqd67AInAnOKyourBJA+umaFNkLLq7Sg== Received: from BL1PR13CA0160.namprd13.prod.outlook.com (2603:10b6:208:2bd::15) by MW4PR12MB6801.namprd12.prod.outlook.com (2603:10b6:303:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:00:35 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:208:2bd:cafe::14) by BL1PR13CA0160.outlook.office365.com (2603:10b6:208:2bd::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:00:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:00:34 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:14 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:13 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:00:12 -0800 From: Shani Peretz To: Dariusz Sosnowski CC: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix min and max MTU reporting' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:09 +0200 Message-ID: <20251221145746.763179-21-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|MW4PR12MB6801:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d2ef612-5b8a-4c1b-ded4-08de40a1b15a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q3mbul//T3b4Q7tWes97CDphocUdHtOsxwGHDpgv1qK76RUmW/3je0BlKj19?= =?us-ascii?Q?X1myQTR2krIG85VLk6Kd8tcZKjN9jVuFo/nI2qjdPe7StjPnY2Ri/HGAj5dR?= =?us-ascii?Q?7p3afhWAV0FxfWnR+BXwiYpOBICEtKgpaRyi+hom3u0NQ1Q+VLGWcJjDOlXx?= =?us-ascii?Q?xcOoQUHU4j8H9NtTrd5s8Aid0rQKyWcnL0l2ux04amviTDfTqzXDkesd1ObL?= =?us-ascii?Q?MdBJQBE44Wc5CjX1/aor63G591w89v1p7Xi+XvHM9t/sV+ZEw0LkFwXaa5yw?= =?us-ascii?Q?HhBbSu2IRqmO0fejXH02rd/+tG5ctQz1caI4+j21UkAbf9XriD7LVh+xwmKm?= =?us-ascii?Q?3RDsX+x9q4qERexAl2/168j4NrY1aalVd9iwY2QPRzI/AtMgciPwwLhfWXnK?= =?us-ascii?Q?EaQlg5dp84ssq7dHebqB29iIo7SfiPP9ThznbH0/o+SVMOlARw898G/uHAgB?= =?us-ascii?Q?FUFAr3qA5J5DgKEepSttQ5/j5ENCt6r0f025d+v8NO4HQWaEKX2Epa8DtyMC?= =?us-ascii?Q?0rLeSZXWTPPoD+NHWcUNxO9pwq3Ss4+3SHyMuBiQNE5smqUQN/5jQSZtumbg?= =?us-ascii?Q?4aPT92wNlRy3K5Adek0pi1ha6JRQSpzyFNWXFiGinPVIEMu3Sbwp9WPxzWR8?= =?us-ascii?Q?6bkMKowY7je/o68id6dMeeYUUPgXbp/ewMi2kqRgcKXaEr8bhWJtt5SASPzv?= =?us-ascii?Q?EqZbCYHKHnvIIxtWnLyBJXQH4M5pCiOT9zZiGeAFhnvkbPx+uM6srqp0wZw3?= =?us-ascii?Q?KlzsA+JfinZ6UNiNS4oFqth8ZanZO2jicEHBRGYf6glJZZFCuveMVYEDgqWI?= =?us-ascii?Q?EZN31n/aDircnvjKLoPUU8L2BALw/eny87rHiW8r8m3BWOSdHiuVgbXbnyei?= =?us-ascii?Q?T1vvAx26hChcDBsfKKerNQYtlnTuYHQEVzrsl0Mtu2u9GPJB4CAQ0cFDfwUs?= =?us-ascii?Q?MlT5lal5TIvWcj3IeTj250lx41Bmiu6NnFy0g0X7Mwtmoilmr9ky7BqMXzml?= =?us-ascii?Q?wJZNrD9n9n5sDwlAs/7c5d/+gdpBi61RDYKVf5d7S36YLM+N++PbWyNRNigI?= =?us-ascii?Q?ttVkV5GSnljbng+h0HGSMFqwXIwZdA+C8BUnDHyBhCi6k6cptJ1e2R+UQZyb?= =?us-ascii?Q?nXqaCUDbkmPqiaeK0VGqRoTZOe4O9pLKIblvP1JbHlB0mvzTtativMGCElSK?= =?us-ascii?Q?7ClsIs+eAcN3wrox9IL6zePMvVziWSaPk3UPsVPXg/TQPyA+YAE536jjG3NF?= =?us-ascii?Q?GX3S7oMifa7MmLhvCG0ZgBJlE0A1G9FtWCUoF4pEPtj4k/xseR4KPE5jdHDL?= =?us-ascii?Q?K3NBQbPjPTfbtYGVIDCIZeewX64dffwvEbhlJF2pj0h9/qITE/BBHFMJ1Eyh?= =?us-ascii?Q?xnbB0syDptgjM5JBTpf0vu6k+AOYj40RXeoYZFByuLfBnnde977Xf4Qh6hY+?= =?us-ascii?Q?gccl+TjU/zp9UmXoBb5iJS41m7Ur9vZonQGb4fWJGzVhFf4BQtW8US36AHXo?= =?us-ascii?Q?+lUZwvDSNuNnmyTCcEyLADUpNiahiiVjjfPVaGppDEsrl8ungf2R3yTo0mWs?= =?us-ascii?Q?NdjvFpCAPmoJP5bvpTW2oFOAnjGkN/BzqR1gW8Yz?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:00:34.0694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d2ef612-5b8a-4c1b-ded4-08de40a1b15a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6801 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/9400a790b28c55b6ed0d94a8e666bce1fd5cd985 Thanks. Shani --- >From 9400a790b28c55b6ed0d94a8e666bce1fd5cd985 Mon Sep 17 00:00:00 2001 From: Dariusz Sosnowski Date: Tue, 4 Nov 2025 18:27:15 +0100 Subject: [PATCH] net/mlx5: fix min and max MTU reporting [ upstream commit 44d657109216a32e8718446f20f91272e10575dd ] mlx5 PMD used hardcoded and incorrect values when reporting maximum MTU and maximum Rx packet length through rte_eth_dev_info_get(). This patch adds support for querying OS for minimum and maximum allowed MTU values. Maximum Rx packet length is then calculated based on these values. On Linux, these values are queried through netlink, using IFLA_MIN_MTU and IFLA_MAX_MTU attributes added in Linux 4.18. Windows API unfortunately does not expose minimum and maximum allowed MTU values. In this case, fallback hardcoded values (working on currently supported HW) will be used. Bugzilla ID: 1719 Fixes: e60fbd5b24fc ("mlx5: add device configure/start/stop") Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_nl.c | 108 ++++++++++++++++++++++ drivers/common/mlx5/linux/mlx5_nl.h | 3 + drivers/common/mlx5/version.map | 1 + drivers/net/mlx5/linux/mlx5_ethdev_os.c | 30 ++++++ drivers/net/mlx5/linux/mlx5_os.c | 2 + drivers/net/mlx5/mlx5.h | 13 +++ drivers/net/mlx5/mlx5_ethdev.c | 42 ++++++++- drivers/net/mlx5/windows/mlx5_ethdev_os.c | 28 ++++++ drivers/net/mlx5/windows/mlx5_os.c | 2 + 9 files changed, 228 insertions(+), 1 deletion(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 28a1f56dba..15304bbfca 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -2032,3 +2032,111 @@ mlx5_nl_devlink_esw_multiport_get(int nlsk_fd, int family_id, const char *pci_ad *enable ? "en" : "dis", pci_addr); return ret; } + +struct mlx5_mtu { + uint32_t min_mtu; + bool min_mtu_set; + uint32_t max_mtu; + bool max_mtu_set; +}; + +static int +mlx5_nl_get_mtu_bounds_cb(struct nlmsghdr *nh, void *arg) +{ + size_t off = NLMSG_LENGTH(sizeof(struct ifinfomsg)); + struct mlx5_mtu *out = arg; + + while (off < nh->nlmsg_len) { + struct rtattr *ra = RTE_PTR_ADD(nh, off); + uint32_t *payload; + + switch (ra->rta_type) { + case IFLA_MIN_MTU: + payload = RTA_DATA(ra); + out->min_mtu = *payload; + out->min_mtu_set = true; + break; + case IFLA_MAX_MTU: + payload = RTA_DATA(ra); + out->max_mtu = *payload; + out->max_mtu_set = true; + break; + default: + /* Nothing to do for other attributes. */ + break; + } + off += RTA_ALIGN(ra->rta_len); + } + + return 0; +} + +/** + * Query minimum and maximum allowed MTU values for given Linux network interface. + * + * This function queries the following interface attributes exposed in netlink since Linux 4.18: + * + * - IFLA_MIN_MTU - minimum allowed MTU + * - IFLA_MAX_MTU - maximum allowed MTU + * + * @param[in] nl + * Netlink socket of the ROUTE kind (NETLINK_ROUTE). + * @param[in] ifindex + * Linux network device index. + * @param[out] min_mtu + * Pointer to minimum allowed MTU. Populated only if both minimum and maximum MTU was queried. + * @param[out] max_mtu + * Pointer to maximum allowed MTU. Populated only if both minimum and maximum MTU was queried. + * + * @return + * 0 on success, negative on error and rte_errno is set. + * + * Known errors: + * + * - (-EINVAL) - either @p min_mtu or @p max_mtu is NULL. + * - (-ENOENT) - either minimum or maximum allowed MTU was not found in interface attributes. + */ +int +mlx5_nl_get_mtu_bounds(int nl, unsigned int ifindex, uint16_t *min_mtu, uint16_t *max_mtu) +{ + struct mlx5_mtu out = { 0 }; + struct { + struct nlmsghdr nh; + struct ifinfomsg info; + } req = { + .nh = { + .nlmsg_len = NLMSG_LENGTH(sizeof(req.info)), + .nlmsg_type = RTM_GETLINK, + .nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK, + }, + .info = { + .ifi_family = AF_UNSPEC, + .ifi_index = ifindex, + }, + }; + uint32_t sn = MLX5_NL_SN_GENERATE; + int ret; + + if (min_mtu == NULL || max_mtu == NULL) { + rte_errno = EINVAL; + return -rte_errno; + } + + ret = mlx5_nl_send(nl, &req.nh, sn); + if (ret < 0) + return ret; + + ret = mlx5_nl_recv(nl, sn, mlx5_nl_get_mtu_bounds_cb, &out); + if (ret < 0) + return ret; + + if (!out.min_mtu_set || !out.max_mtu_set) { + rte_errno = ENOENT; + return -rte_errno; + } + + *min_mtu = out.min_mtu; + *max_mtu = out.max_mtu; + + return ret; +} diff --git a/drivers/common/mlx5/linux/mlx5_nl.h b/drivers/common/mlx5/linux/mlx5_nl.h index 580de3b769..34306258ec 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.h +++ b/drivers/common/mlx5/linux/mlx5_nl.h @@ -87,4 +87,7 @@ __rte_internal int mlx5_nl_devlink_esw_multiport_get(int nlsk_fd, int family_id, const char *pci_addr, int *enable); +__rte_internal +int mlx5_nl_get_mtu_bounds(int nl, unsigned int ifindex, uint16_t *min_mtu, uint16_t *max_mtu); + #endif /* RTE_PMD_MLX5_NL_H_ */ diff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map index 074eed46fd..e43164235e 100644 --- a/drivers/common/mlx5/version.map +++ b/drivers/common/mlx5/version.map @@ -142,6 +142,7 @@ INTERNAL { mlx5_nl_vf_mac_addr_modify; # WINDOWS_NO_EXPORT mlx5_nl_vlan_vmwa_create; # WINDOWS_NO_EXPORT mlx5_nl_vlan_vmwa_delete; # WINDOWS_NO_EXPORT + mlx5_nl_get_mtu_bounds; # WINDOWS_NO_EXPORT mlx5_os_umem_dereg; mlx5_os_umem_reg; diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 1d999ef66b..4d126751a2 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -242,6 +242,36 @@ mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr) return mlx5_ifreq_by_ifname(ifname, req, ifr); } +/** + * Get device minimum and maximum allowed MTU values. + * + * @param dev + * Pointer to Ethernet device. + * @param[out] min_mtu + * Minimum MTU value output buffer. + * @param[out] max_mtu + * Maximum MTU value output buffer. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +int +mlx5_os_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *max_mtu) +{ + struct mlx5_priv *priv = dev->data->dev_private; + int nl_route; + int ret; + + nl_route = mlx5_nl_init(NETLINK_ROUTE, 0); + if (nl_route < 0) + return nl_route; + + ret = mlx5_nl_get_mtu_bounds(nl_route, priv->if_index, min_mtu, max_mtu); + + close(nl_route); + return ret; +} + /** * Get device MTU. * diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index c6e5e7b425..d1ccec71e9 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1521,6 +1521,8 @@ err_secondary: eth_dev->data->mac_addrs = priv->mac; eth_dev->device = dpdk_dev; eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; + /* Fetch minimum and maximum allowed MTU from the device. */ + mlx5_get_mtu_bounds(eth_dev, &priv->min_mtu, &priv->max_mtu); /* Configure the first MAC address by default. */ if (mlx5_get_mac(eth_dev, &mac.addr_bytes)) { DRV_LOG(ERR, diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 75b822785b..1b784b109a 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -74,6 +74,15 @@ /* Maximal number of field/field parts to map into sample registers .*/ #define MLX5_FLEX_ITEM_MAPPING_NUM 32 +/* Number of bytes not included in MTU. */ +#define MLX5_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_VLAN_HLEN + RTE_ETHER_CRC_LEN) + +/* Minimum allowed MTU to be reported whenever PMD cannot query it from OS. */ +#define MLX5_ETH_MIN_MTU (RTE_ETHER_MIN_MTU) + +/* Maximum allowed MTU to be reported whenever PMD cannot query it from OS. */ +#define MLX5_ETH_MAX_MTU (9978) + enum mlx5_ipool_index { #if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H) MLX5_IPOOL_DECAP_ENCAP = 0, /* Pool for encap/decap resource. */ @@ -1840,6 +1849,8 @@ struct mlx5_priv { unsigned int vlan_filter_n; /* Number of configured VLAN filters. */ /* Device properties. */ uint16_t mtu; /* Configured MTU. */ + uint16_t min_mtu; /* Minimum MTU allowed on the NIC. */ + uint16_t max_mtu; /* Maximum MTU allowed on the NIC. */ unsigned int isolated:1; /* Whether isolated mode is enabled. */ unsigned int representor:1; /* Device is a port representor. */ unsigned int master:1; /* Device is a E-Switch master. */ @@ -2133,6 +2144,7 @@ eth_rx_burst_t mlx5_select_rx_function(struct rte_eth_dev *dev); struct mlx5_priv *mlx5_port_to_eswitch_info(uint16_t port, bool valid); struct mlx5_priv *mlx5_dev_to_eswitch_info(struct rte_eth_dev *dev); int mlx5_dev_configure_rss_reta(struct rte_eth_dev *dev); +void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *max_mtu); /* mlx5_ethdev_os.c */ @@ -2171,6 +2183,7 @@ int mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, uint16_t *n_stats, uint16_t *n_stats_sec); void mlx5_os_stats_init(struct rte_eth_dev *dev); int mlx5_get_flag_dropless_rq(struct rte_eth_dev *dev); +int mlx5_os_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *max_mtu); /* mlx5_mac.c */ diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index dbfd46ce1c..39506680a2 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -352,9 +352,11 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) unsigned int max; uint16_t max_wqe; + info->min_mtu = priv->min_mtu; + info->max_mtu = priv->max_mtu; + info->max_rx_pktlen = info->max_mtu + MLX5_ETH_OVERHEAD; /* FIXME: we should ask the device for these values. */ info->min_rx_bufsize = 32; - info->max_rx_pktlen = 65536; info->max_lro_pkt_size = MLX5_MAX_LRO_SIZE; /* * Since we need one CQ per QP, the limit is the minimum number @@ -836,3 +838,41 @@ mlx5_hairpin_cap_get(struct rte_eth_dev *dev, struct rte_eth_hairpin_cap *cap) cap->tx_cap.rte_memory = hca_attr->hairpin_sq_wq_in_host_mem; return 0; } + +/** + * Query minimum and maximum allowed MTU value on the device. + * + * This functions will always return valid MTU bounds. + * In case platform-specific implementation fails or current platform does not support it, + * the fallback default values will be used. + * + * @param[in] dev + * Pointer to Ethernet device + * @param[out] min_mtu + * Minimum MTU value output buffer. + * @param[out] max_mtu + * Maximum MTU value output buffer. + */ +void +mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *max_mtu) +{ + int ret; + + MLX5_ASSERT(min_mtu != NULL); + MLX5_ASSERT(max_mtu != NULL); + + ret = mlx5_os_get_mtu_bounds(dev, min_mtu, max_mtu); + if (ret < 0) { + if (ret != -ENOTSUP) + DRV_LOG(INFO, "port %u failed to query MTU bounds, using fallback values", + dev->data->port_id); + *min_mtu = MLX5_ETH_MIN_MTU; + *max_mtu = MLX5_ETH_MAX_MTU; + + /* This function does not fail. Clear rte_errno. */ + rte_errno = 0; + } + + DRV_LOG(INFO, "port %u minimum MTU is %u", dev->data->port_id, *min_mtu); + DRV_LOG(INFO, "port %u maximum MTU is %u", dev->data->port_id, *max_mtu); +} diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c index 49f750be68..4f43b95a09 100644 --- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c @@ -71,6 +71,34 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) return 0; } +/** + * Get device minimum and maximum allowed MTU. + * + * Windows API does not expose minimum and maximum allowed MTU. + * In this case, this just returns (-ENOTSUP) to allow platform-independent code + * to fallback to default values. + * + * @param dev + * Pointer to Ethernet device. + * @param[out] min_mtu + * Minimum MTU value output buffer. + * @param[out] max_mtu + * Maximum MTU value output buffer. + * + * @return + * (-ENOTSUP) - not supported on Windows + */ +int +mlx5_os_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *max_mtu) +{ + RTE_SET_USED(dev); + RTE_SET_USED(min_mtu); + RTE_SET_USED(max_mtu); + + rte_errno = ENOTSUP; + return -rte_errno; +} + /** * Get device MTU. * diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index a9614b125b..4cb9df1d5f 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -475,6 +475,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, eth_dev->data->mac_addrs = priv->mac; eth_dev->device = dpdk_dev; eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; + /* Fetch minimum and maximum allowed MTU from the device. */ + mlx5_get_mtu_bounds(eth_dev, &priv->min_mtu, &priv->max_mtu); /* Configure the first MAC address by default. */ if (mlx5_get_mac(eth_dev, &mac.addr_bytes)) { DRV_LOG(ERR, -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:18.404105051 +0200 +++ 0021-net-mlx5-fix-min-and-max-MTU-reporting.patch 2025-12-21 16:54:16.776070000 +0200 @@ -1 +1 @@ -From 44d657109216a32e8718446f20f91272e10575dd Mon Sep 17 00:00:00 2001 +From 9400a790b28c55b6ed0d94a8e666bce1fd5cd985 Mon Sep 17 00:00:00 2001 @@ -3 +3 @@ -Date: Wed, 16 Jul 2025 12:25:45 +0200 +Date: Tue, 4 Nov 2025 18:27:15 +0100 @@ -5,0 +6,2 @@ +[ upstream commit 44d657109216a32e8718446f20f91272e10575dd ] + @@ -27 +29 @@ - drivers/common/mlx5/linux/mlx5_nl.c | 109 ++++++++++++++++++++++ + drivers/common/mlx5/linux/mlx5_nl.c | 108 ++++++++++++++++++++++ @@ -28,0 +31 @@ + drivers/common/mlx5/version.map | 1 + @@ -35 +38 @@ - 8 files changed, 228 insertions(+), 1 deletion(-) + 9 files changed, 228 insertions(+), 1 deletion(-) @@ -38 +41 @@ -index 86166e92d0..dd69e229e3 100644 +index 28a1f56dba..15304bbfca 100644 @@ -41,3 +44,3 @@ -@@ -2247,3 +2247,112 @@ mlx5_nl_rdma_monitor_cap_get(int nl, uint8_t *cap) - } - return 0; +@@ -2032,3 +2032,111 @@ mlx5_nl_devlink_esw_multiport_get(int nlsk_fd, int family_id, const char *pci_ad + *enable ? "en" : "dis", pci_addr); + return ret; @@ -109 +111,0 @@ -+RTE_EXPORT_INTERNAL_SYMBOL(mlx5_nl_get_mtu_bounds) @@ -155 +157 @@ -index e32080fa63..26923a88fd 100644 +index 580de3b769..34306258ec 100644 @@ -158,3 +160,3 @@ -@@ -117,4 +117,7 @@ void mlx5_nl_rdma_monitor_info_get(struct nlmsghdr *hdr, struct mlx5_nl_port_inf - __rte_internal - int mlx5_nl_rdma_monitor_cap_get(int nl, uint8_t *cap); +@@ -87,4 +87,7 @@ __rte_internal + int mlx5_nl_devlink_esw_multiport_get(int nlsk_fd, int family_id, + const char *pci_addr, int *enable); @@ -165,0 +168,12 @@ +diff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map +index 074eed46fd..e43164235e 100644 +--- a/drivers/common/mlx5/version.map ++++ b/drivers/common/mlx5/version.map +@@ -142,6 +142,7 @@ INTERNAL { + mlx5_nl_vf_mac_addr_modify; # WINDOWS_NO_EXPORT + mlx5_nl_vlan_vmwa_create; # WINDOWS_NO_EXPORT + mlx5_nl_vlan_vmwa_delete; # WINDOWS_NO_EXPORT ++ mlx5_nl_get_mtu_bounds; # WINDOWS_NO_EXPORT + + mlx5_os_umem_dereg; + mlx5_os_umem_reg; @@ -167 +181 @@ -index 9daeda5435..a371c2c747 100644 +index 1d999ef66b..4d126751a2 100644 @@ -170 +184 @@ -@@ -159,6 +159,36 @@ mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr) +@@ -242,6 +242,36 @@ mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr) @@ -208 +222 @@ -index 696a3e12c7..2bc8ca9284 100644 +index c6e5e7b425..d1ccec71e9 100644 @@ -211 +225 @@ -@@ -1562,6 +1562,8 @@ err_secondary: +@@ -1521,6 +1521,8 @@ err_secondary: @@ -221 +235 @@ -index c08894cd03..53f0a27445 100644 +index 75b822785b..1b784b109a 100644 @@ -240 +254 @@ -@@ -1981,6 +1990,8 @@ struct mlx5_priv { +@@ -1840,6 +1849,8 @@ struct mlx5_priv { @@ -249 +263,3 @@ -@@ -2333,6 +2344,7 @@ struct mlx5_priv *mlx5_dev_to_eswitch_info(struct rte_eth_dev *dev); +@@ -2133,6 +2144,7 @@ eth_rx_burst_t mlx5_select_rx_function(struct rte_eth_dev *dev); + struct mlx5_priv *mlx5_port_to_eswitch_info(uint16_t port, bool valid); + struct mlx5_priv *mlx5_dev_to_eswitch_info(struct rte_eth_dev *dev); @@ -251,2 +266,0 @@ - uint64_t mlx5_get_restore_flags(struct rte_eth_dev *dev, - enum rte_eth_dev_operation op); @@ -257 +271 @@ -@@ -2372,6 +2384,7 @@ int mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, +@@ -2171,6 +2183,7 @@ int mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, @@ -266 +280 @@ -index 68d1c1bfa7..7747b0c869 100644 +index dbfd46ce1c..39506680a2 100644 @@ -269 +283 @@ -@@ -360,9 +360,11 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) +@@ -352,9 +352,11 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) @@ -282,2 +296,2 @@ -@@ -863,3 +865,41 @@ mlx5_get_restore_flags(__rte_unused struct rte_eth_dev *dev, - /* mlx5 PMD does not require any configuration restore. */ +@@ -836,3 +838,41 @@ mlx5_hairpin_cap_get(struct rte_eth_dev *dev, struct rte_eth_hairpin_cap *cap) + cap->tx_cap.rte_memory = hca_attr->hairpin_sq_wq_in_host_mem; @@ -364 +378 @@ -index d583730066..c4e3430bdc 100644 +index a9614b125b..4cb9df1d5f 100644 @@ -367 +381 @@ -@@ -477,6 +477,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, +@@ -475,6 +475,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,